[jira] [Updated] (YARN-1833) TestRMAdminService Fails in trunk and branch-2 : Assert Fails due to different count of UserGroups for currentUser()
[ https://issues.apache.org/jira/browse/YARN-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mit Desai updated YARN-1833: Summary: TestRMAdminService Fails in trunk and branch-2 : Assert Fails due to different count of UserGroups for currentUser() (was: TestRMAdminService Fails in trunk and branch-2) TestRMAdminService Fails in trunk and branch-2 : Assert Fails due to different count of UserGroups for currentUser() Key: YARN-1833 URL: https://issues.apache.org/jira/browse/YARN-1833 Project: Hadoop YARN Issue Type: Bug Affects Versions: 3.0.0, 2.4.0 Reporter: Mit Desai Assignee: Mit Desai Labels: Test Fix For: 3.0.0, 2.4.0, 2.5.0 Attachments: YARN-1833-v2.patch, YARN-1833.patch In the test testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider, the following assert is not needed. {code} Assert.assertTrue(groupWithInit.size() != groupBefore.size()); {code} As the assert takes the default groups for groupWithInit (which in my case are users, sshusers and wheel), it fails as the size of both groupWithInit and groupBefore are same. I do not think we need to have this assert here. Moreover we are also checking that the groupInit does not have the userGroups that are in the groupBefore so removing the assert may not be harmful. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (YARN-1833) TestRMAdminService Fails in trunk and branch-2
[ https://issues.apache.org/jira/browse/YARN-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Eagles updated YARN-1833: -- Fix Version/s: 2.4.0 TestRMAdminService Fails in trunk and branch-2 -- Key: YARN-1833 URL: https://issues.apache.org/jira/browse/YARN-1833 Project: Hadoop YARN Issue Type: Bug Affects Versions: 3.0.0, 2.4.0 Reporter: Mit Desai Assignee: Mit Desai Labels: Test Fix For: 3.0.0, 2.4.0, 2.5.0 Attachments: YARN-1833-v2.patch, YARN-1833.patch In the test testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider, the following assert is not needed. {code} Assert.assertTrue(groupWithInit.size() != groupBefore.size()); {code} As the assert takes the default groups for groupWithInit (which in my case are users, sshusers and wheel), it fails as the size of both groupWithInit and groupBefore are same. I do not think we need to have this assert here. Moreover we are also checking that the groupInit does not have the userGroups that are in the groupBefore so removing the assert may not be harmful. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (YARN-1833) TestRMAdminService Fails in trunk and branch-2
[ https://issues.apache.org/jira/browse/YARN-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akira AJISAKA updated YARN-1833: Hadoop Flags: Reviewed Summary: TestRMAdminService Fails in trunk and branch-2 (was: TestRMAdminService Fails in branch-2) TestRMAdminService Fails in trunk and branch-2 -- Key: YARN-1833 URL: https://issues.apache.org/jira/browse/YARN-1833 Project: Hadoop YARN Issue Type: Bug Affects Versions: 3.0.0, 2.4.0 Reporter: Mit Desai Assignee: Mit Desai Labels: Test Attachments: YARN-1833.patch In the test testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider, the following assert is not needed. {code} Assert.assertTrue(groupWithInit.size() != groupBefore.size()); {code} As the assert takes the default groups for groupWithInit (which in my case are users, sshusers and wheel), it fails as the size of both groupWithInit and groupBefore are same. I do not think we need to have this assert here. Moreover we are also checking that the groupInit does not have the userGroups that are in the groupBefore so removing the assert may not be harmful. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (YARN-1833) TestRMAdminService Fails in trunk and branch-2
[ https://issues.apache.org/jira/browse/YARN-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mit Desai updated YARN-1833: Attachment: YARN-1833-v2.patch Thanks [~jeagles] for the suggestion. I did not think about that solution. Attaching the new patch with the dummyUser for the test and no Assert Removed. TestRMAdminService Fails in trunk and branch-2 -- Key: YARN-1833 URL: https://issues.apache.org/jira/browse/YARN-1833 Project: Hadoop YARN Issue Type: Bug Affects Versions: 3.0.0, 2.4.0 Reporter: Mit Desai Assignee: Mit Desai Labels: Test Attachments: YARN-1833-v2.patch, YARN-1833.patch In the test testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider, the following assert is not needed. {code} Assert.assertTrue(groupWithInit.size() != groupBefore.size()); {code} As the assert takes the default groups for groupWithInit (which in my case are users, sshusers and wheel), it fails as the size of both groupWithInit and groupBefore are same. I do not think we need to have this assert here. Moreover we are also checking that the groupInit does not have the userGroups that are in the groupBefore so removing the assert may not be harmful. -- This message was sent by Atlassian JIRA (v6.2#6252)