[jira] [Updated] (YARN-1865) ShellScriptBuilder does not check for some error conditions
[ https://issues.apache.org/jira/browse/YARN-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Mitic updated YARN-1865: - Attachment: YARN-1865.4.patch Addressing my latest comment to add a test case for the non-zero exit code. Will commit this patch assuming it receives +1 from Jenkins. > ShellScriptBuilder does not check for some error conditions > --- > > Key: YARN-1865 > URL: https://issues.apache.org/jira/browse/YARN-1865 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager >Affects Versions: 3.0.0, 2.2.0, 2.3.0 >Reporter: Remus Rusanu >Assignee: Remus Rusanu >Priority: Minor > Attachments: YARN-1865.1.patch, YARN-1865.2.patch, YARN-1865.3.patch, > YARN-1865.4.patch > > > The WindowsShellScriptBuilder does not check for commands exceeding windows > maximum shell command line length (8191 chars) > Neither Unix nor Windows script builder do not check for error condition > after mkdir nor link > WindowsShellScriptBuilder mkdir is not safe with regard to paths containing > spaces -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (YARN-1865) ShellScriptBuilder does not check for some error conditions
[ https://issues.apache.org/jira/browse/YARN-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remus Rusanu updated YARN-1865: --- Attachment: YARN-1865.3.patch With review feedback > ShellScriptBuilder does not check for some error conditions > --- > > Key: YARN-1865 > URL: https://issues.apache.org/jira/browse/YARN-1865 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager >Affects Versions: 3.0.0, 2.2.0, 2.3.0 >Reporter: Remus Rusanu >Assignee: Remus Rusanu >Priority: Minor > Attachments: YARN-1865.1.patch, YARN-1865.2.patch, YARN-1865.3.patch > > > The WindowsShellScriptBuilder does not check for commands exceeding windows > maximum shell command line length (8191 chars) > Neither Unix nor Windows script builder do not check for error condition > after mkdir nor link > WindowsShellScriptBuilder mkdir is not safe with regard to paths containing > spaces -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (YARN-1865) ShellScriptBuilder does not check for some error conditions
[ https://issues.apache.org/jira/browse/YARN-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remus Rusanu updated YARN-1865: --- Attachment: YARN-1865.2.patch Remove the bogus change in TestcontainerExecutor, reverted the only whitespace change in Shell > ShellScriptBuilder does not check for some error conditions > --- > > Key: YARN-1865 > URL: https://issues.apache.org/jira/browse/YARN-1865 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager >Affects Versions: 3.0.0, 2.2.0, 2.3.0 >Reporter: Remus Rusanu >Assignee: Remus Rusanu >Priority: Minor > Attachments: YARN-1865.1.patch, YARN-1865.2.patch > > > The WindowsShellScriptBuilder does not check for commands exceeding windows > maximum shell command line length (8191 chars) > Neither Unix nor Windows script builder do not check for error condition > after mkdir nor link > WindowsShellScriptBuilder mkdir is not safe with regard to paths containing > spaces -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (YARN-1865) ShellScriptBuilder does not check for some error conditions
[ https://issues.apache.org/jira/browse/YARN-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Nauroth updated YARN-1865: Assignee: Remus Rusanu > ShellScriptBuilder does not check for some error conditions > --- > > Key: YARN-1865 > URL: https://issues.apache.org/jira/browse/YARN-1865 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager >Affects Versions: 3.0.0, 2.2.0, 2.3.0 >Reporter: Remus Rusanu >Assignee: Remus Rusanu >Priority: Minor > Attachments: YARN-1865.1.patch > > > The WindowsShellScriptBuilder does not check for commands exceeding windows > maximum shell command line length (8191 chars) > Neither Unix nor Windows script builder do not check for error condition > after mkdir nor link > WindowsShellScriptBuilder mkdir is not safe with regard to paths containing > spaces -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (YARN-1865) ShellScriptBuilder does not check for some error conditions
[ https://issues.apache.org/jira/browse/YARN-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remus Rusanu updated YARN-1865: --- Attachment: YARN-1865.1.patch > ShellScriptBuilder does not check for some error conditions > --- > > Key: YARN-1865 > URL: https://issues.apache.org/jira/browse/YARN-1865 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager >Affects Versions: 3.0.0, 2.2.0, 2.3.0 >Reporter: Remus Rusanu >Priority: Minor > Attachments: YARN-1865.1.patch > > > The WindowsShellScriptBuilder does not check for commands exceeding windows > maximum shell command line length (8191 chars) > Neither Unix nor Windows script builder do not check for error condition > after mkdir nor link > WindowsShellScriptBuilder mkdir is not safe with regard to paths containing > spaces -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (YARN-1865) ShellScriptBuilder does not check for some error conditions
[ https://issues.apache.org/jira/browse/YARN-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Remus Rusanu updated YARN-1865: --- Priority: Minor (was: Major) > ShellScriptBuilder does not check for some error conditions > --- > > Key: YARN-1865 > URL: https://issues.apache.org/jira/browse/YARN-1865 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager >Affects Versions: 3.0.0, 2.2.0, 2.3.0 >Reporter: Remus Rusanu >Priority: Minor > > The WindowsShellScriptBuilder does not check for commands exceeding windows > maximum shell command line length (8191 chars) > Neither Unix nor Windows script builder do not check for error condition > after mkdir nor link > WindowsShellScriptBuilder mkdir is not safe with regard to paths containing > spaces -- This message was sent by Atlassian JIRA (v6.2#6252)
