Re: [linux-yocto] [PATCH 09/16] media/platform : A feature for platform media devices

2013-11-22 Thread Darren Hart
On Fri, 2013-11-22 at 11:35 -0800, nitin.a.kam...@intel.com wrote:
> From: Nitin A Kamble 
> 
> This enables kernel configuration for bunch of media devices which
> are generally part of some platforms. Many of these devices are
> webcam devices built into platforms.
> 
> Signed-off-by: Nitin A Kamble 
> ---
>  meta/cfg/kernel-cache/features/media/platform.cfg | 15 +++
>  meta/cfg/kernel-cache/features/media/platform.scc |  6 ++
>  2 files changed, 21 insertions(+)
>  create mode 100644 meta/cfg/kernel-cache/features/media/platform.cfg
>  create mode 100644 meta/cfg/kernel-cache/features/media/platform.scc
> 
> diff --git a/meta/cfg/kernel-cache/features/media/platform.cfg 
> b/meta/cfg/kernel-cache/features/media/platform.cfg
> new file mode 100644
> index 000..b7484e7
> --- /dev/null
> +++ b/meta/cfg/kernel-cache/features/media/platform.cfg
> @@ -0,0 +1,15 @@
> +#
> +# Media Platform Configuration
> +#
> +# CONFIG_V4L_PLATFORM_DRIVERS is not set

Hrm, really?

> +
> +CONFIG_V4L_MEM2MEM_DRIVERS=y
> +CONFIG_VIDEO_MEM2MEM_DEINTERLACE=m
> +
> +# CONFIG_V4L_TEST_DRIVERS is not set

Can remove

> +
> +
> +#
> +# Media MMC Support
> +#
> +# CONFIG_SMS_SDIO_DRV is not set

Again, really? Maybe this depends on some SDIO options?

Typically we don't explicitly disable things without a very good reason,
which should be noted in the fragment.

> diff --git a/meta/cfg/kernel-cache/features/media/platform.scc 
> b/meta/cfg/kernel-cache/features/media/platform.scc
> new file mode 100644
> index 000..b3a7e01
> --- /dev/null
> +++ b/meta/cfg/kernel-cache/features/media/platform.scc
> @@ -0,0 +1,6 @@
> +define KFEATURE_DESCRIPTION "Enable Configuration For Platform Media Devices"
> +define KFEATURE_COMPATIBILITY all
> +
> +include media.scc
> +
> +kconf hardware platform.cfg

mem2mem and sdio dependency maybe? Just guessing.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel


___
linux-yocto mailing list
linux-yo...@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto


[linux-yocto] [PATCH 09/16] media/platform : A feature for platform media devices

2013-11-22 Thread nitin . a . kamble
From: Nitin A Kamble 

This enables kernel configuration for bunch of media devices which
are generally part of some platforms. Many of these devices are
webcam devices built into platforms.

Signed-off-by: Nitin A Kamble 
---
 meta/cfg/kernel-cache/features/media/platform.cfg | 15 +++
 meta/cfg/kernel-cache/features/media/platform.scc |  6 ++
 2 files changed, 21 insertions(+)
 create mode 100644 meta/cfg/kernel-cache/features/media/platform.cfg
 create mode 100644 meta/cfg/kernel-cache/features/media/platform.scc

diff --git a/meta/cfg/kernel-cache/features/media/platform.cfg 
b/meta/cfg/kernel-cache/features/media/platform.cfg
new file mode 100644
index 000..b7484e7
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/media/platform.cfg
@@ -0,0 +1,15 @@
+#
+# Media Platform Configuration
+#
+# CONFIG_V4L_PLATFORM_DRIVERS is not set
+
+CONFIG_V4L_MEM2MEM_DRIVERS=y
+CONFIG_VIDEO_MEM2MEM_DEINTERLACE=m
+
+# CONFIG_V4L_TEST_DRIVERS is not set
+
+
+#
+# Media MMC Support
+#
+# CONFIG_SMS_SDIO_DRV is not set
diff --git a/meta/cfg/kernel-cache/features/media/platform.scc 
b/meta/cfg/kernel-cache/features/media/platform.scc
new file mode 100644
index 000..b3a7e01
--- /dev/null
+++ b/meta/cfg/kernel-cache/features/media/platform.scc
@@ -0,0 +1,6 @@
+define KFEATURE_DESCRIPTION "Enable Configuration For Platform Media Devices"
+define KFEATURE_COMPATIBILITY all
+
+include media.scc
+
+kconf hardware platform.cfg
-- 
1.8.1.4

___
linux-yocto mailing list
linux-yo...@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto