Re: [yocto] [meta-raspberrypi][PATCH] gstreamer1.0-omx: remove bbappend for version 1.2.0

[Andrei Gherzan]

On Fri, Mar 10, 2017 at 05:36:19PM -0800, Khem Raj wrote:
>
>
> On 3/7/17 4:07 AM, Paul Barker wrote:
> > On Mon,  6 Mar 2017 17:28:03 +0200
> > "Maxin B. John"  wrote:
> >
> >> OE-Core rev: aa06a18d59eb391d1a7ace9daa0681bdf8daf17f
> >> removed gstreamer1.0-omx_1.2.0 recipe.
> >>
> >> Signed-off-by: Maxin B. John 
> >> ---
> >>  ...o-acquire-buffer-when-src-pad-isn-t-activ.patch |  48 
> >>  .../0001-config-files-path.patch   | 137
> >> - .../0002-fix-decoder-flushing.patch
> >> |  16 --- .../0003-no-timeout-on-get-state.patch |  16 ---
> >>  ...erly-handle-drain-requests-while-flushing.patch |  69 ---
> >>  ...-gst_omx_video_dec_set_format-if-there-s-.patch |  30 -
> >>  ...-unref-allocator-after-getting-it-from-al.patch |  48 
> >>  ...mxvideodec-Use-gstglmemoryegl-for-the-RPi.patch | 115
> >> - .../gstreamer/gstreamer1.0-omx_1.2.0.bbappend
> >> |  14 --- 9 files changed, 493 deletions(-)
> >>  delete mode 100644
> >> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-Don-t-try-to-acquire-buffer-when-src-pad-isn-t-activ.patch
> >> delete mode 100644
> >> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-config-files-path.patch
> >> delete mode 100644
> >> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0002-fix-decoder-flushing.patch
> >> delete mode 100644
> >> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0003-no-timeout-on-get-state.patch
> >> delete mode 100644
> >> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0004-Properly-handle-drain-requests-while-flushing.patch
> >> delete mode 100644
> >> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0005-Don-t-abort-gst_omx_video_dec_set_format-if-there-s-.patch
> >> delete mode 100644
> >> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0006-omxvideodec-unref-allocator-after-getting-it-from-al.patch
> >> delete mode 100644
> >> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0007-omxvideodec-Use-gstglmemoryegl-for-the-RPi.patch
> >> delete mode 100644
> >> recipes-multimedia/gstreamer/gstreamer1.0-omx_1.2.0.bbappend
> >
> > I got a parse failure on all my scheduled builds last night. This patch
> > fixes the builds for me :)
>
> These are now staged in kraj/master on my github with few other changes.

... which made it to master.

--
Andrei Gherzan
gpg: rsa4096/D4D94F67AD0E9640 | t: @agherzan


signature.asc
Description: PGP signature
-- 
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto

Re: [yocto] [meta-raspberrypi][PATCH] gstreamer1.0-omx: remove bbappend for version 1.2.0

[Khem Raj]

On 3/7/17 4:07 AM, Paul Barker wrote:
> On Mon,  6 Mar 2017 17:28:03 +0200
> "Maxin B. John"  wrote:
> 
>> OE-Core rev: aa06a18d59eb391d1a7ace9daa0681bdf8daf17f
>> removed gstreamer1.0-omx_1.2.0 recipe.
>>
>> Signed-off-by: Maxin B. John 
>> ---
>>  ...o-acquire-buffer-when-src-pad-isn-t-activ.patch |  48 
>>  .../0001-config-files-path.patch   | 137
>> - .../0002-fix-decoder-flushing.patch
>> |  16 --- .../0003-no-timeout-on-get-state.patch |  16 ---
>>  ...erly-handle-drain-requests-while-flushing.patch |  69 ---
>>  ...-gst_omx_video_dec_set_format-if-there-s-.patch |  30 -
>>  ...-unref-allocator-after-getting-it-from-al.patch |  48 
>>  ...mxvideodec-Use-gstglmemoryegl-for-the-RPi.patch | 115
>> - .../gstreamer/gstreamer1.0-omx_1.2.0.bbappend
>> |  14 --- 9 files changed, 493 deletions(-)
>>  delete mode 100644
>> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-Don-t-try-to-acquire-buffer-when-src-pad-isn-t-activ.patch
>> delete mode 100644
>> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-config-files-path.patch
>> delete mode 100644
>> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0002-fix-decoder-flushing.patch
>> delete mode 100644
>> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0003-no-timeout-on-get-state.patch
>> delete mode 100644
>> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0004-Properly-handle-drain-requests-while-flushing.patch
>> delete mode 100644
>> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0005-Don-t-abort-gst_omx_video_dec_set_format-if-there-s-.patch
>> delete mode 100644
>> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0006-omxvideodec-unref-allocator-after-getting-it-from-al.patch
>> delete mode 100644
>> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0007-omxvideodec-Use-gstglmemoryegl-for-the-RPi.patch
>> delete mode 100644
>> recipes-multimedia/gstreamer/gstreamer1.0-omx_1.2.0.bbappend
> 
> I got a parse failure on all my scheduled builds last night. This patch
> fixes the builds for me :)

These are now staged in kraj/master on my github with few other changes.

> 
> Thanks,
> Paul
> 
-- 
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto

Re: [yocto] [meta-raspberrypi][PATCH] gstreamer1.0-omx: remove bbappend for version 1.2.0

[Paul Barker]

On Mon,  6 Mar 2017 17:28:03 +0200
"Maxin B. John"  wrote:

> OE-Core rev: aa06a18d59eb391d1a7ace9daa0681bdf8daf17f
> removed gstreamer1.0-omx_1.2.0 recipe.
> 
> Signed-off-by: Maxin B. John 
> ---
>  ...o-acquire-buffer-when-src-pad-isn-t-activ.patch |  48 
>  .../0001-config-files-path.patch   | 137
> - .../0002-fix-decoder-flushing.patch
> |  16 --- .../0003-no-timeout-on-get-state.patch |  16 ---
>  ...erly-handle-drain-requests-while-flushing.patch |  69 ---
>  ...-gst_omx_video_dec_set_format-if-there-s-.patch |  30 -
>  ...-unref-allocator-after-getting-it-from-al.patch |  48 
>  ...mxvideodec-Use-gstglmemoryegl-for-the-RPi.patch | 115
> - .../gstreamer/gstreamer1.0-omx_1.2.0.bbappend
> |  14 --- 9 files changed, 493 deletions(-)
>  delete mode 100644
> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-Don-t-try-to-acquire-buffer-when-src-pad-isn-t-activ.patch
> delete mode 100644
> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-config-files-path.patch
> delete mode 100644
> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0002-fix-decoder-flushing.patch
> delete mode 100644
> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0003-no-timeout-on-get-state.patch
> delete mode 100644
> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0004-Properly-handle-drain-requests-while-flushing.patch
> delete mode 100644
> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0005-Don-t-abort-gst_omx_video_dec_set_format-if-there-s-.patch
> delete mode 100644
> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0006-omxvideodec-unref-allocator-after-getting-it-from-al.patch
> delete mode 100644
> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0007-omxvideodec-Use-gstglmemoryegl-for-the-RPi.patch
> delete mode 100644
> recipes-multimedia/gstreamer/gstreamer1.0-omx_1.2.0.bbappend

I got a parse failure on all my scheduled builds last night. This patch
fixes the builds for me :)

Thanks,
Paul
-- 
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto

Re: [yocto] [meta-raspberrypi][PATCH] gstreamer1.0-omx: remove bbappend for version 1.2.0

[Khem Raj]

On Mon, Mar 6, 2017 at 7:28 AM, Maxin B. John  wrote:
> OE-Core rev: aa06a18d59eb391d1a7ace9daa0681bdf8daf17f
> removed gstreamer1.0-omx_1.2.0 recipe.
>

this is good.

> Signed-off-by: Maxin B. John 
> ---
>  ...o-acquire-buffer-when-src-pad-isn-t-activ.patch |  48 
>  .../0001-config-files-path.patch   | 137 
> -
>  .../0002-fix-decoder-flushing.patch|  16 ---
>  .../0003-no-timeout-on-get-state.patch |  16 ---
>  ...erly-handle-drain-requests-while-flushing.patch |  69 ---
>  ...-gst_omx_video_dec_set_format-if-there-s-.patch |  30 -
>  ...-unref-allocator-after-getting-it-from-al.patch |  48 
>  ...mxvideodec-Use-gstglmemoryegl-for-the-RPi.patch | 115 -
>  .../gstreamer/gstreamer1.0-omx_1.2.0.bbappend  |  14 ---
>  9 files changed, 493 deletions(-)
>  delete mode 100644 
> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-Don-t-try-to-acquire-buffer-when-src-pad-isn-t-activ.patch
>  delete mode 100644 
> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-config-files-path.patch
>  delete mode 100644 
> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0002-fix-decoder-flushing.patch
>  delete mode 100644 
> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0003-no-timeout-on-get-state.patch
>  delete mode 100644 
> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0004-Properly-handle-drain-requests-while-flushing.patch
>  delete mode 100644 
> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0005-Don-t-abort-gst_omx_video_dec_set_format-if-there-s-.patch
>  delete mode 100644 
> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0006-omxvideodec-unref-allocator-after-getting-it-from-al.patch
>  delete mode 100644 
> recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0007-omxvideodec-Use-gstglmemoryegl-for-the-RPi.patch
>  delete mode 100644 
> recipes-multimedia/gstreamer/gstreamer1.0-omx_1.2.0.bbappend
>
> diff --git 
> a/recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-Don-t-try-to-acquire-buffer-when-src-pad-isn-t-activ.patch
>  
> b/recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-Don-t-try-to-acquire-buffer-when-src-pad-isn-t-activ.patch
> deleted file mode 100644
> index 815a7c2..000
> --- 
> a/recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-Don-t-try-to-acquire-buffer-when-src-pad-isn-t-activ.patch
> +++ /dev/null
> @@ -1,48 +0,0 @@
> -From 2e111e52f96f0b942abda120c30a876629bd73fc Mon Sep 17 00:00:00 2001
> -From: =?UTF-8?q?Enrique=20Oca=C3=B1a=20Gonz=C3=A1lez?= 
> -Date: Mon, 25 May 2015 14:53:35 +0200
> -Subject: [PATCH] Don't try to acquire buffer when src pad isn't active
> -
> -This solves a race condition when setting the pipeline from PAUSE to
> -NULL while the decoder loop is still running. Without this patch, the
> -thread which interacts with the decode sink pad gets blocked here:
> -
> -  gst_element_change_state()
> -  gst_element_change_state_func()
> -  gst_element_pads_activate() --> Deactivating pads
> -  activate_pads()
> -  gst_pad_set_active()
> -  gst_pad_activate_mode()
> -  post_activate()
> -  GST_PAD_STREAM_LOCK()
> -
> -while gst_omx_port_acquire_buffer() gets stalled forever in
> -gst_omx_component_wait_message() waiting for a message that will never
> -arrive:
> -
> -  gst_omx_video_dec_loop()
> -  gst_omx_port_acquire_buffer()
> -  gst_omx_component_wait_message()
> 
> - omx/gstomxvideodec.c | 5 +
> - 1 file changed, 5 insertions(+)
> -
> -diff --git a/omx/gstomxvideodec.c b/omx/gstomxvideodec.c
> -index cd24944..57a61dd 100644
>  a/omx/gstomxvideodec.c
> -+++ b/omx/gstomxvideodec.c
> -@@ -1247,6 +1247,11 @@ gst_omx_video_dec_loop (GstOMXVideoDec * self)
> -   GstClockTimeDiff deadline;
> -   OMX_ERRORTYPE err;
> -
> -+  if (!gst_pad_is_active(GST_VIDEO_DECODER_SRC_PAD (self))) {
> -+GST_DEBUG_OBJECT (self, "Src pad not active, not acquiring buffer and 
> flushing instead");
> -+  goto flushing;
> -+  }
> -+
> - #if defined (USE_OMX_TARGET_RPI) && defined (HAVE_GST_GL)
> -   port = self->eglimage ? self->egl_out_port : self->dec_out_port;
> - #else
> ---
> -1.8.3.2
> -
> diff --git 
> a/recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-config-files-path.patch
>  
> b/recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-config-files-path.patch
> deleted file mode 100644
> index a7da922..000
> --- 
> a/recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-config-files-path.patch
> +++ /dev/null
> @@ -1,137 +0,0 @@
>  a/config/bellagio/gstomx.conf
> -+++ b/config/bellagio/gstomx.conf
> -@@ -1,6 +1,6 @@
> - [omxmpeg4videodec]
> - type-name=GstOMXMPEG4VideoDec
> --core-name=/usr/local/lib/libomxil-bellagio.so.0
> -+core-name=/usr/lib/libomxil-bellagio.so.0
> - component-name=OMX.st.video_decoder.mpeg4
> - rank=256
> - in-port-index=0
> -@@ -9,7 +9,7 @@
> -
> - [omxh264dec]
> - type-name=GstOMXH264Dec
> 

[yocto] [meta-raspberrypi][PATCH] gstreamer1.0-omx: remove bbappend for version 1.2.0

[Maxin B. John]

OE-Core rev: aa06a18d59eb391d1a7ace9daa0681bdf8daf17f
removed gstreamer1.0-omx_1.2.0 recipe.

Signed-off-by: Maxin B. John 
---
 ...o-acquire-buffer-when-src-pad-isn-t-activ.patch |  48 
 .../0001-config-files-path.patch   | 137 -
 .../0002-fix-decoder-flushing.patch|  16 ---
 .../0003-no-timeout-on-get-state.patch |  16 ---
 ...erly-handle-drain-requests-while-flushing.patch |  69 ---
 ...-gst_omx_video_dec_set_format-if-there-s-.patch |  30 -
 ...-unref-allocator-after-getting-it-from-al.patch |  48 
 ...mxvideodec-Use-gstglmemoryegl-for-the-RPi.patch | 115 -
 .../gstreamer/gstreamer1.0-omx_1.2.0.bbappend  |  14 ---
 9 files changed, 493 deletions(-)
 delete mode 100644 
recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-Don-t-try-to-acquire-buffer-when-src-pad-isn-t-activ.patch
 delete mode 100644 
recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-config-files-path.patch
 delete mode 100644 
recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0002-fix-decoder-flushing.patch
 delete mode 100644 
recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0003-no-timeout-on-get-state.patch
 delete mode 100644 
recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0004-Properly-handle-drain-requests-while-flushing.patch
 delete mode 100644 
recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0005-Don-t-abort-gst_omx_video_dec_set_format-if-there-s-.patch
 delete mode 100644 
recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0006-omxvideodec-unref-allocator-after-getting-it-from-al.patch
 delete mode 100644 
recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0007-omxvideodec-Use-gstglmemoryegl-for-the-RPi.patch
 delete mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-omx_1.2.0.bbappend

diff --git 
a/recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-Don-t-try-to-acquire-buffer-when-src-pad-isn-t-activ.patch
 
b/recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-Don-t-try-to-acquire-buffer-when-src-pad-isn-t-activ.patch
deleted file mode 100644
index 815a7c2..000
--- 
a/recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-Don-t-try-to-acquire-buffer-when-src-pad-isn-t-activ.patch
+++ /dev/null
@@ -1,48 +0,0 @@
-From 2e111e52f96f0b942abda120c30a876629bd73fc Mon Sep 17 00:00:00 2001
-From: =?UTF-8?q?Enrique=20Oca=C3=B1a=20Gonz=C3=A1lez?= 
-Date: Mon, 25 May 2015 14:53:35 +0200
-Subject: [PATCH] Don't try to acquire buffer when src pad isn't active
-
-This solves a race condition when setting the pipeline from PAUSE to
-NULL while the decoder loop is still running. Without this patch, the
-thread which interacts with the decode sink pad gets blocked here:
-
-  gst_element_change_state()
-  gst_element_change_state_func()
-  gst_element_pads_activate() --> Deactivating pads
-  activate_pads()
-  gst_pad_set_active()
-  gst_pad_activate_mode()
-  post_activate()
-  GST_PAD_STREAM_LOCK()
-
-while gst_omx_port_acquire_buffer() gets stalled forever in
-gst_omx_component_wait_message() waiting for a message that will never
-arrive:
-
-  gst_omx_video_dec_loop()
-  gst_omx_port_acquire_buffer()
-  gst_omx_component_wait_message()

- omx/gstomxvideodec.c | 5 +
- 1 file changed, 5 insertions(+)
-
-diff --git a/omx/gstomxvideodec.c b/omx/gstomxvideodec.c
-index cd24944..57a61dd 100644
 a/omx/gstomxvideodec.c
-+++ b/omx/gstomxvideodec.c
-@@ -1247,6 +1247,11 @@ gst_omx_video_dec_loop (GstOMXVideoDec * self)
-   GstClockTimeDiff deadline;
-   OMX_ERRORTYPE err;
- 
-+  if (!gst_pad_is_active(GST_VIDEO_DECODER_SRC_PAD (self))) {
-+GST_DEBUG_OBJECT (self, "Src pad not active, not acquiring buffer and 
flushing instead");
-+  goto flushing;
-+  }
-+
- #if defined (USE_OMX_TARGET_RPI) && defined (HAVE_GST_GL)
-   port = self->eglimage ? self->egl_out_port : self->dec_out_port;
- #else
--- 
-1.8.3.2
-
diff --git 
a/recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-config-files-path.patch
 
b/recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-config-files-path.patch
deleted file mode 100644
index a7da922..000
--- 
a/recipes-multimedia/gstreamer/gstreamer1.0-omx-1.2.0/0001-config-files-path.patch
+++ /dev/null
@@ -1,137 +0,0 @@
 a/config/bellagio/gstomx.conf
-+++ b/config/bellagio/gstomx.conf
-@@ -1,6 +1,6 @@
- [omxmpeg4videodec]
- type-name=GstOMXMPEG4VideoDec
--core-name=/usr/local/lib/libomxil-bellagio.so.0
-+core-name=/usr/lib/libomxil-bellagio.so.0
- component-name=OMX.st.video_decoder.mpeg4
- rank=256
- in-port-index=0
-@@ -9,7 +9,7 @@
- 
- [omxh264dec]
- type-name=GstOMXH264Dec
--core-name=/usr/local/lib/libomxil-bellagio.so.0
-+core-name=/usr/lib/libomxil-bellagio.so.0
- component-name=OMX.st.video_decoder.avc
- rank=256
- in-port-index=0
-@@ -18,7 +18,7 @@
- 
- [omxmpeg4videoenc]
- type-name=GstOMXMPEG4VideoEnc
--core-name=/usr/local/lib/libomxil-bellagio.so.0