Re: [linux-yocto] Review request 0/5: GRE Refresh [ US43662 ]
Hmm. I noticed that this is going to the wrong mailing list *after* I replied once already. This needs review, before broadcasting to the yocto list. Sorry for the noise! Cheers, Bruce On 14-08-26 05:56 AM, jianchuan.w...@windriver.com wrote: Summary: GRE Refresh Tech Review: Yang Shi Gatekeeper: Bruce Ashfield Lockdown Approval (if needed): Branch Tag: master for WRL 7 IP Statement (form link or license statement, usually automated): Crypto URL(s) (if needed): see http://wiki.wrs.com/PBUeng/LinuxProductDivisionExportProcess Parent Template (where applicable): - Impacted area Impact y/n --- --- docs/tech-pubs n tests n build system n host dependencies n RPM/packaging n toolchain n kernel codey user code n configuration filesn target configuration n Other n Applicable to Yocto/upstream n Comments (indicate scope for each y above): - 0001-gre-add-x-netns-support.patch This patch allows to switch the netns when packet is encapsulated or decapsulated. In other word, the encapsulated packet is received in a netns, where the lookup is done to find the tunnel. Once the tunnel is found, the packet is decapsulated and injecting into the corresponding interface which stands to another netns. 0002-gre-allow-changing-mac-address-when-device-is-up.patch There is no need to require forcing device down on a Ethernet GRE (gretap) tunnel to change the MAC address. 0003-ip6gre-add-x-netns-support.patch This patch allows to switch the netns when packet is encapsulated or decapsulated. In other word, the encapsulated packet is received in a netns, where the lookup is done to find the tunnel. Once the tunnel is found, the packet is decapsulated and injecting into the corresponding interface which stands to another netns. 0004-net-Generalize-checksum_init-functions.patch Create a general __skb_checksum_validate function (actually a macro) to subsume the various checksum_init functions. This function can either init the checksum, or do the full validation (logically checksum_init+skb_check_complete)-- a flag specifies if full vaidation is performed. Also, there is a flag to the function to indicate that zero checksums are allowed (to support optional UDP checksums). 0005-gre6-Call-skb_checksum_simple_validate.patch Use skb_checksum_simple_validate to verify checksum. 0001-GRE-enable-gre-feature.patch GRE: enable gre feature Added Files: None Removed Files: -- None Remaining Changes (diffstat): - include/linux/skbuff.h | 93 +++ net/ipv4/ip_gre.c | 7 --- net/ipv6/ip6_gre.c | 64 ++- 3 files changed, 130 insertions(+), 34 deletions(-) Testing Commands: - Testing gre both ipv4 and ipv6. Node A: 128.224.165.109 Node B: 128.224.165.126 The node A and node B configures For IPV4 as flows: node A: ip tunnel add grem mode gre remote 128.224.165.126 local 128.224.165.109 ttl 255 ip link set grem up ip addr add 10.10.10.1/24 dev grem node B: ip tunnel add grem mode gre remote 128.224.165.109 local 128.224.165.126 ttl 255 ip link set grem up ip addr add 10.10.10.2/24 dev grem The node A and node B configures For IPV6 as flows: node A: ip tunnel add sixbone mode sit remote 128.224.165.126 local 128.224.165.109 ttl 255 ip link set sixbone up ip addr add 3ffe:406:5:1:5:a:2:1/96 dev sixbone #ip route add 3ffe::/15 dev sixbone node B: ip tunnel add sixbone mode sit remote 128.224.165.109 local 128.224.165.126 ttl 255 ip link set sixbone up ip addr add 3ffe:406:5:1:5:a:2:2/96 dev sixbone #ip route add 3ffe::/15 dev sixbone Testing, Expected Results: -- After configuring sucessfully, ping each other is ok. Conditions of submission: - Archbuilt boot boardname - MIPS n n MIPS64n n MIPS64n32 n n ARM n n x86 n n x86_64y y intel-xeon-core PPC n n PPC64 n n SPARC64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review/gatekeep because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that
Re: [linux-yocto] Review request 0/5: GRE Refresh [ US43662 ]
On 14-08-26 05:56 AM, jianchuan.w...@windriver.com wrote: Summary: GRE Refresh Tech Review: Yang Shi Gatekeeper: Bruce Ashfield Lockdown Approval (if needed): Branch Tag: master for WRL 7 IP Statement (form link or license statement, usually automated): Crypto URL(s) (if needed): see http://wiki.wrs.com/PBUeng/LinuxProductDivisionExportProcess Parent Template (where applicable): - Impacted area Impact y/n --- --- docs/tech-pubs n tests n build system n host dependencies n RPM/packaging n toolchain n kernel codey user code n configuration filesn target configuration n Other n Applicable to Yocto/upstream n Comments (indicate scope for each y above): - 0001-gre-add-x-netns-support.patch This patch allows to switch the netns when packet is encapsulated or decapsulated. In other word, the encapsulated packet is received in a netns, where the lookup is done to find the tunnel. Once the tunnel is found, the packet is decapsulated and injecting into the corresponding interface which stands to another netns. 0002-gre-allow-changing-mac-address-when-device-is-up.patch There is no need to require forcing device down on a Ethernet GRE (gretap) tunnel to change the MAC address. 0003-ip6gre-add-x-netns-support.patch This patch allows to switch the netns when packet is encapsulated or decapsulated. In other word, the encapsulated packet is received in a netns, where the lookup is done to find the tunnel. Once the tunnel is found, the packet is decapsulated and injecting into the corresponding interface which stands to another netns. 0004-net-Generalize-checksum_init-functions.patch Create a general __skb_checksum_validate function (actually a macro) to subsume the various checksum_init functions. This function can either init the checksum, or do the full validation (logically checksum_init+skb_check_complete)-- a flag specifies if full vaidation is performed. Also, there is a flag to the function to indicate that zero checksums are allowed (to support optional UDP checksums). 0005-gre6-Call-skb_checksum_simple_validate.patch Use skb_checksum_simple_validate to verify checksum. 0001-GRE-enable-gre-feature.patch GRE: enable gre feature Added Files: None Removed Files: -- None Remaining Changes (diffstat): - include/linux/skbuff.h | 93 +++ net/ipv4/ip_gre.c | 7 --- net/ipv6/ip6_gre.c | 64 ++- 3 files changed, 130 insertions(+), 34 deletions(-) Testing Commands: - Testing gre both ipv4 and ipv6. Node A: 128.224.165.109 Node B: 128.224.165.126 The node A and node B configures For IPV4 as flows: node A: ip tunnel add grem mode gre remote 128.224.165.126 local 128.224.165.109 ttl 255 ip link set grem up ip addr add 10.10.10.1/24 dev grem node B: ip tunnel add grem mode gre remote 128.224.165.109 local 128.224.165.126 ttl 255 ip link set grem up ip addr add 10.10.10.2/24 dev grem The node A and node B configures For IPV6 as flows: node A: ip tunnel add sixbone mode sit remote 128.224.165.126 local 128.224.165.109 ttl 255 ip link set sixbone up ip addr add 3ffe:406:5:1:5:a:2:1/96 dev sixbone #ip route add 3ffe::/15 dev sixbone node B: ip tunnel add sixbone mode sit remote 128.224.165.109 local 128.224.165.126 ttl 255 ip link set sixbone up ip addr add 3ffe:406:5:1:5:a:2:2/96 dev sixbone #ip route add 3ffe::/15 dev sixbone gk Bruce Testing, Expected Results: -- After configuring sucessfully, ping each other is ok. Conditions of submission: - Archbuilt boot boardname - MIPS n n MIPS64n n MIPS64n32 n n ARM n n x86 n n x86_64y y intel-xeon-core PPC n n PPC64 n n SPARC64 n n Reviewer Checklist: --- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review/gatekeep because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You've not properly listed things in the proper sections from the perspective of the SCM for new, removed, and changed files ___ You have
