Re: [yocto] [meta-security][PATCH 05/17] tpm2simulator: add package

[Khem Raj]

> On Oct 17, 2016, at 6:21 PM, akuster808  wrote:
> 
> 
> 
> On 10/17/2016 05:13 PM, Khem Raj wrote:
>>> On Oct 17, 2016, at 5:02 PM, Armin Kuster  
>>>  wrote:
>>> 
>>> Signed-off-by: Armin Kuster  
>>> 
>>> ---
>>> .../tpm2simulator/tpm2simulator-native_116.bb  | 25 
>>> ++
>>> 1 file changed, 25 insertions(+)
>>> create mode 100644 recipes-tpm/tpm2simulator/tpm2simulator-native_116.bb
>>> 
>>> diff --git a/recipes-tpm/tpm2simulator/tpm2simulator-native_116.bb 
>>> b/recipes-tpm/tpm2simulator/tpm2simulator-native_116.bb
>>> new file mode 100644
>>> index 000..33eaf99
>>> --- /dev/null
>>> +++ b/recipes-tpm/tpm2simulator/tpm2simulator-native_116.bb
>>> @@ -0,0 +1,25 @@
>>> +SUMMARY = "TPM 2.0 Simulator Extraction Script"
>>> +LICENSE = "BSD-2-Clause"
>>> +LIC_FILES_CHKSUM = 
>>> "file://../LICENSE;md5=1415f7be284540b81d9d28c67c1a6b8b" 
>>> 
>>> +
>>> +DEPENDS += "python"
>>> +
>>> +SRCREV = "93dc4412432013ed7bcabd42007754c68f6e362e"
>>> +SRC_URI = "git://github.com/stwagnr/tpm2simulator.git"
>>> +
>>> +S = "${WORKDIR}/git/cmake"
>>> +
>>> +PV = "116+git${SRCPV}"
>>> +
>>> +inherit native lib_package cmake
>>> +
>>> +EXTRA_OECMAKE = " \
>>> +   -DCMAKE_BUILD_TYPE=Debug \
>>> +   -DSPEC_VERSION=116 \
>>> +"
>>> +
>>> +do_configure_prepend () {
>>> +   sed -i 's/^SET = False/SET = True/' ${WORKDIR}/git/scripts/settings.py
>> use S instead of WORKDIR
> S = "${WORKDIR}/git/cmake"
> 
> that file does not reside there.

I think it will break devtool and externalsrc builds.

> 
> the build process does a relative ref outside the "cmake" dir to run the 
> scripts.
> 
> unless you mean I should do " ${S}/../scripts/settings.py" ?
>> 
>>> +}
>>> +
>>> +BBCLASSEXTEND = “native"
>> it is not needed.
> k
> 
> thanks for the review.
> 
> - armin
>> 
>>> --
>>> 2.7.4
>>> 
>>> --
>>> ___
>>> yocto mailing list
>>> yocto@yoctoproject.org 
>>> https://lists.yoctoproject.org/listinfo/yocto 
>>> 
>> 
>> 
> 



signature.asc
Description: Message signed with OpenPGP using GPGMail
-- 
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto

Re: [yocto] [meta-security][PATCH 05/17] tpm2simulator: add package

[akuster808]

On 10/17/2016 05:13 PM, Khem Raj wrote:

On Oct 17, 2016, at 5:02 PM, Armin Kuster  wrote:

Signed-off-by: Armin Kuster 
---
.../tpm2simulator/tpm2simulator-native_116.bb  | 25 ++
1 file changed, 25 insertions(+)
create mode 100644 recipes-tpm/tpm2simulator/tpm2simulator-native_116.bb

diff --git a/recipes-tpm/tpm2simulator/tpm2simulator-native_116.bb 
b/recipes-tpm/tpm2simulator/tpm2simulator-native_116.bb
new file mode 100644
index 000..33eaf99
--- /dev/null
+++ b/recipes-tpm/tpm2simulator/tpm2simulator-native_116.bb
@@ -0,0 +1,25 @@
+SUMMARY = "TPM 2.0 Simulator Extraction Script"
+LICENSE = "BSD-2-Clause"
+LIC_FILES_CHKSUM = "file://../LICENSE;md5=1415f7be284540b81d9d28c67c1a6b8b"
+
+DEPENDS += "python"
+
+SRCREV = "93dc4412432013ed7bcabd42007754c68f6e362e"
+SRC_URI = "git://github.com/stwagnr/tpm2simulator.git"
+
+S = "${WORKDIR}/git/cmake"
+
+PV = "116+git${SRCPV}"
+
+inherit native lib_package cmake
+
+EXTRA_OECMAKE = " \
+   -DCMAKE_BUILD_TYPE=Debug \
+   -DSPEC_VERSION=116 \
+"
+
+do_configure_prepend () {
+   sed -i 's/^SET = False/SET = True/' ${WORKDIR}/git/scripts/settings.py

use S instead of WORKDIR

S = "${WORKDIR}/git/cmake"

that file does not reside there.

the build process does a relative ref outside the "cmake" dir to run the 
scripts.


unless you mean I should do " ${S}/../scripts/settings.py" ?



+}
+
+BBCLASSEXTEND = “native"

it is not needed.

k

thanks for the review.

- armin



--
2.7.4

--
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto





-- 
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto

Re: [yocto] [meta-security][PATCH 05/17] tpm2simulator: add package

[Khem Raj]

> On Oct 17, 2016, at 5:02 PM, Armin Kuster  wrote:
> 
> Signed-off-by: Armin Kuster 
> ---
> .../tpm2simulator/tpm2simulator-native_116.bb  | 25 ++
> 1 file changed, 25 insertions(+)
> create mode 100644 recipes-tpm/tpm2simulator/tpm2simulator-native_116.bb
> 
> diff --git a/recipes-tpm/tpm2simulator/tpm2simulator-native_116.bb 
> b/recipes-tpm/tpm2simulator/tpm2simulator-native_116.bb
> new file mode 100644
> index 000..33eaf99
> --- /dev/null
> +++ b/recipes-tpm/tpm2simulator/tpm2simulator-native_116.bb
> @@ -0,0 +1,25 @@
> +SUMMARY = "TPM 2.0 Simulator Extraction Script"
> +LICENSE = "BSD-2-Clause"
> +LIC_FILES_CHKSUM = "file://../LICENSE;md5=1415f7be284540b81d9d28c67c1a6b8b"
> +
> +DEPENDS += "python"
> +
> +SRCREV = "93dc4412432013ed7bcabd42007754c68f6e362e"
> +SRC_URI = "git://github.com/stwagnr/tpm2simulator.git"
> +
> +S = "${WORKDIR}/git/cmake"
> +
> +PV = "116+git${SRCPV}"
> +
> +inherit native lib_package cmake
> +
> +EXTRA_OECMAKE = " \
> + -DCMAKE_BUILD_TYPE=Debug \
> + -DSPEC_VERSION=116 \
> +"
> +
> +do_configure_prepend () {
> + sed -i 's/^SET = False/SET = True/' ${WORKDIR}/git/scripts/settings.py

use S instead of WORKDIR

> +}
> +
> +BBCLASSEXTEND = “native"

it is not needed.

> --
> 2.7.4
> 
> --
> ___
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto



signature.asc
Description: Message signed with OpenPGP using GPGMail
-- 
___
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto