Re: [Zeitgeist] [Merge] lp:~mhr3/zeitgeist/fts-secondary-sorting into lp:zeitgeist

2012-03-08 Thread Michal Hruby
I'm starting to think that doing the secondary sorting in FTS isn't a good 
idea, we're sending the relevancies to the client, so we should keep the full 
Zeitgeist sorting, and since the client has the relevancies, it can do this 
kind of sort itself (or not).
-- 
https://code.launchpad.net/~mhr3/zeitgeist/fts-secondary-sorting/+merge/96479
Your team Zeitgeist Framework Team is requested to review the proposed merge of 
lp:~mhr3/zeitgeist/fts-secondary-sorting into lp:zeitgeist.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


[Zeitgeist] [Bug 926652] Re: security/privacy hole in zeitgeist

2012-03-08 Thread Siegfried Gevatter
** Changed in: zeitgeist (Ubuntu)
   Status: Confirmed = Fix Released

-- 
You received this bug notification because you are a member of Zeitgeist
Framework Team, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/926652

Title:
  security/privacy hole in zeitgeist

Status in Zeitgeist Framework:
  Fix Released
Status in “zeitgeist” package in Ubuntu:
  Fix Released

Bug description:
  zeitgeist data files don't seem to use the write permissions by
  default:

  user@machine:~/.local/share/zeitgeist$ ls -l
  total 7244
  -rw-r--r-- 1 user user 3776512 2012-02-03 23:47 activity.sqlite
  -rw-rw-r-- 1 user user 1996800 2011-10-17 03:09 activity.sqlite.bck
  -rw-r--r-- 1 user user 1623848 2012-02-03 23:47 activity.sqlite-journal

  so that any user on the same machine (or with network access to the
  home drive), including the guest user, will be able to read the highly
  sensitive private information of everybody else and use it to
  blackmail the users, or whatever nasty things one could do with
  private information.

  this could be fixed by having the right permissions or even better by
  making all the privacy-killing features of ubuntu opt in...

To manage notifications about this bug go to:
https://bugs.launchpad.net/zeitgeist/+bug/926652/+subscriptions

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp


Re: [Zeitgeist] [Merge] lp:~mhr3/zeitgeist/fts-secondary-sorting into lp:zeitgeist

2012-03-08 Thread Siegfried Gevatter
As discussed on IRC, I don't really like how this is ending up. We should look 
into re-architecting FTS at some point, starting from the assumption that it's 
only for searching current documents (so it may change from storing all events 
to storing one of each subjects + event information, or whatever). But since 
this stuff is supposed to be working in Precise, I guess it's fine to go with 
the workaround for now.

The main problem I see with the MP right now is that it's just looking at the 
URI when re-requesting the events, so if the request was for something 
particular (especially event interpretation, event manifestation or actor, 
since the subject data could be seen as somewhat more constant) it's likely to 
end up giving a wrong sort of event.

A possible way of fixing this would be merging the uri templates with the 
request templates (the ones used in CompileEventFilterQuery). The trivial 
implementation would go something like:

tmpls = []
for template in templates:
  for uri in uris:
tmpl = copy(template)
tmpl.subject_uri = ...
tmpls.append(tmpl)

However, it may end up generating really big SQL queries (eg. consider just two 
templates for subject_interpretation={Music,Video} and a limit of 100 events; 
that becomes 200 templates with subject_interpretation and 
subject_manifestation, which is 400 conditions in the generated SQL).
-- 
https://code.launchpad.net/~mhr3/zeitgeist/fts-secondary-sorting/+merge/96479
Your team Zeitgeist Framework Team is requested to review the proposed merge of 
lp:~mhr3/zeitgeist/fts-secondary-sorting into lp:zeitgeist.

___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp