Re: [Zeitgeist] [Merge] lp:~jbicha/activity-log-manager/fix-few-warnings into lp:activity-log-manager
Review: Approve -- https://code.launchpad.net/~jbicha/activity-log-manager/fix-few-warnings/+merge/173626 Your team Activity Log Manager is subscribed to branch lp:activity-log-manager. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Merge] lp:~jbicha/activity-log-manager/fix-few-warnings into lp:activity-log-manager
The proposal to merge lp:~jbicha/activity-log-manager/fix-few-warnings into lp:activity-log-manager has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~jbicha/activity-log-manager/fix-few-warnings/+merge/173626 -- https://code.launchpad.net/~jbicha/activity-log-manager/fix-few-warnings/+merge/173626 Your team Activity Log Manager is subscribed to branch lp:activity-log-manager. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Merge] lp:~jbicha/activity-log-manager/rename-standalone-title-too into lp:activity-log-manager
The proposal to merge lp:~jbicha/activity-log-manager/rename-standalone-title-too into lp:activity-log-manager has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~jbicha/activity-log-manager/rename-standalone-title-too/+merge/173061 -- https://code.launchpad.net/~jbicha/activity-log-manager/rename-standalone-title-too/+merge/173061 Your team Activity Log Manager is subscribed to branch lp:activity-log-manager. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Merge] lp:~zeitgeist/activity-log-manager/smaller-exclude-icons into lp:activity-log-manager
Manish Sinha (मनीष सिन्हा) has proposed merging
lp:~zeitgeist/activity-log-manager/smaller-exclude-icons into
lp:activity-log-manager.
Requested reviews:
Rico Tzschichholz (ricotz)
Jeremy Bicha (jbicha)
Related bugs:
Bug #1198364 in Activity Log Manager: "Exclude list should have smaller icons"
https://bugs.launchpad.net/activity-log-manager/+bug/1198364
For more details, see:
https://code.launchpad.net/~zeitgeist/activity-log-manager/smaller-exclude-icons/+merge/173678
Fixes LP: #1198364 where exclude list has smaller icons
--
https://code.launchpad.net/~zeitgeist/activity-log-manager/smaller-exclude-icons/+merge/173678
Your team Zeitgeist Framework Team is subscribed to branch
lp:~zeitgeist/activity-log-manager/smaller-exclude-icons.
=== modified file 'src/unified-privacy.vala'
--- src/unified-privacy.vala 2013-07-09 01:34:49 +
+++ src/unified-privacy.vala 2013-07-09 09:33:25 +
@@ -481,7 +481,7 @@
else if (dir.to_string() == "G_USER_DIRECTORY_PUBLIC_SHARE")
nautilus_icon = new ThemedIcon("folder-publicshare");
if(nautilus_icon != null) {
- var pixbuf = ApplicationsTreeView.get_pixbuf_from_gio_icon(nautilus_icon, 24);
+ var pixbuf = ApplicationsTreeView.get_pixbuf_from_gio_icon(nautilus_icon, 16);
if (pixbuf != null)
icon = pixbuf;
}
@@ -519,7 +519,7 @@
private void add_app_to_view (string app) {
DesktopAppInfo app_info = new DesktopAppInfo(app);
if (app_info != null ) {
-var pix = ApplicationsTreeView.get_pixbuf_from_gio_icon(app_info.get_icon(), 24);
+var pix = ApplicationsTreeView.get_pixbuf_from_gio_icon(app_info.get_icon(), 16);
var markup = ApplicationsTreeView.markup_for_app(app_info);
TreeIter iter;
this.exception_list_store.append(out iter);
@@ -564,11 +564,11 @@
//Based on gnome-contacts contacts-cell-renderer-shape.vala
public class ExceptionCellRenderer : CellRenderer {
- private const int PIXBUF_SIZE = 24;
+ private const int PIXBUF_SIZE = 16;
private const int xspacing = 3;
private const int default_width = 60;
- private const int renderer_height = 30;
+ private const int renderer_height = 22;
private Widget current_widget;
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Merge] lp:~zeitgeist/activity-log-manager/smaller-exclude-icons into lp:activity-log-manager
The proposal to merge lp:~zeitgeist/activity-log-manager/smaller-exclude-icons into lp:activity-log-manager has been updated. Description changed to: Fixes LP: #1198364 where exclude list has smaller icons Looks like: http://i.imgur.com/zPwGMPp.png For more details, see: https://code.launchpad.net/~zeitgeist/activity-log-manager/smaller-exclude-icons/+merge/173678 -- https://code.launchpad.net/~zeitgeist/activity-log-manager/smaller-exclude-icons/+merge/173678 Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/activity-log-manager/smaller-exclude-icons. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~zeitgeist/activity-log-manager/smaller-exclude-icons into lp:activity-log-manager
Review: Needs Fixing design This looks promising, but all icons should be the same size. Folder and document icons should be just as small as app icons. -- https://code.launchpad.net/~zeitgeist/activity-log-manager/smaller-exclude-icons/+merge/173678 Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/activity-log-manager/smaller-exclude-icons. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~zeitgeist/activity-log-manager/smaller-exclude-icons into lp:activity-log-manager
Review: Disapprove I don't see the need in reducing the icon-sizes. The problem which you want to fix is not caused by them. The underlying widget structure is statically sized and therefore doesn't adapt to different font-sizes. And yes, all icons should have the same sizes. So this approach is not the right thing to do imo. (which makes the bug invalid as well) -- https://code.launchpad.net/~zeitgeist/activity-log-manager/smaller-exclude-icons/+merge/173678 Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/activity-log-manager/smaller-exclude-icons. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~zeitgeist/activity-log-manager/smaller-exclude-icons into lp:activity-log-manager
Ah, I didn't read the bug report, sorry. I think that for consistency, icons in this list should be laid out exactly the same way as icons in menu items are. That does mean they should be smaller. However, Rico is right that that wouldn't actually fix the vertical alignment of the text. In the screenshot, the text for the previous-sized folder icons is too high, but the text for the newly-sized application icons is too low. It should be vertically centered, just like text in menu items. -- https://code.launchpad.net/~zeitgeist/activity-log-manager/smaller-exclude-icons/+merge/173678 Your team Zeitgeist Framework Team is subscribed to branch lp:~zeitgeist/activity-log-manager/smaller-exclude-icons. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~malizor/activity-log-manager/fix-967150 into lp:~activity-log-manager/activity-log-manager/vala
This fix was merged more than 6 months ago and and it has yet to reach any Ubuntu version. I understand doing a release only for such a small fix is not really exciting, but what is the point of writing patches if they may never reach users? So, if no more work is planned on Activity Log Manager for Saucy, could someone just release a new package? Thanks! -- https://code.launchpad.net/~malizor/activity-log-manager/fix-967150/+merge/125556 Your team Activity Log Manager is subscribed to branch lp:~activity-log-manager/activity-log-manager/vala. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~malizor/activity-log-manager/fix-967150 into lp:~activity-log-manager/activity-log-manager/vala
I will have a look at this patch and make sure it makes it on 0.9.7 release in maybe a week. Thanks for bringing it to my notice. At the moment the focus of development is a different branch, but I will apply this patch to the focus of development branch -- https://code.launchpad.net/~malizor/activity-log-manager/fix-967150/+merge/125556 Your team Activity Log Manager is subscribed to branch lp:~activity-log-manager/activity-log-manager/vala. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~malizor/activity-log-manager/fix-967150 into lp:~activity-log-manager/activity-log-manager/vala
Thanks Manish, let me know if I need to submit a new merge request against any other branch. -- https://code.launchpad.net/~malizor/activity-log-manager/fix-967150/+merge/125556 Your team Activity Log Manager is subscribed to branch lp:~activity-log-manager/activity-log-manager/vala. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~malizor/activity-log-manager/fix-967150 into lp:~activity-log-manager/activity-log-manager/vala
It's fine. I can just merge it directly if ubuntu focus of development branch does not have this patch applied -- https://code.launchpad.net/~malizor/activity-log-manager/fix-967150/+merge/125556 Your team Activity Log Manager is subscribed to branch lp:~activity-log-manager/activity-log-manager/vala. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Merge] lp:~jbicha/activity-log-manager/fix-add-popup into lp:activity-log-manager
Jeremy Bicha has proposed merging lp:~jbicha/activity-log-manager/fix-add-popup
into lp:activity-log-manager.
Requested reviews:
Activity Log Manager (activity-log-manager)
For more details, see:
https://code.launchpad.net/~jbicha/activity-log-manager/fix-add-popup/+merge/173842
This way the Add menu drops down from the entire Add button instead of popping
up wherever it's clicked.
I think it makes bug 1198367 less noticeable.
--
https://code.launchpad.net/~jbicha/activity-log-manager/fix-add-popup/+merge/173842
Your team Activity Log Manager is requested to review the proposed merge of
lp:~jbicha/activity-log-manager/fix-add-popup into lp:activity-log-manager.
=== modified file 'src/activity-log-manager.vala'
--- src/activity-log-manager.vala 2013-07-08 02:42:55 +
+++ src/activity-log-manager.vala 2013-07-09 23:13:24 +
@@ -5,7 +5,7 @@
* Copyright (C) 2012 Manish Sinha
* Copyright (C) 2012 Intel Corp.
* Authored by: Seif Lotfy
- * Copyright (C) 2013 Jeremey Bicha
+ * Copyright (C) 2013 Jeremy Bicha
*
* alm is free software: you can redistribute it and/or modify it
* under the terms of the GNU Lesser General Public License as published
=== modified file 'src/unified-privacy.vala'
--- src/unified-privacy.vala 2013-07-09 01:34:49 +
+++ src/unified-privacy.vala 2013-07-09 23:13:24 +
@@ -299,15 +299,19 @@
exception_toolbar.get_style_context().add_class(Gtk.STYLE_CLASS_INLINE_TOOLBAR);
exception_toolbar.get_style_context().set_junction_sides(Gtk.JunctionSides.TOP);
- var exception_add = new ToolButton(null, _("Add Item"));
- exception_add.set_icon_name("list-add-symbolic");
- exception_add.clicked.connect(on_add_exception);
+ var container_add = new ToolItem();
+ var exception_add = new Gtk.MenuButton();
+ var icon = new Image.from_icon_name ("list-add-symbolic", Gtk.IconSize.MENU);
+ exception_add.set_image((Widget)icon);
+ exception_add.set_tooltip_text(_("Add Item"));
var exception_remove = new ToolButton(null, _("Remove Item"));
exception_remove.set_icon_name("list-remove-symbolic");
exception_remove.clicked.connect(on_remove_exception);
- exception_toolbar.insert(exception_add, 0);
+ container_add.add(exception_add);
+ container_add.show_all();
+ exception_toolbar.insert(container_add, 0);
exception_toolbar.insert(exception_remove, 1);
exception_menu = new Gtk.Menu ();
@@ -322,6 +326,7 @@
//exception_menu.append(file_menu);
exception_menu.append(app_menu);
exception_menu.show_all ();
+ exception_add.set_popup(exception_menu);
exception_vbox.pack_start(exception_toolbar, false, false);
@@ -358,10 +363,6 @@
add_app_to_view(app);
}
}
-
- private void on_add_exception() {
- exception_menu.popup (null, null, null, 1, get_current_event_time ());
- }
private void on_remove_exception () {
TreeSelection sel = this.exception_list.get_selection ();
@@ -388,7 +389,7 @@
private void on_add_folder() {
var chooser = new FileChooserDialog(
-_("Select a directory to blacklist"),
+_("Select a folder to blacklist"),
null, FileChooserAction.SELECT_FOLDER);
chooser.add_buttons (Stock.OK, ResponseType.OK, Stock.CANCEL, ResponseType.CANCEL);
int res = chooser.run();
___
Mailing list: https://launchpad.net/~zeitgeist
Post to : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~jbicha/activity-log-manager/fix-add-popup into lp:activity-log-manager
Review: Approve -- https://code.launchpad.net/~jbicha/activity-log-manager/fix-add-popup/+merge/173842 Your team Activity Log Manager is subscribed to branch lp:activity-log-manager. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Merge] lp:~jbicha/activity-log-manager/fix-add-popup into lp:activity-log-manager
The proposal to merge lp:~jbicha/activity-log-manager/fix-add-popup into lp:activity-log-manager has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~jbicha/activity-log-manager/fix-add-popup/+merge/173842 -- https://code.launchpad.net/~jbicha/activity-log-manager/fix-add-popup/+merge/173842 Your team Activity Log Manager is subscribed to branch lp:activity-log-manager. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Bug 970842] Re: zeitgeist-daemon memory/cpu leak when using privacy settings and dash search
** Changed in: activity-log-manager Milestone: 0.9.7 => 0.9.8 -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/970842 Title: zeitgeist-daemon memory/cpu leak when using privacy settings and dash search Status in Privacy Manager for Zeitgeist: Confirmed Status in Zeitgeist Framework: Confirmed Status in “zeitgeist” package in Ubuntu: Confirmed Bug description: Reproduce the bug: - Open gnome control center - go to privacy settings - modify a setting (e.g. delete all history). Close it. - open dahsboard - search for anything The symptoms: - the temperature of CPU rises from 45 to 70 and the fan follows. - If you click 'delete history' on gnome center [privacy], you get this in terminal as stacktrace: [21:37:07.321048 CRITICAL] zeitgeist_engine_delete_events: assertion `_tmp0__length1 > 0' failed Workaround: --- - Kill zeitgeist-daemon process or : user@pc:$~ zeitgeist-daemon --replace ProblemType: Bug DistroRelease: Ubuntu 12.04 Package: zeitgeist 0.8.99~beta1-1 ProcVersionSignature: Ubuntu 3.2.0-21.34-generic 3.2.13 Uname: Linux 3.2.0-21-generic x86_64 ApportVersion: 2.0-0ubuntu2 Architecture: amd64 Date: Sun Apr 1 16:19:39 2012 InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Release amd64 (20111012) PackageArchitecture: all SourcePackage: zeitgeist UpgradeStatus: No upgrade log present (probably fresh install) To manage notifications about this bug go to: https://bugs.launchpad.net/activity-log-manager/+bug/970842/+subscriptions ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] Activity Log Manager - Zeitgeist Privacy Manager 0.9.7 released
On behalf of the Zeitgeist Team I am happy to announce Activity Log Manager 0.9.7 What is Zeitgeist? --- Zeitgeist is a service which logs the users's activities and events, anywhere from files opened to websites visited and conversations, and makes this information readily available for other applications to use. It is also able to establish relationships between items based on similarity and usage patterns. Where can you get activity-log-manager? -- https://launchpad.net/activity-log-manager/0.9/0.9.7 Changes: -- * Application now builds even when whoopsie is not present (LP: #1197934) * Renamed "Instant Messaging" to "Chat Logs" (LP: #1198368) * Added screen Lock Option visible only in Unity (LP: #1189313) * Incognito Mode now stop even logging to GtkRecentManager (LP: #992338) * Deleting all history also purges entries in GtkRecentManager (LP: #992338) * Minor UI Changes * The standalone app is now called "Activity Log Manager" to avoid confusion with "Privacy" of upstream GNOME * Unity Online Search Tab now available visible only in Unity * The Privacy Panel in G-C-C- is now called "Security and Privacy" * Use ellipses whenever needed Thanks a lot to Jeremy Bicha for his contributions. - Manish Sinha Activity Log Manager Maintainer ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
