Re: [Zeitgeist] [Merge] lp:~tdfischer/zeitgeist/timerange-deletion-api into lp:zeitgeist
(Follow up from IRC: the too many variables bug has already been fixed) -- https://code.launchpad.net/~tdfischer/zeitgeist/timerange-deletion-api/+merge/97272 Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~tdfischer/zeitgeist/timerange-deletion-api into lp:zeitgeist
Review: Needs Fixing Hi Trever, First of all, thank you for working on this! As commented on IRC, I don't really see a point for storage_state, num_events and result_type in the event deletion method. The original proposal just had time_range and event_templates. (I'm also unconvinced that this methods performance is critical enough to warrant the complexity of duplicating the query. I think I may prefer a FindEventIds+DeleteEvents implementation, like Seif proposed.) -- https://code.launchpad.net/~tdfischer/zeitgeist/timerange-deletion-api/+merge/97272 Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~tdfischer/zeitgeist/timerange-deletion-api into lp:zeitgeist
As noted in the original bug, simply querying all the event ids in a time range and then handing it to delete_events causes the SQL error described: Too many variables -- https://code.launchpad.net/~tdfischer/zeitgeist/timerange-deletion-api/+merge/97272 Your team Zeitgeist Framework Team is subscribed to branch lp:zeitgeist. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Merge] lp:~tdfischer/zeitgeist/timerange-deletion-api into lp:zeitgeist
Trever Fischer has proposed merging lp:~tdfischer/zeitgeist/timerange-deletion-api into lp:zeitgeist with lp:~tdfischer/zeitgeist/common-where as a prerequisite. Requested reviews: Zeitgeist Framework Team (zeitgeist) Related bugs: Bug #799531 in Zeitgeist Framework: API for deletion of events within a timerange? https://bugs.launchpad.net/zeitgeist/+bug/799531 For more details, see: https://code.launchpad.net/~tdfischer/zeitgeist/timerange-deletion-api/+merge/97272 Fixes #799531 -- https://code.launchpad.net/~tdfischer/zeitgeist/timerange-deletion-api/+merge/97272 Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~tdfischer/zeitgeist/timerange-deletion-api into lp:zeitgeist. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Merge] lp:~tdfischer/zeitgeist/timerange-deletion-api into lp:zeitgeist
The proposal to merge lp:~tdfischer/zeitgeist/timerange-deletion-api into lp:zeitgeist has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~tdfischer/zeitgeist/timerange-deletion-api/+merge/97272 -- https://code.launchpad.net/~tdfischer/zeitgeist/timerange-deletion-api/+merge/97272 Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~tdfischer/zeitgeist/timerange-deletion-api into lp:zeitgeist. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
