Re: [Zeitgeist] [Merge] lp:~federico-gnome/zeitgeist/fixes into lp:zeitgeist
sounds good to me +1 Mikkel you can change that in trunk directly then :) On Thu, Jan 20, 2011 at 8:07 AM, Mikkel Kamstrup Erlandsen mikkel.kamst...@gmail.com wrote: Maybe we can replace the check for rdfpipe with something ala: python -c import rdflib if [ $? != 0 ]; then echo You need the Python module 'rdflib' in order to compile Zeitgeist exit 1 fi -- https://code.launchpad.net/~federico-gnome/zeitgeist/fixes/+merge/46803 You are subscribed to branch lp:zeitgeist. -- This is me doing some advertisement for my blog http://seilo.geekyogre.com https://code.launchpad.net/~federico-gnome/zeitgeist/fixes/+merge/46803 Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~federico-gnome/zeitgeist/fixes into lp:zeitgeist. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Merge] lp:~federico-gnome/zeitgeist/fixes into lp:zeitgeist
Federico Mena Quintero has proposed merging lp:~federico-gnome/zeitgeist/fixes into lp:zeitgeist. Requested reviews: Zeitgeist Framework Team (zeitgeist) For more details, see: https://code.launchpad.net/~federico-gnome/zeitgeist/fixes/+merge/46950 Instead of checking for rdfpipe(1), we now check for the rdflib module from python. -- https://code.launchpad.net/~federico-gnome/zeitgeist/fixes/+merge/46950 Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~federico-gnome/zeitgeist/fixes into lp:zeitgeist. === modified file 'configure.ac' --- configure.ac 2011-01-18 10:49:04 + +++ configure.ac 2011-01-20 18:39:08 + @@ -37,10 +37,13 @@ AC_MSG_ERROR(You need the tool `rapper' from the `raptor-utils' package in order to compile Zeitgeist) fi -# check for rdflib -AC_CHECK_PROG(HAVE_RDFLIB, rdfpipe, yes, no) -if test x$HAVE_RDFLIB = xno; then - AC_MSG_ERROR(You need the tool `rdfpipe' from the `python-rdflib' package in order to compile Zeitgeist) +# check for python-rdflib +AC_MSG_CHECKING([for python-rdflib]) +echo import rdflib | python - 2/dev/null +if test $? -ne 0 ; then + AC_MSG_FAILURE([failed. Please install the python-rdflib package.]) +else + AC_MSG_RESULT([yes]) fi AC_OUTPUT ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~federico-gnome/zeitgeist/fixes into lp:zeitgeist
OK, I added the necessary autofoo to do a similar check. Can someone please check it? :) -- https://code.launchpad.net/~federico-gnome/zeitgeist/fixes/+merge/46950 Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~federico-gnome/zeitgeist/fixes into lp:zeitgeist. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
[Zeitgeist] [Merge] lp:~federico-gnome/zeitgeist/fixes into lp:zeitgeist
Federico Mena Quintero has proposed merging lp:~federico-gnome/zeitgeist/fixes into lp:zeitgeist. Requested reviews: Zeitgeist Framework Team (zeitgeist) For more details, see: https://code.launchpad.net/~federico-gnome/zeitgeist/fixes/+merge/46803 Removes the check for 'rdfpipe' from configure.ac. That program is not actually needed, and comes from an obscure package (rdfextras from Google Code). -- https://code.launchpad.net/~federico-gnome/zeitgeist/fixes/+merge/46803 Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~federico-gnome/zeitgeist/fixes into lp:zeitgeist. === modified file 'configure.ac' --- configure.ac 2011-01-18 10:49:04 + +++ configure.ac 2011-01-19 19:21:30 + @@ -37,10 +37,4 @@ AC_MSG_ERROR(You need the tool `rapper' from the `raptor-utils' package in order to compile Zeitgeist) fi -# check for rdflib -AC_CHECK_PROG(HAVE_RDFLIB, rdfpipe, yes, no) -if test x$HAVE_RDFLIB = xno; then - AC_MSG_ERROR(You need the tool `rdfpipe' from the `python-rdflib' package in order to compile Zeitgeist) -fi - AC_OUTPUT ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~federico-gnome/zeitgeist/fixes into lp:zeitgeist
I believe that it's a shorthand check for the python-rdflib package. In Ubuntu, at least, that package ships this tool. We python-rdflib for parsing the ontologies at build time -- https://code.launchpad.net/~federico-gnome/zeitgeist/fixes/+merge/46803 Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~federico-gnome/zeitgeist/fixes into lp:zeitgeist. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
Re: [Zeitgeist] [Merge] lp:~federico-gnome/zeitgeist/fixes into lp:zeitgeist
Maybe we can replace the check for rdfpipe with something ala: python -c import rdflib if [ $? != 0 ]; then echo You need the Python module 'rdflib' in order to compile Zeitgeist exit 1 fi -- https://code.launchpad.net/~federico-gnome/zeitgeist/fixes/+merge/46803 Your team Zeitgeist Framework Team is requested to review the proposed merge of lp:~federico-gnome/zeitgeist/fixes into lp:zeitgeist. ___ Mailing list: https://launchpad.net/~zeitgeist Post to : zeitgeist@lists.launchpad.net Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp