Re: [zeromq-dev] Assertion failed: !more (src/fq.cpp:117)
I actually fixed this bug almost a year ago and totally forgot about it, however it was not ported to 4.1. here is the fix a year ago: https://github.com/zeromq/libzmq/commit/804bce8294daf243d14ac15f426243c568c574a6 On Fri, Oct 21, 2016 at 11:12 AM, Doron Somech wrote: > Sorry, this one should be more accurate: > > https://github.com/somdoron/libzmq/commit/5b0c7144df423b22a75c25e5e3c0d83ff70eb006 > > On Fri, Oct 21, 2016 at 10:07 AM, Doron Somech wrote: >> Try to apply following commit, I think it should fix it: >> >> https://github.com/somdoron/libzmq/commit/83e93f9ea45ff789d9fa9c92e01335a4c0386be0 >> >> Martin, what do you think? >> >> On Thu, Oct 20, 2016 at 7:28 PM, Ranjeet Kumar wrote: >>> Yes, >>> I had used >>> zsocket_set_router_handover( self->router, 1); >>> >>> in my code. >>> >>> On Thu, Oct 20, 2016 at 7:21 PM, Doron Somech wrote: Is the handover option enabled? On Fri, Sep 16, 2016 at 11:13 AM, Ranjeet Kumar wrote: > Hi Martin, > > Yes, it is very often. I am having 100k clients connecting with my > server. > So in order to run the application i had commented the line from fq.cpp > 117 > zmq_assert (!more); > > And now it is working for me. > > > Thanks > (Ranjeet Kumar) > > > On Fri, Sep 16, 2016 at 12:18 AM, Martin Hurton > wrote: >> >> Hi Ranjeet, >> >> Is this easy to reproduce? Thanks. >> >> - Martin >> >> On Sat, Sep 10, 2016 at 3:17 PM, Ranjeet Kumar >> wrote: >>> >>> Hi, >>> >>> I am using zeromq 4.1.5 and czmq 3.0.2. I am using the server-client >>> as >>> router dealer. I am getting this Assertion failed: !more >>> (src/fq.cpp:117) >>> issue while 50k clients starts making connecting with the server. >>> >>> stack trace is below: >>> Assertion failed: !more (src/fq.cpp:117) >>> >>> Program received signal SIGABRT, Aborted. >>> [Switching to Thread 0x7490d700 (LWP 24885)] >>> 0x768f15f7 in raise () from /lib64/libc.so.6 >>> Missing separate debuginfos, use: debuginfo-install >>> glibc-2.17-106.el7_2.6.x86_64 libgcc-4.8.5-4.el7.x86_64 >>> libstdc++-4.8.5-4.el7.x86_64 >>> (gdb) bt >>> #0 0x768f15f7 in raise () from /lib64/libc.so.6 >>> #1 0x768f2ce8 in abort () from /lib64/libc.so.6 >>> #2 0x77b8f769 in zmq::zmq_abort >>> (errmsg_=errmsg_@entry=0x77bc1eca "!more") at src/err.cpp:83 >>> #3 0x77b8fccd in zmq::fq_t::recvpipe >>> (this=this@entry=0x60bdc0, >>> msg_=msg_@entry=0x7490ce60, pipe_=pipe_@entry=0x7490cd08) at >>> src/fq.cpp:117 >>> #4 0x77ba3423 in zmq::router_t::xrecv (this=0x60b8d0, >>> msg_=0x7490ce60) at src/router.cpp:301 >>> #5 0x77ba878b in zmq::socket_base_t::recv >>> (this=this@entry=0x60b8d0, msg_=msg_@entry=0x7490ce60, >>> flags_=flags_@entry=0) at src/socket_base.cpp:910 >>> #6 0x77ba1015 in forward (from_=from_@entry=0x60b8d0, >>> to_=to_@entry=0x60c0b0, capture_=capture_@entry=0x0, msg_=...) at >>> src/proxy.cpp:81 >>> #7 0x77ba11e7 in zmq::proxy (frontend_=0x60b8d0, >>> backend_=0x60c0b0, capture_=0x0, control_=0x0) at src/proxy.cpp:188 >>> #8 0x00403fcf in broker_task (args=0x0) at >>> push_server.cpp:1348 >>> #9 0x7791978f in s_thread_shim (args=0x60d590) at >>> src/zthread.c:84 >>> #10 0x776b6dc5 in start_thread () from /lib64/libpthread.so.0 >>> #11 0x769b2ced in clone () from /lib64/libc.so.6 >>> >>> Any suggestion to fix this issue. >>> >>> Thanks >>> (Ranjeet Kumar) >>> >>> >>> >>> ___ >>> zeromq-dev mailing list >>> zeromq-dev@lists.zeromq.org >>> http://lists.zeromq.org/mailman/listinfo/zeromq-dev >> >> >> >> ___ >> zeromq-dev mailing list >> zeromq-dev@lists.zeromq.org >> http://lists.zeromq.org/mailman/listinfo/zeromq-dev > > > > ___ > zeromq-dev mailing list > zeromq-dev@lists.zeromq.org > http://lists.zeromq.org/mailman/listinfo/zeromq-dev ___ zeromq-dev mailing list zeromq-dev@lists.zeromq.org http://lists.zeromq.org/mailman/listinfo/zeromq-dev >>> >>> >>> >>> ___ >>> zeromq-dev mailing list >>> zeromq-dev@lists.zeromq.org >>> http://lists.zeromq.org/mailman/listinfo/zeromq-dev ___ zeromq-dev mailing list zeromq-dev@lists.zeromq.org http://lists.zeromq.org/mailman/listinfo/zeromq-dev
Re: [zeromq-dev] Assertion failed: !more (src/fq.cpp:117) = fix works!
Not really, only if you are in the middle of receiving multipart message you will continue to get it. If not, you won't get any pending messages. On Fri, Oct 21, 2016 at 1:23 PM, zmqdev wrote: > Hi Doron, > > I tried out your latest repo > > > https://github.com/somdoron/libzmq/commit/3775d0853a8c1f1c3854a94c7fe12e78046faeca > > with the changes to src/socket_base.cpp, src/pipe.cpp and src/pipe.hpp. > > I confirm that the problem reported at > > https://github.com/zeromq/libzmq/issues/2163 > > is solved: the assertion in src/fq.cpp:118 is not triggered anymore. > > Thanks! > > There is one point I'm unsure about. The documentation of zmq_disconnect > states > > Any outstanding messages physically received from the network but > not > yet received by the application with _zmq_recv()_ shall be > discarded. > > https://github.com/zeromq/libzmq/blob/master/doc/zmq_disconnect.txt#L19-L20 > > In the PUB->SUB test case, the message is not discarded by the > zmq_disconnect, and is received (sans abort) with zmq_msg_recv. > > Doesn't this behavior contradict the doc? > > ___ > zeromq-dev mailing list > zeromq-dev@lists.zeromq.org > http://lists.zeromq.org/mailman/listinfo/zeromq-dev ___ zeromq-dev mailing list zeromq-dev@lists.zeromq.org http://lists.zeromq.org/mailman/listinfo/zeromq-dev
Re: [zeromq-dev] Assertion failed: !more (src/fq.cpp:117) = fix works!
Hi Doron, I tried out your latest repo https://github.com/somdoron/libzmq/commit/3775d0853a8c1f1c3854a94c7fe12e78046faeca with the changes to src/socket_base.cpp, src/pipe.cpp and src/pipe.hpp. I confirm that the problem reported at https://github.com/zeromq/libzmq/issues/2163 is solved: the assertion in src/fq.cpp:118 is not triggered anymore. Thanks! There is one point I'm unsure about. The documentation of zmq_disconnect states Any outstanding messages physically received from the network but not yet received by the application with _zmq_recv()_ shall be discarded. https://github.com/zeromq/libzmq/blob/master/doc/zmq_disconnect.txt#L19-L20 In the PUB->SUB test case, the message is not discarded by the zmq_disconnect, and is received (sans abort) with zmq_msg_recv. Doesn't this behavior contradict the doc? ___ zeromq-dev mailing list zeromq-dev@lists.zeromq.org http://lists.zeromq.org/mailman/listinfo/zeromq-dev
Re: [zeromq-dev] Assertion failed: !more (src/fq.cpp:117)
Sorry, this one should be more accurate: https://github.com/somdoron/libzmq/commit/5b0c7144df423b22a75c25e5e3c0d83ff70eb006 On Fri, Oct 21, 2016 at 10:07 AM, Doron Somech wrote: > Try to apply following commit, I think it should fix it: > > https://github.com/somdoron/libzmq/commit/83e93f9ea45ff789d9fa9c92e01335a4c0386be0 > > Martin, what do you think? > > On Thu, Oct 20, 2016 at 7:28 PM, Ranjeet Kumar wrote: >> Yes, >> I had used >> zsocket_set_router_handover( self->router, 1); >> >> in my code. >> >> On Thu, Oct 20, 2016 at 7:21 PM, Doron Somech wrote: >>> >>> Is the handover option enabled? >>> >>> On Fri, Sep 16, 2016 at 11:13 AM, Ranjeet Kumar >>> wrote: >>> > Hi Martin, >>> > >>> > Yes, it is very often. I am having 100k clients connecting with my >>> > server. >>> > So in order to run the application i had commented the line from fq.cpp >>> > 117 >>> > zmq_assert (!more); >>> > >>> > And now it is working for me. >>> > >>> > >>> > Thanks >>> > (Ranjeet Kumar) >>> > >>> > >>> > On Fri, Sep 16, 2016 at 12:18 AM, Martin Hurton >>> > wrote: >>> >> >>> >> Hi Ranjeet, >>> >> >>> >> Is this easy to reproduce? Thanks. >>> >> >>> >> - Martin >>> >> >>> >> On Sat, Sep 10, 2016 at 3:17 PM, Ranjeet Kumar >>> >> wrote: >>> >>> >>> >>> Hi, >>> >>> >>> >>> I am using zeromq 4.1.5 and czmq 3.0.2. I am using the server-client >>> >>> as >>> >>> router dealer. I am getting this Assertion failed: !more >>> >>> (src/fq.cpp:117) >>> >>> issue while 50k clients starts making connecting with the server. >>> >>> >>> >>> stack trace is below: >>> >>> Assertion failed: !more (src/fq.cpp:117) >>> >>> >>> >>> Program received signal SIGABRT, Aborted. >>> >>> [Switching to Thread 0x7490d700 (LWP 24885)] >>> >>> 0x768f15f7 in raise () from /lib64/libc.so.6 >>> >>> Missing separate debuginfos, use: debuginfo-install >>> >>> glibc-2.17-106.el7_2.6.x86_64 libgcc-4.8.5-4.el7.x86_64 >>> >>> libstdc++-4.8.5-4.el7.x86_64 >>> >>> (gdb) bt >>> >>> #0 0x768f15f7 in raise () from /lib64/libc.so.6 >>> >>> #1 0x768f2ce8 in abort () from /lib64/libc.so.6 >>> >>> #2 0x77b8f769 in zmq::zmq_abort >>> >>> (errmsg_=errmsg_@entry=0x77bc1eca "!more") at src/err.cpp:83 >>> >>> #3 0x77b8fccd in zmq::fq_t::recvpipe >>> >>> (this=this@entry=0x60bdc0, >>> >>> msg_=msg_@entry=0x7490ce60, pipe_=pipe_@entry=0x7490cd08) at >>> >>> src/fq.cpp:117 >>> >>> #4 0x77ba3423 in zmq::router_t::xrecv (this=0x60b8d0, >>> >>> msg_=0x7490ce60) at src/router.cpp:301 >>> >>> #5 0x77ba878b in zmq::socket_base_t::recv >>> >>> (this=this@entry=0x60b8d0, msg_=msg_@entry=0x7490ce60, >>> >>> flags_=flags_@entry=0) at src/socket_base.cpp:910 >>> >>> #6 0x77ba1015 in forward (from_=from_@entry=0x60b8d0, >>> >>> to_=to_@entry=0x60c0b0, capture_=capture_@entry=0x0, msg_=...) at >>> >>> src/proxy.cpp:81 >>> >>> #7 0x77ba11e7 in zmq::proxy (frontend_=0x60b8d0, >>> >>> backend_=0x60c0b0, capture_=0x0, control_=0x0) at src/proxy.cpp:188 >>> >>> #8 0x00403fcf in broker_task (args=0x0) at >>> >>> push_server.cpp:1348 >>> >>> #9 0x7791978f in s_thread_shim (args=0x60d590) at >>> >>> src/zthread.c:84 >>> >>> #10 0x776b6dc5 in start_thread () from /lib64/libpthread.so.0 >>> >>> #11 0x769b2ced in clone () from /lib64/libc.so.6 >>> >>> >>> >>> Any suggestion to fix this issue. >>> >>> >>> >>> Thanks >>> >>> (Ranjeet Kumar) >>> >>> >>> >>> >>> >>> >>> >>> ___ >>> >>> zeromq-dev mailing list >>> >>> zeromq-dev@lists.zeromq.org >>> >>> http://lists.zeromq.org/mailman/listinfo/zeromq-dev >>> >> >>> >> >>> >> >>> >> ___ >>> >> zeromq-dev mailing list >>> >> zeromq-dev@lists.zeromq.org >>> >> http://lists.zeromq.org/mailman/listinfo/zeromq-dev >>> > >>> > >>> > >>> > ___ >>> > zeromq-dev mailing list >>> > zeromq-dev@lists.zeromq.org >>> > http://lists.zeromq.org/mailman/listinfo/zeromq-dev >>> ___ >>> zeromq-dev mailing list >>> zeromq-dev@lists.zeromq.org >>> http://lists.zeromq.org/mailman/listinfo/zeromq-dev >> >> >> >> ___ >> zeromq-dev mailing list >> zeromq-dev@lists.zeromq.org >> http://lists.zeromq.org/mailman/listinfo/zeromq-dev ___ zeromq-dev mailing list zeromq-dev@lists.zeromq.org http://lists.zeromq.org/mailman/listinfo/zeromq-dev
Re: [zeromq-dev] Assertion failed: !more (src/fq.cpp:117)
Try to apply following commit, I think it should fix it: https://github.com/somdoron/libzmq/commit/83e93f9ea45ff789d9fa9c92e01335a4c0386be0 Martin, what do you think? On Thu, Oct 20, 2016 at 7:28 PM, Ranjeet Kumar wrote: > Yes, > I had used > zsocket_set_router_handover( self->router, 1); > > in my code. > > On Thu, Oct 20, 2016 at 7:21 PM, Doron Somech wrote: >> >> Is the handover option enabled? >> >> On Fri, Sep 16, 2016 at 11:13 AM, Ranjeet Kumar >> wrote: >> > Hi Martin, >> > >> > Yes, it is very often. I am having 100k clients connecting with my >> > server. >> > So in order to run the application i had commented the line from fq.cpp >> > 117 >> > zmq_assert (!more); >> > >> > And now it is working for me. >> > >> > >> > Thanks >> > (Ranjeet Kumar) >> > >> > >> > On Fri, Sep 16, 2016 at 12:18 AM, Martin Hurton >> > wrote: >> >> >> >> Hi Ranjeet, >> >> >> >> Is this easy to reproduce? Thanks. >> >> >> >> - Martin >> >> >> >> On Sat, Sep 10, 2016 at 3:17 PM, Ranjeet Kumar >> >> wrote: >> >>> >> >>> Hi, >> >>> >> >>> I am using zeromq 4.1.5 and czmq 3.0.2. I am using the server-client >> >>> as >> >>> router dealer. I am getting this Assertion failed: !more >> >>> (src/fq.cpp:117) >> >>> issue while 50k clients starts making connecting with the server. >> >>> >> >>> stack trace is below: >> >>> Assertion failed: !more (src/fq.cpp:117) >> >>> >> >>> Program received signal SIGABRT, Aborted. >> >>> [Switching to Thread 0x7490d700 (LWP 24885)] >> >>> 0x768f15f7 in raise () from /lib64/libc.so.6 >> >>> Missing separate debuginfos, use: debuginfo-install >> >>> glibc-2.17-106.el7_2.6.x86_64 libgcc-4.8.5-4.el7.x86_64 >> >>> libstdc++-4.8.5-4.el7.x86_64 >> >>> (gdb) bt >> >>> #0 0x768f15f7 in raise () from /lib64/libc.so.6 >> >>> #1 0x768f2ce8 in abort () from /lib64/libc.so.6 >> >>> #2 0x77b8f769 in zmq::zmq_abort >> >>> (errmsg_=errmsg_@entry=0x77bc1eca "!more") at src/err.cpp:83 >> >>> #3 0x77b8fccd in zmq::fq_t::recvpipe >> >>> (this=this@entry=0x60bdc0, >> >>> msg_=msg_@entry=0x7490ce60, pipe_=pipe_@entry=0x7490cd08) at >> >>> src/fq.cpp:117 >> >>> #4 0x77ba3423 in zmq::router_t::xrecv (this=0x60b8d0, >> >>> msg_=0x7490ce60) at src/router.cpp:301 >> >>> #5 0x77ba878b in zmq::socket_base_t::recv >> >>> (this=this@entry=0x60b8d0, msg_=msg_@entry=0x7490ce60, >> >>> flags_=flags_@entry=0) at src/socket_base.cpp:910 >> >>> #6 0x77ba1015 in forward (from_=from_@entry=0x60b8d0, >> >>> to_=to_@entry=0x60c0b0, capture_=capture_@entry=0x0, msg_=...) at >> >>> src/proxy.cpp:81 >> >>> #7 0x77ba11e7 in zmq::proxy (frontend_=0x60b8d0, >> >>> backend_=0x60c0b0, capture_=0x0, control_=0x0) at src/proxy.cpp:188 >> >>> #8 0x00403fcf in broker_task (args=0x0) at >> >>> push_server.cpp:1348 >> >>> #9 0x7791978f in s_thread_shim (args=0x60d590) at >> >>> src/zthread.c:84 >> >>> #10 0x776b6dc5 in start_thread () from /lib64/libpthread.so.0 >> >>> #11 0x769b2ced in clone () from /lib64/libc.so.6 >> >>> >> >>> Any suggestion to fix this issue. >> >>> >> >>> Thanks >> >>> (Ranjeet Kumar) >> >>> >> >>> >> >>> >> >>> ___ >> >>> zeromq-dev mailing list >> >>> zeromq-dev@lists.zeromq.org >> >>> http://lists.zeromq.org/mailman/listinfo/zeromq-dev >> >> >> >> >> >> >> >> ___ >> >> zeromq-dev mailing list >> >> zeromq-dev@lists.zeromq.org >> >> http://lists.zeromq.org/mailman/listinfo/zeromq-dev >> > >> > >> > >> > ___ >> > zeromq-dev mailing list >> > zeromq-dev@lists.zeromq.org >> > http://lists.zeromq.org/mailman/listinfo/zeromq-dev >> ___ >> zeromq-dev mailing list >> zeromq-dev@lists.zeromq.org >> http://lists.zeromq.org/mailman/listinfo/zeromq-dev > > > > ___ > zeromq-dev mailing list > zeromq-dev@lists.zeromq.org > http://lists.zeromq.org/mailman/listinfo/zeromq-dev ___ zeromq-dev mailing list zeromq-dev@lists.zeromq.org http://lists.zeromq.org/mailman/listinfo/zeromq-dev