Re: [zeta-dev] Review request about components Document

2011-07-09 Thread flyingmana

Am 09.07.2011 18:49, schrieb Fabrice PICCINALI:

hello devs,

i am new to Zeta and i do not know what is the best way to improve Zeta.

I have made a little patch for a bug in component Document.

What can i do in order to help for including this patch in the depot ?

It would be nice to get some feedback : validation, critics, flames, 
other about this.


Everything is there :
https://issues.apache.org/jira/browse/ZETACOMP-82

Cheers,
Fabrice


hi,

i have no commit rights, but as you only add a functionality, it should 
easy get into the repository.

If you want to help even more, you could add a unittest for this case.


[zeta-dev] Review request about components Document

2011-07-09 Thread Fabrice PICCINALI

hello devs,

i am new to Zeta and i do not know what is the best way to improve Zeta.

I have made a little patch for a bug in component Document.

What can i do in order to help for including this patch in the depot ?

It would be nice to get some feedback : validation, critics, flames, other 
about this.

Everything is there :
https://issues.apache.org/jira/browse/ZETACOMP-82

Cheers,
Fabrice



[zeta-dev] sqlabstraction update -> multiple tables @ once

2011-07-09 Thread Dominique 'NetAndroid' Schramm
Hi,

i put my head into the core of the sqlabstraction to find out how an
update performs for multiple tables. for an example:

$q = $pdb->createUpdateQuery();
$q->update('`domains`,`emailaddresses`')
->set('`domains.change`', '0')
->set('`emailaddresses.change`', '0');
$stmt = $q->prepare();
$stmt->execute();

@ the sqlabstraction i found the following code:

line:104
public function update( $table )
{
$table = $this->getIdentifier( $table );
$this->table = $table;
return $this;
}

this code means for me that only one table at once is possible. but why?
i think it will be quite simple to extend this section for multiple
tables update like the sql query. i am not perhaps i can create the code
and give it back to you?

-- 
Dominique 'NetAndroid' Schramm
- Twitter: @NetAndroid_BY
- Identi.ca: @netandroid
- Blog: http://netandroid.nl/