[jira] Created: (ZOOKEEPER-114) cleanup ugly event messages in zookeeper client
cleanup ugly event messages in zookeeper client
---
Key: ZOOKEEPER-114
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-114
Project: Zookeeper
Issue Type: Improvement
Components: java client
Reporter: Patrick Hunt
Fix For: 3.0.0
Cleanup the event messages output by the java command line client:
The java client ZooKeeper.java has a process method in MyWatcher that prints
raw event information to the console. Many new users find this confusing (esp
since state changes have a null path).
public void process(WatcherEvent event) {
System.err.println(event.getPath() + ": " + event.getState() + "-"
+ event.getType());
}
If this is a state change we should print that, if it's an event we should
print that (state change doesn't have a path). Somewhere in the message we
should also indicate that the client received a watch notification from the
server.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-108) sync implementation reorders operations
[
https://issues.apache.org/jira/browse/ZOOKEEPER-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620462#action_12620462
]
Mahadev konar commented on ZOOKEEPER-108:
-
it took me a while to understand the bug and the fix :) ...
the patch looks good -- with a few comments --
1) there are two unnecessary imports --
one of commitprocessor in followerrequestprocessor
the other one of linkedlist in followerzookeeperserver
can we remove them?
2)
this code is a little confusing thugh it was there before as well --
if(request.type == ZooDefs.OpCode.sync){
zks.getLeader().processSync(request);
if(!zks.getLeader().syncHandler.containsKey(request.sessionId)){
zks.getLeader().syncHandler.put(request.sessionId, null);
nextProcessor.processRequest(request);
}
}
this is in ProposalRequestProcessor -
why dont we do nextprocessor.processRequest if we have the session in the
synchandler?
> sync implementation reorders operations
> ---
>
> Key: ZOOKEEPER-108
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-108
> Project: Zookeeper
> Issue Type: Bug
> Components: server
>Reporter: Flavio Paiva Junqueira
>Assignee: Flavio Paiva Junqueira
> Attachments: SyncTest.java, ZOOKEEPER-108.patch
>
>
> The current implementation of sync is broken. There is a race condition that
> causes a follower to return operations out of order, causing clients to drop
> their connections to a server.
> I'll be attaching a patch to fix this problem shortly.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-82: -- Attachment: ZOOKEEPER-82-b.patch I took the liberty of updating the patch for the following: 1) fixed the use of ObservableNIOServerCnxn in favor of NIOServerCnxn factory. 2) recreated the patch - applies cleanly (on my system at least). If the changes are acceptable please submit for review. > Make the ZooKeeperServer more DI friendly > - > > Key: ZOOKEEPER-82 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: ZOOKEEPER-82-b.patch, ZOOKEEPER-82-b.patch > > > Proposed changes were discussed in [this mailing list > thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED]: > Basic goals are: > * Decouple the current configuration system from the public API. I > see stuff like ZooKeeperServer being coupled to ServerConfig a bit. > * Allow the use of setter injection in addition to constructor > injection. This is the most important thing needed to let spring more > easily configure the objects. > * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-113) ZooKeeper.java should be interface not concrete class.
ZooKeeper.java should be interface not concrete class. -- Key: ZOOKEEPER-113 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-113 Project: Zookeeper Issue Type: Improvement Components: java client Reporter: Patrick Hunt I think ZooKeeper class in src/java/main should be an interface rather than a concrete class. Among other OO goodness this would give us more flexibility when implementing tests on client code. Would also require something like a factory to be created, which might actually work well with another JIRA we have which is the idea to use a URI(s) rather than a host:port combination when creating zookeeper clients. Unfortunately this would have a big impact on clients as it's not b/w compatible (instantiating a new client that is). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-112) src/java/main ZooKeeper.java has test code embedded into it.
src/java/main ZooKeeper.java has test code embedded into it. Key: ZOOKEEPER-112 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-112 Project: Zookeeper Issue Type: Bug Components: tests Reporter: Patrick Hunt Assignee: Patrick Hunt src/java/main ZooKeeper.java has a method "public void disconnect()" that is not part of the public api but put there for testing purposes (to test disconnection of the client from the server w/o actually shutting down the session) This method needs to be moved out of the public api. preferably we should have a subclass in the test code itself that provides this method. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated ZOOKEEPER-110: -- Attachment: (was: revthrushell.diff) > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: ZOOKEEPER-110.patch > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated ZOOKEEPER-110: -- Attachment: (was: svntask.diff) > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: ZOOKEEPER-110.patch > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated ZOOKEEPER-110: -- Attachment: ZOOKEEPER-110.patch renamed patch, deleted old version. > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: ZOOKEEPER-110.patch > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620407#action_12620407 ] Patrick Hunt commented on ZOOKEEPER-110: I'm against (-1) adding any new dependencies... eg powershell. Andrew -- would you be able to provide a working .bat file? Jakob -- FYI we are following a convention for patch file naming such as "ZOOKEEPER-110.patch" where the file name is the ID of the jira issue. If you update a patch just re-upload with the same name, jira maintains a history of files with the same name. (please remove the old/invalid patches). Among other things this helps reviewers to keep track of the various patches. Thanks. > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: revthrushell.diff, svntask.diff > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620404#action_12620404 ] Patrick Hunt commented on ZOOKEEPER-110: I noticed this in the ant exec manpage: Cygwin Users The task will not understand paths such as /bin/sh for the executable parameter. This is because the Java VM in which Ant is running is a standard Windows executable and is not aware of the Cygwin environment (i.e., doesn't load cygwin1.dll). The only work-around for this is to compile a JVM under Cygwin (at your own risk). See for instance sun jdk 6 build instructions for cygwin. I created a simple build.xml and regardless of whether I run under cmd or cygwin bash I still get "Windows XP" as the os.name. What about Mac users, are they covered as well? > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: revthrushell.diff, svntask.diff > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated ZOOKEEPER-110: -- Attachment: revthrushell.diff I've re-done the patch to use a shell script to obtain the revision number, ala Hadoop's approach. This works on *nix machines, maintains functionality, removes the reliance on svnant (which can be deleted from the lib directory) and introduces no new dependencies. As far as Windows machines go, the operating system's poor default scripting environment makes this rather easy task pretty difficult. However, it would be easy enough to do in MS Powershell, and I don't think it's unreasonable to expect developers' machines to have that tool installed at this point. So I could certainly write up an equivalent script in Powershell, create another exec task targeted to Windows, and we'd be back to good without introducing a cygwin dependency (just a Powershell one). One unknown: I don't know how ant would identify a Windows machine with cygwin but without Powershell. Let me know if this sounds reasonable. If so, I can explore that option. Hope this is useful. -jg > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: revthrushell.diff, svntask.diff > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-63) Race condition in client close() operation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620396#action_12620396 ] Patrick Hunt commented on ZOOKEEPER-63: --- Assigning to myself - I've cleaned up the tests as part of ZOOKEEPER-111 (this was blocking progress on this issue). I'll dig into this issue now. Looking at the code for zk close it seems to me that the issue is related to how the client send/event threads manage state. In particular these threads look "out/up" at the parent (zookeeper.state) rather than managing state internally and having operations for code (zk client) to make changes to that state. There is a race condition in the close where sendthread thinks that the connection is still open (not closed) and retries the server connection rather than shutting down. I will probably have to have significant changes to how send/event threads are managed - they need to manage their own internal state and take updates from zookeeper client we'll see. > Race condition in client close() operation > -- > > Key: ZOOKEEPER-63 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-63 > Project: Zookeeper > Issue Type: Bug > Components: java client >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Attachments: patch_ZOOKEEPER-63.patch > > > There is a race condition in the java close operation on ZooKeeper.java. > Client is sending a disconnect request to the server. Server will close any > open connections with the client when it receives this. If the client has not > yet shutdown it's subthreads (event/send threads for example) these threads > may consider the condition an error. We see this alot in the tests where the > clients output error logs because they are unaware that a disconnection has > been requested by the client. > Ben mentioned: perhaps we just have to change state to closed (on client) > before sending disconnect request. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-63) Race condition in client close() operation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reassigned ZOOKEEPER-63: - Assignee: Patrick Hunt (was: james strachan) > Race condition in client close() operation > -- > > Key: ZOOKEEPER-63 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-63 > Project: Zookeeper > Issue Type: Bug > Components: java client >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Attachments: patch_ZOOKEEPER-63.patch > > > There is a race condition in the java close operation on ZooKeeper.java. > Client is sending a disconnect request to the server. Server will close any > open connections with the client when it receives this. If the client has not > yet shutdown it's subthreads (event/send threads for example) these threads > may consider the condition an error. We see this alot in the tests where the > clients output error logs because they are unaware that a disconnection has > been requested by the client. > Ben mentioned: perhaps we just have to change state to closed (on client) > before sending disconnect request. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-111) significant cleanup of existing tests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-111: --- Status: Patch Available (was: Open) > significant cleanup of existing tests > - > > Key: ZOOKEEPER-111 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-111 > Project: Zookeeper > Issue Type: Improvement > Components: tests >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Attachments: ZOOKEEPER-111.patch > > > About to submit a patch that significantly cleans up existing tests. > 1) removed the need for "sleep" calls in the tests, instead I monitor the > status of the server (using the client socket "stat" command) which provides > a barrier to the client test operations. I use this barrier both when > starting and ending the test. > 2) also fixed a number of problems in the tests where the test itself was > broken. > 3) general cleanup and some refactoring to make it easier to write new tests, > maintain old, and track down issues if the test does find a problem. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-111) significant cleanup of existing tests
[ https://issues.apache.org/jira/browse/ZOOKEEPER-111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-111: --- Attachment: ZOOKEEPER-111.patch This patch is tested/passing on three machines: 1) my personal 1cpu 1.2ghz machine ubuntu 2) hudson zones machine (dual core x86 solaris) 3) 2cpu dualcore (4cores) 2ghz rhel Note: I've comment out testReuse in SessionTest for the time being. The bug in ZOOKEEPER-63 is causing this test to fail (intermittently). I've updated that jira to note this issue and as part of fixing that bug I will re-enable this test. Otw all tests are maintained from the mainline. > significant cleanup of existing tests > - > > Key: ZOOKEEPER-111 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-111 > Project: Zookeeper > Issue Type: Improvement > Components: tests >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Attachments: ZOOKEEPER-111.patch > > > About to submit a patch that significantly cleans up existing tests. > 1) removed the need for "sleep" calls in the tests, instead I monitor the > status of the server (using the client socket "stat" command) which provides > a barrier to the client test operations. I use this barrier both when > starting and ending the test. > 2) also fixed a number of problems in the tests where the test itself was > broken. > 3) general cleanup and some refactoring to make it easier to write new tests, > maintain old, and track down issues if the test does find a problem. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-63) Race condition in client close() operation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-63?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620386#action_12620386 ] Patrick Hunt commented on ZOOKEEPER-63: --- SessionTest testReuse test is intermittently failing seeming due to this issue. > Race condition in client close() operation > -- > > Key: ZOOKEEPER-63 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-63 > Project: Zookeeper > Issue Type: Bug > Components: java client >Reporter: Patrick Hunt >Assignee: james strachan > Attachments: patch_ZOOKEEPER-63.patch > > > There is a race condition in the java close operation on ZooKeeper.java. > Client is sending a disconnect request to the server. Server will close any > open connections with the client when it receives this. If the client has not > yet shutdown it's subthreads (event/send threads for example) these threads > may consider the condition an error. We see this alot in the tests where the > clients output error logs because they are unaware that a disconnection has > been requested by the client. > Ben mentioned: perhaps we just have to change state to closed (on client) > before sending disconnect request. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-111) significant cleanup of existing tests
significant cleanup of existing tests - Key: ZOOKEEPER-111 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-111 Project: Zookeeper Issue Type: Improvement Components: tests Reporter: Patrick Hunt Assignee: Patrick Hunt About to submit a patch that significantly cleans up existing tests. 1) removed the need for "sleep" calls in the tests, instead I monitor the status of the server (using the client socket "stat" command) which provides a barrier to the client test operations. I use this barrier both when starting and ending the test. 2) also fixed a number of problems in the tests where the test itself was broken. 3) general cleanup and some refactoring to make it easier to write new tests, maintain old, and track down issues if the test does find a problem. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620379#action_12620379 ] Patrick Hunt commented on ZOOKEEPER-110: No worries Jakob, we appreciate your contributions and willingness to work with the community! Honestly I didn't know myself until Owen mentioned it. (that's why we have parental oversight. ;-) ) Regards. > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: svntask.diff > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620368#action_12620368 ] jghoman edited comment on ZOOKEEPER-110 at 8/6/08 11:33 AM: Yes, in the ant exec task you can specify which os the command should run on, so we should be able to write two separate exec tasks: one for win, one for *nix. I'm writing the script for linux now/modifying the buld.xml and will upload the patch in a bit. I can look at how to do it in windows as well, but I'm not sure how to get the info without a good scripting environment. Sorry if it was incorrect to upload the patch that required the bad license. -jg was (Author: jghoman): Yes, in the ant exec task you can specify which os the command should run on, so we should be able to write two separate exec tasks: one for win, one for *nix. I'm writing the script for linux now/modifying the buld.xml and will upload the patch in a bit. I can look at how to do it in windows as well, but I'm not sure how to get the info within a good scripting environment. Sorry if it was incorrect to upload the patch that required the bad license. -jg > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: svntask.diff > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620368#action_12620368 ] Jakob Homan commented on ZOOKEEPER-110: --- Yes, in the ant exec task you can specify which os the command should run on, so we should be able to write two separate exec tasks: one for win, one for *nix. I'm writing the script for linux now/modifying the buld.xml and will upload the patch in a bit. I can look at how to do it in windows as well, but I'm not sure how to get the info within a good scripting environment. Sorry if it was incorrect to upload the patch that required the bad license. -jg > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: svntask.diff > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620364#action_12620364 ] Patrick Hunt commented on ZOOKEEPER-110: We don't want to add dependency on cygwin for zookeeper. What other options are available? In ant there is no way to determine we are on windows and run another script? > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: svntask.diff > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620340#action_12620340 ] Owen O'Malley commented on ZOOKEEPER-110: - And the script *does* work on Windows, provided you have cygwin installed. > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: svntask.diff > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620337#action_12620337 ] Doug Cutting commented on ZOOKEEPER-110: > The task will fail on Windows - it won't be able to find the > executable "sh.exe". Hadoop requires cygwin on Windows. > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: svntask.diff > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620329#action_12620329 ] Andrew Kornev commented on ZOOKEEPER-110: - I'd like to point out that the hadoop's solution is non-portable. The task will fail on Windows -- it won't be able to find the executable "sh.exe". By the way, this portability issue was one of the reasons we had to use svnant. > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: svntask.diff > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12620323#action_12620323 ] Owen O'Malley commented on ZOOKEEPER-110: - Basically, the saveVersion script creates a Java source file that defines a package level attribute. There is a utility class that looks for the attribute and uses it if it is available. I took that approach so that the project compiles and runs, even if the script was not run to generate the version information. > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: svntask.diff > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-110: --- Assignee: Jakob Homan Status: Open (was: Patch Available) I'm +1 on this change, -1 on using svntask re the issues Owen mentioned. Jakob -- notice that Hadoop core does something very similar, however they use a script, could you reuse this rather than relying on a third party library? http://svn.apache.org/repos/asf/hadoop/core/trunk/build.xml http://svn.apache.org/repos/asf/hadoop/core/trunk/src/saveVersion.sh > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: svntask.diff > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Build failed in Hudson: ZooKeeper-trunk #45
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/45/changes -- [...truncated 19830 lines...] [junit] at org.apache.zookeeper.server.ZooKeeperServer.touch(ZooKeeperServer.java:697) [junit] at org.apache.zookeeper.server.ZooKeeperServer.submitRequest(ZooKeeperServer.java:867) [junit] at org.apache.zookeeper.server.NIOServerCnxn.readRequest(NIOServerCnxn.java:438) [junit] at org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:293) [junit] at org.apache.zookeeper.server.NIOServerCnxn$Factory.run(NIOServerCnxn.java:149) [junit] 2008-08-06 10:43:09,570 - INFO [SendThread:[EMAIL PROTECTED] - Attempting connection to server /127.0.0.1:33299 [junit] 2008-08-06 10:43:09,571 - INFO [SendThread:[EMAIL PROTECTED] - Priming connection to java.nio.channels.SocketChannel[connected local=/127.0.0.1:33305 remote=/127.0.0.1:33299] [junit] 2008-08-06 10:43:09,576 - WARN [NIOServerCxn.Factory:[EMAIL PROTECTED] - Connected to /127.0.0.1:33305 lastZxid 0 [junit] 2008-08-06 10:43:09,576 - WARN [NIOServerCxn.Factory:[EMAIL PROTECTED] - Creating new session 11b979cc0cb0001 [junit] 2008-08-06 10:43:09,591 - WARN [SyncThread:[EMAIL PROTECTED] - Finished init of 11b979cc0cb0001: true [junit] before close zk with session id 79824117914337281! [junit] 2008-08-06 10:43:09,592 - INFO [ProcessThread:[EMAIL PROTECTED] - Processed session termination request for id: 11b979cc0cb0001 [junit] 2008-08-06 10:43:09,606 - WARN [SendThread:[EMAIL PROTECTED] - Closing: [junit] java.io.IOException: Read error rc = -1 java.nio.DirectByteBuffer[pos=0 lim=4 cap=4] [junit] at org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:491) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:718) [junit] before shutdown zs! [junit] after shutdown zs! [junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 16.958 sec [junit] Running org.apache.zookeeper.test.WatcherFuncTest [junit] 2008-08-06 10:43:10,877 - INFO [main:[EMAIL PROTECTED] - Client test setup [junit] 2008-08-06 10:43:15,970 - INFO [main:[EMAIL PROTECTED] - Client test setup finished [junit] 2008-08-06 10:43:15,987 - INFO [SendThread:[EMAIL PROTECTED] - Attempting connection to server /127.0.0.1:33221 [junit] 2008-08-06 10:43:15,988 - INFO [SendThread:[EMAIL PROTECTED] - Priming connection to java.nio.channels.SocketChannel[connected local=/127.0.0.1:33309 remote=/127.0.0.1:33221] [junit] 2008-08-06 10:43:15,997 - WARN [NIOServerCxn.Factory:[EMAIL PROTECTED] - Connected to /127.0.0.1:33309 lastZxid 0 [junit] 2008-08-06 10:43:15,999 - WARN [NIOServerCxn.Factory:[EMAIL PROTECTED] - Creating new session 11b979cf5e8 [junit] 2008-08-06 10:43:16,027 - WARN [SyncThread:[EMAIL PROTECTED] - Finished init of 11b979cf5e8: true [junit] 2008-08-06 10:43:16,029 - INFO [SendThread:[EMAIL PROTECTED] - Attempting connection to server /127.0.0.1:33221 [junit] 2008-08-06 10:43:16,030 - INFO [SendThread:[EMAIL PROTECTED] - Priming connection to java.nio.channels.SocketChannel[connected local=/127.0.0.1:33310 remote=/127.0.0.1:33221] [junit] 2008-08-06 10:43:16,031 - WARN [NIOServerCxn.Factory:[EMAIL PROTECTED] - Connected to /127.0.0.1:33310 lastZxid 0 [junit] 2008-08-06 10:43:16,032 - WARN [NIOServerCxn.Factory:[EMAIL PROTECTED] - Creating new session 11b979cf5e80001 [junit] 2008-08-06 10:43:16,042 - WARN [SyncThread:[EMAIL PROTECTED] - Finished init of 11b979cf5e80001: true [junit] 2008-08-06 10:43:16,215 - INFO [ProcessThread:[EMAIL PROTECTED] - Processed session termination request for id: 11b979cf5e8 [junit] 2008-08-06 10:43:16,227 - WARN [SendThread:[EMAIL PROTECTED] - Closing: [junit] java.io.IOException: Read error rc = -1 java.nio.DirectByteBuffer[pos=0 lim=4 cap=4] [junit] at org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:491) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:718) [junit] 2008-08-06 10:43:16,334 - INFO [ProcessThread:[EMAIL PROTECTED] - Processed session termination request for id: 11b979cf5e80001 [junit] 2008-08-06 10:43:16,343 - WARN [SendThread:[EMAIL PROTECTED] - Closing: [junit] java.io.IOException: Read error rc = -1 java.nio.DirectByteBuffer[pos=0 lim=4 cap=4] [junit] at org.apache.zookeeper.ClientCnxn$SendThread.doIO(ClientCnxn.java:491) [junit] at org.apache.zookeeper.ClientCnxn$SendThread.run(ClientCnxn.java:718) [junit] 2008-08-06 10:43:17,630 - INFO [SendThread:[EMAIL PROTECTED] - Attempting connection to server /127.0.0.1:33221 [junit] 2008-08-06 10:43:17,630 - INFO [SendThread:[EMAIL PROTECTED] - Priming connection to java.nio.channels.SocketChannel[connected local=/127.0.0.1:33311 remote=/127.0.0.1:33221] [junit] 2008-08-06 10:43:17,631
