[jira] Commented: (ZOOKEEPER-123) In two places, the wrong class is specified for the logger
[ https://issues.apache.org/jira/browse/ZOOKEEPER-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12626542#action_12626542 ] Hudson commented on ZOOKEEPER-123: -- Integrated in ZooKeeper-trunk #67 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/67/]) In two places, the wrong class is specified for the logger -- Key: ZOOKEEPER-123 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-123 Project: Zookeeper Issue Type: Bug Components: java client, tests Affects Versions: 3.0.0 Reporter: Jakob Homan Assignee: Jakob Homan Priority: Minor Fix For: 3.0.0 Attachments: ZOOKEEPER-123.patch Copy and paste strikes again. In two logger instantiations, the wrong class is passed to the constructor. In ClientTest.java and ClientCnxn.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-2) Synchronization issues in QuorumPeer and FastLeader election
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12626544#action_12626544 ] Hudson commented on ZOOKEEPER-2: Integrated in ZooKeeper-trunk #67 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/67/]) Synchronization issues in QuorumPeer and FastLeader election Key: ZOOKEEPER-2 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2 Project: Zookeeper Issue Type: Bug Components: leaderElection Reporter: Benjamin Reed Assignee: Flavio Paiva Junqueira Fix For: 3.0.0 Attachments: patch-le-polish, patch-le-polish, ZOOKEEPER-2.patch There are a couple of cases of member variables that need to be marked volatile or surrounded in a synchronization block. A couple of examples are: * QuorumPeer state should be synchronous * currentVote in QuorumPeer is marked volatile, but when it's members are often accessed individually as if they were in an atomic unit. Such code should be changed to get a reference to the currentVote and they access members through that reference. * It looks like logicalClock in FastLeaderElection should be volatile. It should either be fixed or commented to explain why it doesn't need to be. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-128) test coverage on async client operations needs to be improved
test coverage on async client operations needs to be improved - Key: ZOOKEEPER-128 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-128 Project: Zookeeper Issue Type: Improvement Components: java client Reporter: Patrick Hunt Assignee: Patrick Hunt Attachments: ZOOKEEPER-128.patch clover reports limited testing of the async client operations. need addition tests to verify this functionality. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-128) test coverage on async client operations needs to be improved
[ https://issues.apache.org/jira/browse/ZOOKEEPER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-128: --- Attachment: ZOOKEEPER-128.patch some basic async operations tests test coverage on async client operations needs to be improved - Key: ZOOKEEPER-128 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-128 Project: Zookeeper Issue Type: Improvement Components: java client Reporter: Patrick Hunt Assignee: Patrick Hunt Attachments: ZOOKEEPER-128.patch clover reports limited testing of the async client operations. need addition tests to verify this functionality. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-128) test coverage on async client operations needs to be improved
[ https://issues.apache.org/jira/browse/ZOOKEEPER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-128: --- Status: Patch Available (was: Open) test coverage on async client operations needs to be improved - Key: ZOOKEEPER-128 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-128 Project: Zookeeper Issue Type: Improvement Components: java client Reporter: Patrick Hunt Assignee: Patrick Hunt Attachments: ZOOKEEPER-128.patch clover reports limited testing of the async client operations. need addition tests to verify this functionality. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-112) src/java/main ZooKeeper.java has test code embedded into it.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-112: --- Fix Version/s: 3.0.0 Moving to 3.0.0 src/java/main ZooKeeper.java has test code embedded into it. Key: ZOOKEEPER-112 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-112 Project: Zookeeper Issue Type: Bug Components: tests Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.0.0 src/java/main ZooKeeper.java has a method public void disconnect() that is not part of the public api but put there for testing purposes (to test disconnection of the client from the server w/o actually shutting down the session) This method needs to be moved out of the public api. preferably we should have a subclass in the test code itself that provides this method. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-128) test coverage on async client operations needs to be improved
[ https://issues.apache.org/jira/browse/ZOOKEEPER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-128: --- Fix Version/s: 3.0.0 test coverage on async client operations needs to be improved - Key: ZOOKEEPER-128 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-128 Project: Zookeeper Issue Type: Improvement Components: java client Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.0.0 Attachments: ZOOKEEPER-128.patch clover reports limited testing of the async client operations. need addition tests to verify this functionality. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.