[jira] Updated: (ZOOKEEPER-112) src/java/main ZooKeeper.java has test code embedded into it.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-112: --- Attachment: ZOOKEEPER-112.patch This is the same as the last patch + it has a change to remove the processWatchEvent(event) from the public api of ZooKeeper.java client class. Basically I have a (private) nested class that implements the Watcher.process(event) method and I provide an instance of that class to the client cnxn. ZooKeeper client public intf is very clean at this point. src/java/main ZooKeeper.java has test code embedded into it. Key: ZOOKEEPER-112 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-112 Project: Zookeeper Issue Type: Bug Components: tests Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.0.0 Attachments: ZOOKEEPER-112.patch, ZOOKEEPER-112.patch src/java/main ZooKeeper.java has a method public void disconnect() that is not part of the public api but put there for testing purposes (to test disconnection of the client from the server w/o actually shutting down the session) This method needs to be moved out of the public api. preferably we should have a subclass in the test code itself that provides this method. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-112) src/java/main ZooKeeper.java has test code embedded into it.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-112: --- Status: Patch Available (was: Open) src/java/main ZooKeeper.java has test code embedded into it. Key: ZOOKEEPER-112 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-112 Project: Zookeeper Issue Type: Bug Components: tests Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.0.0 Attachments: ZOOKEEPER-112.patch, ZOOKEEPER-112.patch src/java/main ZooKeeper.java has a method public void disconnect() that is not part of the public api but put there for testing purposes (to test disconnection of the client from the server w/o actually shutting down the session) This method needs to be moved out of the public api. preferably we should have a subclass in the test code itself that provides this method. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-129) Thrift proxy
Thrift proxy Key: ZOOKEEPER-129 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-129 Project: Zookeeper Issue Type: New Feature Reporter: Chris Smith Priority: Trivial Attachments: thriftkeeper.patch This is a basic server that acts as a proxy between a thrift interface and ZooKeeper. It doesn't support watches, and I'm not entirely convinced the session handling makes sense, but it works for basic operations like creating, listing and deleting nodes. The patch puts the code and (basic) build file under src/contrib/thrift; the build file requires the thrift compiler to be in the path, and the thrift and zookeeper libraries in the lib dir. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-129) Thrift proxy
[ https://issues.apache.org/jira/browse/ZOOKEEPER-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Smith updated ZOOKEEPER-129: -- Attachment: thriftkeeper.patch Thrift proxy Key: ZOOKEEPER-129 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-129 Project: Zookeeper Issue Type: New Feature Reporter: Chris Smith Priority: Trivial Attachments: thriftkeeper.patch This is a basic server that acts as a proxy between a thrift interface and ZooKeeper. It doesn't support watches, and I'm not entirely convinced the session handling makes sense, but it works for basic operations like creating, listing and deleting nodes. The patch puts the code and (basic) build file under src/contrib/thrift; the build file requires the thrift compiler to be in the path, and the thrift and zookeeper libraries in the lib dir. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-129) Thrift proxy
[ https://issues.apache.org/jira/browse/ZOOKEEPER-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12627058#action_12627058 ] Mahadev konar commented on ZOOKEEPER-129: - chris, would you be willing to provide a complete interface that supports watches? I think it would be good to have this as a part of contrib. If you do decide on creating a complete interface, then two important things that you would need to do is 1) documentation in forrest on how it works and setup. 2) unit tests to test the interface. Thrift proxy Key: ZOOKEEPER-129 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-129 Project: Zookeeper Issue Type: New Feature Reporter: Chris Smith Priority: Trivial Attachments: thriftkeeper.patch This is a basic server that acts as a proxy between a thrift interface and ZooKeeper. It doesn't support watches, and I'm not entirely convinced the session handling makes sense, but it works for basic operations like creating, listing and deleting nodes. The patch puts the code and (basic) build file under src/contrib/thrift; the build file requires the thrift compiler to be in the path, and the thrift and zookeeper libraries in the lib dir. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-129) Thrift proxy
[ https://issues.apache.org/jira/browse/ZOOKEEPER-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12627109#action_12627109 ] Patrick Hunt commented on ZOOKEEPER-129: +1 on Mahadev's comments (unit tests should live within this contrib module's subdir(s) somewhere) Having a readme that details how to build/simpleexample would be nice for ppl not already experienced with thrift. also: 1) *.java/.xml/.thrift files need apache source license headers 2) libthrift.jar needs to be renamed to specify the version 3) libthrift.jar also needs an accompanying libthrift-###.LICENSE.txt file ( see src/java/lib for examples with junit/log4j) Thrift proxy Key: ZOOKEEPER-129 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-129 Project: Zookeeper Issue Type: New Feature Reporter: Chris Smith Priority: Trivial Attachments: thriftkeeper.patch This is a basic server that acts as a proxy between a thrift interface and ZooKeeper. It doesn't support watches, and I'm not entirely convinced the session handling makes sense, but it works for basic operations like creating, listing and deleting nodes. The patch puts the code and (basic) build file under src/contrib/thrift; the build file requires the thrift compiler to be in the path, and the thrift and zookeeper libraries in the lib dir. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-130) update build.xml to support apache release process
[ https://issues.apache.org/jira/browse/ZOOKEEPER-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-130: --- Attachment: ZOOKEEPER-130.patch this patch adds package, tar and binary targets package generates the build/zookeeper-version directory structure tar tars package output binary tars package output excluding source that is includes as binary (jar) Note: in this patch src/c and src/contrib/zkfuse (non-java code) are not compiled as binary but rather the source is included - end user would be expected to compile for the particular platform they are interested in supporting (linux/mac/32/64/solaris/etc...) update build.xml to support apache release process -- Key: ZOOKEEPER-130 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-130 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.0.0 Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.0.0 Attachments: ZOOKEEPER-130.patch update the build process to support tar and binary targets similar in structure to hadoop-core build. this is needed as part of the 3.0.0 release process. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
