[jira] Assigned: (ZOOKEEPER-136) sync causes hang in all followers of quorum

2008-09-08 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt reassigned ZOOKEEPER-136:
--

Assignee: Benjamin Reed  (was: Patrick Hunt)

Ben is working on the fix.

 sync causes hang in all followers of quorum
 ---

 Key: ZOOKEEPER-136
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.0.0
Reporter: Patrick Hunt
Assignee: Benjamin Reed
 Fix For: 3.0.0

 Attachments: log_ZOOKEEPER-136.txt, testfails_ZOOKEEPER-136.patch, 
 testfails_ZOOKEEPER-136.patch


 The attached test causes all of the followers of a quorum to hang. Leader 
 continues to function correctly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-132) Create Enum to replace CreateFlag in ZooKepper.create method

2008-09-08 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-132:
---

Attachment: ZOOKEEPER-132.patch

Updated based on latest svn mainline.

 Create Enum to replace CreateFlag in ZooKepper.create method
 

 Key: ZOOKEEPER-132
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-132
 Project: Zookeeper
  Issue Type: Sub-task
  Components: java client
Affects Versions: 3.0.0
Reporter: Jakob Homan
Assignee: Jakob Homan
 Fix For: 3.0.0

 Attachments: ZOOKEEPER-132.patch, ZOOKEEPER-132.patch, 
 ZOOKEEPER-132.patch


 Replace the current named constant integer in the craete method with a 
 typesafe enum value.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-118) findbugs flagged switch statement in followerrequestprocessor.run()

2008-09-08 Thread Flavio Paiva Junqueira (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12629285#action_12629285
 ] 

Flavio Paiva Junqueira commented on ZOOKEEPER-118:
--

This piece of code seems correct. Sync should be processed along with other 
quorum operations such as create, but it does require some special code. In 
this case case, a follower saves the pending sync operations it has received 
from its clients before forwarding it to the leader. 

 findbugs flagged switch statement in followerrequestprocessor.run()
 ---

 Key: ZOOKEEPER-118
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-118
 Project: Zookeeper
  Issue Type: Bug
  Components: server
Reporter: Patrick Hunt
Assignee: Flavio Paiva Junqueira

 followerrequestprocessor:
 is the case statement for SYNC supposed to fall through?
 switch (request.type) {
 case OpCode.sync:
 zks.pendingSyncs.add(request);
 case OpCode.create:
 Please update the docs/code appropriately (if correct note it with comment 
 just after the sync case statement.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Created: (ZOOKEEPER-137) client watcher objects can lose events

2008-09-08 Thread Patrick Hunt (JIRA)
client watcher objects can lose events
--

 Key: ZOOKEEPER-137
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-137
 Project: Zookeeper
  Issue Type: Bug
  Components: java client
Affects Versions: 3.0.0
Reporter: Patrick Hunt
Assignee: Patrick Hunt
 Fix For: 3.0.0


if a single watcher (A) is registered on a single node for both a getdata and 
exists watch the second watch event may be lost:

1) getdata(node, A)
2) setdata(node...)
3) exists(node, A)
4) delete(node...)

if watch events for 2 is processed on the client (zookeeper.java, zkwatcher) 
after 3 completes then the zkwatcher process event method will clear the watch 
and the subsequent operation's (4) event will be ignored

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum

2008-09-08 Thread Benjamin Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-136:


Attachment: (was: log_ZOOKEEPER-136.txt)

 sync causes hang in all followers of quorum
 ---

 Key: ZOOKEEPER-136
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.0.0
Reporter: Patrick Hunt
Assignee: Benjamin Reed
 Fix For: 3.0.0


 The attached test causes all of the followers of a quorum to hang. Leader 
 continues to function correctly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum

2008-09-08 Thread Benjamin Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-136:


Attachment: (was: testfails_ZOOKEEPER-136.patch)

 sync causes hang in all followers of quorum
 ---

 Key: ZOOKEEPER-136
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.0.0
Reporter: Patrick Hunt
Assignee: Benjamin Reed
 Fix For: 3.0.0


 The attached test causes all of the followers of a quorum to hang. Leader 
 continues to function correctly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum

2008-09-08 Thread Benjamin Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-136:


Status: Patch Available  (was: Open)

 sync causes hang in all followers of quorum
 ---

 Key: ZOOKEEPER-136
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.0.0
Reporter: Patrick Hunt
Assignee: Benjamin Reed
 Fix For: 3.0.0

 Attachments: ZOOKEEPER-136.patch


 The attached test causes all of the followers of a quorum to hang. Leader 
 continues to function correctly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum

2008-09-08 Thread Benjamin Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-136:


Attachment: ZOOKEEPER-136.patch

This patch includes the tests that Pat wrote and the fix for the problem.

The fix involves three things:

1) The leader creates a FollowerSyncRequest that contains a reference to the 
FollowerHandler doing the sync. This allows us to get rid of the handler 
hashmap.

2) The pendingSyncs uses a List to track multiple syncs per change

3) CommitRequest processor was changed to take a boolean to flag whether to 
wait for syncs to come from the leader.


 sync causes hang in all followers of quorum
 ---

 Key: ZOOKEEPER-136
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136
 Project: Zookeeper
  Issue Type: Bug
Affects Versions: 3.0.0
Reporter: Patrick Hunt
Assignee: Benjamin Reed
 Fix For: 3.0.0

 Attachments: ZOOKEEPER-136.patch


 The attached test causes all of the followers of a quorum to hang. Leader 
 continues to function correctly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.