[jira] Updated: (ZOOKEEPER-411) Building zookeeper fails on RHEL 5 64 bit during test-cppunit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-411: --- Resolution: Fixed Status: Resolved (was: Patch Available) +1, thanks Mahadev Committed revision 776889. > Building zookeeper fails on RHEL 5 64 bit during test-cppunit > - > > Key: ZOOKEEPER-411 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-411 > Project: Zookeeper > Issue Type: Bug > Environment: RHEL5, 64bit >Reporter: Lee Tucker >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-411.patch, ZOOKEEPER-411.patch, > ZOOKEEPER-411.patch, ZOOKEEPER-411.patch > > > [exec] Zookeeper_simpleSystem::testAsyncWatcherAutoReset : assertion > [exec] > [exec] > /grid/0/gs/gridre/hudson/workspace/zootestbuild/trunk/src/c/tests/TestClient.cc:499: > Assertion: assertion failed [Expression: ctx.waitForDisconnected(zk)] > [exec] Failures !!! > [exec] Run: 32 Failure total: 1 Failures: 1 Errors: 0 > [exec] make: *** [run-check] Error 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-414) zkServer.sh is duplicated in a couple of places
[ https://issues.apache.org/jira/browse/ZOOKEEPER-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711398#action_12711398 ] Mahadev konar commented on ZOOKEEPER-414: - agreed... . > zkServer.sh is duplicated in a couple of places > --- > > Key: ZOOKEEPER-414 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-414 > Project: Zookeeper > Issue Type: Improvement >Reporter: Benjamin Reed >Assignee: Mahadev konar > Fix For: 3.3.0 > > > we have zkServer.sh in 4 different places. some differ only in whitespace. it > would be much more maintainable if there were only one version that > everything used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-414) zkServer.sh is duplicated in a couple of places
zkServer.sh is duplicated in a couple of places --- Key: ZOOKEEPER-414 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-414 Project: Zookeeper Issue Type: Improvement Reporter: Benjamin Reed Assignee: Mahadev konar Fix For: 3.3.0 we have zkServer.sh in 4 different places. some differ only in whitespace. it would be much more maintainable if there were only one version that everything used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-413) two flaws need addressing in the c tests that can cause false positive failures
two flaws need addressing in the c tests that can cause false positive failures --- Key: ZOOKEEPER-413 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-413 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Patrick Hunt Assignee: Mahadev konar Priority: Minor Fix For: 3.2.0 1) createClient in testclient.cc (check all tests) is not correctly waiting for syncconnected to the server 2) there are some instances of while(xxx); in the test code, this could cause problems, really we need to have some limit on the number of iterations (other than just the test, which may never return false), also the loop should have some sort of sleep(100msec) (whatever time) in order to limit cpu use. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-413) two flaws need addressing in the c tests that can cause false positive failures
[ https://issues.apache.org/jira/browse/ZOOKEEPER-413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-413: --- Component/s: tests > two flaws need addressing in the c tests that can cause false positive > failures > --- > > Key: ZOOKEEPER-413 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-413 > Project: Zookeeper > Issue Type: Bug > Components: c client, tests >Reporter: Patrick Hunt >Assignee: Mahadev konar >Priority: Minor > Fix For: 3.2.0 > > > 1) createClient in testclient.cc (check all tests) is not correctly waiting > for syncconnected to the server > 2) there are some instances of while(xxx); in the test code, this could cause > problems, really we need to > have some limit on the number of iterations (other than just the test, which > may never return false), also the > loop should have some sort of sleep(100msec) (whatever time) in order to > limit cpu use. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-411) Building zookeeper fails on RHEL 5 64 bit during test-cppunit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-411: Attachment: ZOOKEEPER-411.patch this patch removes usage of fuser in build.xml. > Building zookeeper fails on RHEL 5 64 bit during test-cppunit > - > > Key: ZOOKEEPER-411 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-411 > Project: Zookeeper > Issue Type: Bug > Environment: RHEL5, 64bit >Reporter: Lee Tucker >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-411.patch, ZOOKEEPER-411.patch, > ZOOKEEPER-411.patch, ZOOKEEPER-411.patch > > > [exec] Zookeeper_simpleSystem::testAsyncWatcherAutoReset : assertion > [exec] > [exec] > /grid/0/gs/gridre/hudson/workspace/zootestbuild/trunk/src/c/tests/TestClient.cc:499: > Assertion: assertion failed [Expression: ctx.waitForDisconnected(zk)] > [exec] Failures !!! > [exec] Run: 32 Failure total: 1 Failures: 1 Errors: 0 > [exec] make: *** [run-check] Error 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-411) Building zookeeper fails on RHEL 5 64 bit during test-cppunit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-411: Attachment: ZOOKEEPER-411.patch this patch removes the use of fuser from all the scripts also from the build file... pat can you review this? see if ant test passes on your machine. > Building zookeeper fails on RHEL 5 64 bit during test-cppunit > - > > Key: ZOOKEEPER-411 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-411 > Project: Zookeeper > Issue Type: Bug > Environment: RHEL5, 64bit >Reporter: Lee Tucker >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-411.patch, ZOOKEEPER-411.patch, > ZOOKEEPER-411.patch > > > [exec] Zookeeper_simpleSystem::testAsyncWatcherAutoReset : assertion > [exec] > [exec] > /grid/0/gs/gridre/hudson/workspace/zootestbuild/trunk/src/c/tests/TestClient.cc:499: > Assertion: assertion failed [Expression: ctx.waitForDisconnected(zk)] > [exec] Failures !!! > [exec] Run: 32 Failure total: 1 Failures: 1 Errors: 0 > [exec] make: *** [run-check] Error 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-402) zookeeper c library segfaults on data for a node in zookeeper being null.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-402: Status: Patch Available (was: Open) > zookeeper c library segfaults on data for a node in zookeeper being null. > - > > Key: ZOOKEEPER-402 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.1.1, 3.1.0 >Reporter: Mahadev konar >Assignee: Mahadev konar >Priority: Critical > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-402.patch, ZOOKEEPER-402.patch > > > the zookeeper c client library seg faults on data being null for a zoo node. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-411) Building zookeeper fails on RHEL 5 64 bit during test-cppunit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711346#action_12711346 ] Patrick Hunt commented on ZOOKEEPER-411: Can you fix this in all locations in the source? src/c/tests/zkServer.sh 36:fuser -skn tcp 22181/tcp src/contrib/rest/src/test/zkServer.sh 36:fuser -skn tcp 22182/tcp src/contrib/zkpython/src/test/zkServer.sh 36:#fuser -skn tcp 22182/tcp src/recipes/lock/src/c/tests/zkServer.sh 32:fuser -skn tcp 22181/tcp also remove this (now unnecessary) build.xml 671: 675: > Building zookeeper fails on RHEL 5 64 bit during test-cppunit > - > > Key: ZOOKEEPER-411 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-411 > Project: Zookeeper > Issue Type: Bug > Environment: RHEL5, 64bit >Reporter: Lee Tucker >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-411.patch, ZOOKEEPER-411.patch > > > [exec] Zookeeper_simpleSystem::testAsyncWatcherAutoReset : assertion > [exec] > [exec] > /grid/0/gs/gridre/hudson/workspace/zootestbuild/trunk/src/c/tests/TestClient.cc:499: > Assertion: assertion failed [Expression: ctx.waitForDisconnected(zk)] > [exec] Failures !!! > [exec] Run: 32 Failure total: 1 Failures: 1 Errors: 0 > [exec] make: *** [run-check] Error 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-402) zookeeper c library segfaults on data for a node in zookeeper being null.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-402: Attachment: ZOOKEEPER-402.patch removed the path, from the patch... > zookeeper c library segfaults on data for a node in zookeeper being null. > - > > Key: ZOOKEEPER-402 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.1.0, 3.1.1 >Reporter: Mahadev konar >Assignee: Mahadev konar >Priority: Critical > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-402.patch, ZOOKEEPER-402.patch > > > the zookeeper c client library seg faults on data being null for a zoo node. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-411) Building zookeeper fails on RHEL 5 64 bit during test-cppunit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-411: Hadoop Flags: [Reviewed] +1 looks good > Building zookeeper fails on RHEL 5 64 bit during test-cppunit > - > > Key: ZOOKEEPER-411 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-411 > Project: Zookeeper > Issue Type: Bug > Environment: RHEL5, 64bit >Reporter: Lee Tucker >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-411.patch, ZOOKEEPER-411.patch > > > [exec] Zookeeper_simpleSystem::testAsyncWatcherAutoReset : assertion > [exec] > [exec] > /grid/0/gs/gridre/hudson/workspace/zootestbuild/trunk/src/c/tests/TestClient.cc:499: > Assertion: assertion failed [Expression: ctx.waitForDisconnected(zk)] > [exec] Failures !!! > [exec] Run: 32 Failure total: 1 Failures: 1 Errors: 0 > [exec] make: *** [run-check] Error 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-411) Building zookeeper fails on RHEL 5 64 bit during test-cppunit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-411: Attachment: ZOOKEEPER-411.patch this patch also deletes the pid files once the process is killed. > Building zookeeper fails on RHEL 5 64 bit during test-cppunit > - > > Key: ZOOKEEPER-411 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-411 > Project: Zookeeper > Issue Type: Bug > Environment: RHEL5, 64bit >Reporter: Lee Tucker >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-411.patch, ZOOKEEPER-411.patch > > > [exec] Zookeeper_simpleSystem::testAsyncWatcherAutoReset : assertion > [exec] > [exec] > /grid/0/gs/gridre/hudson/workspace/zootestbuild/trunk/src/c/tests/TestClient.cc:499: > Assertion: assertion failed [Expression: ctx.waitForDisconnected(zk)] > [exec] Failures !!! > [exec] Run: 32 Failure total: 1 Failures: 1 Errors: 0 > [exec] make: *** [run-check] Error 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-411) Building zookeeper fails on RHEL 5 64 bit during test-cppunit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711331#action_12711331 ] Benjamin Reed commented on ZOOKEEPER-411: - you should remove the pid files. > Building zookeeper fails on RHEL 5 64 bit during test-cppunit > - > > Key: ZOOKEEPER-411 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-411 > Project: Zookeeper > Issue Type: Bug > Environment: RHEL5, 64bit >Reporter: Lee Tucker >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-411.patch > > > [exec] Zookeeper_simpleSystem::testAsyncWatcherAutoReset : assertion > [exec] > [exec] > /grid/0/gs/gridre/hudson/workspace/zootestbuild/trunk/src/c/tests/TestClient.cc:499: > Assertion: assertion failed [Expression: ctx.waitForDisconnected(zk)] > [exec] Failures !!! > [exec] Run: 32 Failure total: 1 Failures: 1 Errors: 0 > [exec] make: *** [run-check] Error 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-411) Building zookeeper fails on RHEL 5 64 bit during test-cppunit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-411: Attachment: ZOOKEEPER-411.patch it turns out that the test was failing becasue the zookeeper server wasnt being shut down in the c tests. Loooks like fuser does not work as published on rhel 5. I wasted quite some time on trying to figure out why fuser wasnt working but didnt find an answer. So, I decided to just change the script to get the pid and for killing the server kill it with the pid already stored in the file from previous start. - this patch changes the script to use pid instead of fuser. I tested it to see iit works on rhel 5 64 bit, ipv6 machine. > Building zookeeper fails on RHEL 5 64 bit during test-cppunit > - > > Key: ZOOKEEPER-411 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-411 > Project: Zookeeper > Issue Type: Bug > Environment: RHEL5, 64bit >Reporter: Lee Tucker >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-411.patch > > > [exec] Zookeeper_simpleSystem::testAsyncWatcherAutoReset : assertion > [exec] > [exec] > /grid/0/gs/gridre/hudson/workspace/zootestbuild/trunk/src/c/tests/TestClient.cc:499: > Assertion: assertion failed [Expression: ctx.waitForDisconnected(zk)] > [exec] Failures !!! > [exec] Run: 32 Failure total: 1 Failures: 1 Errors: 0 > [exec] make: *** [run-check] Error 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-411) Building zookeeper fails on RHEL 5 64 bit during test-cppunit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-411: Status: Patch Available (was: Open) > Building zookeeper fails on RHEL 5 64 bit during test-cppunit > - > > Key: ZOOKEEPER-411 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-411 > Project: Zookeeper > Issue Type: Bug > Environment: RHEL5, 64bit >Reporter: Lee Tucker >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-411.patch > > > [exec] Zookeeper_simpleSystem::testAsyncWatcherAutoReset : assertion > [exec] > [exec] > /grid/0/gs/gridre/hudson/workspace/zootestbuild/trunk/src/c/tests/TestClient.cc:499: > Assertion: assertion failed [Expression: ctx.waitForDisconnected(zk)] > [exec] Failures !!! > [exec] Run: 32 Failure total: 1 Failures: 1 Errors: 0 > [exec] make: *** [run-check] Error 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-311) handle small path lengths in zoo_create()
[
https://issues.apache.org/jira/browse/ZOOKEEPER-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711316#action_12711316
]
Benjamin Reed commented on ZOOKEEPER-311:
-
i think we should commit this patch now. the only change in behavior is when
the length of the buffer to receive the name is of length 1. it is a silly
corner case, but really the fact that we don't put a null there should be
considered a bug.
> handle small path lengths in zoo_create()
> -
>
> Key: ZOOKEEPER-311
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-311
> Project: Zookeeper
> Issue Type: Improvement
> Components: c client
>Affects Versions: 3.0.0, 3.0.1, 3.1.0
>Reporter: Chris Darroch
>Assignee: Chris Darroch
>Priority: Minor
> Fix For: 4.0.0
>
> Attachments: ZOOKEEPER-311.patch, ZOOKEEPER-311.patch
>
>
> The synchronous completion for zoo_create() contains the following code:\\
> {noformat}
> if (sc->u.str.str_len > strlen(res.path)) {
> len = strlen(res.path);
> } else {
> len = sc->u.str.str_len-1;
> }
> if (len > 0) {
> memcpy(sc->u.str.str, res.path, len);
> sc->u.str.str[len] = '\0';
> }
> {noformat}
> In the case where the max_realpath_len argument to zoo_create() is 0, none of
> this code executes, which is OK. In the case where max_realpath_len is 1, a
> user might expect their buffer to be filled with a null terminator, but
> again, nothing will happen (even if strlen(res.path) is 0, which is unlikely
> since new node's will have paths longer than "/").
> The name of the argument to zoo_create() is also a little misleading, as is
> its description ("the maximum length of real path you would want") in
> zookeeper.h, and the example usage in the Programmer's Guide:
> {noformat}
> int rc = zoo_create(zh,"/xyz","value", 5, &CREATE_ONLY, ZOO_EPHEMERAL,
> buffer, sizeof(buffer)-1);
> {noformat}
> In fact this value should be the actual length of the buffer, including space
> for the null terminator. If the user supplies a max_realpath_len of 10 and a
> buffer of 11 bytes, and strlen(res.path) is 10, the code will truncate the
> returned value to 9 bytes and put the null terminator in the second-last
> byte, leaving the final byte of the buffer unused.
> It would be better, I think, to rename the realpath and max_realpath_len
> arguments to something like path_buffer and path_buffer_len, akin to
> zoo_set(). The path_buffer_len would be treated as the full length of the
> buffer (as the code does now, in fact, but the docs suggest otherwise).
> The code in the synchronous completion could then be changed as per the
> attached patch.
> Since this would change, slightly, the behaviour or "contract" of the API, I
> would be inclined to suggest waiting until 4.0.0 to implement this change.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-407) address all findbugs warnings in org.apache.zookeeper.server.quorum.** packages
[ https://issues.apache.org/jira/browse/ZOOKEEPER-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-407: Resolution: Fixed Status: Resolved (was: Patch Available) Committed revision 776826. > address all findbugs warnings in org.apache.zookeeper.server.quorum.** > packages > --- > > Key: ZOOKEEPER-407 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-407 > Project: Zookeeper > Issue Type: Sub-task > Components: server >Reporter: Patrick Hunt >Assignee: Flavio Paiva Junqueira > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-407.patch, ZOOKEEPER-407.patch, > ZOOKEEPER-407.patch > > > Flavio please address the findbugs warnings in quorum and sub packages. See > http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/308/violations/ > for a list of issues or use ant's findbugs (or eclipse) to identify the > issues. > In general we should try to fix these, but ignoring the warning (annotation) > is ok if it includes comments to effect why, also has > to be reviewed/approved. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-358) Throw exception when ledger does not exist
[ https://issues.apache.org/jira/browse/ZOOKEEPER-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711299#action_12711299 ] Benjamin Reed commented on ZOOKEEPER-358: - +1 looks good > Throw exception when ledger does not exist > -- > > Key: ZOOKEEPER-358 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-358 > Project: Zookeeper > Issue Type: Improvement > Components: contrib-bookkeeper >Affects Versions: 3.1.1 >Reporter: Luca Telloli >Assignee: Flavio Paiva Junqueira >Priority: Minor > Attachments: ZOOKEEPER-358.patch > > > Currently, openLedger() in the BookKeeper client returns null if the ledger > ID does not exist on ZK. Maybe it would be better to throw a specific > exception so it can be handled by the client side. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-403) cleanup javac compiler warnings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-403: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) Committed revision 776807. > cleanup javac compiler warnings > --- > > Key: ZOOKEEPER-403 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-403 > Project: Zookeeper > Issue Type: Improvement > Components: java client, server >Reporter: Patrick Hunt >Assignee: Flavio Paiva Junqueira > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-403.patch, ZOOKEEPER-403.patch > > > Cleanup javac warnings, also turn on lint by default in ant build.xml for > main org.apache.zookeeper classes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-410) address all findbugs warnings in client/server classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-410. - Resolution: Fixed Committed revision 776806. > address all findbugs warnings in client/server classes > -- > > Key: ZOOKEEPER-410 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-410 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-410.patch > > > trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java > trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java > trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java > trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java > trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java > trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java > trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-410) address all findbugs warnings in client/server classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-410: Hadoop Flags: [Reviewed] +1 you're right. you didn't change the behavior. (i think there used to be a return in the if case, but that is a separate issue) > address all findbugs warnings in client/server classes > -- > > Key: ZOOKEEPER-410 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-410 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-410.patch > > > trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java > trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java > trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java > trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java > trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java > trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java > trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-292) commit configure scripts (autotools) to svn for c projects and include in release
[ https://issues.apache.org/jira/browse/ZOOKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-292: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) Committed revision 776798. > commit configure scripts (autotools) to svn for c projects and include in > release > - > > Key: ZOOKEEPER-292 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-292 > Project: Zookeeper > Issue Type: Improvement > Components: c client, contrib-zkfuse >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-292.patch > > > We currently don't include configure scripts, just the .ac file itself. This > means that users are required > to run "autoreconf; ./configure" rather than just configure. > We should commit the configure script(s) to svn (hadoop core does this btw) > for our autotools based projects (currently c client api and zkfuse). > Also these should be included in the build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-345) the CLIs should allow addAuth to be invoked
[ https://issues.apache.org/jira/browse/ZOOKEEPER-345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-345: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) Committed revision 776793. > the CLIs should allow addAuth to be invoked > --- > > Key: ZOOKEEPER-345 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-345 > Project: Zookeeper > Issue Type: Improvement > Components: c client, java client >Reporter: Patrick Hunt >Assignee: Henry Robinson > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-345.patch, ZOOKEEPER-345.patch > > > Not sure about the c client but the java CLI ZooKeeperMain does not allow > addAuth to be called, it should have a command for this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-410) address all findbugs warnings in client/server classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711260#action_12711260 ] Patrick Hunt commented on ZOOKEEPER-410: Ben, I don't think that's the case re finalreqprocessor - I was pretty careful with that change, and I'm reviewing it now and I don't think anything changed. I moved the remove up a bit, but otw the behavior is unchanged. Can you take another look? > address all findbugs warnings in client/server classes > -- > > Key: ZOOKEEPER-410 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-410 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-410.patch > > > trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java > trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java > trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java > trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java > trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java > trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java > trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-405) nullpointer exception in zookeeper java shell.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-405: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) Committed revision 776788. > nullpointer exception in zookeeper java shell. > -- > > Key: ZOOKEEPER-405 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-405 > Project: Zookeeper > Issue Type: Bug >Reporter: Mahadev konar >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-405.patch > > > The java client shell does not handle null return data and throws out null > pointer exception. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-410) address all findbugs warnings in client/server classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-410: Status: Open (was: Patch Available) excellent job pat. my only problem with the patch is that in FinalRequestProcessor you have changed the behavior for the case where the expected xid is greater than the actual one seen. if the incoming xid is lower than expected you lose the outstanding change, which may be the next one in the pipe, which will result in another warning and skip, and so on. > address all findbugs warnings in client/server classes > -- > > Key: ZOOKEEPER-410 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-410 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-410.patch > > > trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java > trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java > trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java > trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java > trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java > trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java > trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-407) address all findbugs warnings in org.apache.zookeeper.server.quorum.** packages
[ https://issues.apache.org/jira/browse/ZOOKEEPER-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-407: Hadoop Flags: [Reviewed] +1 ready to commit > address all findbugs warnings in org.apache.zookeeper.server.quorum.** > packages > --- > > Key: ZOOKEEPER-407 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-407 > Project: Zookeeper > Issue Type: Sub-task > Components: server >Reporter: Patrick Hunt >Assignee: Flavio Paiva Junqueira > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-407.patch, ZOOKEEPER-407.patch, > ZOOKEEPER-407.patch > > > Flavio please address the findbugs warnings in quorum and sub packages. See > http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/308/violations/ > for a list of issues or use ant's findbugs (or eclipse) to identify the > issues. > In general we should try to fix these, but ignoring the warning (annotation) > is ok if it includes comments to effect why, also has > to be reviewed/approved. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-403) cleanup javac compiler warnings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711240#action_12711240 ] Benjamin Reed commented on ZOOKEEPER-403: - +1 ready to commit > cleanup javac compiler warnings > --- > > Key: ZOOKEEPER-403 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-403 > Project: Zookeeper > Issue Type: Improvement > Components: java client, server >Reporter: Patrick Hunt >Assignee: Flavio Paiva Junqueira > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-403.patch, ZOOKEEPER-403.patch > > > Cleanup javac warnings, also turn on lint by default in ant build.xml for > main org.apache.zookeeper classes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-292) commit configure scripts (autotools) to svn for c projects and include in release
[ https://issues.apache.org/jira/browse/ZOOKEEPER-292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711237#action_12711237 ] Benjamin Reed commented on ZOOKEEPER-292: - +1 ready to commit > commit configure scripts (autotools) to svn for c projects and include in > release > - > > Key: ZOOKEEPER-292 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-292 > Project: Zookeeper > Issue Type: Improvement > Components: c client, contrib-zkfuse >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-292.patch > > > We currently don't include configure scripts, just the .ac file itself. This > means that users are required > to run "autoreconf; ./configure" rather than just configure. > We should commit the configure script(s) to svn (hadoop core does this btw) > for our autotools based projects (currently c client api and zkfuse). > Also these should be included in the build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-402) zookeeper c library segfaults on data for a node in zookeeper being null.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-402: Status: Open (was: Patch Available) you have a hard coded path that is specific to your machine mahadev. > zookeeper c library segfaults on data for a node in zookeeper being null. > - > > Key: ZOOKEEPER-402 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.1.1, 3.1.0 >Reporter: Mahadev konar >Assignee: Mahadev konar >Priority: Critical > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-402.patch > > > the zookeeper c client library seg faults on data being null for a zoo node. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-345) the CLIs should allow addAuth to be invoked
[ https://issues.apache.org/jira/browse/ZOOKEEPER-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711232#action_12711232 ] Benjamin Reed commented on ZOOKEEPER-345: - +1 ready to commit > the CLIs should allow addAuth to be invoked > --- > > Key: ZOOKEEPER-345 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-345 > Project: Zookeeper > Issue Type: Improvement > Components: c client, java client >Reporter: Patrick Hunt >Assignee: Henry Robinson > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-345.patch, ZOOKEEPER-345.patch > > > Not sure about the c client but the java CLI ZooKeeperMain does not allow > addAuth to be called, it should have a command for this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-405) nullpointer exception in zookeeper java shell.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711234#action_12711234 ] Benjamin Reed commented on ZOOKEEPER-405: - +1 ready to commit > nullpointer exception in zookeeper java shell. > -- > > Key: ZOOKEEPER-405 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-405 > Project: Zookeeper > Issue Type: Bug >Reporter: Mahadev konar >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-405.patch > > > The java client shell does not handle null return data and throws out null > pointer exception. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-383) Asynchronous version of createLedger()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-383: - Status: Patch Available (was: Open) > Asynchronous version of createLedger() > -- > > Key: ZOOKEEPER-383 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-383 > Project: Zookeeper > Issue Type: New Feature > Components: contrib-bookkeeper >Reporter: Utkarsh Srivastava >Assignee: Flavio Paiva Junqueira > Attachments: ZOOKEEPER-383.patch, ZOOKEEPER-383.patch > > > While there are async versions for read and write, there is no async version > for creating a ledger. This can cause applications to have to change their > whole thread design. > It should be easier and more consistent to add an async version of > createLedger(). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Build failed in Hudson: ZooKeeper-trunk #315
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/315/ -- [...truncated 126358 lines...] [exec] libtool: link: ranlib .libs/libzkst.a [exec] libtool: link: ( cd ".libs" && rm -f "libzkst.la" && ln -s "../libzkst.la" "libzkst.la" ) [exec] /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/include -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/tests -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/generated -Wall -Werror -g -O2 -MT hashtable_itr.lo -MD -MP -MF .deps/hashtable_itr.Tpo -c -o hashtable_itr.lo `test -f 'src/hashtable/hashtable_itr.c' || echo 'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/'`src/hashtable/hashtable_itr.c [exec] libtool: compile: gcc -DHAVE_CONFIG_H -I. -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/include -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/tests -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/generated -Wall -Werror -g -O2 -MT hashtable_itr.lo -MD -MP -MF .deps/hashtable_itr.Tpo -c http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/src/hashtable/hashtable_itr.c -fPIC -DPIC -o .libs/hashtable_itr.o [exec] libtool: compile: gcc -DHAVE_CONFIG_H -I. -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/include -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/tests -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/generated -Wall -Werror -g -O2 -MT hashtable_itr.lo -MD -MP -MF .deps/hashtable_itr.Tpo -c http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/src/hashtable/hashtable_itr.c -o hashtable_itr.o >/dev/null 2>&1 [exec] mv -f .deps/hashtable_itr.Tpo .deps/hashtable_itr.Plo [exec] /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/include -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/tests -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/generated -Wall -Werror -g -O2 -MT hashtable.lo -MD -MP -MF .deps/hashtable.Tpo -c -o hashtable.lo `test -f 'src/hashtable/hashtable.c' || echo 'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/'`src/hashtable/hashtable.c [exec] libtool: compile: gcc -DHAVE_CONFIG_H -I. -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/include -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/tests -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/generated -Wall -Werror -g -O2 -MT hashtable.lo -MD -MP -MF .deps/hashtable.Tpo -c http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/src/hashtable/hashtable.c -fPIC -DPIC -o .libs/hashtable.o [exec] libtool: compile: gcc -DHAVE_CONFIG_H -I. -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/include -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/tests -Ihttp://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/generated -Wall -Werror -g -O2 -MT hashtable.lo -MD -MP -MF .deps/hashtable.Tpo -c http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/c/src/hashtable/hashtable.c -o hashtable.o >/dev/null 2>&1 [exec] mv -f .deps/hashtable.Tpo .deps/hashtable.Plo [exec] /bin/bash ./libtool --tag=CC --mode=link gcc -Wall -Werror -g -O2 -o libhashtable.la hashtable_itr.lo hashtable.lo [exec] libtool: link: ar cru .libs/libhashtable.a .libs/hashtable_itr.o .libs/hashtable.o [exec] libtool: link: ranlib .libs/libhashtable.a [exec] libtool: link: ( cd ".libs" && rm -f "libhashtable.la" && ln -s "../libhashtable.la" "libhashtable.la" ) [exec] /bin/bash ./libtool --tag=CC --mode=link gcc -Wall -Werror -g -O2 -no-undefined -version-info 2 -o libzookeeper_st.la -rpath http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/test/test-cppunit/lib libzkst.la libhashtable.la [exec] libtool: link: gcc -shared -Wl,--whole-archive ./.libs/libzkst.a ./.libs/libhashtable.a -Wl,--no-whole-archive -lm-Wl,-
[jira] Updated: (ZOOKEEPER-383) Asynchronous version of createLedger()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-383: - Attachment: ZOOKEEPER-383.patch In this new patch, I have moved all asynchronous callback interfaces inside one interface AsyncCallback, as we do in ZooKeeper. Consequently, I have removed the previous interfaces. I have also moved some constants we use to determine the path of znodes in ZooKeeper to BKDefs. It adds a unit test and all tests pass for me. > Asynchronous version of createLedger() > -- > > Key: ZOOKEEPER-383 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-383 > Project: Zookeeper > Issue Type: New Feature > Components: contrib-bookkeeper >Reporter: Utkarsh Srivastava >Assignee: Flavio Paiva Junqueira > Attachments: ZOOKEEPER-383.patch, ZOOKEEPER-383.patch > > > While there are async versions for read and write, there is no async version > for creating a ledger. This can cause applications to have to change their > whole thread design. > It should be easier and more consistent to add an async version of > createLedger(). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-407) address all findbugs warnings in org.apache.zookeeper.server.quorum.** packages
[ https://issues.apache.org/jira/browse/ZOOKEEPER-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-407: - Status: Patch Available (was: Open) > address all findbugs warnings in org.apache.zookeeper.server.quorum.** > packages > --- > > Key: ZOOKEEPER-407 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-407 > Project: Zookeeper > Issue Type: Sub-task > Components: server >Reporter: Patrick Hunt >Assignee: Flavio Paiva Junqueira > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-407.patch, ZOOKEEPER-407.patch, > ZOOKEEPER-407.patch > > > Flavio please address the findbugs warnings in quorum and sub packages. See > http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/308/violations/ > for a list of issues or use ant's findbugs (or eclipse) to identify the > issues. > In general we should try to fix these, but ignoring the warning (annotation) > is ok if it includes comments to effect why, also has > to be reviewed/approved. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-412) checkstyle target fails trunk build
checkstyle target fails trunk build --- Key: ZOOKEEPER-412 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-412 Project: Zookeeper Issue Type: Bug Reporter: Giridharan Kesavan BUILD FAILED /home/hudson/hudson-slave/workspace/ZooKeeper-trunk/trunk/build.xml:865: Unable to create a Checker: cannot initialize module PackageHtml - Unable to instantiate PackageHtml Tnx! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
