[jira] Updated: (ZOOKEEPER-568) SyncRequestProcessor snapping too frequently - counts non-log events as log events
[ https://issues.apache.org/jira/browse/ZOOKEEPER-568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-568: Resolution: Fixed Status: Resolved (was: Patch Available) Committed revision 833639. SyncRequestProcessor snapping too frequently - counts non-log events as log events -- Key: ZOOKEEPER-568 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-568 Project: Zookeeper Issue Type: Bug Affects Versions: 3.2.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-568.patch Noticed the following issues in SyncRequestProcessor 1) logCount is incremented even for non-log events (say getData) txnlog should return indication if request was logged or not (if hdr ==null it returns) also: 2) move r.nextInt below logCount++ (ie if an actual log event) 3) fix indentation after txnlog.append (for some reason has unnecessary 4 char indent) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Build failed in Hudson: ZooKeeper-trunk #521
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/521/changes Changes: [breed] ZOOKEEPER-568. SyncRequestProcessor snapping too frequently - counts non-log events as log events [breed] ZOOKEEPER-558. server sent stats not being updated [phunt] ZOOKEEPER-537. The zookeeper jar includes the java source files -- [...truncated 94217 lines...] [junit] 2009-11-07 10:50:01,128 - INFO [NIOServerCxn.Factory:11225:nioservercnxn$fact...@213] - Accepted socket connection from /127.0.0.1:48100 [junit] 2009-11-07 10:50:01,128 - INFO [NIOServerCxn.Factory:11225:nioserverc...@689] - Client attempting to renew session 0x124ce43c469 at /127.0.0.1:48100 [junit] 2009-11-07 10:50:01,128 - INFO [NIOServerCxn.Factory:11225:nioserverc...@] - Established session 0x124ce43c469 for client /127.0.0.1:48100 [junit] 2009-11-07 10:50:01,129 - INFO [main-SendThread(localhost:11225):clientcnxn$sendthr...@640] - Session establishment complete, sessionid = 0x124ce43c469 [junit] 2009-11-07 10:50:01,140 - INFO [main:clientb...@374] - STOPPING server [junit] 2009-11-07 10:50:01,141 - INFO [main:nioserverc...@954] - Closed socket connection for client /127.0.0.1:48100 which had sessionid 0x124ce43c469 [junit] 2009-11-07 10:50:01,141 - INFO [main-SendThread(localhost:11225):clientcnxn$sendthr...@1042] - Unable to read additional data from server sessionid 0x124ce43c469, likely server has closed socket, closing socket connection and attempting reconnect [junit] 2009-11-07 10:50:01,141 - INFO [NIOServerCxn.Factory:11225:nioservercnxn$fact...@240] - NIOServerCnxn factory exited run method [junit] 2009-11-07 10:50:01,142 - INFO [main:finalrequestproces...@329] - shutdown of request processor complete [junit] 2009-11-07 10:50:01,142 - INFO [SyncThread:0:syncrequestproces...@151] - SyncRequestProcessor exited! [junit] 2009-11-07 10:50:01,142 - INFO [ProcessThread:-1:preprequestproces...@119] - PrepRequestProcessor exited loop! [junit] ensureOnly:[] [junit] 2009-11-07 10:50:01,242 - INFO [main:clientb...@367] - STARTING server [junit] 2009-11-07 10:50:01,242 - INFO [main:zookeeperser...@160] - Created server [junit] 2009-11-07 10:50:01,243 - INFO [main:nioservercnxn$fact...@122] - binding to port 11225 [junit] 2009-11-07 10:50:01,244 - INFO [main:files...@81] - Reading snapshot http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/test/tmp/test5395889823440550425.junit.dir/version-2/snapshot.5 [junit] 2009-11-07 10:50:01,247 - INFO [main:filetxnsnap...@208] - Snapshotting: 6 [junit] 2009-11-07 10:50:01,248 - INFO [NIOServerCxn.Factory:11225:nioservercnxn$fact...@213] - Accepted socket connection from /127.0.0.1:48102 [junit] 2009-11-07 10:50:01,249 - INFO [NIOServerCxn.Factory:11225:nioserverc...@799] - Processing stat command from /127.0.0.1:48102 [junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] 2009-11-07 10:50:01,249 - INFO [NIOServerCxn.Factory:11225:nioserverc...@954] - Closed socket connection for client /127.0.0.1:48102 (no session established for client) [junit] expect:InMemoryDataTree [junit] found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] expect:StandaloneServer_port [junit] found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2009-11-07 10:50:02,766 - INFO [main-SendThread(localhost:11225):clientcnxn$sendthr...@924] - Opening socket connection to server localhost/127.0.0.1:11225 [junit] 2009-11-07 10:50:02,766 - INFO [main-SendThread(localhost:11225):clientcnxn$sendthr...@837] - Socket connection established to localhost/127.0.0.1:11225, initiating session [junit] 2009-11-07 10:50:02,766 - INFO [NIOServerCxn.Factory:11225:nioservercnxn$fact...@213] - Accepted socket connection from /127.0.0.1:48103 [junit] 2009-11-07 10:50:02,767 - INFO [NIOServerCxn.Factory:11225:nioserverc...@689] - Client attempting to renew session 0x124ce43c469 at /127.0.0.1:48103 [junit] 2009-11-07 10:50:02,767 - INFO [NIOServerCxn.Factory:11225:nioserverc...@] - Established session 0x124ce43c469 for client /127.0.0.1:48103 [junit] 2009-11-07 10:50:02,767 - INFO [main-SendThread(localhost:11225):clientcnxn$sendthr...@640] - Session establishment complete, sessionid = 0x124ce43c469 [junit] 2009-11-07 10:50:03,000 - INFO [SessionTracker:sessiontrackeri...@144] - SessionTrackerImpl exited loop! [junit] 2009-11-07 10:50:03,778 - INFO [ProcessThread:-1:preprequestproces...@384] - Processed session termination for sessionid: 0x124ce43c469 [junit] 2009-11-07 10:50:03,779 - INFO [main:zookee...@524] - Session: 0x124ce43c469 closed [junit] 2009-11-07 10:50:03,779 - INFO [main:clientb...@397] - tearDown starting
Hudson build is back to normal: ZooKeeper-trunk #522
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/522/
[jira] Commented: (ZOOKEEPER-537) The zookeeper jar includes the java source files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12774726#action_12774726 ] Hudson commented on ZOOKEEPER-537: -- Integrated in ZooKeeper-trunk #522 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/522/]) The zookeeper jar includes the java source files Key: ZOOKEEPER-537 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-537 Project: Zookeeper Issue Type: Bug Affects Versions: 3.3.0 Reporter: Thomas Dudziak Assignee: Thomas Dudziak Fix For: 3.3.0 Attachments: build.patch, ZOOKEEPER-537.patch This is a problem if you use zookeeper as a dependency in maven because for whatever reason the maven compiler plugin will pick up the java files in the jar and compile them to the output directory. From there they will land in the generated jar file for whatever project happens to depend on zookeeper thus introducing duplicate classes (once in zookeeper.jar, once in the project's artifact). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-568) SyncRequestProcessor snapping too frequently - counts non-log events as log events
[ https://issues.apache.org/jira/browse/ZOOKEEPER-568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12774725#action_12774725 ] Hudson commented on ZOOKEEPER-568: -- Integrated in ZooKeeper-trunk #522 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/522/]) SyncRequestProcessor snapping too frequently - counts non-log events as log events -- Key: ZOOKEEPER-568 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-568 Project: Zookeeper Issue Type: Bug Affects Versions: 3.2.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-568.patch Noticed the following issues in SyncRequestProcessor 1) logCount is incremented even for non-log events (say getData) txnlog should return indication if request was logged or not (if hdr ==null it returns) also: 2) move r.nextInt below logCount++ (ie if an actual log event) 3) fix indentation after txnlog.append (for some reason has unnecessary 4 char indent) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-558) server sent stats not being updated
[ https://issues.apache.org/jira/browse/ZOOKEEPER-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12774727#action_12774727 ] Hudson commented on ZOOKEEPER-558: -- Integrated in ZooKeeper-trunk #522 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/522/]) server sent stats not being updated - Key: ZOOKEEPER-558 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-558 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.2.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Critical Fix For: 3.3.0 Attachments: ZOOKEEPER-558.patch, ZOOKEEPER-558.patch the server and connection sent stat is not being updated. if you run stat on the client port the sent packets is much lower than it should be seems that sendbuffer is not updating the stats when it shortcircuits the send. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-570) AsyncHammerTest is broken, callbacks need to validate rc parameter
AsyncHammerTest is broken, callbacks need to validate rc parameter -- Key: ZOOKEEPER-570 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-570 Project: Zookeeper Issue Type: Bug Components: tests Affects Versions: 3.2.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Critical Fix For: 3.2.2, 3.3.0 the asynchammertest is not validating the rc in the callback, more serious is that it is using path in the create callback to delete the node, rather than name (which is important in the case of a sequential node creation as in this case) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-570) AsyncHammerTest is broken, callbacks need to validate rc parameter
[ https://issues.apache.org/jira/browse/ZOOKEEPER-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-570: --- Attachment: ZOOKEEPER-570.patch Fixed the test: 1) delete now uses name rather than path (since create is using seq flag) this was the main issue previously 2) fail the test if create or delete operations fail 3) don't send messages to the server until connected - otw false positive failure due to queued aysnc op when client times out AsyncHammerTest is broken, callbacks need to validate rc parameter -- Key: ZOOKEEPER-570 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-570 Project: Zookeeper Issue Type: Bug Components: tests Affects Versions: 3.2.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Critical Fix For: 3.2.2, 3.3.0 Attachments: ZOOKEEPER-570.patch the asynchammertest is not validating the rc in the callback, more serious is that it is using path in the create callback to delete the node, rather than name (which is important in the case of a sequential node creation as in this case) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-570) AsyncHammerTest is broken, callbacks need to validate rc parameter
[ https://issues.apache.org/jira/browse/ZOOKEEPER-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-570: --- Status: Patch Available (was: Open) AsyncHammerTest is broken, callbacks need to validate rc parameter -- Key: ZOOKEEPER-570 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-570 Project: Zookeeper Issue Type: Bug Components: tests Affects Versions: 3.2.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Critical Fix For: 3.2.2, 3.3.0 Attachments: ZOOKEEPER-570.patch the asynchammertest is not validating the rc in the callback, more serious is that it is using path in the create callback to delete the node, rather than name (which is important in the case of a sequential node creation as in this case) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-570) AsyncHammerTest is broken, callbacks need to validate rc parameter
[ https://issues.apache.org/jira/browse/ZOOKEEPER-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12774740#action_12774740 ] Hadoop QA commented on ZOOKEEPER-570: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12424290/ZOOKEEPER-570.patch against trunk revision 833639. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/55/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/55/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/55/console This message is automatically generated. AsyncHammerTest is broken, callbacks need to validate rc parameter -- Key: ZOOKEEPER-570 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-570 Project: Zookeeper Issue Type: Bug Components: tests Affects Versions: 3.2.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Critical Fix For: 3.2.2, 3.3.0 Attachments: ZOOKEEPER-570.patch the asynchammertest is not validating the rc in the callback, more serious is that it is using path in the create callback to delete the node, rather than name (which is important in the case of a sequential node creation as in this case) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
