Re: [VOTE] Release ZooKeeper 3.2.2 (candidate 1)
+1, I've also run ant test and some separate tests. -Flavio On Dec 9, 2009, at 8:10 AM, Mahadev Konar wrote: +1 I ran ant test and some smoke tests. thanks mahadev On 12/8/09 2:32 PM, Patrick Hunt ph...@apache.org wrote: I've created a second candidate build for ZooKeeper 3.2.2. This is a bug fix release addressing 13 issues (three critical) -- see the release notes for details. *** Please download, test and VOTE before the *** vote closes 3pm pacific time, Friday, December 11.*** http://people.apache.org/~phunt/zookeeper-3.2.2-candidate-1/ Should we release this? Patrick
Re: [VOTE] Release ZooKeeper 3.1.2 (candidate 1)
+1 Flavio Junqueira wrote: +1, I've also run ant test and some manual tests. -Flavio On Dec 9, 2009, at 8:12 AM, Mahadev Konar wrote: +1 I ran ant test and smoke tests. Thanks mahadev On 12/8/09 2:30 PM, Patrick Hunt ph...@apache.org wrote: I've created a second candidate build for ZooKeeper 3.1.2. This is a bug fix release addressing three critical issues -- see the release notes for details. *** Please download, test and VOTE before the *** vote closes 3pm pacific time, Friday, December 11.*** http://people.apache.org/~phunt/zookeeper-3.1.2-candidate-1/ Should we release this? Patrick
Re: [VOTE] Release ZooKeeper 3.2.2 (candidate 1)
+1 Flavio Junqueira wrote: +1, I've also run ant test and some separate tests. -Flavio On Dec 9, 2009, at 8:10 AM, Mahadev Konar wrote: +1 I ran ant test and some smoke tests. thanks mahadev On 12/8/09 2:32 PM, Patrick Hunt ph...@apache.org wrote: I've created a second candidate build for ZooKeeper 3.2.2. This is a bug fix release addressing 13 issues (three critical) -- see the release notes for details. *** Please download, test and VOTE before the *** vote closes 3pm pacific time, Friday, December 11.*** http://people.apache.org/~phunt/zookeeper-3.2.2-candidate-1/ Should we release this? Patrick
[jira] Created: (ZOOKEEPER-615) wrong javadoc for create with a sequence flag
wrong javadoc for create with a sequence flag - Key: ZOOKEEPER-615 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-615 Project: Zookeeper Issue Type: Bug Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 The javadoc for create with a sequence flag mentions a suffix of _i but the true suffix is just i and no _. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-615) wrong javadoc for create with a sequence flag
[ https://issues.apache.org/jira/browse/ZOOKEEPER-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-615: Description: The javadoc for create with a sequence flag mentions a suffix of \_i but the true suffix is just i and no \_. was: The javadoc for create with a sequence flag mentions a suffix of _i but the true suffix is just i and no _. wrong javadoc for create with a sequence flag - Key: ZOOKEEPER-615 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-615 Project: Zookeeper Issue Type: Bug Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 The javadoc for create with a sequence flag mentions a suffix of \_i but the true suffix is just i and no \_. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-616) Provide a function to parse out the name and the sequence number from a zknode path
[ https://issues.apache.org/jira/browse/ZOOKEEPER-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-616: Fix Version/s: 3.3.0 Provide a function to parse out the name and the sequence number from a zknode path --- Key: ZOOKEEPER-616 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-616 Project: Zookeeper Issue Type: New Feature Components: c client, java client Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1, 3.2.0, 3.2.1 Reporter: Avery Ching Priority: Minor Fix For: 3.3.0 Given a zookeeper path and knowing it was created with the SEQUENCE flag, it would be nice to be able to get the sequence number and the name. Currently, it is not documented how many bytes the sequence number uses in the path (Mahadev told me 10 for 3.1.1 for example), and having a function to retrieve this data would hide the actual number of bytes used and provide the useful functionality for users. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-615) wrong javadoc for create with a sequence flag
[ https://issues.apache.org/jira/browse/ZOOKEEPER-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-615: Attachment: ZOOKEEPER-615.patch this patch removes the \_ and also specifies in both java and c that the suffix is 0 padded and fixed length of 10 digits. wrong javadoc for create with a sequence flag - Key: ZOOKEEPER-615 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-615 Project: Zookeeper Issue Type: Bug Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 Attachments: ZOOKEEPER-615.patch The javadoc for create with a sequence flag mentions a suffix of \_i but the true suffix is just i and no \_. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-458:
Status: Open (was: Patch Available)
I spent some time debugging this. This is the stack trace from the core dump:
{quote}
#0 0x2b101d67f6e3 in ?? () from /lib/libc.so.6
#1 0x2b101d680e98 in ?? () from /lib/libc.so.6
#2 0x2b101d681276 in free () from /lib/libc.so.6
#3 0x00407b4e in __wrap_free (p=0xc03d80) at
/homes/mahadev/zookeeper-trunk/src/c/tests/LibCMocks.cc:197
#4 0x00441197 in free_buffer (b=0xbff8d0) at
/homes/mahadev/zookeeper-trunk/src/c/src/zookeeper.c:763
#5 0x00441aa5 in destroy_completion_entry (c=0xc02dd0) at
/homes/mahadev/zookeeper-trunk/src/c/src/zookeeper.c:2048
#6 0x00441dc2 in process_completions (zh=0xc02920) at
/homes/mahadev/zookeeper-trunk/src/c/src/zookeeper.c:1727
#7 0x004457a8 in zookeeper_process (zh=0xc02920, events=-1912149552)
at /homes/mahadev/zookeeper-trunk/src/c/src/zookeeper.c:1974
#8 0x004316dd in yield (zh=0xc02920, seconds=1) at
/homes/mahadev/zookeeper-trunk/src/c/tests/TestClient.cc:107
#9 0x00433406 in watchCtx::waitForConnected (this=0x7fff8e06f100,
zh=0xc02920) at /homes/mahadev/zookeeper-trunk/src/c/tests/TestClient.cc:165
#10 0x0043448d in Zookeeper_simpleSystem::testConnectIndex1
(this=0xbfdaa0) at /homes/mahadev/zookeeper-trunk/src/c/tests/TestClient.cc:846
#11 0x00431a02 in CppUnit::TestCallerZookeeper_simpleSystem::runTest
(this=0xbfdd00) at /usr/include/cppunit/TestCaller.h:166
#12 0x004566fa in CppUnit::TestCaseMethodFunctor::operator() ()
#13 0x004618e4 in CppUnit::DefaultProtector::protect ()
#14 0x0046315f in CppUnit::ProtectorChain::protect ()
#15 0x0045e1b2 in CppUnit::TestResult::protect ()
#16 0x004564ba in CppUnit::TestCase::run ()
#17 0x00463d03 in CppUnit::TestComposite::doRunChildTests ()
#18 0x00463c26 in CppUnit::TestComposite::run ()
#19 0x00463d03 in CppUnit::TestComposite::doRunChildTests ()
#20 0x00463c26 in CppUnit::TestComposite::run ()
#21 0x0045da0a in CppUnit::TestResult::runTest ()
#22 0x0045ff62 in CppUnit::TestRunner::run ()
{quote}
I tried debugging but could not find much time.
Steven,
can you take a look and see if you find something obvious?
connect_index in zookeeper handle might get out of bound.
-
Key: ZOOKEEPER-458
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Mahadev konar
Assignee: Steven Cheng
Fix For: 3.3.0
Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch,
ZOOKEEPER-458.patch, ZOOKEEPER-458.patch
connect_index in zookeeper handle might get out of bound. the zokoeeper_init
method checks for index == count and sets it to zero. If the index becomes
greater than count, then it will go out of bounds.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-458: --- Attachment: ZOOKEEPER-458.patch Maybe free_buffer is getting called twice on the same structure, changed patch to null out the buffer field. If free_buffer is getting called twice, we should see a __wrap_free ... p = 0 in the backtrace. It's also possible that the buffer is getting free'd since buffer is shared with the iarchive zookeeper.c:1781 but I couldn't find any paths where the iarchive buffer is free'd by manually tracing through. One thing I am confused about is that the segfault happens at the end of the testConnectIndex1 test, but the path that it is taking is processing outstanding synchronous completions. The only synchronous completion that could be there is the zoo_exists call, but this was completed at the beginning of the test, before the server was stopped. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: [VOTE] Release ZooKeeper 3.2.2 (candidate 1)
+1 Put it under hbase and ran a loading on a small cluster. Completed. Checked out doc. Looks right on cursory glance. St.Ack On Tue, Dec 8, 2009 at 2:32 PM, Patrick Hunt ph...@apache.org wrote: I've created a second candidate build for ZooKeeper 3.2.2. This is a bug fix release addressing 13 issues (three critical) -- see the release notes for details. *** Please download, test and VOTE before the *** vote closes 3pm pacific time, Friday, December 11.*** http://people.apache.org/~phunt/zookeeper-3.2.2-candidate-1/http://people.apache.org/%7Ephunt/zookeeper-3.2.2-candidate-1/ Should we release this? Patrick
[jira] Commented: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12788538#action_12788538
]
Mahadev konar commented on ZOOKEEPER-458:
-
I tried running the new patch on the hudson machine. I get a core dump but this
time there is no trace of zookeeper internal calls. This looks very fishy!
{quote}
#0 0x2ab7e7ead225 in free () from /lib/libc.so.6
#1 0x004053fb in __gnu_cxx::new_allocatorstd::string::deallocate
(this=0x7fffc3845648, __p=0x3e7) at
/usr/include/c++/4.3/ext/new_allocator.h:98
#2 0x00405855 in std::_Deque_basestd::string,
std::allocatorstd::string ::_M_deallocate_node (this=0x7fffc3845648,
__p=0x3e7) at /usr/include/c++/4.3/bits/stl_deque.h:454
#3 0x00405886 in std::_Deque_basestd::string,
std::allocatorstd::string ::_M_destroy_nodes (this=0x7fffc3845648,
__nstart=0x13d3368, __nfinish=0x13d3370) at
/usr/include/c++/4.3/bits/stl_deque.h:557
#4 0x0040592b in ~_Deque_base (this=0x7fffc3845648) at
/usr/include/c++/4.3/bits/stl_deque.h:480
#5 0x004059a8 in ~deque (this=0x7fffc3845648) at
/usr/include/c++/4.3/bits/stl_deque.h:776
#6 0x004059fa in ~Message (this=0x7fffc3845640) at
/usr/include/cppunit/Message.h:39
#7 0x004351bc in Zookeeper_simpleSystem::testConnectIndex1
(this=0x13cede0) at /homes/mahadev/zookeeper-trunk/src/c/tests/TestClient.cc:846
#8 0x00431cc6 in CppUnit::TestCallerZookeeper_simpleSystem::runTest
(this=0x13cf040) at /usr/include/cppunit/TestCaller.h:166
#9 0x0045bb4a in CppUnit::TestCaseMethodFunctor::operator() ()
#10 0x00466d34 in CppUnit::DefaultProtector::protect ()
#11 0x004685af in CppUnit::ProtectorChain::protect ()
#12 0x00463602 in CppUnit::TestResult::protect ()
#13 0x0045b90a in CppUnit::TestCase::run ()
#14 0x00469153 in CppUnit::TestComposite::doRunChildTests ()
#15 0x00469076 in CppUnit::TestComposite::run ()
#16 0x00469153 in CppUnit::TestComposite::doRunChildTests ()
#17 0x00469076 in CppUnit::TestComposite::run ()
#18 0x00462e5a in CppUnit::TestResult::runTest ()
#19 0x004653b2 in CppUnit::TestRunner::run ()
#20 0x004047ea in main (argc=1, argv=0x7fffc38462d8) at
/homes/mahadev/zookeeper-trunk/src/c/tests/TestDriver.cc:152
{quote}
connect_index in zookeeper handle might get out of bound.
-
Key: ZOOKEEPER-458
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Mahadev konar
Assignee: Steven Cheng
Fix For: 3.3.0
Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch,
ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch
connect_index in zookeeper handle might get out of bound. the zokoeeper_init
method checks for index == count and sets it to zero. If the index becomes
greater than count, then it will go out of bounds.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-458: --- Attachment: ZOOKEEPER-458.patch Really looks like something with free... maybe this patch will be able to catch it better... marks the buffer node by setting len=-1 and checks it later. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-458) connect_index in zookeeper handle might get out of bound.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steven Cheng updated ZOOKEEPER-458: --- Attachment: ZOOKEEPER-458.patch This patch, rather. connect_index in zookeeper handle might get out of bound. - Key: ZOOKEEPER-458 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-458 Project: Zookeeper Issue Type: Bug Components: c client Reporter: Mahadev konar Assignee: Steven Cheng Fix For: 3.3.0 Attachments: ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch, ZOOKEEPER-458.patch connect_index in zookeeper handle might get out of bound. the zokoeeper_init method checks for index == count and sets it to zero. If the index becomes greater than count, then it will go out of bounds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
