Build failed in Hudson: ZooKeeper-trunk #629
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/629/changes
Changes:
[mahadev] ZOOKEEPER-534. The test target in contib/bookkeeper does not depend
on jar target. (phunt via mahadev)
[mahadev] ZOOKEEPER-627. zkpython arbitrarily restricts the size of a \'get\'
to 512 bytes (henry robinson via mahadev)
[phunt] ZOOKEEPER-630. Trunk has duplicate ObserverTest.java files
[phunt] ZOOKEEPER-609. ObserverTest failure zk should not be connected
expected not same
--
[...truncated 120676 lines...]
| |modules|| artifacts |
| conf | number| search|dwnlded|evicted|| number|dwnlded|
-
| jdiff | 2 | 0 | 0 | 0 || 2 | 0 |
-
[ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper
[ivy:retrieve] confs: [jdiff]
[ivy:retrieve] 2 artifacts copied, 0 already retrieved (1896kB/11ms)
write-null:
api-xml:
[javadoc] Generating Javadoc
[javadoc] Javadoc execution
[javadoc] Loading source files for package org.apache.zookeeper...
[javadoc] Constructing Javadoc information...
[javadoc] JDiff: doclet started ...
[javadoc] JDiff: writing the API to file
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/lib/jdiff/zookeeper_3.3.0.xml'...
[javadoc]
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/main/org/apache/zookeeper/ClientWatchManager.java:38:
warning - @return tag has no arguments.
[javadoc] JDiff: finished (took 0s, not including scanning the source files).
[javadoc] 1 warning
api-report:
[mkdir] Created dir:
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/docs/jdiff
[javadoc] Generating Javadoc
[javadoc] Javadoc execution
[javadoc] Loading source file
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/jdiff/lib/Null.java...
[javadoc] Loading source files for package org.apache.jute.compiler...
[javadoc] Loading source files for package
org.apache.jute.compiler.generated...
[javadoc] Loading source files for package org.apache.zookeeper...
[javadoc] Loading source files for package org.apache.zookeeper.common...
[javadoc] Loading source files for package org.apache.zookeeper.jmx...
[javadoc] Loading source files for package org.apache.zookeeper.server...
[javadoc] Loading source files for package org.apache.zookeeper.server.auth...
[javadoc] Loading source files for package
org.apache.zookeeper.server.persistence...
[javadoc] Loading source files for package
org.apache.zookeeper.server.quorum...
[javadoc] Loading source files for package
org.apache.zookeeper.server.quorum.flexible...
[javadoc] Loading source files for package
org.apache.zookeeper.server.upgrade...
[javadoc] Loading source files for package org.apache.zookeeper.server.util...
[javadoc] Loading source files for package
org.apache.zookeeper.version.util...
[javadoc] Constructing Javadoc information...
[javadoc] JDiff: doclet started ...
[javadoc] JDiff: reading the old API in from file
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/lib/jdiff/zookeeper_3.1.1.xml'...Warning:
incorrectly formatted @link in text: API errors.
[javadoc] This is never thrown by the server, it shouldn't be used other than
[javadoc] to indicate a range. Specifically error codes greater than this
[javadoc] value are API errors (while values less than this indicate a
[javadoc] {...@link #SYSTEMERROR}).
[javadoc] finished
[javadoc] JDiff: reading the new API in from file
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/lib/jdiff/zookeeper_3.3.0.xml'...Warning:
incorrectly formatted @link in text: API errors.
[javadoc] This is never thrown by the server, it shouldn't be used other than
[javadoc] to indicate a range. Specifically error codes greater than this
[javadoc] value are API errors (while values less than this indicate a
[javadoc] {...@link #SYSTEMERROR}).
[javadoc] finished
[javadoc] JDiff: comparing the old and new APIs ...
[javadoc] Approximately 8% difference between the APIs
[javadoc] JDiff: reading the comments in from file
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/docs/jdiff/user_comments_for_zookeeper_3.1.1_to_zookeeper_3.3.0.xml'...
[javadoc] (this will be created)
[javadoc] JDiff: generating HTML report into the file
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/docs/jdiff/changes.html'
and the subdirectory
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/docs/jdiff/changes'
[javadoc] Note: all the comments have been newly generated
[javadoc] JDiff: writing the comments out to file
[jira] Commented: (ZOOKEEPER-600) TODO pondering about allocation behavior in zkpython may be removed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12791901#action_12791901
]
Gustavo Niemeyer commented on ZOOKEEPER-600:
I believe it's ready for integration.
TODO pondering about allocation behavior in zkpython may be removed
---
Key: ZOOKEEPER-600
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-600
Project: Zookeeper
Issue Type: Bug
Components: contrib-bindings
Affects Versions: 3.2.1
Reporter: Gustavo Niemeyer
Assignee: Gustavo Niemeyer
Priority: Trivial
Fix For: 3.3.0
Attachments: deallocate-vector.patch
I suppose the TODO below is referring to the path variable which is passed
in as an output variable to PyArg_ParseTuple right below. The TODO may be
removed, since the code is right. Code using PyArg_ParseTuple will borrow
the reference from the calling code, since there's a stack behind the call to
the enclosing function (pyzoo_get_children in this case) which won't go away
until the function returns.
Index: src/contrib/zkpython/src/c/zookeeper.c
===
--- src/contrib/zkpython/src/c/zookeeper.c(revision 885582)
+++ src/contrib/zkpython/src/c/zookeeper.c(working copy)
@@ -774,8 +774,6 @@
static PyObject *pyzoo_get_children(PyObject *self, PyObject *args)
{
- // TO DO: Does Python copy the string or the reference? If it's the former
- // we should free the String_vector
int zkhid;
char *path;
PyObject *watcherfn = Py_None;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Fwd: Build failed in Hudson: ZooKeeper-trunk #629
The patch of ZOOKEEPER-623 should fix the cause of the failure.
-Flavio
Begin forwarded message:
From: Apache Hudson Server hud...@hudson.zones.apache.org
Date: December 17, 2009 12:07:16 PM GMT+01:00
To: zookeeper-dev@hadoop.apache.org zookeeper-
d...@hadoop.apache.org
Subject: Build failed in Hudson: ZooKeeper-trunk #629
Reply-To: zookeeper-dev@hadoop.apache.org zookeeper-dev@hadoop.apache.org
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/629/changes
Changes:
[mahadev] ZOOKEEPER-534. The test target in contib/bookkeeper does
not depend on jar target. (phunt via mahadev)
[mahadev] ZOOKEEPER-627. zkpython arbitrarily restricts the size of
a \'get\' to 512 bytes (henry robinson via mahadev)
[phunt] ZOOKEEPER-630. Trunk has duplicate ObserverTest.java files
[phunt] ZOOKEEPER-609. ObserverTest failure zk should not be
connected expected not same
--
[...truncated 120676 lines...]
| |modules||
artifacts |
| conf | number| search|dwnlded|evicted|| number|
dwnlded|
-
| jdiff | 2 | 0 | 0 | 0 || 2
| 0 |
-
[ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper
[ivy:retrieve] confs: [jdiff]
[ivy:retrieve] 2 artifacts copied, 0 already retrieved (1896kB/11ms)
write-null:
api-xml:
[javadoc] Generating Javadoc
[javadoc] Javadoc execution
[javadoc] Loading source files for package org.apache.zookeeper...
[javadoc] Constructing Javadoc information...
[javadoc] JDiff: doclet started ...
[javadoc] JDiff: writing the API to file 'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/lib/jdiff/zookeeper_3.3.0.xml'...
[javadoc] http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/main/org/apache/zookeeper/ClientWatchManager.java
:38: warning - @return tag has no arguments.
[javadoc] JDiff: finished (took 0s, not including scanning the
source files).
[javadoc] 1 warning
api-report:
[mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/docs/jdiff
[javadoc] Generating Javadoc
[javadoc] Javadoc execution
[javadoc] Loading source file http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/jdiff/lib/Null.java...
[javadoc] Loading source files for package
org.apache.jute.compiler...
[javadoc] Loading source files for package
org.apache.jute.compiler.generated...
[javadoc] Loading source files for package org.apache.zookeeper...
[javadoc] Loading source files for package
org.apache.zookeeper.common...
[javadoc] Loading source files for package
org.apache.zookeeper.jmx...
[javadoc] Loading source files for package
org.apache.zookeeper.server...
[javadoc] Loading source files for package
org.apache.zookeeper.server.auth...
[javadoc] Loading source files for package
org.apache.zookeeper.server.persistence...
[javadoc] Loading source files for package
org.apache.zookeeper.server.quorum...
[javadoc] Loading source files for package
org.apache.zookeeper.server.quorum.flexible...
[javadoc] Loading source files for package
org.apache.zookeeper.server.upgrade...
[javadoc] Loading source files for package
org.apache.zookeeper.server.util...
[javadoc] Loading source files for package
org.apache.zookeeper.version.util...
[javadoc] Constructing Javadoc information...
[javadoc] JDiff: doclet started ...
[javadoc] JDiff: reading the old API in from file 'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/lib/jdiff/zookeeper_3.1.1.xml'...Warning
: incorrectly formatted @link in text: API errors.
[javadoc] This is never thrown by the server, it shouldn't be used
other than
[javadoc] to indicate a range. Specifically error codes greater
than this
[javadoc] value are API errors (while values less than this
indicate a
[javadoc] {...@link #SYSTEMERROR}).
[javadoc] finished
[javadoc] JDiff: reading the new API in from file 'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/lib/jdiff/zookeeper_3.3.0.xml'...Warning
: incorrectly formatted @link in text: API errors.
[javadoc] This is never thrown by the server, it shouldn't be used
other than
[javadoc] to indicate a range. Specifically error codes greater
than this
[javadoc] value are API errors (while values less than this
indicate a
[javadoc] {...@link #SYSTEMERROR}).
[javadoc] finished
[javadoc] JDiff: comparing the old and new APIs ...
[javadoc] Approximately 8% difference between the APIs
[javadoc] JDiff: reading the comments in from file 'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/docs/jdiff/user_comments_for_zookeeper_3.1.1_to_zookeeper_3.3.0.xml'...
[jira] Updated: (ZOOKEEPER-623) ClientBase in bookkeeper.util requires junit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-623: - Status: Open (was: Patch Available) It is a good observation, Mahadev. I'm uploading a new patch that uses the zookeeper version of the class. This patch, however, does not compile because we need to modify bookeeper/build.xml as you suggest. I haven't had a chance to look into it so if you know exactly what to modify, please either make the modification yourself or let me know where it is. ClientBase in bookkeeper.util requires junit Key: ZOOKEEPER-623 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-623 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.3.0 Attachments: ZOOKEEPER-623.patch, ZOOKEEPER-623.patch Class org.apache.bookkeeper.util.ClientBase requires junit, and when I tried to just compile bookkeeper, no test, with the patch of ZOOKEEPER-534, compilation failed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-623) ClientBase in bookkeeper.util requires junit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-623: - Attachment: ZOOKEEPER-623.patch ClientBase in bookkeeper.util requires junit Key: ZOOKEEPER-623 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-623 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.3.0 Attachments: ZOOKEEPER-623.patch, ZOOKEEPER-623.patch Class org.apache.bookkeeper.util.ClientBase requires junit, and when I tried to just compile bookkeeper, no test, with the patch of ZOOKEEPER-534, compilation failed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Build failed in Hudson: ZooKeeper-trunk #629
Sure, if you run ant test it works because ivy will fetch junit. It
shouldn't work if you just run ant.
-Flavio
On Dec 17, 2009, at 5:55 PM, Benjamin Reed wrote:
weird. i just did a fresh checkout and ant test and it succeeded.
ben
Flavio Junqueira wrote:
The patch of ZOOKEEPER-623 should fix the cause of the failure.
-Flavio
Begin forwarded message:
From: Apache Hudson Server hud...@hudson.zones.apache.org
Date: December 17, 2009 12:07:16 PM GMT+01:00
To: zookeeper-dev@hadoop.apache.org zookeeper-
d...@hadoop.apache.org
Subject: Build failed in Hudson: ZooKeeper-trunk #629
Reply-To: zookeeper-dev@hadoop.apache.org zookeeper-dev@hadoop.apache.org
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/629/changes
Changes:
[mahadev] ZOOKEEPER-534. The test target in contib/bookkeeper does
not depend on jar target. (phunt via mahadev)
[mahadev] ZOOKEEPER-627. zkpython arbitrarily restricts the size of
a \'get\' to 512 bytes (henry robinson via mahadev)
[phunt] ZOOKEEPER-630. Trunk has duplicate ObserverTest.java files
[phunt] ZOOKEEPER-609. ObserverTest failure zk should not be
connected expected not same
--
[...truncated 120676 lines...]
| |modules||
artifacts |
| conf | number| search|dwnlded|evicted|| number|
dwnlded|
-
| jdiff | 2 | 0 | 0 | 0 || 2
| 0 |
-
[ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper
[ivy:retrieve] confs: [jdiff]
[ivy:retrieve] 2 artifacts copied, 0 already retrieved (1896kB/
11ms)
write-null:
api-xml:
[javadoc] Generating Javadoc
[javadoc] Javadoc execution
[javadoc] Loading source files for package org.apache.zookeeper...
[javadoc] Constructing Javadoc information...
[javadoc] JDiff: doclet started ...
[javadoc] JDiff: writing the API to file 'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/lib/jdiff/zookeeper_3.3.0.xml'
...
[javadoc]
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/main/org/apache/zookeeper/ClientWatchManager.java
:38: warning - @return tag has no arguments.
[javadoc] JDiff: finished (took 0s, not including scanning the
source files).
[javadoc] 1 warning
api-report:
[mkdir] Created dir:
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/docs/jdiff
[javadoc] Generating Javadoc
[javadoc] Javadoc execution
[javadoc] Loading source file http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/jdiff/lib/Null.java
...
[javadoc] Loading source files for package
org.apache.jute.compiler...
[javadoc] Loading source files for package
org.apache.jute.compiler.generated...
[javadoc] Loading source files for package org.apache.zookeeper...
[javadoc] Loading source files for package
org.apache.zookeeper.common...
[javadoc] Loading source files for package
org.apache.zookeeper.jmx...
[javadoc] Loading source files for package
org.apache.zookeeper.server...
[javadoc] Loading source files for package
org.apache.zookeeper.server.auth...
[javadoc] Loading source files for package
org.apache.zookeeper.server.persistence...
[javadoc] Loading source files for package
org.apache.zookeeper.server.quorum...
[javadoc] Loading source files for package
org.apache.zookeeper.server.quorum.flexible...
[javadoc] Loading source files for package
org.apache.zookeeper.server.upgrade...
[javadoc] Loading source files for package
org.apache.zookeeper.server.util...
[javadoc] Loading source files for package
org.apache.zookeeper.version.util...
[javadoc] Constructing Javadoc information...
[javadoc] JDiff: doclet started ...
[javadoc] JDiff: reading the old API in from file
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/lib/jdiff/zookeeper_3.1.1.xml'...Warning
: incorrectly formatted @link in text: API errors.
[javadoc] This is never thrown by the server, it shouldn't be used
other than
[javadoc] to indicate a range. Specifically error codes greater
than this
[javadoc] value are API errors (while values less than this
indicate a
[javadoc] {...@link #SYSTEMERROR}).
[javadoc] finished
[javadoc] JDiff: reading the new API in from file
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/lib/jdiff/zookeeper_3.3.0.xml'...Warning
: incorrectly formatted @link in text: API errors.
[javadoc] This is never thrown by the server, it shouldn't be used
other than
[javadoc] to indicate a range. Specifically error codes greater
than this
[javadoc] value are API errors (while values less than this
indicate a
[javadoc] {...@link #SYSTEMERROR}).
[javadoc] finished
[javadoc] JDiff: comparing the old and new APIs ...
[javadoc] Approximately 8% difference between the APIs
[javadoc] JDiff: reading the comments in
[jira] Resolved: (ZOOKEEPER-623) ClientBase in bookkeeper.util requires junit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed resolved ZOOKEEPER-623. - Resolution: Fixed Hadoop Flags: [Reviewed] Committed revision 891809. ClientBase in bookkeeper.util requires junit Key: ZOOKEEPER-623 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-623 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.3.0 Attachments: ZOOKEEPER-623.patch, ZOOKEEPER-623.patch Class org.apache.bookkeeper.util.ClientBase requires junit, and when I tried to just compile bookkeeper, no test, with the patch of ZOOKEEPER-534, compilation failed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Build failed in Hudson: ZooKeeper-trunk #630
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/630/
--
[...truncated 120123 lines...]
| |modules|| artifacts |
| conf | number| search|dwnlded|evicted|| number|dwnlded|
-
| jdiff | 2 | 0 | 0 | 0 || 2 | 0 |
-
[ivy:retrieve] :: retrieving :: org.apache.zookeeper#zookeeper
[ivy:retrieve] confs: [jdiff]
[ivy:retrieve] 2 artifacts copied, 0 already retrieved (1896kB/10ms)
write-null:
api-xml:
[javadoc] Generating Javadoc
[javadoc] Javadoc execution
[javadoc] Loading source files for package org.apache.zookeeper...
[javadoc] Constructing Javadoc information...
[javadoc] JDiff: doclet started ...
[javadoc] JDiff: writing the API to file
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/lib/jdiff/zookeeper_3.3.0.xml'...
[javadoc]
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/main/org/apache/zookeeper/ClientWatchManager.java:38:
warning - @return tag has no arguments.
[javadoc] JDiff: finished (took 0s, not including scanning the source files).
[javadoc] 1 warning
api-report:
[mkdir] Created dir:
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/docs/jdiff
[javadoc] Generating Javadoc
[javadoc] Javadoc execution
[javadoc] Loading source file
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/jdiff/lib/Null.java...
[javadoc] Loading source files for package org.apache.jute.compiler...
[javadoc] Loading source files for package
org.apache.jute.compiler.generated...
[javadoc] Loading source files for package org.apache.zookeeper...
[javadoc] Loading source files for package org.apache.zookeeper.common...
[javadoc] Loading source files for package org.apache.zookeeper.jmx...
[javadoc] Loading source files for package org.apache.zookeeper.server...
[javadoc] Loading source files for package org.apache.zookeeper.server.auth...
[javadoc] Loading source files for package
org.apache.zookeeper.server.persistence...
[javadoc] Loading source files for package
org.apache.zookeeper.server.quorum...
[javadoc] Loading source files for package
org.apache.zookeeper.server.quorum.flexible...
[javadoc] Loading source files for package
org.apache.zookeeper.server.upgrade...
[javadoc] Loading source files for package org.apache.zookeeper.server.util...
[javadoc] Loading source files for package
org.apache.zookeeper.version.util...
[javadoc] Constructing Javadoc information...
[javadoc] JDiff: doclet started ...
[javadoc] JDiff: reading the old API in from file
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/lib/jdiff/zookeeper_3.1.1.xml'...Warning:
incorrectly formatted @link in text: API errors.
[javadoc] This is never thrown by the server, it shouldn't be used other than
[javadoc] to indicate a range. Specifically error codes greater than this
[javadoc] value are API errors (while values less than this indicate a
[javadoc] {...@link #SYSTEMERROR}).
[javadoc] finished
[javadoc] JDiff: reading the new API in from file
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/lib/jdiff/zookeeper_3.3.0.xml'...Warning:
incorrectly formatted @link in text: API errors.
[javadoc] This is never thrown by the server, it shouldn't be used other than
[javadoc] to indicate a range. Specifically error codes greater than this
[javadoc] value are API errors (while values less than this indicate a
[javadoc] {...@link #SYSTEMERROR}).
[javadoc] finished
[javadoc] JDiff: comparing the old and new APIs ...
[javadoc] Approximately 8% difference between the APIs
[javadoc] JDiff: reading the comments in from file
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/docs/jdiff/user_comments_for_zookeeper_3.1.1_to_zookeeper_3.3.0.xml'...
[javadoc] (this will be created)
[javadoc] JDiff: generating HTML report into the file
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/docs/jdiff/changes.html'
and the subdirectory
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/docs/jdiff/changes'
[javadoc] Note: all the comments have been newly generated
[javadoc] JDiff: writing the comments out to file
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/docs/jdiff/user_comments_for_zookeeper_3.1.1_to_zookeeper_3.3.0.xml'...
[javadoc] JDiff: finished (took 0s).
check-cppunit-configure:
create-cppunit-configure:
ivy-retrieve-test:
[ivy:retrieve] :: resolving dependencies :: org.apache.zookeeper#zookeeper;3.3.0
[ivy:retrieve] confs: [test]
[ivy:retrieve] found junit#junit;4.7 in
Build failed in Hudson: ZooKeeper-trunk #631
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/631/changes Changes: [breed] ZOOKEEPER-623. ClientBase in bookkeeper.util requires junit -- [...truncated 196691 lines...] [junit] 2009-12-17 17:50:00,101 - INFO [main-SendThread(localhost:11225):clientcnxn$sendthr...@934] - Opening socket connection to server localhost/127.0.0.1:11225 [junit] 2009-12-17 17:50:00,102 - INFO [main-SendThread(localhost:11225):clientcnxn$sendthr...@842] - Socket connection established to localhost/127.0.0.1:11225, initiating session [junit] 2009-12-17 17:50:00,102 - INFO [NIOServerCxn.Factory:11225:nioservercnxn$fact...@237] - Accepted socket connection from /127.0.0.1:57993 [junit] 2009-12-17 17:50:00,102 - INFO [NIOServerCxn.Factory:11225:nioserverc...@715] - Client attempting to renew session 0x1259dc2a53a at /127.0.0.1:57993 [junit] 2009-12-17 17:50:00,103 - INFO [NIOServerCxn.Factory:11225:nioserverc...@1148] - Established session 0x1259dc2a53a with negotiated timeout 6000 for client /127.0.0.1:57993 [junit] 2009-12-17 17:50:00,103 - INFO [main-SendThread(localhost:11225):clientcnxn$sendthr...@641] - Session establishment complete on server localhost/127.0.0.1:11225, sessionid = 0x1259dc2a53a, negotiated timeout = 6000 [junit] 2009-12-17 17:50:00,112 - INFO [main:clientb...@385] - STOPPING server [junit] 2009-12-17 17:50:00,113 - INFO [main:nioserverc...@995] - Closed socket connection for client /127.0.0.1:57993 which had sessionid 0x1259dc2a53a [junit] 2009-12-17 17:50:00,114 - INFO [main-SendThread(localhost:11225):clientcnxn$sendthr...@1052] - Unable to read additional data from server sessionid 0x1259dc2a53a, likely server has closed socket, closing socket connection and attempting reconnect [junit] 2009-12-17 17:50:00,114 - INFO [NIOServerCxn.Factory:11225:nioservercnxn$fact...@264] - NIOServerCnxn factory exited run method [junit] 2009-12-17 17:50:00,114 - INFO [main:finalrequestproces...@365] - shutdown of request processor complete [junit] 2009-12-17 17:50:00,114 - INFO [SyncThread:0:syncrequestproces...@151] - SyncRequestProcessor exited! [junit] 2009-12-17 17:50:00,114 - INFO [ProcessThread:-1:preprequestproces...@119] - PrepRequestProcessor exited loop! [junit] ensureOnly:[] [junit] 2009-12-17 17:50:00,214 - INFO [main:clientb...@378] - STARTING server [junit] 2009-12-17 17:50:00,214 - INFO [main:zookeeperser...@161] - Created server [junit] 2009-12-17 17:50:00,215 - INFO [main:nioservercnxn$fact...@141] - binding to port 11225 [junit] 2009-12-17 17:50:00,221 - INFO [main:files...@81] - Reading snapshot http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/test/tmp/test8608050365017150474.junit.dir/version-2/snapshot.5 [junit] 2009-12-17 17:50:00,223 - INFO [main:filetxnsnap...@208] - Snapshotting: 6 [junit] 2009-12-17 17:50:00,226 - INFO [NIOServerCxn.Factory:11225:nioservercnxn$fact...@237] - Accepted socket connection from /127.0.0.1:57995 [junit] 2009-12-17 17:50:00,227 - INFO [NIOServerCxn.Factory:11225:nioserverc...@809] - Processing stat command from /127.0.0.1:57995 [junit] 2009-12-17 17:50:00,227 - INFO [NIOServerCxn.Factory:11225:nioserverc...@995] - Closed socket connection for client /127.0.0.1:57995 (no session established for client) [junit] ensureOnly:[InMemoryDataTree, StandaloneServer_port] [junit] expect:InMemoryDataTree [junit] found:InMemoryDataTree org.apache.ZooKeeperService:name0=StandaloneServer_port-1,name1=InMemoryDataTree [junit] expect:StandaloneServer_port [junit] found:StandaloneServer_port org.apache.ZooKeeperService:name0=StandaloneServer_port-1 [junit] 2009-12-17 17:50:01,896 - INFO [main-SendThread(localhost:11225):clientcnxn$sendthr...@934] - Opening socket connection to server localhost/127.0.0.1:11225 [junit] 2009-12-17 17:50:01,897 - INFO [main-SendThread(localhost:11225):clientcnxn$sendthr...@842] - Socket connection established to localhost/127.0.0.1:11225, initiating session [junit] 2009-12-17 17:50:01,897 - INFO [NIOServerCxn.Factory:11225:nioservercnxn$fact...@237] - Accepted socket connection from /127.0.0.1:57996 [junit] 2009-12-17 17:50:01,897 - INFO [NIOServerCxn.Factory:11225:nioserverc...@715] - Client attempting to renew session 0x1259dc2a53a at /127.0.0.1:57996 [junit] 2009-12-17 17:50:01,899 - INFO [NIOServerCxn.Factory:11225:nioserverc...@1148] - Established session 0x1259dc2a53a with negotiated timeout 6000 for client /127.0.0.1:57996 [junit] 2009-12-17 17:50:01,899 - INFO [main-SendThread(localhost:11225):clientcnxn$sendthr...@641] - Session establishment complete on server localhost/127.0.0.1:11225, sessionid = 0x1259dc2a53a, negotiated timeout = 6000 [junit] 2009-12-17 17:50:02,909 - INFO [ProcessThread:-1:preprequestproces...@385] -
[jira] Updated: (ZOOKEEPER-623) ClientBase in bookkeeper.util requires junit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-623: Attachment: ZOOKEEPER-623_2.patch makes bookkeeper tests work again. ClientBase in bookkeeper.util requires junit Key: ZOOKEEPER-623 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-623 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.3.0 Attachments: ZOOKEEPER-623.patch, ZOOKEEPER-623.patch, ZOOKEEPER-623_2.patch Class org.apache.bookkeeper.util.ClientBase requires junit, and when I tried to just compile bookkeeper, no test, with the patch of ZOOKEEPER-534, compilation failed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-623) ClientBase in bookkeeper.util requires junit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792060#action_12792060 ] Mahadev konar commented on ZOOKEEPER-623: - +1 great patch ben!!! ClientBase in bookkeeper.util requires junit Key: ZOOKEEPER-623 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-623 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.3.0 Attachments: ZOOKEEPER-623.patch, ZOOKEEPER-623.patch, ZOOKEEPER-623_2.patch Class org.apache.bookkeeper.util.ClientBase requires junit, and when I tried to just compile bookkeeper, no test, with the patch of ZOOKEEPER-534, compilation failed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-600) TODO pondering about allocation behavior in zkpython may be removed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792069#action_12792069
]
Henry Robinson commented on ZOOKEEPER-600:
--
Yes, this looks good to me - I'd like to see a test included, but we have no
infrastructure for C-side tests which this would probably need. Can be
committed as far as I am concerned. Thanks Gustavo!
TODO pondering about allocation behavior in zkpython may be removed
---
Key: ZOOKEEPER-600
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-600
Project: Zookeeper
Issue Type: Bug
Components: contrib-bindings
Affects Versions: 3.2.1
Reporter: Gustavo Niemeyer
Assignee: Gustavo Niemeyer
Priority: Trivial
Fix For: 3.3.0
Attachments: deallocate-vector.patch
I suppose the TODO below is referring to the path variable which is passed
in as an output variable to PyArg_ParseTuple right below. The TODO may be
removed, since the code is right. Code using PyArg_ParseTuple will borrow
the reference from the calling code, since there's a stack behind the call to
the enclosing function (pyzoo_get_children in this case) which won't go away
until the function returns.
Index: src/contrib/zkpython/src/c/zookeeper.c
===
--- src/contrib/zkpython/src/c/zookeeper.c(revision 885582)
+++ src/contrib/zkpython/src/c/zookeeper.c(working copy)
@@ -774,8 +774,6 @@
static PyObject *pyzoo_get_children(PyObject *self, PyObject *args)
{
- // TO DO: Does Python copy the string or the reference? If it's the former
- // we should free the String_vector
int zkhid;
char *path;
PyObject *watcherfn = Py_None;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-623) ClientBase in bookkeeper.util requires junit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-623: Attachment: ZOOKEEPER-623_2.patch updated to not try to resolve ClientBase and print a better message. ClientBase in bookkeeper.util requires junit Key: ZOOKEEPER-623 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-623 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.3.0 Attachments: ZOOKEEPER-623.patch, ZOOKEEPER-623.patch, ZOOKEEPER-623_2.patch, ZOOKEEPER-623_2.patch Class org.apache.bookkeeper.util.ClientBase requires junit, and when I tried to just compile bookkeeper, no test, with the patch of ZOOKEEPER-534, compilation failed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Reopened: (ZOOKEEPER-623) ClientBase in bookkeeper.util requires junit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar reopened ZOOKEEPER-623: - reopening the issue. ClientBase in bookkeeper.util requires junit Key: ZOOKEEPER-623 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-623 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.3.0 Attachments: ZOOKEEPER-623.patch, ZOOKEEPER-623.patch, ZOOKEEPER-623_2.patch, ZOOKEEPER-623_2.patch Class org.apache.bookkeeper.util.ClientBase requires junit, and when I tried to just compile bookkeeper, no test, with the patch of ZOOKEEPER-534, compilation failed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Hudson build is back to normal: ZooKeeper-trunk #632
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/632/
[jira] Commented: (ZOOKEEPER-630) Trunk has duplicate ObserverTest.java files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792092#action_12792092 ] Hudson commented on ZOOKEEPER-630: -- Integrated in ZooKeeper-trunk #632 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/632/]) Trunk has duplicate ObserverTest.java files --- Key: ZOOKEEPER-630 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-630 Project: Zookeeper Issue Type: Bug Components: tests Reporter: Henry Robinson Assignee: Henry Robinson Fix For: 3.3.0 Attachments: ZOOKEEPER-630.patch There are two identical ObserverTest.java files in trunk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-534) The test target in contib/bookkeeper does not depend on jar target.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792091#action_12792091 ] Hudson commented on ZOOKEEPER-534: -- Integrated in ZooKeeper-trunk #632 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/632/]) The test target in contib/bookkeeper does not depend on jar target. --- Key: ZOOKEEPER-534 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-534 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Affects Versions: 3.2.0, 3.2.1 Reporter: Mahadev konar Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-534.patch The test target in contib/bookkeeper does not depend on jar target. So the ant test target gives compilation errors if the main is not compiled which can be prevented if it depends on jar. It can then check if main has been compiled or not and throw out a reasonable error. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-627) zkpython arbitrarily restricts the size of a 'get' to 512 bytes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792089#action_12792089 ] Hudson commented on ZOOKEEPER-627: -- Integrated in ZooKeeper-trunk #632 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/632/]) zkpython arbitrarily restricts the size of a 'get' to 512 bytes --- Key: ZOOKEEPER-627 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-627 Project: Zookeeper Issue Type: Bug Components: contrib-bindings Reporter: Henry Robinson Assignee: Henry Robinson Fix For: 3.3.0 Attachments: ZOOKEEPER-627.patch, ZOOKEEPER-627.patch, ZOOKEEPER-627.patch Reported on the list: I'm working on using ZooKeeper for an internal application at Digg. I've been using the zkpython package and I just noticed that the data I was receiving from a zookeeper.get() call was being truncated. After some quick digging I found that zookeeper.c limits the data returned to 512 characters (see http://svn.apache.org/viewvc/hadoop/zookeeper/tags/release-3.2.2/src/contrib/zkpython/src/c/zookeeper.c?view=markup line 855). Is there a reason for this? The only information regarding node size that I've read is that it should not exceed 1MB so this limit seems a bit arbitrary and restrictive. Thanks for the great work! Rich -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-609) ObserverTest failure zk should not be connected expected not same
[ https://issues.apache.org/jira/browse/ZOOKEEPER-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792090#action_12792090 ] Hudson commented on ZOOKEEPER-609: -- Integrated in ZooKeeper-trunk #632 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/632/]) ObserverTest failure zk should not be connected expected not same --- Key: ZOOKEEPER-609 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-609 Project: Zookeeper Issue Type: Bug Components: quorum, server Affects Versions: 3.3.0 Reporter: Patrick Hunt Assignee: Henry Robinson Priority: Blocker Fix For: 3.3.0 Attachments: TEST-org.apache.zookeeper.server.quorum.ObserverTest.xml, ZOOKEEPER-609.patch ObserverTest failed running on 8core I ran the test as: ant -Dtest.junit.output.format=xml -Dtest.output -Dtestcase=AsyncHammerTest clean test-core-java test.out -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-623) ClientBase in bookkeeper.util requires junit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792093#action_12792093 ] Hudson commented on ZOOKEEPER-623: -- Integrated in ZooKeeper-trunk #632 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/632/]) ClientBase in bookkeeper.util requires junit Key: ZOOKEEPER-623 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-623 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.3.0 Attachments: ZOOKEEPER-623.patch, ZOOKEEPER-623.patch, ZOOKEEPER-623_2.patch, ZOOKEEPER-623_2.patch Class org.apache.bookkeeper.util.ClientBase requires junit, and when I tried to just compile bookkeeper, no test, with the patch of ZOOKEEPER-534, compilation failed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-623) ClientBase in bookkeeper.util requires junit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792109#action_12792109 ] Hudson commented on ZOOKEEPER-623: -- Integrated in ZooKeeper-trunk #633 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/633/]) . ClientBase in bookkeeper.util requires junit ClientBase in bookkeeper.util requires junit Key: ZOOKEEPER-623 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-623 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.3.0 Attachments: ZOOKEEPER-623.patch, ZOOKEEPER-623.patch, ZOOKEEPER-623_2.patch, ZOOKEEPER-623_2.patch Class org.apache.bookkeeper.util.ClientBase requires junit, and when I tried to just compile bookkeeper, no test, with the patch of ZOOKEEPER-534, compilation failed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-596) The last logged zxid calculated by zookeeper servers could cause problems in leader election if data gets corrupted.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-596: Attachment: ZOOKEEPER-596.patch patch that addresses ben's comments. Also removed some unnecessary logging from the tests. The last logged zxid calculated by zookeeper servers could cause problems in leader election if data gets corrupted. Key: ZOOKEEPER-596 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-596 Project: Zookeeper Issue Type: Bug Affects Versions: 3.2.1 Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 Attachments: ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch It is possible that the last loggged zxid as reported by all the servers during leader election is not the last zxid that the server can upload data to. It is very much possible that some transaction or snapshot gets corrupted and the servers actually do not have valid data till last logged zxid. We need to make sure that what the servers report as there last logged zxid, they are able to load data till that zxid. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-596) The last logged zxid calculated by zookeeper servers could cause problems in leader election if data gets corrupted.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-596: Status: Patch Available (was: Open) The last logged zxid calculated by zookeeper servers could cause problems in leader election if data gets corrupted. Key: ZOOKEEPER-596 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-596 Project: Zookeeper Issue Type: Bug Affects Versions: 3.2.1 Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 Attachments: ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch It is possible that the last loggged zxid as reported by all the servers during leader election is not the last zxid that the server can upload data to. It is very much possible that some transaction or snapshot gets corrupted and the servers actually do not have valid data till last logged zxid. We need to make sure that what the servers report as there last logged zxid, they are able to load data till that zxid. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-596) The last logged zxid calculated by zookeeper servers could cause problems in leader election if data gets corrupted.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-596: Status: Open (was: Patch Available) The last logged zxid calculated by zookeeper servers could cause problems in leader election if data gets corrupted. Key: ZOOKEEPER-596 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-596 Project: Zookeeper Issue Type: Bug Affects Versions: 3.2.1 Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 Attachments: ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch It is possible that the last loggged zxid as reported by all the servers during leader election is not the last zxid that the server can upload data to. It is very much possible that some transaction or snapshot gets corrupted and the servers actually do not have valid data till last logged zxid. We need to make sure that what the servers report as there last logged zxid, they are able to load data till that zxid. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-596) The last logged zxid calculated by zookeeper servers could cause problems in leader election if data gets corrupted.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792142#action_12792142 ] Benjamin Reed commented on ZOOKEEPER-596: - +1 (assuming it passes test) The last logged zxid calculated by zookeeper servers could cause problems in leader election if data gets corrupted. Key: ZOOKEEPER-596 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-596 Project: Zookeeper Issue Type: Bug Affects Versions: 3.2.1 Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 Attachments: ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch It is possible that the last loggged zxid as reported by all the servers during leader election is not the last zxid that the server can upload data to. It is very much possible that some transaction or snapshot gets corrupted and the servers actually do not have valid data till last logged zxid. We need to make sure that what the servers report as there last logged zxid, they are able to load data till that zxid. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-426) Windows versions of zookeeper scripts
[ https://issues.apache.org/jira/browse/ZOOKEEPER-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792150#action_12792150 ] Benjamin Reed commented on ZOOKEEPER-426: - the plan is to put all of these files in bin and svn add them correct? Windows versions of zookeeper scripts - Key: ZOOKEEPER-426 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-426 Project: Zookeeper Issue Type: Improvement Components: scripts Affects Versions: 3.1.1 Reporter: David Bosschaert Assignee: David Bosschaert Fix For: 3.3.0 Attachments: README.txt, zkCli.cmd, zkCli.cmd, zkEnv.cmd, zkEnv.cmd, zkServer.cmd, zkServer.cmd Attached are a some Windows versions of the zookeeper scripts. They aren't as powerful as the .sh ones but they do work for me and can be invoked with any directory as the current dir. The biggest trick in the scripts is in the zkEnv.cmd one where it says: set ZOOCFGDIR=%~dp0%..\conf this basically figures out the location of the zkEnv.cmd file and sets the conf directory relative to that. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-606) bin scripts don't work in cygwin (spaces in paths)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792153#action_12792153 ] Benjamin Reed commented on ZOOKEEPER-606: - +1 bin scripts don't work in cygwin (spaces in paths) -- Key: ZOOKEEPER-606 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-606 Project: Zookeeper Issue Type: Bug Components: scripts Affects Versions: 3.2.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-606.patch, ZOOKEEPER-606.patch the scripts in bin fail under cygwin due to spaces not handled properly -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-606) bin scripts don't work in cygwin (spaces in paths)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-606: Resolution: Fixed Release Note: Committed revision 891944. Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) bin scripts don't work in cygwin (spaces in paths) -- Key: ZOOKEEPER-606 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-606 Project: Zookeeper Issue Type: Bug Components: scripts Affects Versions: 3.2.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-606.patch, ZOOKEEPER-606.patch the scripts in bin fail under cygwin due to spaces not handled properly -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-426) Windows versions of zookeeper scripts
[ https://issues.apache.org/jira/browse/ZOOKEEPER-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792179#action_12792179 ] Patrick Hunt commented on ZOOKEEPER-426: bq. (all these files need to be put into bin directory, please next time submit as a patch file) yes, all the cmd and the README as well. Windows versions of zookeeper scripts - Key: ZOOKEEPER-426 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-426 Project: Zookeeper Issue Type: Improvement Components: scripts Affects Versions: 3.1.1 Reporter: David Bosschaert Assignee: David Bosschaert Fix For: 3.3.0 Attachments: README.txt, zkCli.cmd, zkCli.cmd, zkEnv.cmd, zkEnv.cmd, zkServer.cmd, zkServer.cmd Attached are a some Windows versions of the zookeeper scripts. They aren't as powerful as the .sh ones but they do work for me and can be invoked with any directory as the current dir. The biggest trick in the scripts is in the zkEnv.cmd one where it says: set ZOOCFGDIR=%~dp0%..\conf this basically figures out the location of the zkEnv.cmd file and sets the conf directory relative to that. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-600) TODO pondering about allocation behavior in zkpython may be removed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-600:
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
great ... I just committed this. thanks gustavo.
TODO pondering about allocation behavior in zkpython may be removed
---
Key: ZOOKEEPER-600
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-600
Project: Zookeeper
Issue Type: Bug
Components: contrib-bindings
Affects Versions: 3.2.1
Reporter: Gustavo Niemeyer
Assignee: Gustavo Niemeyer
Priority: Trivial
Fix For: 3.3.0
Attachments: deallocate-vector.patch
I suppose the TODO below is referring to the path variable which is passed
in as an output variable to PyArg_ParseTuple right below. The TODO may be
removed, since the code is right. Code using PyArg_ParseTuple will borrow
the reference from the calling code, since there's a stack behind the call to
the enclosing function (pyzoo_get_children in this case) which won't go away
until the function returns.
Index: src/contrib/zkpython/src/c/zookeeper.c
===
--- src/contrib/zkpython/src/c/zookeeper.c(revision 885582)
+++ src/contrib/zkpython/src/c/zookeeper.c(working copy)
@@ -774,8 +774,6 @@
static PyObject *pyzoo_get_children(PyObject *self, PyObject *args)
{
- // TO DO: Does Python copy the string or the reference? If it's the former
- // we should free the String_vector
int zkhid;
char *path;
PyObject *watcherfn = Py_None;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-596) The last logged zxid calculated by zookeeper servers could cause problems in leader election if data gets corrupted.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792253#action_12792253 ] Hadoop QA commented on ZOOKEEPER-596: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12428346/ZOOKEEPER-596.patch against trunk revision 892001. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/93/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/93/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/93/console This message is automatically generated. The last logged zxid calculated by zookeeper servers could cause problems in leader election if data gets corrupted. Key: ZOOKEEPER-596 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-596 Project: Zookeeper Issue Type: Bug Affects Versions: 3.2.1 Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 Attachments: ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch It is possible that the last loggged zxid as reported by all the servers during leader election is not the last zxid that the server can upload data to. It is very much possible that some transaction or snapshot gets corrupted and the servers actually do not have valid data till last logged zxid. We need to make sure that what the servers report as there last logged zxid, they are able to load data till that zxid. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-596) The last logged zxid calculated by zookeeper servers could cause problems in leader election if data gets corrupted.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-596: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) I just committed this. The last logged zxid calculated by zookeeper servers could cause problems in leader election if data gets corrupted. Key: ZOOKEEPER-596 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-596 Project: Zookeeper Issue Type: Bug Affects Versions: 3.2.1 Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 Attachments: ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch, ZOOKEEPER-596.patch It is possible that the last loggged zxid as reported by all the servers during leader election is not the last zxid that the server can upload data to. It is very much possible that some transaction or snapshot gets corrupted and the servers actually do not have valid data till last logged zxid. We need to make sure that what the servers report as there last logged zxid, they are able to load data till that zxid. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-629) FLELostMessageTest assumes that the first zxid on a startup of quorum is -1.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-629: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) This was committed as part of ZOOKEEPER-596. Thanks flavio! FLELostMessageTest assumes that the first zxid on a startup of quorum is -1. Key: ZOOKEEPER-629 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-629 Project: Zookeeper Issue Type: Bug Reporter: Mahadev konar Assignee: Flavio Paiva Junqueira Fix For: 3.3.0 Attachments: ZOOKEEPER-629.patch FLELostMessageTest assumes that the first zxid exchange will be -1 zxid. WIth ZOOKEEPER-596 the zxid would be 0 and not -1. So the corresponding change needs to be made to this test. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-544) improve client testability - allow test client to access connected server location
[ https://issues.apache.org/jira/browse/ZOOKEEPER-544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-544: Status: Open (was: Patch Available) trying hudson out agian, after all the changes went in improve client testability - allow test client to access connected server location -- Key: ZOOKEEPER-544 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-544 Project: Zookeeper Issue Type: Improvement Components: c client, java client, tests Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-544.patch This came up recently on the user list. If you are developing tests for your zk client you need to be able to access the server that your session is currently connected to. The reason is that your test needs to know which server in the quorum to shutdown in order to verify you are handling failover correctly. Similar for session expiration testing. however we should be careful, we prefer not to expose this to all clients, this is an implementation detail that we typically want to hide. also we should provide this in both the c and java clients I suspect we should add a protected method on ZooKeeper. This will make a higher bar (user will have to subclass) for the user to access this method. In tests it's fine, typically you want a TestableZooKeeper class anyway. In c we unfortunately have less options, we can just rely on docs for now. In both cases (c/java) we need to be very very clear in the docs that this is for testing only and to clearly define semantics. We should add the following at the same time: toString() method to ZooKeeper which includes server ip/port, client port, any other information deemed useful (connection stats like send/recv?) the java ZooKeeper is missing deterministic connection order that the c client has. this is also useful for testing. again, protected and clear docs that this is for testing purposes only! Any other things we should expose? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-544) improve client testability - allow test client to access connected server location
[ https://issues.apache.org/jira/browse/ZOOKEEPER-544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-544: Status: Patch Available (was: Open) improve client testability - allow test client to access connected server location -- Key: ZOOKEEPER-544 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-544 Project: Zookeeper Issue Type: Improvement Components: c client, java client, tests Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-544.patch This came up recently on the user list. If you are developing tests for your zk client you need to be able to access the server that your session is currently connected to. The reason is that your test needs to know which server in the quorum to shutdown in order to verify you are handling failover correctly. Similar for session expiration testing. however we should be careful, we prefer not to expose this to all clients, this is an implementation detail that we typically want to hide. also we should provide this in both the c and java clients I suspect we should add a protected method on ZooKeeper. This will make a higher bar (user will have to subclass) for the user to access this method. In tests it's fine, typically you want a TestableZooKeeper class anyway. In c we unfortunately have less options, we can just rely on docs for now. In both cases (c/java) we need to be very very clear in the docs that this is for testing only and to clearly define semantics. We should add the following at the same time: toString() method to ZooKeeper which includes server ip/port, client port, any other information deemed useful (connection stats like send/recv?) the java ZooKeeper is missing deterministic connection order that the c client has. this is also useful for testing. again, protected and clear docs that this is for testing purposes only! Any other things we should expose? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-544) improve client testability - allow test client to access connected server location
[ https://issues.apache.org/jira/browse/ZOOKEEPER-544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12792342#action_12792342 ] Hadoop QA commented on ZOOKEEPER-544: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12424336/ZOOKEEPER-544.patch against trunk revision 892111. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/94/console This message is automatically generated. improve client testability - allow test client to access connected server location -- Key: ZOOKEEPER-544 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-544 Project: Zookeeper Issue Type: Improvement Components: c client, java client, tests Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-544.patch This came up recently on the user list. If you are developing tests for your zk client you need to be able to access the server that your session is currently connected to. The reason is that your test needs to know which server in the quorum to shutdown in order to verify you are handling failover correctly. Similar for session expiration testing. however we should be careful, we prefer not to expose this to all clients, this is an implementation detail that we typically want to hide. also we should provide this in both the c and java clients I suspect we should add a protected method on ZooKeeper. This will make a higher bar (user will have to subclass) for the user to access this method. In tests it's fine, typically you want a TestableZooKeeper class anyway. In c we unfortunately have less options, we can just rely on docs for now. In both cases (c/java) we need to be very very clear in the docs that this is for testing only and to clearly define semantics. We should add the following at the same time: toString() method to ZooKeeper which includes server ip/port, client port, any other information deemed useful (connection stats like send/recv?) the java ZooKeeper is missing deterministic connection order that the c client has. this is also useful for testing. again, protected and clear docs that this is for testing purposes only! Any other things we should expose? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-544) improve client testability - allow test client to access connected server location
[ https://issues.apache.org/jira/browse/ZOOKEEPER-544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-544: Status: Open (was: Patch Available) updating the patch to trunk. improve client testability - allow test client to access connected server location -- Key: ZOOKEEPER-544 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-544 Project: Zookeeper Issue Type: Improvement Components: c client, java client, tests Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-544.patch This came up recently on the user list. If you are developing tests for your zk client you need to be able to access the server that your session is currently connected to. The reason is that your test needs to know which server in the quorum to shutdown in order to verify you are handling failover correctly. Similar for session expiration testing. however we should be careful, we prefer not to expose this to all clients, this is an implementation detail that we typically want to hide. also we should provide this in both the c and java clients I suspect we should add a protected method on ZooKeeper. This will make a higher bar (user will have to subclass) for the user to access this method. In tests it's fine, typically you want a TestableZooKeeper class anyway. In c we unfortunately have less options, we can just rely on docs for now. In both cases (c/java) we need to be very very clear in the docs that this is for testing only and to clearly define semantics. We should add the following at the same time: toString() method to ZooKeeper which includes server ip/port, client port, any other information deemed useful (connection stats like send/recv?) the java ZooKeeper is missing deterministic connection order that the c client has. this is also useful for testing. again, protected and clear docs that this is for testing purposes only! Any other things we should expose? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-544) improve client testability - allow test client to access connected server location
[ https://issues.apache.org/jira/browse/ZOOKEEPER-544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-544: Attachment: ZOOKEEPER-544.patch updating the patch to trunk. Resolved the conflict. Pat, can you check if the patch is all fine and I didnt miss anything. improve client testability - allow test client to access connected server location -- Key: ZOOKEEPER-544 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-544 Project: Zookeeper Issue Type: Improvement Components: c client, java client, tests Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-544.patch, ZOOKEEPER-544.patch This came up recently on the user list. If you are developing tests for your zk client you need to be able to access the server that your session is currently connected to. The reason is that your test needs to know which server in the quorum to shutdown in order to verify you are handling failover correctly. Similar for session expiration testing. however we should be careful, we prefer not to expose this to all clients, this is an implementation detail that we typically want to hide. also we should provide this in both the c and java clients I suspect we should add a protected method on ZooKeeper. This will make a higher bar (user will have to subclass) for the user to access this method. In tests it's fine, typically you want a TestableZooKeeper class anyway. In c we unfortunately have less options, we can just rely on docs for now. In both cases (c/java) we need to be very very clear in the docs that this is for testing only and to clearly define semantics. We should add the following at the same time: toString() method to ZooKeeper which includes server ip/port, client port, any other information deemed useful (connection stats like send/recv?) the java ZooKeeper is missing deterministic connection order that the c client has. this is also useful for testing. again, protected and clear docs that this is for testing purposes only! Any other things we should expose? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-544) improve client testability - allow test client to access connected server location
[ https://issues.apache.org/jira/browse/ZOOKEEPER-544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-544: Status: Patch Available (was: Open) improve client testability - allow test client to access connected server location -- Key: ZOOKEEPER-544 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-544 Project: Zookeeper Issue Type: Improvement Components: c client, java client, tests Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.3.0 Attachments: ZOOKEEPER-544.patch, ZOOKEEPER-544.patch This came up recently on the user list. If you are developing tests for your zk client you need to be able to access the server that your session is currently connected to. The reason is that your test needs to know which server in the quorum to shutdown in order to verify you are handling failover correctly. Similar for session expiration testing. however we should be careful, we prefer not to expose this to all clients, this is an implementation detail that we typically want to hide. also we should provide this in both the c and java clients I suspect we should add a protected method on ZooKeeper. This will make a higher bar (user will have to subclass) for the user to access this method. In tests it's fine, typically you want a TestableZooKeeper class anyway. In c we unfortunately have less options, we can just rely on docs for now. In both cases (c/java) we need to be very very clear in the docs that this is for testing only and to clearly define semantics. We should add the following at the same time: toString() method to ZooKeeper which includes server ip/port, client port, any other information deemed useful (connection stats like send/recv?) the java ZooKeeper is missing deterministic connection order that the c client has. this is also useful for testing. again, protected and clear docs that this is for testing purposes only! Any other things we should expose? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
