[jira] Assigned: (ZOOKEEPER-640) make build.xml more configurable to ease packaging for linux distros
[
https://issues.apache.org/jira/browse/ZOOKEEPER-640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt reassigned ZOOKEEPER-640:
--
Assignee: Patrick Hunt
> make build.xml more configurable to ease packaging for linux distros
>
>
> Key: ZOOKEEPER-640
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-640
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.2.1, 3.2.2
>Reporter: Thomas Koch
>Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-640.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> Hi,
> I started packaging Zookeeper for Debian[1][2]. Thereby I had a problem
> excluding contrib/rest from the build without patching the upstream tarball.
> Could you please add some properties to your build.xml that allow me to
> (de)select contribs? In the example below I can easily override the
> properties:
>
>
>
>
> dir="."
>includes="${contribfilesetincludes}"
>excludes="${contribfilesetexcludes}"
>/>
>
>
>
>
>
> Could you please also add a line to project.classpath:
>
>
> For Debian I may not compile based on the jar files in lib but must use the
> jars already in Debian.
> [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=561947
> [2] http://git.debian.org/?p=pkg-java/zookeeper.git
> Thank you!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-640) make build.xml more configurable to ease packaging for linux distros
[
https://issues.apache.org/jira/browse/ZOOKEEPER-640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-640:
---
Attachment: ZOOKEEPER-640.patch
Thomas, checkout this patch and let me know.
It was a bit tricky with additional.libs since ant doesn't support
conditionals, but I got around
it with a fairly clean hack. All you need to do is specify additional.lib.dir
and turn off (set to "")
the excludes for that same fileset.
I tried various scenarios and it seemed ok for me. Give it a try, work for you?
If so I'll
work on getting it committed to 3.3.0
> make build.xml more configurable to ease packaging for linux distros
>
>
> Key: ZOOKEEPER-640
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-640
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.2.1, 3.2.2
>Reporter: Thomas Koch
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-640.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> Hi,
> I started packaging Zookeeper for Debian[1][2]. Thereby I had a problem
> excluding contrib/rest from the build without patching the upstream tarball.
> Could you please add some properties to your build.xml that allow me to
> (de)select contribs? In the example below I can easily override the
> properties:
>
>
>
>
> dir="."
>includes="${contribfilesetincludes}"
>excludes="${contribfilesetexcludes}"
>/>
>
>
>
>
>
> Could you please also add a line to project.classpath:
>
>
> For Debian I may not compile based on the jar files in lib but must use the
> jars already in Debian.
> [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=561947
> [2] http://git.debian.org/?p=pkg-java/zookeeper.git
> Thank you!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-640) make build.xml more configurable to ease packaging for linux distros
[
https://issues.apache.org/jira/browse/ZOOKEEPER-640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798121#action_12798121
]
Patrick Hunt commented on ZOOKEEPER-640:
Great to see this being packaged for Debian! Shouldn't be a problem. A few
questions though:
1) contrib include/exclude seems fine to me, good idea
2) for the "additional.lib.dir" :
a) you want this changed in build.xml at the toplevel and also for the
contribs, right? Same variable name
used in both ok?
b) do you really want a dir or a path string instead, ie additional.lib.dir or
additional.libs.path (where libs.path is a list of directories/jars)
libs.path would give you more control (you would specify/order the jars
explicitly vs just *.jar") This might be important
for example if you have multiple jars with same capability but diff version...
it would require you to specify the
list of jars though.
> make build.xml more configurable to ease packaging for linux distros
>
>
> Key: ZOOKEEPER-640
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-640
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.2.1, 3.2.2
>Reporter: Thomas Koch
> Fix For: 3.3.0
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> Hi,
> I started packaging Zookeeper for Debian[1][2]. Thereby I had a problem
> excluding contrib/rest from the build without patching the upstream tarball.
> Could you please add some properties to your build.xml that allow me to
> (de)select contribs? In the example below I can easily override the
> properties:
>
>
>
>
> dir="."
>includes="${contribfilesetincludes}"
>excludes="${contribfilesetexcludes}"
>/>
>
>
>
>
>
> Could you please also add a line to project.classpath:
>
>
> For Debian I may not compile based on the jar files in lib but must use the
> jars already in Debian.
> [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=561947
> [2] http://git.debian.org/?p=pkg-java/zookeeper.git
> Thank you!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-640) make build.xml more configurable to ease packaging for linux distros
[
https://issues.apache.org/jira/browse/ZOOKEEPER-640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-640:
---
Fix Version/s: 3.3.0
> make build.xml more configurable to ease packaging for linux distros
>
>
> Key: ZOOKEEPER-640
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-640
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.2.1, 3.2.2
>Reporter: Thomas Koch
> Fix For: 3.3.0
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> Hi,
> I started packaging Zookeeper for Debian[1][2]. Thereby I had a problem
> excluding contrib/rest from the build without patching the upstream tarball.
> Could you please add some properties to your build.xml that allow me to
> (de)select contribs? In the example below I can easily override the
> properties:
>
>
>
>
> dir="."
>includes="${contribfilesetincludes}"
>excludes="${contribfilesetexcludes}"
>/>
>
>
>
>
>
> Could you please also add a line to project.classpath:
>
>
> For Debian I may not compile based on the jar files in lib but must use the
> jars already in Debian.
> [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=561947
> [2] http://git.debian.org/?p=pkg-java/zookeeper.git
> Thank you!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-638) upgrade ivy to 2.1.0 final from 2.1.0 release candidate
[ https://issues.apache.org/jira/browse/ZOOKEEPER-638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-638: Hadoop Flags: [Reviewed] +1 looks good. why didn't hadoopqa run? > upgrade ivy to 2.1.0 final from 2.1.0 release candidate > --- > > Key: ZOOKEEPER-638 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-638 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-638.patch > > > 2.1.0 is now available -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-640) make build.xml more configurable to ease packaging for linux distros
[
https://issues.apache.org/jira/browse/ZOOKEEPER-640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-640:
--
Description:
Hi,
I started packaging Zookeeper for Debian[1][2]. Thereby I had a problem
excluding contrib/rest from the build without patching the upstream tarball.
Could you please add some properties to your build.xml that allow me to
(de)select contribs? In the example below I can easily override the properties:
Could you please also add a line to project.classpath:
For Debian I may not compile based on the jar files in lib but must use the
jars already in Debian.
[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=561947
[2] http://git.debian.org/?p=pkg-java/zookeeper.git
Thank you!
was:
Hi,
I started packaging Zookeeper for Debian[1][2]. Thereby I had a problem
excluding contrib/rest from the build without patching the upstream tarball.
Could you please add some properties to your build.xml that allow me to
(de)select contribs? In the example below I can easily override the properties:
[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=561947
[2] http://git.debian.org/?p=pkg-java/zookeeper.git
Thank you!
> make build.xml more configurable to ease packaging for linux distros
>
>
> Key: ZOOKEEPER-640
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-640
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.2.1, 3.2.2
>Reporter: Thomas Koch
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> Hi,
> I started packaging Zookeeper for Debian[1][2]. Thereby I had a problem
> excluding contrib/rest from the build without patching the upstream tarball.
> Could you please add some properties to your build.xml that allow me to
> (de)select contribs? In the example below I can easily override the
> properties:
>
>
>
>
> dir="."
>includes="${contribfilesetincludes}"
>excludes="${contribfilesetexcludes}"
>/>
>
>
>
>
>
> Could you please also add a line to project.classpath:
>
>
> For Debian I may not compile based on the jar files in lib but must use the
> jars already in Debian.
> [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=561947
> [2] http://git.debian.org/?p=pkg-java/zookeeper.git
> Thank you!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Packaging for Debian started
Hi, I've started packaging zookeeper for Debian at: http://git.debian.org/?p=pkg-java/zookeeper.git The Debian RequestForPackaging bug can be found at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=561947 Thank you for ZooKeeper! Thomas Koch, http://www.koch.ro
[jira] Created: (ZOOKEEPER-640) make build.xml more configurable to ease packaging for linux distros
make build.xml more configurable to ease packaging for linux distros Key: ZOOKEEPER-640 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-640 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.2.1, 3.2.2 Reporter: Thomas Koch Hi, I started packaging Zookeeper for Debian[1][2]. Thereby I had a problem excluding contrib/rest from the build without patching the upstream tarball. Could you please add some properties to your build.xml that allow me to (de)select contribs? In the example below I can easily override the properties: [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=561947 [2] http://git.debian.org/?p=pkg-java/zookeeper.git Thank you! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
