[jira] Updated: (ZOOKEEPER-738) zookeeper.jute.h fails to compile with -pedantic
[
https://issues.apache.org/jira/browse/ZOOKEEPER-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jozef Hatala updated ZOOKEEPER-738:
---
Attachment: semi.patch
The attached patch removes the extra semicolon after the call to JType.genCDecl
(which comes with its own semicolon already):
src/java/main/org/apache/jute/compiler/JType.java:
52 String genCDecl(String name) {
53 return + mCName + +name+;\n;
54 }
The attached diff is against
http://svn.apache.org/repos/asf/hadoop/zookeeper/trunk at revision 932666
specifically.
(Regenerated the files like this: rm -rf src/{c,java}/generated/ ant
compile_jute)
Testing done: I diff:ed the C and Java files that ant compile_jute generates
in the ZK tree *with* and *without* this patch applied, and I confirmed that
the only difference between the two is that with the patch applied the extra
semicolon is not present any more. (Diff:ed like this: diff -ru
src{.orig,}/c/generated/)
zookeeper.jute.h fails to compile with -pedantic
-
Key: ZOOKEEPER-738
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-738
Project: Zookeeper
Issue Type: Bug
Components: c client
Affects Versions: 3.3.0
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Fix For: 3.3.1, 3.4.0
Attachments: semi.patch
/home/y/include/zookeeper/zookeeper.jute.h:96: error: extra semicolon
/home/y/include/zookeeper/zookeeper.jute.h:158: error: extra semicolon
/home/y/include/zookeeper/zookeeper.jute.h:288: error: extra semicolon
the code generator needs to be updated to not output a naked semi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-631) zkpython's C code could do with a style clean-up
[ https://issues.apache.org/jira/browse/ZOOKEEPER-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Robinson updated ZOOKEEPER-631: - Status: Patch Available (was: Open) zkpython's C code could do with a style clean-up Key: ZOOKEEPER-631 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-631 Project: Zookeeper Issue Type: Improvement Components: contrib-bindings Reporter: Henry Robinson Assignee: Henry Robinson Priority: Minor Attachments: ZOOKEEPER-631.patch Inconsistent formatting / use of parenthesis / some error checking - all need fixing. Also, the documentation in the header file could do with a reformat. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-631) zkpython's C code could do with a style clean-up
[ https://issues.apache.org/jira/browse/ZOOKEEPER-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12858375#action_12858375 ] Hadoop QA commented on ZOOKEEPER-631: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12442027/ZOOKEEPER-631.patch against trunk revision 934312. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/57/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/57/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/57/console This message is automatically generated. zkpython's C code could do with a style clean-up Key: ZOOKEEPER-631 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-631 Project: Zookeeper Issue Type: Improvement Components: contrib-bindings Reporter: Henry Robinson Assignee: Henry Robinson Priority: Minor Attachments: ZOOKEEPER-631.patch Inconsistent formatting / use of parenthesis / some error checking - all need fixing. Also, the documentation in the header file could do with a reformat. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-631) zkpython's C code could do with a style clean-up
[ https://issues.apache.org/jira/browse/ZOOKEEPER-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12858377#action_12858377 ] Henry Robinson commented on ZOOKEEPER-631: -- The existing tests are the ones that validate this patch. To test the Py_None and memory allocation issues is hard because in the first case the GC behaviour is hard to force and in the second we would have to stub out calloc(..) somehow! zkpython's C code could do with a style clean-up Key: ZOOKEEPER-631 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-631 Project: Zookeeper Issue Type: Improvement Components: contrib-bindings Reporter: Henry Robinson Assignee: Henry Robinson Priority: Minor Attachments: ZOOKEEPER-631.patch Inconsistent formatting / use of parenthesis / some error checking - all need fixing. Also, the documentation in the header file could do with a reformat. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
