[jira] Commented: (ZOOKEEPER-747) Add C# generation to Jute
[ https://issues.apache.org/jira/browse/ZOOKEEPER-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12859645#action_12859645 ] Hadoop QA commented on ZOOKEEPER-747: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12442510/ZOOKEEPER-747.patch against trunk revision 934312. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 25 release audit warnings (more than the trunk's current 24 warnings). -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/64/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/64/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/64/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/64/console This message is automatically generated. Add C# generation to Jute - Key: ZOOKEEPER-747 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-747 Project: Zookeeper Issue Type: New Feature Reporter: Eric Hauser Attachments: ZOOKEEPER-747.patch The following patch adds a new language, C#, to the Jute code generation. The code that is generated does have a dependency on a third party library, Jon Skeet's MiscUtil, which is Apache licensed. The library is necessary because C# does not provide big endian support in the base class libraries. As none of the existing Jute code has any unit tests, I have not added tests for this patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-748) zkPython's NodeExistsException should include information about the node that exists
zkPython's NodeExistsException should include information about the node that
exists
Key: ZOOKEEPER-748
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-748
Project: Zookeeper
Issue Type: Improvement
Components: contrib-bindings
Affects Versions: 3.3.0
Reporter: Joseph Koshy
Currently the code creates a {{zookeeper.NodeExistsException}} object with a
string argument node exists.
Including the name of the node that caused the exception would be useful, in
that it allows user code like the following:
{code:title=example1}
try:
zookeeper.create(zh, n1, ...)
zookeeper.create(zh, n2, ...)
except zookeeper.NodeExistsException, n:
print Node \%s\ exists. % n
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-747) Add C# generation to Jute
[ https://issues.apache.org/jira/browse/ZOOKEEPER-747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-747: --- Fix Version/s: 3.4.0 Component/s: jute Add C# generation to Jute - Key: ZOOKEEPER-747 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-747 Project: Zookeeper Issue Type: New Feature Components: jute Reporter: Eric Hauser Assignee: Eric Hauser Fix For: 3.4.0 Attachments: ZOOKEEPER-747.patch The following patch adds a new language, C#, to the Jute code generation. The code that is generated does have a dependency on a third party library, Jon Skeet's MiscUtil, which is Apache licensed. The library is necessary because C# does not provide big endian support in the base class libraries. As none of the existing Jute code has any unit tests, I have not added tests for this patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-747) Add C# generation to Jute
[ https://issues.apache.org/jira/browse/ZOOKEEPER-747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-747: --- Status: Open (was: Patch Available) Eric, this is great. QABot noticed that there's a RAT issue that needs to be addressed: [rat:report] !? /grid/0/hudson/hudson-slave/workspace/Zookeeper-Patch-h1.grid.sp2.yahoo.net/trunk/build/zookeeper-3.4.0/src/java/main/org/apache/jute/compiler/CSharpGenerator.java Basically the Apache license header is missing (take a look at the other .java files in that directory) Once this is fixed we'll review/commit the change. Thanks! Add C# generation to Jute - Key: ZOOKEEPER-747 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-747 Project: Zookeeper Issue Type: New Feature Components: jute Reporter: Eric Hauser Assignee: Eric Hauser Fix For: 3.4.0 Attachments: ZOOKEEPER-747.patch The following patch adds a new language, C#, to the Jute code generation. The code that is generated does have a dependency on a third party library, Jon Skeet's MiscUtil, which is Apache licensed. The library is necessary because C# does not provide big endian support in the base class libraries. As none of the existing Jute code has any unit tests, I have not added tests for this patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-746) learner outputs session id to log in dec (should be hex)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-746: --- Attachment: ZOOKEEPER-746.patch this patch addresses the issue (outputs the session id as hex formatted) learner outputs session id to log in dec (should be hex) Key: ZOOKEEPER-746 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-746 Project: Zookeeper Issue Type: Bug Components: quorum, server Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.3.1, 3.4.0 Attachments: ZOOKEEPER-746.patch usability issue, should be in hex: 2010-04-21 11:31:13,827 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11354:lear...@95] - Revalidating client: 83353578391797760 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-746) learner outputs session id to log in dec (should be hex)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-746: --- Status: Patch Available (was: Open) learner outputs session id to log in dec (should be hex) Key: ZOOKEEPER-746 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-746 Project: Zookeeper Issue Type: Bug Components: quorum, server Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.3.1, 3.4.0 Attachments: ZOOKEEPER-746.patch usability issue, should be in hex: 2010-04-21 11:31:13,827 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11354:lear...@95] - Revalidating client: 83353578391797760 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: .NET client
Eric, this is great. I've slated the change for 3.4.0, if you could address the RAT issue (add license header), resubmit and someone will review and work with you to get committed. Thanks! And getting the client bindings would be great too. Patrick On 04/21/2010 08:32 PM, Eric Hauser wrote: I submitted the Jute changes back as ZOOKEEPER-747. Regarding contrib, I'd be happy to submit the client bindings back once I do a bit more cleanup. On Mon, Apr 19, 2010 at 1:11 PM, Patrick Hunt ph...@apache.org mailto:ph...@apache.org wrote: Hi Eric, this sounds great! Please consider submitting the client binding back, you could start it as a contrib package (src/contrib) until things settle and you get some usage. We recently have been seeing interest in running ZK on windows servers, so having .net would be awesome. http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute It would be nice to see the Jute support, btw this is a port of Hadoop's recordio package from a few years ago. We are actually looking to move to Avro at some point, I'm sure they would love to have .net support as well. Regards, Patrick On 04/15/2010 05:55 PM, Eric Hauser wrote: Hi, I've ported the Java ZK client to .NET. It's available for forking at http://github.com/ewhauser/zookeeper/. It is still in very early stages, but all of the client tests that I have ported complete successfully - both normal calls and watches are working successfully. Some things to keep in mind: - It's not actively being used at the moment - I have not had any chance to do any performance testing - The API will definitely be changing. I've ported watches over as is in order to get everything working, but I'll be changing that to use events instead to make it more .NET-like. - There are not any asynchronous methods on the ZK client API -- async method calls are easy to do .NET. May add a wrapper for it at some point. If there is any interest in having any part of my work go back into trunk, I'm happy to sign the ASF release. In particular, it would be nice if the C# support I added to Jute made it back into the core code base.
[jira] Updated: (ZOOKEEPER-746) learner outputs session id to log in dec (should be hex)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Robinson updated ZOOKEEPER-746: - Hadoop Flags: [Reviewed] +1, patch looks good to me. No tests required, pre-empting Hudsonbot. learner outputs session id to log in dec (should be hex) Key: ZOOKEEPER-746 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-746 Project: Zookeeper Issue Type: Bug Components: quorum, server Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.3.1, 3.4.0 Attachments: ZOOKEEPER-746.patch usability issue, should be in hex: 2010-04-21 11:31:13,827 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11354:lear...@95] - Revalidating client: 83353578391797760 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-748) zkPython's NodeExistsException should include information about the node that exists
[
https://issues.apache.org/jira/browse/ZOOKEEPER-748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-748:
---
Fix Version/s: 3.4.0
Good idea. The keeper exception has a path field, this should be exposed by
zkpython. (in all cases, not just for node exists)
zkPython's NodeExistsException should include information about the node that
exists
Key: ZOOKEEPER-748
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-748
Project: Zookeeper
Issue Type: Improvement
Components: contrib-bindings
Affects Versions: 3.3.0
Reporter: Joseph Koshy
Fix For: 3.4.0
Currently the code creates a {{zookeeper.NodeExistsException}} object with a
string argument node exists.
Including the name of the node that caused the exception would be useful, in
that it allows user code like the following:
{code:title=example1}
try:
zookeeper.create(zh, n1, ...)
zookeeper.create(zh, n2, ...)
except zookeeper.NodeExistsException, n:
print Node \%s\ exists. % n
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-746) learner outputs session id to log in dec (should be hex)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12859667#action_12859667 ] Hadoop QA commented on ZOOKEEPER-746: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12442513/ZOOKEEPER-746.patch against trunk revision 934312. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/65/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/65/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/65/console This message is automatically generated. learner outputs session id to log in dec (should be hex) Key: ZOOKEEPER-746 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-746 Project: Zookeeper Issue Type: Bug Components: quorum, server Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Minor Fix For: 3.3.1, 3.4.0 Attachments: ZOOKEEPER-746.patch usability issue, should be in hex: 2010-04-21 11:31:13,827 - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11354:lear...@95] - Revalidating client: 83353578391797760 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-741) root level create on REST proxy fails
[ https://issues.apache.org/jira/browse/ZOOKEEPER-741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-741: --- Hadoop Flags: [Reviewed] root level create on REST proxy fails - Key: ZOOKEEPER-741 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-741 Project: Zookeeper Issue Type: Bug Components: contrib Affects Versions: 3.3.0 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Critical Fix For: 3.3.1, 3.4.0 Attachments: ZOOKEEPER-741.patch Create /foo using the REST proxy fails. Also upgrade to the latest Jersey/Grizzly while we are at it (fixes for func/security) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-741) root level create on REST proxy fails
[ https://issues.apache.org/jira/browse/ZOOKEEPER-741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-741: --- Status: Resolved (was: Patch Available) Resolution: Fixed Committed to 3.3 branch and trunk. root level create on REST proxy fails - Key: ZOOKEEPER-741 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-741 Project: Zookeeper Issue Type: Bug Components: contrib Affects Versions: 3.3.0 Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Critical Fix For: 3.3.1, 3.4.0 Attachments: ZOOKEEPER-741.patch Create /foo using the REST proxy fails. Also upgrade to the latest Jersey/Grizzly while we are at it (fixes for func/security) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
