[jira] Updated: (ZOOKEEPER-733) use netty to handle client connections

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-733:
---

Attachment: ZOOKEEPER-733.patch

This latest patch ports the prior patches to the latest trunk.

I also incorporated Ben's flow control ideas, I had to fix a number of issues 
as part of this but in general it seems to be working.

At this point all the tests seem to be working. Still alot of work to do (this 
patch is a WIP, esp have added a number of logging messages to help debug a 
number of flow control issues).

One issue remains with the tests - I'm ignoring the sessionmoved tests for the 
time being. Still need to debug those.

Looking pretty good at this point. Need to verify nio, docs, etc... but in 
general netty on the server side seems to be working.

> use netty to handle client connections
> --
>
> Key: ZOOKEEPER-733
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-733
> Project: Zookeeper
>  Issue Type: Improvement
>Reporter: Benjamin Reed
> Attachments: accessive.jar, flowctl.zip, moved.zip, 
> QuorumTestFailed_sessionmoved_TRACE_LOG.txt.gz, ZOOKEEPER-733.patch, 
> ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch
>
>
> we currently have our own asynchronous NIO socket engine to be able to handle 
> lots of clients with a single thread. over time the engine has become more 
> complicated. we would also like the engine to use multiple threads on 
> machines with lots of cores. plus, we would like to be able to support things 
> like SSL. if we switch to netty, we can simplify our code and get the 
> previously mentioned benefits.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-733) use netty to handle client connections

[Patrick Hunt (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-733:
---

 Assignee: Patrick Hunt
Fix Version/s: 3.4.0
  Component/s: server

> use netty to handle client connections
> --
>
> Key: ZOOKEEPER-733
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-733
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: Benjamin Reed
>Assignee: Patrick Hunt
> Fix For: 3.4.0
>
> Attachments: accessive.jar, flowctl.zip, moved.zip, 
> QuorumTestFailed_sessionmoved_TRACE_LOG.txt.gz, ZOOKEEPER-733.patch, 
> ZOOKEEPER-733.patch, ZOOKEEPER-733.patch, ZOOKEEPER-733.patch
>
>
> we currently have our own asynchronous NIO socket engine to be able to handle 
> lots of clients with a single thread. over time the engine has become more 
> complicated. we would also like the engine to use multiple threads on 
> machines with lots of cores. plus, we would like to be able to support things 
> like SSL. if we switch to netty, we can simplify our code and get the 
> previously mentioned benefits.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-784) server-side functionality for read-only mode

[Sergey Doroshenko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Doroshenko updated ZOOKEEPER-784:


Status: Open  (was: Patch Available)

> server-side functionality for read-only mode
> 
>
> Key: ZOOKEEPER-784
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-784
> Project: Zookeeper
>  Issue Type: Sub-task
>  Components: server
>Reporter: Sergey Doroshenko
>Assignee: Sergey Doroshenko
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, 
> ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, 
> ZOOKEEPER-784.patch
>
>
> As per http://wiki.apache.org/hadoop/ZooKeeper/GSoCReadOnlyMode , create 
> ReadOnlyZooKeeperServer which comes into play when peer is partitioned.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-784) server-side functionality for read-only mode

[Sergey Doroshenko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Doroshenko updated ZOOKEEPER-784:


Attachment: ZOOKEEPER-784.patch

Fixed issue with compatibility with C client. Now all tests should pass

> server-side functionality for read-only mode
> 
>
> Key: ZOOKEEPER-784
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-784
> Project: Zookeeper
>  Issue Type: Sub-task
>  Components: server
>Reporter: Sergey Doroshenko
>Assignee: Sergey Doroshenko
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, 
> ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, 
> ZOOKEEPER-784.patch
>
>
> As per http://wiki.apache.org/hadoop/ZooKeeper/GSoCReadOnlyMode , create 
> ReadOnlyZooKeeperServer which comes into play when peer is partitioned.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-784) server-side functionality for read-only mode

[Sergey Doroshenko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Doroshenko updated ZOOKEEPER-784:


Status: Patch Available  (was: Open)

> server-side functionality for read-only mode
> 
>
> Key: ZOOKEEPER-784
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-784
> Project: Zookeeper
>  Issue Type: Sub-task
>  Components: server
>Reporter: Sergey Doroshenko
>Assignee: Sergey Doroshenko
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, 
> ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, 
> ZOOKEEPER-784.patch
>
>
> As per http://wiki.apache.org/hadoop/ZooKeeper/GSoCReadOnlyMode , create 
> ReadOnlyZooKeeperServer which comes into play when peer is partitioned.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-784) server-side functionality for read-only mode

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886667#action_12886667
 ] 

Hadoop QA commented on ZOOKEEPER-784:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12449071/ZOOKEEPER-784.patch
  against trunk revision 961026.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 13 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/136/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/136/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/136/console

This message is automatically generated.

> server-side functionality for read-only mode
> 
>
> Key: ZOOKEEPER-784
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-784
> Project: Zookeeper
>  Issue Type: Sub-task
>  Components: server
>Reporter: Sergey Doroshenko
>Assignee: Sergey Doroshenko
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, 
> ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, 
> ZOOKEEPER-784.patch
>
>
> As per http://wiki.apache.org/hadoop/ZooKeeper/GSoCReadOnlyMode , create 
> ReadOnlyZooKeeperServer which comes into play when peer is partitioned.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-784) server-side functionality for read-only mode

[Sergey Doroshenko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Doroshenko updated ZOOKEEPER-784:


Status: Open  (was: Patch Available)

> server-side functionality for read-only mode
> 
>
> Key: ZOOKEEPER-784
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-784
> Project: Zookeeper
>  Issue Type: Sub-task
>  Components: server
>Reporter: Sergey Doroshenko
>Assignee: Sergey Doroshenko
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, 
> ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, 
> ZOOKEEPER-784.patch
>
>
> As per http://wiki.apache.org/hadoop/ZooKeeper/GSoCReadOnlyMode , create 
> ReadOnlyZooKeeperServer which comes into play when peer is partitioned.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-784) server-side functionality for read-only mode

[Sergey Doroshenko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Doroshenko updated ZOOKEEPER-784:


Status: Patch Available  (was: Open)

> server-side functionality for read-only mode
> 
>
> Key: ZOOKEEPER-784
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-784
> Project: Zookeeper
>  Issue Type: Sub-task
>  Components: server
>Reporter: Sergey Doroshenko
>Assignee: Sergey Doroshenko
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, 
> ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, 
> ZOOKEEPER-784.patch
>
>
> As per http://wiki.apache.org/hadoop/ZooKeeper/GSoCReadOnlyMode , create 
> ReadOnlyZooKeeperServer which comes into play when peer is partitioned.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-784) server-side functionality for read-only mode

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886677#action_12886677
 ] 

Hadoop QA commented on ZOOKEEPER-784:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12449071/ZOOKEEPER-784.patch
  against trunk revision 961026.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 13 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

-1 core tests.  The patch failed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/137/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/137/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/137/console

This message is automatically generated.

> server-side functionality for read-only mode
> 
>
> Key: ZOOKEEPER-784
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-784
> Project: Zookeeper
>  Issue Type: Sub-task
>  Components: server
>Reporter: Sergey Doroshenko
>Assignee: Sergey Doroshenko
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, 
> ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, 
> ZOOKEEPER-784.patch
>
>
> As per http://wiki.apache.org/hadoop/ZooKeeper/GSoCReadOnlyMode , create 
> ReadOnlyZooKeeperServer which comes into play when peer is partitioned.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-784) server-side functionality for read-only mode

[Sergey Doroshenko (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886686#action_12886686
 ] 

Sergey Doroshenko commented on ZOOKEEPER-784:
-

Hudson says there's one failing test: QuorumZxidSyncTest.testBehindLeader. But 
that's strange.
1) I can't reproduce this on my machine -- all tests pass.
2) Also, this test was passing ok with previous patch. And current patch is 
nearly the same as the previous one, changes made after previous patch can't 
cause this test to fail.

> server-side functionality for read-only mode
> 
>
> Key: ZOOKEEPER-784
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-784
> Project: Zookeeper
>  Issue Type: Sub-task
>  Components: server
>Reporter: Sergey Doroshenko
>Assignee: Sergey Doroshenko
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, 
> ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, ZOOKEEPER-784.patch, 
> ZOOKEEPER-784.patch
>
>
> As per http://wiki.apache.org/hadoop/ZooKeeper/GSoCReadOnlyMode , create 
> ReadOnlyZooKeeperServer which comes into play when peer is partitioned.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-795) eventThread isn't shutdown after a connection "session expired" event coming

[Sergey Doroshenko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sergey Doroshenko updated ZOOKEEPER-795:


Attachment: ZOOKEEPER-795.patch

This simple patch fixes both issues.
No tests included, verified with Daniel's class. Not sure if we need yet 
another 20-seconds test for this.

> eventThread isn't shutdown after a connection "session expired" event coming
> 
>
> Key: ZOOKEEPER-795
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-795
> Project: Zookeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.3.1
> Environment: ubuntu 10.04
>Reporter: mathieu barcikowski
>Priority: Blocker
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ExpiredSessionThreadLeak.java, ZOOKEEPER-795.patch
>
>
> Hi,
> I notice a problem with the eventThread located in ClientCnxn.java file.
> The eventThread isn't shutdown after a connection "session expired" event 
> coming (i.e. never receive EventOfDeath).
> When a session timeout occurs and the session is marked as expired, the 
> connexion is fully closed (socket, SendThread...) expect for the eventThread.
> As a result, if i create a new zookeeper object and connect through it, I got 
> a zombi thread which will never be kill (as for the previous zookeeper 
> object, the state is already close, calling close again don't do anything).
> So everytime I will create a new zookeeper connection after a expired 
> session, I will have a one more zombi EventThread.
> How to reproduce :
> - Start a zookeeper client connection in debug mode
> - Pause the jvm enough time to the expired event occur
> - Watch for example with jvisualvm the list of threads, the sendThread is 
> succesfully killed, but the EventThread go to wait state for a infinity of 
> time
> - if you reopen a new zookeeper connection, and do again the previous steps, 
> another EventThread will be present in infinite wait state

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-799) Add tools and recipes for monitoring as a contrib

[Andrei Savu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Savu updated ZOOKEEPER-799:
--

Attachment: ZOOKEEPER-799.patch
monitoring.tar.gz


* fixed {{GangliaHandler}} in {{check_zookeeper.py}} to allow the user to 
specify the path to gmetric on the command line (default value: 
/usr/bin/gmetric)
* it seems like it's safe to to use {{unit32}}, at least for now 
* added notice for the Ganglia Python module - it only works with 3.1.x 

Matt thanks again for reviewing this patch. 

Travis I would really like to know what you think about this because as I 
remember, at Twitter, you are using Ganglia for monitoring ZooKeeper. 

What else should I do to get this patch committed? Add more source code 
comments? More details in the docs?

> Add tools and recipes for monitoring as a contrib
> -
>
> Key: ZOOKEEPER-799
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-799
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: contrib
>Affects Versions: 3.3.0, 3.3.1, 3.4.0
>Reporter: Andrei Savu
>Assignee: Andrei Savu
> Attachments: monitoring.tar.gz, monitoring.tar.gz, 
> ZOOKEEPER-799.patch, ZOOKEEPER-799.patch
>
>
> Tools and Recipes for Monitoring ZooKeeper using Cacti, Nagios or Ganglia. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-165) Content needed: "Monitoring"

[Andrei Savu (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886745#action_12886745
 ] 

Andrei Savu commented on ZOOKEEPER-165:
---

How do you think this JIRA should be solved? Is is enough to just specify in 
the forrest docs that there is a monitoring contrib ZOOKEEPER-799? 

> Content needed: "Monitoring"
> 
>
> Key: ZOOKEEPER-165
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-165
> Project: Zookeeper
>  Issue Type: Sub-task
>  Components: documentation
>Reporter: Robbie Scott
>   Original Estimate: 8h
>  Remaining Estimate: 8h
>
> Content/information needed on how to Monitor a zooKeeper deployment. I think 
> we can talk about jmx, etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-765) Add python example script

[Andrei Savu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Savu updated ZOOKEEPER-765:
--

  Status: Patch Available  (was: Open)
Release Note: Travis Crawford wrote a skeleton script that shows how to 
setup znode watches and how to react to events using the Python client 
libraries. 
Assignee: Andrei Savu  (was: Travis Crawford)

> Add python example script
> -
>
> Key: ZOOKEEPER-765
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-765
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: contrib-bindings, documentation
>Reporter: Travis Crawford
>Assignee: Andrei Savu
>Priority: Minor
> Fix For: 3.4.0
>
> Attachments: zk.py, ZOOKEEPER-765.patch
>
>
> When adding some zookeeper-based functionality to a python script I had to 
> figure everything out without guidance, which while doable, would have been a 
> lot easier with an example. I extracted a skeleton program structure out with 
> hopes its useful to others (maybe add as an example in the source or wiki?).
> This script does an aget() and sets a watch, and hopefully illustrates what's 
> going on, and where to plug in your application code that gets run when the 
> znode changes.
> There are probably some bugs, which if we fix now and provide a well-reviewed 
> example hopefully others will not run into the same mistakes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-765) Add python example script

[Andrei Savu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Savu updated ZOOKEEPER-765:
--

Attachment: ZOOKEEPER-765.patch

I have created a patch containing the script Travis wrote. I have also fixed 
some typos and added more comments that explain how to play with it. 

I have also added a reference to zk-smoketest [1] because that's another good 
example that shows how to use the python ZooKeeper client library. 

[1] http://github.com/phunt/zk-smoketest 

> Add python example script
> -
>
> Key: ZOOKEEPER-765
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-765
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: contrib-bindings, documentation
>Reporter: Travis Crawford
>Assignee: Travis Crawford
>Priority: Minor
> Fix For: 3.4.0
>
> Attachments: zk.py, ZOOKEEPER-765.patch
>
>
> When adding some zookeeper-based functionality to a python script I had to 
> figure everything out without guidance, which while doable, would have been a 
> lot easier with an example. I extracted a skeleton program structure out with 
> hopes its useful to others (maybe add as an example in the source or wiki?).
> This script does an aget() and sets a watch, and hopefully illustrates what's 
> going on, and where to plug in your application code that gets run when the 
> znode changes.
> There are probably some bugs, which if we fix now and provide a well-reviewed 
> example hopefully others will not run into the same mistakes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-780) zkCli.sh generates a ArrayIndexOutOfBoundsException

[Andrei Savu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Savu updated ZOOKEEPER-780:
--

   Status: Patch Available  (was: Open)
 Release Note: If no data is provided for the new node when using the 
"create" zkCli.sh command assume an empty byte array. 
Fix Version/s: 3.4.0

> zkCli.sh  generates a ArrayIndexOutOfBoundsException 
> -
>
> Key: ZOOKEEPER-780
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-780
> Project: Zookeeper
>  Issue Type: Bug
>  Components: scripts
>Affects Versions: 3.3.1
> Environment: Linux Ubuntu running in VMPlayer on top of Windows XP
>Reporter: Miguel Correia
>Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-780.patch
>
>
> I'm starting to play with Zookeeper so I'm still running it in standalone 
> mode. This is not a big issue, but here it goes for the records. 
> I've run zkCli.sh to run some commands in the server. I created a znode 
> /groups. When I tried to create a znode client_1 inside /groups, I forgot to 
> include the data: an exception was generated and zkCli-sh crashed, instead of 
> just showing an error. I tried a few variations and it seems like the problem 
> is not including the data.
> A copy of the screen:
> [zk: localhost:2181(CONNECTED) 3] create /groups firstgroup
> Created /groups
> [zk: localhost:2181(CONNECTED) 4] create -e /groups/client_1
> Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 3
>   at 
> org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain.java:678)
>   at org.apache.zookeeper.ZooKeeperMain.processCmd(ZooKeeperMain.java:581)
>   at 
> org.apache.zookeeper.ZooKeeperMain.executeLine(ZooKeeperMain.java:353)
>   at org.apache.zookeeper.ZooKeeperMain.run(ZooKeeperMain.java:311)
>   at org.apache.zookeeper.ZooKeeperMain.main(ZooKeeperMain.java:270)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-765) Add python example script

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886781#action_12886781
 ] 

Hadoop QA commented on ZOOKEEPER-765:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12449092/ZOOKEEPER-765.patch
  against trunk revision 961026.

+1 @author.  The patch does not contain any @author tags.

+0 tests included.  The patch appears to be a documentation patch that 
doesn't require tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

-1 release audit.  The applied patch generated 19 release audit warnings 
(more than the trunk's current 17 warnings).

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/138/testReport/
Release audit warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/138/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/138/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/138/console

This message is automatically generated.

> Add python example script
> -
>
> Key: ZOOKEEPER-765
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-765
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: contrib-bindings, documentation
>Reporter: Travis Crawford
>Assignee: Andrei Savu
>Priority: Minor
> Fix For: 3.4.0
>
> Attachments: zk.py, ZOOKEEPER-765.patch
>
>
> When adding some zookeeper-based functionality to a python script I had to 
> figure everything out without guidance, which while doable, would have been a 
> lot easier with an example. I extracted a skeleton program structure out with 
> hopes its useful to others (maybe add as an example in the source or wiki?).
> This script does an aget() and sets a watch, and hopefully illustrates what's 
> going on, and where to plug in your application code that gets run when the 
> znode changes.
> There are probably some bugs, which if we fix now and provide a well-reviewed 
> example hopefully others will not run into the same mistakes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-780) zkCli.sh generates a ArrayIndexOutOfBoundsException

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886782#action_12886782
 ] 

Hadoop QA commented on ZOOKEEPER-780:
-

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12445820/ZOOKEEPER-780.patch
  against trunk revision 961026.

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no tests are needed for this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/95/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/95/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/95/console

This message is automatically generated.

> zkCli.sh  generates a ArrayIndexOutOfBoundsException 
> -
>
> Key: ZOOKEEPER-780
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-780
> Project: Zookeeper
>  Issue Type: Bug
>  Components: scripts
>Affects Versions: 3.3.1
> Environment: Linux Ubuntu running in VMPlayer on top of Windows XP
>Reporter: Miguel Correia
>Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-780.patch
>
>
> I'm starting to play with Zookeeper so I'm still running it in standalone 
> mode. This is not a big issue, but here it goes for the records. 
> I've run zkCli.sh to run some commands in the server. I created a znode 
> /groups. When I tried to create a znode client_1 inside /groups, I forgot to 
> include the data: an exception was generated and zkCli-sh crashed, instead of 
> just showing an error. I tried a few variations and it seems like the problem 
> is not including the data.
> A copy of the screen:
> [zk: localhost:2181(CONNECTED) 3] create /groups firstgroup
> Created /groups
> [zk: localhost:2181(CONNECTED) 4] create -e /groups/client_1
> Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 3
>   at 
> org.apache.zookeeper.ZooKeeperMain.processZKCmd(ZooKeeperMain.java:678)
>   at org.apache.zookeeper.ZooKeeperMain.processCmd(ZooKeeperMain.java:581)
>   at 
> org.apache.zookeeper.ZooKeeperMain.executeLine(ZooKeeperMain.java:353)
>   at org.apache.zookeeper.ZooKeeperMain.run(ZooKeeperMain.java:311)
>   at org.apache.zookeeper.ZooKeeperMain.main(ZooKeeperMain.java:270)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Build failed in Hudson: ZooKeeper-trunk #872

[Apache Hudson Server]

See 

--
[...truncated 137801 lines...]
 [exec] libtool: compile:  gcc -DHAVE_CONFIG_H -I. 
-I 
-I
 
-I
 
-I
 -DTHREADED -g -O2 -D_GNU_SOURCE -MT libzkmt_la-recordio.lo -MD -MP -MF 
.deps/libzkmt_la-recordio.Tpo -c 

 -o libzkmt_la-recordio.o >/dev/null 2>&1
 [exec] mv -f .deps/libzkmt_la-recordio.Tpo .deps/libzkmt_la-recordio.Plo
 [exec] /bin/bash ./libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H 
-I. 
-I  
-I
 
-I
 
-I
  -DTHREADED -g -O2 -D_GNU_SOURCE -MT libzkmt_la-zookeeper.jute.lo -MD -MP -MF 
.deps/libzkmt_la-zookeeper.jute.Tpo -c -o libzkmt_la-zookeeper.jute.lo `test -f 
'generated/zookeeper.jute.c' || echo 
'
 [exec] libtool: compile:  gcc -DHAVE_CONFIG_H -I. 
-I 
-I
 
-I
 
-I
 -DTHREADED -g -O2 -D_GNU_SOURCE -MT libzkmt_la-zookeeper.jute.lo -MD -MP -MF 
.deps/libzkmt_la-zookeeper.jute.Tpo -c 

  -fPIC -DPIC -o .libs/libzkmt_la-zookeeper.jute.o
 [exec] libtool: compile:  gcc -DHAVE_CONFIG_H -I. 
-I 
-I
 
-I
 
-I
 -DTHREADED -g -O2 -D_GNU_SOURCE -MT libzkmt_la-zookeeper.jute.lo -MD -MP -MF 
.deps/libzkmt_la-zookeeper.jute.Tpo -c 

 -o libzkmt_la-zookeeper.jute.o >/dev/null 2>&1
 [exec] mv -f .deps/libzkmt_la-zookeeper.jute.Tpo 
.deps/libzkmt_la-zookeeper.jute.Plo
 [exec] /bin/bash ./libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H 
-I. 
-I  
-I
 
-I
 
-I
  -DTHREADED -g -O2 -D_GNU_SOURCE -MT libzkmt_la-zk_log.lo -MD -MP -MF 
.deps/libzkmt_la-zk_log.Tpo -c -o libzkmt_la-zk_log.lo `test -f 'src/zk_log.c' 
|| echo 
'
 [exec] libtool: compile:  gcc -DHAVE_CONFIG_H -I. 
-I 
-I
 
-I
 
-I
 -DTHREADED -g -O2 -D_GNU_SOURCE -MT libzkmt_la-zk_log.lo -MD -MP -MF 
.deps/libzkmt_la-zk_log.Tpo -c 

  -fPIC -DPIC -o .libs/libzkmt_la-zk_log.o
 [exec] libtool: compile:  gcc -DHAVE_CONFIG_H -I. 
-I 
-I
 
-I
 
-I
 -DTHREADED -g -O2 -D_GNU_SOURCE -MT libzkmt_la-zk_log.lo -MD -MP -MF 
.deps/libzkmt_la-zk_log.Tpo -c 

 -o libzkmt_la-zk_log.o >/dev/null 2>&1
 [exec] mv -f .deps/libzkmt_la-zk_log.Tpo .deps/libzkmt_la-zk_log.Plo
  

[jira] Commented: (ZOOKEEPER-806) Cluster management with Zookeeper - Norbert

[Benjamin Reed (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886864#action_12886864
 ] 

Benjamin Reed commented on ZOOKEEPER-806:
-

this looks really cool. is there a collaboration model you were thinking of? 
(btw, have you guys thought of presenting this at the hadoop summit or similar 
venue?)

> Cluster management with Zookeeper - Norbert
> ---
>
> Key: ZOOKEEPER-806
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-806
> Project: Zookeeper
>  Issue Type: New Feature
>Reporter: John Wang
>
> Hello, we have built a cluster management layer on top of Zookeeper here at 
> the SNA team at LinkedIn: 
> http://sna-projects.com/norbert/
> We were wondering ways for collaboration as this is a very useful application 
> of zookeeper.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (ZOOKEEPER-807) bookkeeper does not put enough meta-data in to do recovery properly

[Benjamin Reed (JIRA)]

bookkeeper does not put enough meta-data in to do recovery properly
---

 Key: ZOOKEEPER-807
 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-807
 Project: Zookeeper
  Issue Type: Bug
  Components: contrib-bookkeeper
Reporter: Benjamin Reed


somewhere, probably zookeeper, we need to keep track of the the information 
about keys used for access and for mac validation as well as the digest type 
for entries. we can't write a general recovery tool without it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-712) Bookie recovery

[Benjamin Reed (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-712:


Hadoop Flags: [Reviewed]

+1 looks good. thanx erwin!

> Bookie recovery
> ---
>
> Key: ZOOKEEPER-712
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-712
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
>Assignee: Erwin Tam
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-712.patch
>
>
> Recover the ledger fragments of a bookie once it crashes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-719) Add throttling to BookKeeper client

[Benjamin Reed (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-719:


Status: Resolved  (was: Patch Available)
Resolution: Fixed

Committed revision 962693.

> Add throttling to BookKeeper client
> ---
>
> Key: ZOOKEEPER-719
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-719
> Project: Zookeeper
>  Issue Type: Bug
>  Components: contrib-bookkeeper
>Affects Versions: 3.3.0
>Reporter: Flavio Paiva Junqueira
>Assignee: Flavio Paiva Junqueira
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-719.patch, ZOOKEEPER-719.patch, 
> ZOOKEEPER-719.patch, ZOOKEEPER-719.patch
>
>
> Add throttling to client to control the rate of operations to bookies. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-712) Bookie recovery

[Benjamin Reed (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-712:


Status: Resolved  (was: Patch Available)
Resolution: Fixed

Committed revision 962697.


> Bookie recovery
> ---
>
> Key: ZOOKEEPER-712
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-712
> Project: Zookeeper
>  Issue Type: New Feature
>  Components: contrib-bookkeeper
>Reporter: Flavio Paiva Junqueira
>Assignee: Erwin Tam
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-712.patch
>
>
> Recover the ledger fragments of a bookie once it crashes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-794) Callbacks are not invoked when the client is closed

[Benjamin Reed (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-794:


Status: Open  (was: Patch Available)

-1 we need to get a test in. also the fix has a race condition. the boolean 
flag may changed after it is checked and before the request is queued.

> Callbacks are not invoked when the client is closed
> ---
>
> Key: ZOOKEEPER-794
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-794
> Project: Zookeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.3.1
>Reporter: Alexis Midon
>Assignee: Alexis Midon
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-794.patch.txt, ZOOKEEPER-794.txt
>
>
> I noticed that ZooKeeper has different behaviors when calling synchronous or 
> asynchronous actions on a closed ZooKeeper client.
> Actually a synchronous call will throw a "session expired" exception while an 
> asynchronous call will do nothing. No exception, no callback invocation.
> Actually, even if the EventThread receives the Packet with the session 
> expired err code, the packet is never processed since the thread has been 
> killed by the ventOfDeath. So the call back is not invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-806) Cluster management with Zookeeper - Norbert

[Patrick Hunt (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886909#action_12886909
 ] 

Patrick Hunt commented on ZOOKEEPER-806:


Re Ben's latest comment please consider presenting norbert at the upcoming 
Hadoop World:
http://www.cloudera.com/company/press-center/hadoop-world-speaker-submission/

> Cluster management with Zookeeper - Norbert
> ---
>
> Key: ZOOKEEPER-806
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-806
> Project: Zookeeper
>  Issue Type: New Feature
>Reporter: John Wang
>
> Hello, we have built a cluster management layer on top of Zookeeper here at 
> the SNA team at LinkedIn: 
> http://sna-projects.com/norbert/
> We were wondering ways for collaboration as this is a very useful application 
> of zookeeper.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-794) Callbacks are not invoked when the client is closed

[Benjamin Reed (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-794:


Status: Patch Available  (was: Open)

> Callbacks are not invoked when the client is closed
> ---
>
> Key: ZOOKEEPER-794
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-794
> Project: Zookeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.3.1
>Reporter: Alexis Midon
>Assignee: Alexis Midon
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-794.patch.txt, ZOOKEEPER-794.txt, 
> ZOOKEEPER-794_2.patch
>
>
> I noticed that ZooKeeper has different behaviors when calling synchronous or 
> asynchronous actions on a closed ZooKeeper client.
> Actually a synchronous call will throw a "session expired" exception while an 
> asynchronous call will do nothing. No exception, no callback invocation.
> Actually, even if the EventThread receives the Packet with the session 
> expired err code, the packet is never processed since the thread has been 
> killed by the ventOfDeath. So the call back is not invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (ZOOKEEPER-794) Callbacks are not invoked when the client is closed

[Benjamin Reed (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-794:


Attachment: ZOOKEEPER-794_2.patch

i've added a test case and i think i've addressed the race condition. alexis 
can you check it out. the only change to your code was to make waskilled 
volatile and move where it was set.

> Callbacks are not invoked when the client is closed
> ---
>
> Key: ZOOKEEPER-794
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-794
> Project: Zookeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.3.1
>Reporter: Alexis Midon
>Assignee: Alexis Midon
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-794.patch.txt, ZOOKEEPER-794.txt, 
> ZOOKEEPER-794_2.patch
>
>
> I noticed that ZooKeeper has different behaviors when calling synchronous or 
> asynchronous actions on a closed ZooKeeper client.
> Actually a synchronous call will throw a "session expired" exception while an 
> asynchronous call will do nothing. No exception, no callback invocation.
> Actually, even if the EventThread receives the Packet with the session 
> expired err code, the packet is never processed since the thread has been 
> killed by the ventOfDeath. So the call back is not invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (ZOOKEEPER-794) Callbacks are not invoked when the client is closed

[Hadoop QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886953#action_12886953
 ] 

Hadoop QA commented on ZOOKEEPER-794:
-

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12449135/ZOOKEEPER-794_2.patch
  against trunk revision 962697.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/139/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/139/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/139/console

This message is automatically generated.

> Callbacks are not invoked when the client is closed
> ---
>
> Key: ZOOKEEPER-794
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-794
> Project: Zookeeper
>  Issue Type: Bug
>  Components: java client
>Affects Versions: 3.3.1
>Reporter: Alexis Midon
>Assignee: Alexis Midon
> Fix For: 3.3.2, 3.4.0
>
> Attachments: ZOOKEEPER-794.patch.txt, ZOOKEEPER-794.txt, 
> ZOOKEEPER-794_2.patch
>
>
> I noticed that ZooKeeper has different behaviors when calling synchronous or 
> asynchronous actions on a closed ZooKeeper client.
> Actually a synchronous call will throw a "session expired" exception while an 
> asynchronous call will do nothing. No exception, no callback invocation.
> Actually, even if the EventThread receives the Packet with the session 
> expired err code, the packet is never processed since the thread has been 
> killed by the ventOfDeath. So the call back is not invoked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.