Re: Zoosh!
Hi Michi - This sounds cool - but your link goes to what I think is a Yahoo-internal site, and I suspect that 'yinst' is a Yahoo-specific tool. Perhaps you either did not mean to send this mail to this list, or you are not aware that this is a public mailing list, open to all? Either way, thanks for your interest in ZooKeeper, and if what you have written would be of interest to a general audience, please do consider contributing it back! cheers, Henry On 31 August 2010 17:40, Michi Mutsuzaki mic...@yahoo-inc.com wrote: I created a wrapper package for Java zookeeper shell. Unlike C version, it supports command history and tab completion. $ yinst install zoosh -br test $ zoosh localhost:2181 http://dist.corp.yahoo.com/by-package/zoosh/ --Michi -- Henry Robinson Software Engineer Cloudera 415-994-6679
Re: Zoosh!
Hi Henry, Yes, I meant to send this to a different email address. Sorry! --Michi On 8/31/10 11:31 PM, Henry Robinson he...@cloudera.com wrote: Hi Michi - This sounds cool - but your link goes to what I think is a Yahoo-internal site, and I suspect that 'yinst' is a Yahoo-specific tool. Perhaps you either did not mean to send this mail to this list, or you are not aware that this is a public mailing list, open to all? Either way, thanks for your interest in ZooKeeper, and if what you have written would be of interest to a general audience, please do consider contributing it back! cheers, Henry On 31 August 2010 17:40, Michi Mutsuzaki mic...@yahoo-inc.com wrote: I created a wrapper package for Java zookeeper shell. Unlike C version, it supports command history and tab completion. $ yinst install zoosh -br test $ zoosh localhost:2181 http://dist.corp.yahoo.com/by-package/zoosh/ --Michi -- Henry Robinson Software Engineer Cloudera 415-994-6679
[jira] Commented: (ZOOKEEPER-823) update ZooKeeper java client to optionally use Netty for connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12904959#action_12904959 ] Patrick Hunt commented on ZOOKEEPER-823: I only had time to apply the patch and run the tests -- the latest patch (Thomas's changes) is failing in both ACLTest and NettyNettySuiteTest. All tests were passing for me when I created the original patches, either the trunk is broken or the latest changes have introduced some problem. Both of these failed tests heavily exercise the client code (nio/netty) so I suspect it's a real issue with the latest refactoring. You'll need to look into these more deeply. update ZooKeeper java client to optionally use Netty for connections Key: ZOOKEEPER-823 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-823 Project: Zookeeper Issue Type: New Feature Components: java client Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: ZOOKEEPER-823.patch, ZOOKEEPER-823.patch, ZOOKEEPER-823.patch This jira will port the client side connection code to use netty rather than direct nio. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-823) update ZooKeeper java client to optionally use Netty for connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12904961#action_12904961 ] Patrick Hunt commented on ZOOKEEPER-823: FYI: I tried acltest on the trunk w/o this patch and it passed. update ZooKeeper java client to optionally use Netty for connections Key: ZOOKEEPER-823 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-823 Project: Zookeeper Issue Type: New Feature Components: java client Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: ZOOKEEPER-823.patch, ZOOKEEPER-823.patch, ZOOKEEPER-823.patch This jira will port the client side connection code to use netty rather than direct nio. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Build failed in Hudson: ZooKeeper-trunk #921
See https://hudson.apache.org/hudson/job/ZooKeeper-trunk/921/ -- [...truncated 169849 lines...] [junit] 2010-09-01 10:51:30,572 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11237:nioservercnxnfact...@196] - Accepted socket connection from /127.0.0.1:59697 [junit] 2010-09-01 10:51:30,572 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11237:nioserverc...@791] - Processing stat command from /127.0.0.1:59697 [junit] 2010-09-01 10:51:30,572 [myid:] - INFO [Thread-338:nioservercnxn$statcomm...@645] - Stat command output [junit] 2010-09-01 10:51:30,573 [myid:] - INFO [Thread-338:nioserverc...@967] - Closed socket connection for client /127.0.0.1:59697 (no session established for client) [junit] 2010-09-01 10:51:30,573 [myid:] - INFO [main:quorumb...@195] - 127.0.0.1:11237 is accepting client connections [junit] 2010-09-01 10:51:30,573 [myid:] - INFO [main:clientb...@225] - connecting to 127.0.0.1 11238 [junit] 2010-09-01 10:51:30,574 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11238:nioservercnxnfact...@196] - Accepted socket connection from /127.0.0.1:34418 [junit] 2010-09-01 10:51:30,574 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11238:nioserverc...@791] - Processing stat command from /127.0.0.1:34418 [junit] 2010-09-01 10:51:30,574 [myid:] - INFO [Thread-339:nioservercnxn$statcomm...@645] - Stat command output [junit] 2010-09-01 10:51:30,575 [myid:] - INFO [Thread-339:nioserverc...@967] - Closed socket connection for client /127.0.0.1:34418 (no session established for client) [junit] 2010-09-01 10:51:30,575 [myid:] - INFO [main:quorumb...@195] - 127.0.0.1:11238 is accepting client connections [junit] 2010-09-01 10:51:30,576 [myid:] - INFO [main:clientb...@225] - connecting to 127.0.0.1 11239 [junit] 2010-09-01 10:51:30,576 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11239:nioservercnxnfact...@196] - Accepted socket connection from /127.0.0.1:32872 [junit] 2010-09-01 10:51:30,576 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11239:nioserverc...@791] - Processing stat command from /127.0.0.1:32872 [junit] 2010-09-01 10:51:30,577 [myid:] - INFO [Thread-340:nioserverc...@967] - Closed socket connection for client /127.0.0.1:32872 (no session established for client) [junit] 2010-09-01 10:51:30,827 [myid:] - INFO [main:clientb...@225] - connecting to 127.0.0.1 11239 [junit] 2010-09-01 10:51:30,828 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11239:nioservercnxnfact...@196] - Accepted socket connection from /127.0.0.1:32873 [junit] 2010-09-01 10:51:30,828 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11239:nioserverc...@791] - Processing stat command from /127.0.0.1:32873 [junit] 2010-09-01 10:51:30,828 [myid:] - INFO [Thread-341:nioserverc...@967] - Closed socket connection for client /127.0.0.1:32873 (no session established for client) [junit] 2010-09-01 10:51:31,079 [myid:] - INFO [main:clientb...@225] - connecting to 127.0.0.1 11239 [junit] 2010-09-01 10:51:31,079 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11239:nioservercnxnfact...@196] - Accepted socket connection from /127.0.0.1:32874 [junit] 2010-09-01 10:51:31,079 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11239:nioserverc...@791] - Processing stat command from /127.0.0.1:32874 [junit] 2010-09-01 10:51:31,080 [myid:] - INFO [Thread-342:nioserverc...@967] - Closed socket connection for client /127.0.0.1:32874 (no session established for client) [junit] 2010-09-01 10:51:31,330 [myid:] - INFO [main:clientb...@225] - connecting to 127.0.0.1 11239 [junit] 2010-09-01 10:51:31,330 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11239:nioservercnxnfact...@196] - Accepted socket connection from /127.0.0.1:32875 [junit] 2010-09-01 10:51:31,331 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11239:nioserverc...@791] - Processing stat command from /127.0.0.1:32875 [junit] 2010-09-01 10:51:31,331 [myid:] - INFO [Thread-343:nioserverc...@967] - Closed socket connection for client /127.0.0.1:32875 (no session established for client) [junit] 2010-09-01 10:51:31,581 [myid:] - INFO [main:clientb...@225] - connecting to 127.0.0.1 11239 [junit] 2010-09-01 10:51:31,582 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11239:nioservercnxnfact...@196] - Accepted socket connection from /127.0.0.1:32876 [junit] 2010-09-01 10:51:31,582 [myid:] - INFO [NIOServerCxn.Factory:0.0.0.0/0.0.0.0:11239:nioserverc...@791] - Processing stat command from /127.0.0.1:32876 [junit] 2010-09-01 10:51:31,582 [myid:] - INFO [Thread-344:nioservercnxn$statcomm...@645] - Stat command output [junit] 2010-09-01 10:51:31,583 [myid:] - INFO [Thread-344:nioserverc...@967] - Closed socket connection for client /127.0.0.1:32876 (no session established for client)
race condition in InvalidSnapShotTest on client close
Hi, I believe, that I've found a race condition in org.apache.zookeeper.server.InvalidSnapshotTest In this test the server is closed before the client. The client, on close(), submits as last package with type ZooDefs.OpCode.closeSession and waits for this package to be finished. However, nobody is there to awake the thread from packet.wait(). The sendThread will on cleanup call packet.notifyAll() in finishpackage. The race condition is: If an exception occurs in the sendThread, closing is already true, so the sendThread breaks out of it's loop, calls cleanup and finishes. If this happens, before the main thread calls packet.wait() then there's nobody left to awake the main thread. Regards, Thomas Koch, http://www.koch.ro
[jira] Updated: (ZOOKEEPER-823) update ZooKeeper java client to optionally use Netty for connections
[
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Koch updated ZOOKEEPER-823:
--
Attachment: ZOOKEEPER-823.patch
I changed the following things:
- call the correct cleanup() method. I f..ed up to refactor the call hierarchy
- combine doReads() and doWrites() again into doIO() in NIO as it was before
- all access to selector is synchronized on ClientCnxnSocket
I'm having problems to run the testsuite and believe that I'm somehow bitten by
ZOOKEEPER-126. Some Tests just block and when I debug them, they always wait
indefinitely on packet.wait().
Something like the following helped, however with every different attempt to
solve ZOOKEEPER-126 other tests failed respectively blocked.
src/java/main/org/apache/zookeeper/ClientCnxn.java
@@ -1088,6 +1088,10 @@ public class ClientCnxn {
ReplyHeader r = new ReplyHeader();
Packet packet = queuePacket(h, r, request, response, null, null, null,
null, watchRegistration);
+if(h.getType() == ZooDefs.OpCode.closeSession){
+Thread.sleep((long) (sessionTimeout*1.1));
+return r;
+}
synchronized (packet) {
while (!packet.finished) {
packet.wait();
My tests still run now with the above code. Some take 10 minutes and more.
I also had to reduce the number of hammerthreads in
org.apache.zookeeper.test.AsyncHammerTest to 10 to make it work.
I'm running openjdk
java version 1.6.0_18
OpenJDK Runtime Environment (IcedTea6 1.8.1) (6b18-1.8.1-1)
OpenJDK 64-Bit Server VM (build 16.0-b13, mixed mode)
update ZooKeeper java client to optionally use Netty for connections
Key: ZOOKEEPER-823
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-823
Project: Zookeeper
Issue Type: New Feature
Components: java client
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Fix For: 3.4.0
Attachments: ZOOKEEPER-823.patch, ZOOKEEPER-823.patch,
ZOOKEEPER-823.patch, ZOOKEEPER-823.patch
This jira will port the client side connection code to use netty rather than
direct nio.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-823) update ZooKeeper java client to optionally use Netty for connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Koch updated ZOOKEEPER-823: -- Status: Patch Available (was: Open) update ZooKeeper java client to optionally use Netty for connections Key: ZOOKEEPER-823 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-823 Project: Zookeeper Issue Type: New Feature Components: java client Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: ZOOKEEPER-823.patch, ZOOKEEPER-823.patch, ZOOKEEPER-823.patch, ZOOKEEPER-823.patch This jira will port the client side connection code to use netty rather than direct nio. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-823) update ZooKeeper java client to optionally use Netty for connections
[ https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-823: --- Status: Open (was: Patch Available) Now this test is hanging for me (with most recent patch): [junit] Running org.apache.zookeeper.server.InvalidSnapshotTest ZOOKEEPER-126 has never really been much of an issue - don't remember seeing it in tests. Could be that timing shifted, however I was not seeing any of this with my original patch. update ZooKeeper java client to optionally use Netty for connections Key: ZOOKEEPER-823 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-823 Project: Zookeeper Issue Type: New Feature Components: java client Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.4.0 Attachments: ZOOKEEPER-823.patch, ZOOKEEPER-823.patch, ZOOKEEPER-823.patch, ZOOKEEPER-823.patch This jira will port the client side connection code to use netty rather than direct nio. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
