[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12622666#action_12622666 ] Andrew Kornev commented on ZOOKEEPER-110: - +1 I'll commit the patch and delete the svnant directory and its contents. Build script relies on svnant, which is not compatible with subversion 1.5 working copies - Key: ZOOKEEPER-110 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 Project: Zookeeper Issue Type: Bug Components: build Affects Versions: 3.0.0 Environment: Subversion 1.5 command line, or subclipse version 1.4.x Reporter: Jakob Homan Assignee: Jakob Homan Attachments: ZOOKEEPER-110.patch, ZOOKEEPER-110.patch The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with this version of subversion is too old, please get a newer version... This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly. Those with svn 1.5 can get the code from the trunk, but cannot do an ant build. svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-110: Attachment: ZOOKEEPER-110.patch It turns out that the original patch used the exec task attribute osfamily that is only available since ant 1.7. This patch ensures that build.xml is compatible with pre-1.7 versions. The apache license headers are also included. Please review. Thanks! Build script relies on svnant, which is not compatible with subversion 1.5 working copies - Key: ZOOKEEPER-110 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 Project: Zookeeper Issue Type: Bug Components: build Affects Versions: 3.0.0 Environment: Subversion 1.5 command line, or subclipse version 1.4.x Reporter: Jakob Homan Assignee: Jakob Homan Attachments: ZOOKEEPER-110.patch, ZOOKEEPER-110.patch, ZOOKEEPER-110.patch, ZOOKEEPER-110.patch The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with this version of subversion is too old, please get a newer version... This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly. Those with svn 1.5 can get the code from the trunk, but cannot do an ant build. svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-56) Add clover support to build.xml
[ https://issues.apache.org/jira/browse/ZOOKEEPER-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12622334#action_12622334 ] Andrew Kornev commented on ZOOKEEPER-56: +1, looks good! Add clover support to build.xml --- Key: ZOOKEEPER-56 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-56 Project: Zookeeper Issue Type: Improvement Components: build Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.0.0 Attachments: ZOOKEEPER-56.patch, ZOOKEEPER-56.patch Clover is what ASF uses for code coverage. We currently have cobertura, but need to add support for clover (keep the existing cobertura support for individual developers to use). Clover is run automatically by ASF Hudson. Hadoop has support for clover in their build.xml, port their clover related targets into zookeeper build.xml -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12620329#action_12620329 ] Andrew Kornev commented on ZOOKEEPER-110: - I'd like to point out that the hadoop's solution is non-portable. The exec task will fail on Windows -- it won't be able to find the executable sh.exe. By the way, this portability issue was one of the reasons we had to use svnant. Build script relies on svnant, which is not compatible with subversion 1.5 working copies - Key: ZOOKEEPER-110 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 Project: Zookeeper Issue Type: Bug Components: build Affects Versions: 3.0.0 Environment: Subversion 1.5 command line, or subclipse version 1.4.x Reporter: Jakob Homan Assignee: Jakob Homan Attachments: svntask.diff The current build.xml ant script uses svnant to obtain the latest revision number from the repo, however svnant is not compatible with subversion 1.5 (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build fails with working copies checked out by this version. The build fails with this version of subversion is too old, please get a newer version... This will become more apparent as svn 1.5 trickles out; I'm using a brand new dev environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather quickly. Those with svn 1.5 can get the code from the trunk, but cannot do an ant build. svnant hasn't been updated in more than a year and appears to be dead, so it may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Closed: (ZOOKEEPER-39) Use Watcher objects rather than boolean on read operations
[ https://issues.apache.org/jira/browse/ZOOKEEPER-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev closed ZOOKEEPER-39. -- Use Watcher objects rather than boolean on read operations -- Key: ZOOKEEPER-39 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-39 Project: Zookeeper Issue Type: New Feature Components: c client, java client Reporter: Patrick Hunt Assignee: Andrew Kornev Fix For: 3.0.0 Attachments: ZOOKEEPER-39.patch, ZOOKEEPER-39_license.patch Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1962501group_id=209147atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-39) Use Watcher objects rather than boolean on read operations
[ https://issues.apache.org/jira/browse/ZOOKEEPER-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-39: --- Resolution: Fixed Status: Resolved (was: Patch Available) Patch committed Use Watcher objects rather than boolean on read operations -- Key: ZOOKEEPER-39 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-39 Project: Zookeeper Issue Type: New Feature Components: c client, java client Reporter: Patrick Hunt Assignee: Andrew Kornev Fix For: 3.0.0 Attachments: ZOOKEEPER-39.patch, ZOOKEEPER-39_license.patch Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1962501group_id=209147atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-81) JMX module is using 1 java 6 method that has a java 5 equivalent
[ https://issues.apache.org/jira/browse/ZOOKEEPER-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12615704#action_12615704 ] Andrew Kornev commented on ZOOKEEPER-81: Long story short -- MXBean is a runtime dependency. Some internal machinery for handling user defined MXBeans is missing in Java 5. For details please refer to http://java.sun.com/javase/6/docs/technotes/guides/jmx/enhancements.html. The second bullet on the top says: ??MXBeans have been added. MXBeans are MBeans that provide a convenient way to bundle related values together without requiring clients to be specially configured to handle the bundles. A defined set of MXBeans already existed in the J2SE 5.0 platform, but Java SE 6 introduces an API to allow you to program your own custom MXBeans.?? Although there is absolutely nothing wrong with your patch, would you be terribly disappointed if I leave the things the way they are and simply close this jira as won't fix? :-) JMX module is using 1 java 6 method that has a java 5 equivalent Key: ZOOKEEPER-81 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-81 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Hiram Chirino Assignee: Andrew Kornev Attachments: ZOOKEEPER-81.patch It would be nice if the jmx module compiled and ran on java 5 too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-81) JMX module is using 1 java 6 method that has a java 5 equivalent
[ https://issues.apache.org/jira/browse/ZOOKEEPER-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12615741#action_12615741 ] Andrew Kornev commented on ZOOKEEPER-81: Would you like to verify whether or not there is a Java 6 runtime dependency? Would you be willing to contribute a patch (including this change) to break such a dependency? Would you be interested in implementing additional JMX beans? You can find some ideas here http://sourceforge.net/tracker/index.php?func=detailaid=1894138group_id=209147atid=1008547 .Things like enabling/disabling tracing thru a JMX Console seem to be useful. JMX module is using 1 java 6 method that has a java 5 equivalent Key: ZOOKEEPER-81 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-81 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Hiram Chirino Assignee: Andrew Kornev Attachments: ZOOKEEPER-81.patch It would be nice if the jmx module compiled and ran on java 5 too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-81) JMX module is using 1 java 6 method that has a java 5 equivalent
[ https://issues.apache.org/jira/browse/ZOOKEEPER-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12615760#action_12615760 ] Andrew Kornev commented on ZOOKEEPER-81: Committed! Thanks Hiram! JMX module is using 1 java 6 method that has a java 5 equivalent Key: ZOOKEEPER-81 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-81 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Hiram Chirino Assignee: Andrew Kornev Attachments: ZOOKEEPER-81.patch It would be nice if the jmx module compiled and ran on java 5 too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-81) JMX module is using 1 java 6 method that has a java 5 equivalent
[ https://issues.apache.org/jira/browse/ZOOKEEPER-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12614787#action_12614787 ] Andrew Kornev commented on ZOOKEEPER-81: The JMX instrumentation code relies on the MXBean feature that is available only since Java 6. The build.xml conditionally includes the JMX code only when compiled under Java 6. JMX module is using 1 java 6 method that has a java 5 equivalent Key: ZOOKEEPER-81 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-81 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Hiram Chirino Attachments: ZOOKEEPER-81.patch It would be nice if the jmx module compiled and ran on java 5 too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-39) Use Watcher objects rather than boolean on read operations
[ https://issues.apache.org/jira/browse/ZOOKEEPER-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12614121#action_12614121 ] Andrew Kornev commented on ZOOKEEPER-39: The watcher processing is now done in multiple steps: 1) when application issues a zokeeper query with watcher enabled, a temporary watcher registration is created and stored along with the completion entry in the completion queue. 2) upon succesful response from the server, the watcher registration is moved from the completion queue to the watcher object map. If the server returns an error the watcher registration is discarded. 3) when a watch event arrives, the client uses the watcher map to determine if there are watchers set on the znode (using the znode path as the key). It then calles the watcher callback passing in the watcher context along with the znode path and the event type info. 4) the watcher object is deleted from the map prior to calling the application watcher in the step 3) Use Watcher objects rather than boolean on read operations -- Key: ZOOKEEPER-39 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-39 Project: Zookeeper Issue Type: New Feature Components: c client, java client Reporter: Patrick Hunt Assignee: Andrew Kornev Fix For: 3.0.0 Attachments: ZOOKEEPER-39.patch Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1962501group_id=209147atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-25) FUSE for ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-25: --- Status: Patch Available (was: Open) FUSE for ZooKeeper -- Key: ZOOKEEPER-25 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-25 Project: Zookeeper Issue Type: New Feature Reporter: Patrick Hunt Assignee: Patrick Hunt Attachments: configure.ac.patch, ZOOKEEPER-25.patch.gz Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1873981group_id=209147atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-38) headers (version+) in log/snap files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-38: --- Attachment: ZOOKEEPER-38.patch Added more javadocs, use the URI class for passing provider URLs, implemented support for terminating the server if the database files format is not supported (wrong version). headers (version+) in log/snap files Key: ZOOKEEPER-38 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-38 Project: Zookeeper Issue Type: New Feature Components: server Reporter: Patrick Hunt Assignee: Andrew Kornev Fix For: 3.0.0 Attachments: ZOOKEEPER-38.patch, ZOOKEEPER-38.patch, ZOOKEEPER-38.patch Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1961767group_id=209147atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-70) Add skeleton forrest doc structure for ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12612220#action_12612220 ] Andrew Kornev commented on ZOOKEEPER-70: +1 Add skeleton forrest doc structure for ZooKeeper Key: ZOOKEEPER-70 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-70 Project: Zookeeper Issue Type: Task Components: documentation Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.0.0 Attachments: ZOOKEEPER-70.tar.gz, ZOOKEEPER-70_1.patch, ZOOKEEPER-70_2.patch Add a skeleton forrest doc structure for ZooKeeper. Doug has suggested using hbase as a starting point. Note: I noticed that forrest doesn't work with java6, it will run with java5. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-70) Add skeleton forrest doc structure for ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-70: --- Status: Patch Available (was: Open) Add skeleton forrest doc structure for ZooKeeper Key: ZOOKEEPER-70 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-70 Project: Zookeeper Issue Type: Task Components: documentation Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.0.0 Attachments: ZOOKEEPER-70.tar.gz, ZOOKEEPER-70_1.patch, ZOOKEEPER-70_2.patch Add a skeleton forrest doc structure for ZooKeeper. Doug has suggested using hbase as a starting point. Note: I noticed that forrest doesn't work with java6, it will run with java5. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-70) Add skeleton forrest doc structure for ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-70: --- Attachment: ZOOKEEPER-70_2.patch The patch fixes the problem with the build.xml: on Windows, the extention .bat must be specified explicitely when using the exec ant task. Other than that, the patch looks good and I was able to generate a site (with most of the links broken) Add skeleton forrest doc structure for ZooKeeper Key: ZOOKEEPER-70 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-70 Project: Zookeeper Issue Type: Task Components: documentation Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.0.0 Attachments: ZOOKEEPER-70.tar.gz, ZOOKEEPER-70_1.patch, ZOOKEEPER-70_2.patch Add a skeleton forrest doc structure for ZooKeeper. Doug has suggested using hbase as a starting point. Note: I noticed that forrest doesn't work with java6, it will run with java5. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-39) Use Watcher objects rather than boolean on read operations
[ https://issues.apache.org/jira/browse/ZOOKEEPER-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-39: --- Status: Patch Available (was: Open) Use Watcher objects rather than boolean on read operations -- Key: ZOOKEEPER-39 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-39 Project: Zookeeper Issue Type: New Feature Components: c client, java client Reporter: Patrick Hunt Assignee: Andrew Kornev Fix For: 3.0.0 Attachments: ZOOKEEPER-39.patch Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1962501group_id=209147atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-66) Add NullWatcher, a watcher that does nothing
[ https://issues.apache.org/jira/browse/ZOOKEEPER-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12610882#action_12610882 ] Andrew Kornev commented on ZOOKEEPER-66: I concur with Flavio: application must implement a watcher. At the very least you'd want to know about the session events such as connect, disconnect, and especially session expiration and athentication failure. The latter two cannot be automatically recovered from and must be handled by the application in a certain way (a new ZooKeeper object must be instantiated). Add NullWatcher, a watcher that does nothing Key: ZOOKEEPER-66 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-66 Project: Zookeeper Issue Type: New Feature Components: java client Reporter: Anthony Urso Priority: Minor Attachments: nullwatcher.diff I found that I was repeating this code all over the place. Here is a NullWatcher class, a Watcher that does nothing at all. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-45) Restructure the SVN repository after initial import
[ https://issues.apache.org/jira/browse/ZOOKEEPER-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12608578#action_12608578 ] Andrew Kornev commented on ZOOKEEPER-45: To Mahadev, Pat and other hadoop admirers: I'd like to keep the changelogs for java, c and other stuff that is not either c or java in their respective subdirectories. The fact that all those components released in a single package should have no bearing on the location of a source file within the source hierarchy. Or, put in a different way, no one would seriously consider a proposal to move all of the c and java source files under the same directory just because they end up in the same release tar file. Having said that, I support the idea of having a top level CHANGES.txt for changes that are not specific to any component (for example, addition of a new contributed component, creation of a new top level source dir, modification of sample config file, etc). Restructure the SVN repository after initial import --- Key: ZOOKEEPER-45 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-45 Project: Zookeeper Issue Type: Task Components: build Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.0.0 Attachments: add_timestamp_log4j.patch, build_fixlog4j.patch SVN and the ant build have to be updated after the initial import from SourceForge (see INFRA-1644) in order to get us aligned with Apache release process/collateral and some general cleanup of the repository. Please review/comment on the following: I intend to follow these steps: 1) collapse svn hadoop/zookeeper/trunk/zookeeper/... down to hadoop/zookeeper/trunk/... (remove unnecessary zk dir under trunk) 2) change the java package prefix from com.yahoo to org.apache 3) update the license headers in all source files 4) replace LICENSE file in root dir with Apache LICENSE file 5) add attribution NOTICE file to root dir 6) update the README file appropriately 7) create a new src directory in the zk root 8) move root c directory into src 9) move root java directory into src 10) create root docs directory 11) create src/docs directory 12) rename src/java/src to src/java/main 13) move root test directory to src/java/test 14) build.xml will be updated appropriately for all the moves. it will also be updated with apache specific targets similar to what exists in hadoop (such as building the forrest documentation). steps 1011 are required for zk documentation storage. src/docs is the location of all documentation in forrest xml format - the documentation source/originals (what you edit when you change the docs). the ant script is setup to build docs (forrest) into the root docs directory. these files are also committed to svn (both docs and src/docs). later, during a release process, the files in the root docs directory are checked out onto the system hosting the apache web site and pushed to the mirrors. I'll submit patches for any changes/additions of files. However I suspect that the directory move operations in SVN will not have an accompanying patch - this script is the documentation of what will be changed (comments added for any deviation). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
