[jira] Resolved: (ZOOKEEPER-926) Fork Hadoop common's test-patch.sh and modify for Zookeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Daley resolved ZOOKEEPER-926. --- Resolution: Fixed Committed. Resolving this issue for now. Open new issues for further fixes/enhancements. > Fork Hadoop common's test-patch.sh and modify for Zookeeper > --- > > Key: ZOOKEEPER-926 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-926 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Nigel Daley >Assignee: Nigel Daley > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-926.patch > > > Zookeeper currently uses the test-patch.sh script from the Hadoop nightly > dir. This is now out of date. I propose we just copy the updated one in > Hadoop common and then modify for ZK. This will also help as ZK moves out of > Hadoop to it's own TLP. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-902) Fix findbug issue in trunk "Malicious code vulnerability"
[ https://issues.apache.org/jira/browse/ZOOKEEPER-902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930236#action_12930236 ] Nigel Daley commented on ZOOKEEPER-902: --- The patch for this issue should also update src/java/test/bin/test-patch.properties to set OK_FINDBUGS_WARNINGS=0 > Fix findbug issue in trunk "Malicious code vulnerability" > - > > Key: ZOOKEEPER-902 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-902 > Project: Zookeeper > Issue Type: Bug > Components: quorum, server >Affects Versions: 3.4.0 >Reporter: Patrick Hunt >Priority: Minor > Fix For: 3.4.0 > > > https://hudson.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/970/artifact/trunk/findbugs/zookeeper-findbugs-report.html#Warnings_MALICIOUS_CODE > Malicious code vulnerability Warnings > Code Warning > MSorg.apache.zookeeper.server.quorum.LeaderElection.epochGen isn't final > but should be -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-926) Fork Hadoop common's test-patch.sh and modify for Zookeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nigel Daley updated ZOOKEEPER-926: -- Attachment: ZOOKEEPER-926.patch Initial patch to replace the old test-patch file. Further changes will be needed. > Fork Hadoop common's test-patch.sh and modify for Zookeeper > --- > > Key: ZOOKEEPER-926 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-926 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Nigel Daley > Attachments: ZOOKEEPER-926.patch > > > Zookeeper currently uses the test-patch.sh script from the Hadoop nightly > dir. This is now out of date. I propose we just copy the updated one in > Hadoop common and then modify for ZK. This will also help as ZK moves out of > Hadoop to it's own TLP. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-926) Fork Hadoop common's test-patch.sh and modify for Zookeeper
Fork Hadoop common's test-patch.sh and modify for Zookeeper --- Key: ZOOKEEPER-926 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-926 Project: Zookeeper Issue Type: Improvement Components: build Reporter: Nigel Daley Zookeeper currently uses the test-patch.sh script from the Hadoop nightly dir. This is now out of date. I propose we just copy the updated one in Hadoop common and then modify for ZK. This will also help as ZK moves out of Hadoop to it's own TLP. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-241) Build of a distro fails after clean target is run
Build of a distro fails after clean target is run
-
Key: ZOOKEEPER-241
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-241
Project: Zookeeper
Issue Type: Bug
Components: build
Affects Versions: 3.0.1
Reporter: Nigel Daley
Priority: Critical
When the ZooKeeper distro is downloaded, if the clean target is run, it deletes
the .revision file:
{quote}
clean:
[delete] Deleting directory /home/foo/zookeeper-3.0.1/build
[delete] Deleting directory /home/foo/zookeeper-3.0.1/src/java/generated
[delete] Deleting directory /home/foo/zookeeper-3.0.1/src/c/generated
[delete] Deleting directory /home/foo/zookeeper-3.0.1/.revision
{quote}
This causes subsequent builds in the distro to fail with:
{quote}
compile-main:
[javac] Compiling 73 source files to /home/foo/zookeeper-3.0.1/build/classes
[javac]
/home/foo/zookeeper-3.0.1/src/java/main/org/apache/zookeeper/Version.java:21:
package org.apache.zookeeper.version does not exist
[javac] public class Version implements org.apache.zookeeper.version.Info{
[javac] ^
...
{quote}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-78) added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation
[
https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616591#action_12616591
]
Nigel Daley commented on ZOOKEEPER-78:
--
{quote}
Fewer, simpler mechanisms generally include more people.
{quote}
+1. Let's stick with a process for now that all contributors can use, not just
ASF committers.
> added a high level protocol/feature - for easy Leader Election or exclusive
> Write Lock creation
> ---
>
> Key: ZOOKEEPER-78
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-78
> Project: Zookeeper
> Issue Type: New Feature
> Components: java client
>Affects Versions: 3.0.0
>Reporter: james strachan
> Attachments: patch_with_including_Benjamin's_fix.patch,
> using_zookeeper_facade.patch
>
>
> Here's a patch which adds a little WriteLock helper class for performing
> leader elections or creating exclusive locks in some directory znode. Note
> its an early cut; am sure we can improve it over time. The aim is to avoid
> folks having to use the low level ZK stuff but provide a simpler high level
> abstraction.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-83) Switch to using maven to build ZooKeeper
[ https://issues.apache.org/jira/browse/ZOOKEEPER-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616583#action_12616583 ] Nigel Daley commented on ZOOKEEPER-83: -- +1 for staying with Ant and creating maven artifacts. > Switch to using maven to build ZooKeeper > > > Key: ZOOKEEPER-83 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-83 > Project: Zookeeper > Issue Type: Improvement > Components: build >Reporter: Hiram Chirino > Attachments: zookeeper-mavened.tgz > > > Maven is a great too for building java projects at the ASF. It helps > standardize the build a bit since it's a convention oriented. > It's dependency auto downloading would remove the need to store the > dependencies in svn, and it will handle many of the suggested ASF policies > like gpg signing of the releases and such. > The ZooKeeper build is almost vanilla except for the jute compiler bits. > Things that would need to change are: > * re-organize the source tree a little so that it uses the maven directory > conventions > * seperate the jute bits out into seperate modules so that a maven plugin > can be with it > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
