[jira] Commented: (ZOOKEEPER-457) Make ZookeeperMain public, support for HBase (and other) embedded clients
[ https://issues.apache.org/jira/browse/ZOOKEEPER-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726195#action_12726195 ] Nitay Joffe commented on ZOOKEEPER-457: --- For reference, this is currently in HBase's ZooKeeper jar. The relevant HBase issue is: HBASE-1329. > Make ZookeeperMain public, support for HBase (and other) embedded clients > - > > Key: ZOOKEEPER-457 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-457 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.1.1 >Reporter: ryan rawson > Fix For: 3.2.0 > > Attachments: zk.patch > > > hi folks, we have made some changes to zookeeper to facilitate providing an > embedded zk client in our own hbase client. This will allow our users to use > 1 shell to manipulate both hbase things and zookeeper things. It requires > making a few things public, and in the process rearranging how some static > things are initialized. > It's fairly trivial refactoring, hopefully you guys approve! > Thanks! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ZOOKEEPER-431) Expose methods to ease ZK integration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716049#action_12716049 ] Nitay Joffe edited comment on ZOOKEEPER-431 at 6/3/09 1:16 PM: --- For more information see HBASE-1449. was (Author: nitay): For more information see HBASE-1449 for more information. > Expose methods to ease ZK integration > - > > Key: ZOOKEEPER-431 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-431 > Project: Zookeeper > Issue Type: Improvement >Reporter: Jean-Daniel Cryans > Fix For: 3.2.0 > > Attachments: zookeeper-431.patch > > > HBase committer here. I opened this jira to see if it's possible to include > some changes in the way quorum servers are started in order to ease the > integration with HBase. Basically the major things we would change is how > methods are exposed in QPM/QPC and such. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-431) Expose methods to ease ZK integration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716049#action_12716049 ] Nitay Joffe commented on ZOOKEEPER-431: --- For more information see HBASE-1449 for more information. > Expose methods to ease ZK integration > - > > Key: ZOOKEEPER-431 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-431 > Project: Zookeeper > Issue Type: Improvement >Reporter: Jean-Daniel Cryans > Fix For: 3.2.0 > > Attachments: zookeeper-431.patch > > > HBase committer here. I opened this jira to see if it's possible to include > some changes in the way quorum servers are started in order to ease the > integration with HBase. Basically the major things we would change is how > methods are exposed in QPM/QPC and such. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-374) Uninitialized struct variable in C causes warning which is treated as an error
[ https://issues.apache.org/jira/browse/ZOOKEEPER-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699124#action_12699124 ] Nitay Joffe commented on ZOOKEEPER-374: --- +1. Works for me. > Uninitialized struct variable in C causes warning which is treated as an error > -- > > Key: ZOOKEEPER-374 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-374 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.1.1 > Environment: i686-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. > build 5490) >Reporter: Nitay Joffe >Assignee: Patrick Hunt >Priority: Trivial > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-374.patch > > > nitay-joffes-macbook-pro:c nitay$ pwd > /Users/nitay/code/zookeeper/src/c > nitay-joffes-macbook-pro:c nitay$ make > make all-am > /bin/sh ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. > -I./include -I./tests -I./generated -Wall -Werror -g -O2 -MT zookeeper.lo > -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' > || echo './'`src/zookeeper.c > libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests > -I./generated -Wall -Werror -g -O2 -MT zookeeper.lo -MD -MP -MF > .deps/zookeeper.Tpo -c src/zookeeper.c -fno-common -DPIC -o .libs/zookeeper.o > cc1: warnings being treated as errors > src/zookeeper.c: In function 'zoo_add_auth': > src/zookeeper.c:2378: warning: 'auth.buff' may be used uninitialized in this > function > src/zookeeper.c:2378: warning: 'auth.len' may be used uninitialized in this > function > make[1]: *** [zookeeper.lo] Error 1 > make: *** [all] Error 2 > Need to set auth.buff and auth.len to zero. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-374) Uninitialized struct variable in C causes warning which is treated as an error
[ https://issues.apache.org/jira/browse/ZOOKEEPER-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitay Joffe updated ZOOKEEPER-374: -- Environment: i686-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5490) > Uninitialized struct variable in C causes warning which is treated as an error > -- > > Key: ZOOKEEPER-374 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-374 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.1.1 > Environment: i686-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. > build 5490) >Reporter: Nitay Joffe >Priority: Trivial > Fix For: 3.2.0 > > > nitay-joffes-macbook-pro:c nitay$ pwd > /Users/nitay/code/zookeeper/src/c > nitay-joffes-macbook-pro:c nitay$ make > make all-am > /bin/sh ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. > -I./include -I./tests -I./generated -Wall -Werror -g -O2 -MT zookeeper.lo > -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' > || echo './'`src/zookeeper.c > libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests > -I./generated -Wall -Werror -g -O2 -MT zookeeper.lo -MD -MP -MF > .deps/zookeeper.Tpo -c src/zookeeper.c -fno-common -DPIC -o .libs/zookeeper.o > cc1: warnings being treated as errors > src/zookeeper.c: In function 'zoo_add_auth': > src/zookeeper.c:2378: warning: 'auth.buff' may be used uninitialized in this > function > src/zookeeper.c:2378: warning: 'auth.len' may be used uninitialized in this > function > make[1]: *** [zookeeper.lo] Error 1 > make: *** [all] Error 2 > Need to set auth.buff and auth.len to zero. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-374) Uninitialized struct variable in C causes warning which is treated as an error
[ https://issues.apache.org/jira/browse/ZOOKEEPER-374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitay Joffe updated ZOOKEEPER-374: -- Priority: Trivial (was: Major) > Uninitialized struct variable in C causes warning which is treated as an error > -- > > Key: ZOOKEEPER-374 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-374 > Project: Zookeeper > Issue Type: Bug > Components: c client >Affects Versions: 3.1.1 >Reporter: Nitay Joffe >Priority: Trivial > > nitay-joffes-macbook-pro:c nitay$ pwd > /Users/nitay/code/zookeeper/src/c > nitay-joffes-macbook-pro:c nitay$ make > make all-am > /bin/sh ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. > -I./include -I./tests -I./generated -Wall -Werror -g -O2 -MT zookeeper.lo > -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' > || echo './'`src/zookeeper.c > libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests > -I./generated -Wall -Werror -g -O2 -MT zookeeper.lo -MD -MP -MF > .deps/zookeeper.Tpo -c src/zookeeper.c -fno-common -DPIC -o .libs/zookeeper.o > cc1: warnings being treated as errors > src/zookeeper.c: In function 'zoo_add_auth': > src/zookeeper.c:2378: warning: 'auth.buff' may be used uninitialized in this > function > src/zookeeper.c:2378: warning: 'auth.len' may be used uninitialized in this > function > make[1]: *** [zookeeper.lo] Error 1 > make: *** [all] Error 2 > Need to set auth.buff and auth.len to zero. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-374) Uninitialized struct variable in C causes warning which is treated as an error
Uninitialized struct variable in C causes warning which is treated as an error -- Key: ZOOKEEPER-374 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-374 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.1.1 Reporter: Nitay Joffe nitay-joffes-macbook-pro:c nitay$ pwd /Users/nitay/code/zookeeper/src/c nitay-joffes-macbook-pro:c nitay$ make make all-am /bin/sh ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c -o zookeeper.lo `test -f 'src/zookeeper.c' || echo './'`src/zookeeper.c libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -fno-common -DPIC -o .libs/zookeeper.o cc1: warnings being treated as errors src/zookeeper.c: In function 'zoo_add_auth': src/zookeeper.c:2378: warning: 'auth.buff' may be used uninitialized in this function src/zookeeper.c:2378: warning: 'auth.len' may be used uninitialized in this function make[1]: *** [zookeeper.lo] Error 1 make: *** [all] Error 2 Need to set auth.buff and auth.len to zero. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-347) zkfuse uses non-standard String
[
https://issues.apache.org/jira/browse/ZOOKEEPER-347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nitay Joffe reassigned ZOOKEEPER-347:
-
Assignee: Patrick Hunt
> zkfuse uses non-standard String
> ---
>
> Key: ZOOKEEPER-347
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-347
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-zkfuse
>Affects Versions: 3.1.0
> Environment: gcc (GCC) 4.3.2 20081105 (Red Hat 4.3.2-7)
>Reporter: Nitay Joffe
>Assignee: Patrick Hunt
>Priority: Minor
> Fix For: 3.2.0
>
>
> I'm getting an error compiling zkfuse:
> g++ -DHAVE_CONFIG_H -I. -I..
> -I/home/nitay/code/zookeeper-git/src/contrib/zkfuse/../../c/include
> -I/home/nitay/code/zookeeper-git/src/contrib/zkfuse/../../c/generated
> -I../include -I/usr/include -D_FILE_OFFSET_BITS=64 -D_REENTRANT -g -O2 -MT
> zkfuse.o -MD -MP -MF .deps/zkfuse.Tpo -c -o zkfuse.o zkfuse.cc
> zkfuse.cc: In function 'int main(int, char**)':
> zkfuse.cc:4282: error: 'String' does not name a type
> zkfuse.cc:4283: error: 'file' was not declared in this scope
> make[2]: *** [zkfuse.o] Error 1
> make[2]: Leaving directory
> `/home/nitay/code/zookeeper-git/src/contrib/zkfuse/src'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/home/nitay/code/zookeeper-git/src/contrib/zkfuse'
> make: *** [all] Error 2
> 4279 /**
> 4280 * Initialize log4cxx
> 4281 */
> 4282 const String file("log4cxx.properties");
> 4283 PropertyConfigurator::configureAndWatch( file, 5000 );
> 4284 LOG_INFO(LOG, "Starting zkfuse");
> String is not standard, we should change it to std::string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-347) zkfuse uses non-standard String
zkfuse uses non-standard String
---
Key: ZOOKEEPER-347
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-347
Project: Zookeeper
Issue Type: Bug
Components: contrib-zkfuse
Affects Versions: 3.1.0
Environment: gcc (GCC) 4.3.2 20081105 (Red Hat 4.3.2-7)
Reporter: Nitay Joffe
Priority: Minor
I'm getting an error compiling zkfuse:
g++ -DHAVE_CONFIG_H -I. -I..
-I/home/nitay/code/zookeeper-git/src/contrib/zkfuse/../../c/include
-I/home/nitay/code/zookeeper-git/src/contrib/zkfuse/../../c/generated
-I../include -I/usr/include -D_FILE_OFFSET_BITS=64 -D_REENTRANT -g -O2 -MT
zkfuse.o -MD -MP -MF .deps/zkfuse.Tpo -c -o zkfuse.o zkfuse.cc
zkfuse.cc: In function 'int main(int, char**)':
zkfuse.cc:4282: error: 'String' does not name a type
zkfuse.cc:4283: error: 'file' was not declared in this scope
make[2]: *** [zkfuse.o] Error 1
make[2]: Leaving directory
`/home/nitay/code/zookeeper-git/src/contrib/zkfuse/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nitay/code/zookeeper-git/src/contrib/zkfuse'
make: *** [all] Error 2
4279 /**
4280 * Initialize log4cxx
4281 */
4282 const String file("log4cxx.properties");
4283 PropertyConfigurator::configureAndWatch( file, 5000 );
4284 LOG_INFO(LOG, "Starting zkfuse");
String is not standard, we should change it to std::string.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-279) Variable expansion in zoo.cfg
[
https://issues.apache.org/jira/browse/ZOOKEEPER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nitay Joffe updated ZOOKEEPER-279:
--
Affects Version/s: 3.1.0
Status: Patch Available (was: Open)
Can we get a review for this?
> Variable expansion in zoo.cfg
> -
>
> Key: ZOOKEEPER-279
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
> Project: Zookeeper
> Issue Type: Improvement
>Affects Versions: 3.1.0
>Reporter: Nitay Joffe
>Priority: Minor
> Attachments: HBaseQPC.java, zookeeper-279.patch
>
>
> We would like to define certain parts of ZooKeeper's configuration using
> variables that get substituted. For example, we want the ZooKeeper quorum to
> be able to use a dataDir configured per user. In other words, something like:
> tickTime=2000
> dataDir=/tmp/zookeeper-${user.name}
> clientPort=2181
> initLimit=5
> syncLimit=2
> server.1=zoo1:2888:3888
> server.2=zoo2:2888:3888
> server.3=zoo3:2888:3888
> I think Java already has a system for configuration that allows something
> like this using Properties?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-277) Define PATH_SEPARATOR
[ https://issues.apache.org/jira/browse/ZOOKEEPER-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671565#action_12671565 ] Nitay Joffe commented on ZOOKEEPER-277: --- Should also add some constant, say ZNODE_ANY_VERSION, for accepting any version, that is -1. > Define PATH_SEPARATOR > - > > Key: ZOOKEEPER-277 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-277 > Project: Zookeeper > Issue Type: Improvement > Components: c client, documentation, java client, server, tests >Reporter: Nitay Joffe >Priority: Trivial > > We should define a constant for PATH_SEPARATOR = "/" and use that throughout > the code rather than the hardcoded "/". Users can be told to use this > constant to be safe in case of future changes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-272) getChildren can fail for large numbers of children
[ https://issues.apache.org/jira/browse/ZOOKEEPER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668371#action_12668371 ] Nitay Joffe commented on ZOOKEEPER-272: --- What about having getChildren() return an Iterator instead of a List? Using such an abstraction allows us to put the implementation details of what "walking the list children" mean inside ZooKeeper instead of client code. With an Iterator we can make the next() call handle the multiple offset getChildren() calls under the hood, rather than put this burden on the client. Furthermore, if we have, say, some compressed protocol, a lot of space/cpu can be saved by only decompressing/storing the current child being worked on. > getChildren can fail for large numbers of children > -- > > Key: ZOOKEEPER-272 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-272 > Project: Zookeeper > Issue Type: Bug >Reporter: Joshua Tuberville >Assignee: Mahadev konar > Fix For: 3.1.0 > > Attachments: ZOOKEEPER-272.patch > > > Zookeeper allows creation of an abritrary number of children, yet if the > String array of children names exceeds 4,194,304 bytes a getChildren will > fail because ClientCnxn$SendThread.readLength() throws an exception on line > 490. Mahadev Konar questioned this byte limit's need. In any case > consistency of create children, get children should exist. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-279) Variable expansion in zoo.cfg
[
https://issues.apache.org/jira/browse/ZOOKEEPER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667361#action_12667361
]
Nitay Joffe commented on ZOOKEEPER-279:
---
More specifically, we are trying to make zoo.cfg play nicely with hadoop/hbase
conf so that we can interpolate things like hadoop.tmp.dir as the default for
the ZK dataDir.
> Variable expansion in zoo.cfg
> -
>
> Key: ZOOKEEPER-279
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
> Project: Zookeeper
> Issue Type: Improvement
>Reporter: Nitay Joffe
>Priority: Minor
>
> We would like to define certain parts of ZooKeeper's configuration using
> variables that get substituted. For example, we want the ZooKeeper quorum to
> be able to use a dataDir configured per user. In other words, something like:
> tickTime=2000
> dataDir=/tmp/zookeeper-${user.name}
> clientPort=2181
> initLimit=5
> syncLimit=2
> server.1=zoo1:2888:3888
> server.2=zoo2:2888:3888
> server.3=zoo3:2888:3888
> I think Java already has a system for configuration that allows something
> like this using Properties?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-279) Variable expansion in zoo.cfg
Variable expansion in zoo.cfg
-
Key: ZOOKEEPER-279
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-279
Project: Zookeeper
Issue Type: Improvement
Reporter: Nitay Joffe
Priority: Minor
We would like to define certain parts of ZooKeeper's configuration using
variables that get substituted. For example, we want the ZooKeeper quorum to be
able to use a dataDir configured per user. In other words, something like:
tickTime=2000
dataDir=/tmp/zookeeper-${user.name}
clientPort=2181
initLimit=5
syncLimit=2
server.1=zoo1:2888:3888
server.2=zoo2:2888:3888
server.3=zoo3:2888:3888
I think Java already has a system for configuration that allows something like
this using Properties?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-278) Create a test jar
Create a test jar - Key: ZOOKEEPER-278 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-278 Project: Zookeeper Issue Type: Improvement Components: tests Reporter: Nitay Joffe Priority: Minor I am working on integrating ZooKeeper into HBase. I've found myself copying a lot of the test infrastructure code from places like zk.t.QuorumTest to create classes like MiniZooKeeper so that I can test my new additions in HBase. I think things would be a lot easier if we shipped a ZooKeeper test jar for others to use. Additionally, I think we should clean up the test code a bit so that the tests use some common infrastructure rather than each doing its own setup/teardown of a ZK cluster. I believe this is how things are done for testing Hadoop things HBase. For more context, see hbase-1144.patch in https://issues.apache.org/jira/browse/HBASE-1144 I would do this myself but I can't currently contribute to Apache projects other than HBase because of company issues. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-277) Define PATH_SEPARATOR
Define PATH_SEPARATOR - Key: ZOOKEEPER-277 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-277 Project: Zookeeper Issue Type: Improvement Reporter: Nitay Joffe Priority: Trivial We should define a constant for PATH_SEPARATOR = "/" and use that throughout the code rather than the hardcoded "/". Users can be told to use this constant to be safe in case of future changes. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-248) QuorumPeer should use Map interface instead of HashMap implementation.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitay Joffe updated ZOOKEEPER-248: -- Status: Patch Available (was: Open) > QuorumPeer should use Map interface instead of HashMap implementation. > -- > > Key: ZOOKEEPER-248 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-248 > Project: Zookeeper > Issue Type: Improvement > Components: quorum >Affects Versions: 3.0.1, 3.0.0 >Reporter: Nitay Joffe >Priority: Trivial > Fix For: 3.1.0 > > Attachments: 248.patch > > > Using HashMap directly to store quorumPeers member variable unnecessarily > decides for the user what implementation of Map to use. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-249) QuorumPeer.getClientPort() always returns -1
[ https://issues.apache.org/jira/browse/ZOOKEEPER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitay Joffe updated ZOOKEEPER-249: -- Status: Patch Available (was: Open) > QuorumPeer.getClientPort() always returns -1 > > > Key: ZOOKEEPER-249 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-249 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.1, 3.0.0 >Reporter: Nitay Joffe >Priority: Trivial > Fix For: 3.1.0 > > Attachments: 249.patch > > > This was changed in SVN 700690: > http://svn.apache.org/viewvc/hadoop/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java?r1=700690&r2=700689&pathrev=700690 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-249) QuorumPeer.getClientPort() always returns -1
[ https://issues.apache.org/jira/browse/ZOOKEEPER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654559#action_12654559 ] Nitay Joffe commented on ZOOKEEPER-249: --- Besides the ZOOKEEPER- before the name, is my patch okay format wise? It's generated from a git checkout, not an svn one. I think the only difference is you need to use patch -p1 instead of -p0. Otherwise it should work the same. Thanks, -n > QuorumPeer.getClientPort() always returns -1 > > > Key: ZOOKEEPER-249 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-249 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0, 3.0.1 >Reporter: Nitay Joffe >Priority: Trivial > Fix For: 3.1.0 > > Attachments: 249.patch > > > This was changed in SVN 700690: > http://svn.apache.org/viewvc/hadoop/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java?r1=700690&r2=700689&pathrev=700690 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-249) QuorumPeer.getClientPort() always returns -1
[ https://issues.apache.org/jira/browse/ZOOKEEPER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitay Joffe updated ZOOKEEPER-249: -- Attachment: 249.patch > QuorumPeer.getClientPort() always returns -1 > > > Key: ZOOKEEPER-249 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-249 > Project: Zookeeper > Issue Type: Bug >Reporter: Nitay Joffe >Priority: Trivial > Attachments: 249.patch > > > This was changed in SVN 700690: > http://svn.apache.org/viewvc/hadoop/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java?r1=700690&r2=700689&pathrev=700690 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-249) QuorumPeer.getClientPort() always returns -1
QuorumPeer.getClientPort() always returns -1 Key: ZOOKEEPER-249 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-249 Project: Zookeeper Issue Type: Bug Reporter: Nitay Joffe Priority: Trivial This was changed in SVN 700690: http://svn.apache.org/viewvc/hadoop/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java?r1=700690&r2=700689&pathrev=700690 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-248) QuorumPeer should use Map interface instead of HashMap implementation.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitay Joffe updated ZOOKEEPER-248: -- Status: Patch Available (was: Open) > QuorumPeer should use Map interface instead of HashMap implementation. > -- > > Key: ZOOKEEPER-248 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-248 > Project: Zookeeper > Issue Type: Improvement > Components: quorum >Reporter: Nitay Joffe >Priority: Trivial > Attachments: 248.patch > > > Using HashMap directly to store quorumPeers member variable unnecessarily > decides for the user what implementation of Map to use. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-248) QuorumPeer should use Map interface instead of HashMap implementation.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitay Joffe updated ZOOKEEPER-248: -- Attachment: 248.patch > QuorumPeer should use Map interface instead of HashMap implementation. > -- > > Key: ZOOKEEPER-248 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-248 > Project: Zookeeper > Issue Type: Improvement > Components: quorum >Reporter: Nitay Joffe >Priority: Trivial > Attachments: 248.patch > > > Using HashMap directly to store quorumPeers member variable unnecessarily > decides for the user what implementation of Map to use. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-248) QuorumPeer should use Map interface instead of HashMap implementation.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitay Joffe updated ZOOKEEPER-248: -- Status: Open (was: Patch Available) > QuorumPeer should use Map interface instead of HashMap implementation. > -- > > Key: ZOOKEEPER-248 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-248 > Project: Zookeeper > Issue Type: Improvement > Components: quorum >Reporter: Nitay Joffe >Priority: Trivial > Attachments: 248.patch > > > Using HashMap directly to store quorumPeers member variable unnecessarily > decides for the user what implementation of Map to use. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-248) QuorumPeer should use Map interface instead of HashMap implementation.
QuorumPeer should use Map interface instead of HashMap implementation. -- Key: ZOOKEEPER-248 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-248 Project: Zookeeper Issue Type: Improvement Components: quorum Reporter: Nitay Joffe Priority: Trivial Using HashMap directly to store quorumPeers member variable unnecessarily decides for the user what implementation of Map to use. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
