[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Status: Patch Available (was: Open) Corrects error of not initializing the second element of an array on line 202-204 of zoo_selock.c. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch, ZOOKEEPER-767.patch, > ZOOKEEPER-767.patch, ZOOKEEPER-767.patch, ZOOKEEPER-767.patch > > Time Spent: 8h > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Attachment: ZOOKEEPER-767.patch This patch corrects an error in zoo_selock.c in which the second element of a two element array is not initialized before use. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch, ZOOKEEPER-767.patch, > ZOOKEEPER-767.patch, ZOOKEEPER-767.patch, ZOOKEEPER-767.patch > > Time Spent: 8h > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Status: Open (was: Patch Available) Found bug in C code. Line 202 - 204 does no initialize index 1 of the array but re-initializes index 0. Fixing coming next... > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch, ZOOKEEPER-767.patch, > ZOOKEEPER-767.patch, ZOOKEEPER-767.patch > > Time Spent: 8h > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Status: Patch Available (was: Open) Includes C code. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch, ZOOKEEPER-767.patch, > ZOOKEEPER-767.patch, ZOOKEEPER-767.patch > > Time Spent: 8h > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Status: Open (was: Patch Available) > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch, ZOOKEEPER-767.patch, > ZOOKEEPER-767.patch, ZOOKEEPER-767.patch > > Time Spent: 8h > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Attachment: (was: ZOOKEEPER-767.patch) > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch, ZOOKEEPER-767.patch, > ZOOKEEPER-767.patch, ZOOKEEPER-767.patch > > Time Spent: 8h > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Attachment: ZOOKEEPER-767.patch Patch for java and c implementations of locking in zookeeper. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch, ZOOKEEPER-767.patch, > ZOOKEEPER-767.patch, ZOOKEEPER-767.patch > > Time Spent: 8h > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Status: Patch Available (was: Open) New patch contains java and c recipe code. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch, ZOOKEEPER-767.patch, > ZOOKEEPER-767.patch, ZOOKEEPER-767.patch > > Time Spent: 8h > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Status: Open (was: Patch Available) Canceling last patch. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch, ZOOKEEPER-767.patch, > ZOOKEEPER-767.patch, ZOOKEEPER-767.patch > > Time Spent: 8h > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Attachment: ZOOKEEPER-767.patch Patch containing java and c implementations of recipe locking code. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch, ZOOKEEPER-767.patch, > ZOOKEEPER-767.patch, ZOOKEEPER-767.patch > > Time Spent: 8h > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Work logged: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#action_11084 ] Sam Baskinger logged work on ZOOKEEPER-767: --- Author: Sam Baskinger Created on: 04/Aug/10 02:39 AM Start Date: 04/Aug/10 02:38 AM Worklog Time Spent: 8h Work Description: Coarse cut implementation and unit tests on C version done. Documentation and cleanup pending. Issue Time Tracking --- Time Spent: 8h > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch, ZOOKEEPER-767.patch, > ZOOKEEPER-767.patch > > Time Spent: 8h > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12894840#action_12894840 ] Sam Baskinger commented on ZOOKEEPER-767: - I could certainly put some effort into that. My time's a little constrained now and I don't move nearly as quickly as I do in Java, but I try to get something written up. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch, ZOOKEEPER-767.patch, > ZOOKEEPER-767.patch > > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Status: Patch Available (was: Open) Fixed failure cases in the event of a thrown exception after requesting a lock. Optimization in returning earlier (and avoiding a needless create operation) when a lock file is already held by the caller. Also, some variable names were updated from the read/write to shared/exclusive. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch, ZOOKEEPER-767.patch, > ZOOKEEPER-767.patch > > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878717#action_12878717 ] Sam Baskinger commented on ZOOKEEPER-767: - Thanks of the code-snippet Benjamin. You're absolutely right. Fixed #1. Regarding #2, when getting a shared lock we ignore existing shared locks and only look for exclusive locks. Line 225 of the new patch has: {noformat} if (child.startsWith(EXLOCK)) { ... {noformat} If I'm not confusing the matter, while a single "exclusive lock" node represents a single exclusive lock, a series of contiguous "shared lock" nodes make up the total of a shared lock. I took some time to stare at the code in question and corresponding code in the getExclusiveLock() call and I think they are as we intended them. As for #3, wow, I fell asleep at the IDE for that one. Thank you. Any exception will result in a "roll back" of the lock file creation and the Exception is propagated up the stack. Now, the larger question of the existing lock implementation, the existing {{WriteLock.java}} doesn't appear to closely follow the recipe (I'm reading http://hadoop.apache.org/zookeeper/docs/current/recipes.html#sc_recipes_Locks ) . What would prevent us from using it is the lack of first scheduling a lock (creating the node) and then doing the blocking logic. We realize this is potentially more work, but there may be some very high reader contention and we need to ensure that a single writer process doesn't starve. There is the added benefit of being able to observe the finite list of readers that must complete before the writer can lock. Other than that, if the existing WriteLock had shared/exclusive coexisting and a block-until-timeout construct, we would probably prefer to spend our time integrating that code than crafting up our own. It may well be that the {{SharedExclusiveLock.java}} file has too many production concerns in it and doesn't suite the goal of a recipe file. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch, ZOOKEEPER-767.patch, > ZOOKEEPER-767.patch > > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Attachment: ZOOKEEPER-767.patch 1) Moving lock-ownership checks before we perform a zookeeper action. 2) Wrapping any code that may throw an exception after creating a lock file with a catch block that will delete the lock file and propagate the exception up the call stack. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch, ZOOKEEPER-767.patch, > ZOOKEEPER-767.patch > > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875336#action_12875336 ] Sam Baskinger commented on ZOOKEEPER-767: - Thanks for the feedback Benjamin, Replying by email removed snippets from your message. Same comments as above, but with quotes for context (and fewer smilies). Perhaps I misread the recipe or am missing the philosophy of ZK's atomicity. It wouldn't be the first time. To your points: > 1) shouldn't you check to see if you already have a lock before you do the > create? that will remove the code right after the create in the getLock() > methods. We do the create to ensure that we, at some point, will hold a lock. I do want to do the create, ensuring my turn, and then wait until I'm at the front of the line (front being defined in the exclusive or shared way). > 2) if you already have an exclusive lock, shouldn't that also count as a > shared lock? There should be a unit test that ensure that this does indeed happen, semantically. Exclusive locks block all shared access, if I take your meaning correctly. > 3) the error handling is a bit problematic. a connection loss exception or an > interrupt can leave a process holding a lock without knowing it. I thought the API guaranteed that in the event of a connection loss the EPHEMERAL creation property would guarantee that when the session timed out the file would be removed and watchers would be signaled. > 4) when you go through the children, you may end up checking for the > existence of every znode before you, which could be wasteful. All but those behind me in the line of locks. This could certainly be optimized and is something I thought about, but moved past to get the rough implementation in flight. > i think it may be better to expand the current locking code to handle shared > lock rather than add a new lock implementation. the current lock recipe > implementation only does exclusive locks, but it is implemented in a way that > makes it easy to support shared locks as well and it takes care of the > above problems. If the above 4 points hold, then extending the other implementation may be better for the community. I hope you'll include the code, but if not, we're very happy with it and appreciate ZooKeeper! Keep up the fine work. What do you think? What did I miss? :) Sam Baskinger > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch, ZOOKEEPER-767.patch > > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875334#action_12875334 ] Sam Baskinger commented on ZOOKEEPER-767: - Thanks for the feedback Benjamin, Perhaps I misread the recipe or am missing the philosophy of ZK's atomicity. It wouldn't be the first time. :) To your points: We do the create to ensure that we, at some point, will hold a lock. I do want to do the create, ensuring my turn, and then wait until I'm at the front of the line (front being defined in the exclusive or shared way). There should be a unit test that ensure that this does indeed happen, semantically. Exclusive locks block all shared access, if I take your meaning correctly. I thought the API guaranteed that in the event of a connection loss the EPHEMERAL creation property would guarantee that when the session timed out the file would be removed and watchers would be signaled. All but those behind me in the line of locks. This could certainly be optimized and is something I thought about, but moved past to get the rough implementation in flight. If the above 4 points hold, then extending the other implementation may be better for the community. :) I hope you'll include the code, but if not, we're very happy with it and appreciate ZooKeeper! Keep up the fine work. :) What do you think? What did I miss? :) Sam Baskinger > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch, ZOOKEEPER-767.patch > > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869122#action_12869122 ] Sam Baskinger commented on ZOOKEEPER-767: - Thank you for all this, Parick. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch, ZOOKEEPER-767.patch > > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Status: Patch Available (was: Open) Shared/Exclusive locking. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch > > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Attachment: (was: ZOOKEEPER-767.patch) > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch > > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Attachment: ZOOKEEPER-767.patch Implementation of a Shared/Exclusive lock per recipe page. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch > > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Attachment: ZOOKEEPER-767.patch Unit tests and recipe implementation of a SharedExclusiveLock. This new attachment contains copyright/license information for the test class. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch > > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Status: Patch Available (was: Open) This patch is the same as the previous one of the same name but with the license block added to the top of the test class. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch > > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864913#action_12864913 ] Sam Baskinger commented on ZOOKEEPER-767: - I was wondering about that! Thanks, Patrick. I've got a few moments right now to get that updated. Naive question, do I need to invalidate / reflag the issue as having a patch for the build to pick it up? Thank you! Sam Baskinger > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Attachment: (was: ZOOKEEPER-767.patch) > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Status: Patch Available (was: Open) Patch file ZOOKEEPER-767.patch contains unit tests and an updated (fixed) implementation file. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch > > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Attachment: ZOOKEEPER-767.patch Unit tests and new SharedExclusiveLock recipe implementation. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-767.patch > > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Status: Open (was: Patch Available) Submitting new patch with unit tests. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Attachment: (was: Lock.java.patch) > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Assignee: Sam Baskinger >Priority: Minor > Fix For: 3.4.0 > > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Attachment: Lock.java.patch Patch file for com.ni.zookeeper.utils.Lock. This patch should probably be renamed/repackaged after application. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Priority: Minor > Attachments: Lock.java.patch > > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sam Baskinger updated ZOOKEEPER-767: Status: Patch Available (was: Open) Release Note: New recipe code. Fix Version/s: (was: 3.4.0) The package information has not been changed as I expect the maintainers would like to give this a suitable home and class name in the code base. > Submitting Demo/Recipe Shared / Exclusive Lock Code > --- > > Key: ZOOKEEPER-767 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 > Project: Zookeeper > Issue Type: Improvement > Components: recipes >Affects Versions: 3.3.0 >Reporter: Sam Baskinger >Priority: Minor > > Networked Insights would like to share-back some code for shared/exclusive > locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-767) Submitting Demo/Recipe Shared / Exclusive Lock Code
Submitting Demo/Recipe Shared / Exclusive Lock Code --- Key: ZOOKEEPER-767 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767 Project: Zookeeper Issue Type: Improvement Components: recipes Affects Versions: 3.3.0 Reporter: Sam Baskinger Priority: Minor Networked Insights would like to share-back some code for shared/exclusive locking that we are using in our labs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.