[jira] Commented: (ZOOKEEPER-16) Need to do path validation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12668995#action_12668995 ] Mahadev konar commented on ZOOKEEPER-16: i think the we should avoid doing more work at the server and let the client handle the path checking. Doing this check in the PrepRequestPRocessor will have performance impact. On the other hand we could do some minor chekcing on the server to see if the path is null, starts with / and others... we can open up another jira for path validation on server side if you feel strongly abt it. for 2) their should be some client c libarary that should catch unicode characters .. again we can open another jira for that. for now we can go with this... Need to do path validation -- Key: ZOOKEEPER-16 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-16 Project: Zookeeper Issue Type: Bug Components: c client, java client, server Affects Versions: 3.0.0, 3.0.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.1.0 Attachments: ZOOKEEPER-16.patch, ZOOKEEPER-16.patch, ZOOKEEPER-16.patch Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1963141group_id=209147atid=1008544 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-16) Need to do path validation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12668997#action_12668997 ] Mahadev konar commented on ZOOKEEPER-16: well thinking abt it more ... - if we just do a check for path in create in prep requestprocessor then it should not be a performance impact Need to do path validation -- Key: ZOOKEEPER-16 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-16 Project: Zookeeper Issue Type: Bug Components: c client, java client, server Affects Versions: 3.0.0, 3.0.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.1.0 Attachments: ZOOKEEPER-16.patch, ZOOKEEPER-16.patch, ZOOKEEPER-16.patch Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1963141group_id=209147atid=1008544 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-16) Need to do path validation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12668760#action_12668760 ] Benjamin Reed commented on ZOOKEEPER-16: The patch looks good. there are two issues that i see: 1) we don't validate the path at the server. in some sense that is the most important place to do it. we need to put checks into PrepRequestProcessor and FinalRequestProcessor. 2) the check for C may give false positives for unicode characters. if the server check is in place, we can probably just make the client do the obvious check: c 0x00 c 0x1f and then let the server catch the rest. Need to do path validation -- Key: ZOOKEEPER-16 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-16 Project: Zookeeper Issue Type: Bug Components: c client, java client, server Affects Versions: 3.0.0, 3.0.1 Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.1.0 Attachments: ZOOKEEPER-16.patch, ZOOKEEPER-16.patch, ZOOKEEPER-16.patch Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1963141group_id=209147atid=1008544 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-16) Need to do path validation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12655066#action_12655066 ] Patrick Hunt commented on ZOOKEEPER-16: --- Hm, I didn't think of IAE, that's a good idea. I didn't know about the concept of not having checked excep on async either, that's an interesting idea. Can we document that somewhere? perhaps the internals documentation in forrest? I'll update the patch to use IAE. Need to do path validation -- Key: ZOOKEEPER-16 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-16 Project: Zookeeper Issue Type: Bug Components: c client, java client, server Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.1.0 Attachments: ZOOKEEPER-16.patch Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1963141group_id=209147atid=1008544 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-16) Need to do path validation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12626228#action_12626228 ] Patrick Hunt commented on ZOOKEEPER-16: --- As part of this fix we need to verify that the patch specified by the user is non-null. Need to do path validation -- Key: ZOOKEEPER-16 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-16 Project: Zookeeper Issue Type: Bug Components: c client, java client, server Reporter: Patrick Hunt Assignee: Benjamin Reed Fix For: 3.1.0 Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1963141group_id=209147atid=1008544 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-16) Need to do path validation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12614016#action_12614016 ] Patrick Hunt commented on ZOOKEEPER-16: --- Are we validating that the path is not null? See ZOOKEEPER-77 which seems to be throwing an NPE due to null path. Need to do path validation -- Key: ZOOKEEPER-16 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-16 Project: Zookeeper Issue Type: Bug Components: c client, java client, server Reporter: Patrick Hunt Assignee: Benjamin Reed Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1963141group_id=209147atid=1008544 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-16) Need to do path validation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12605385#action_12605385 ] Benjamin Reed commented on ZOOKEEPER-16: The following characters cannot be used because they don't display well (or render in confusing ways): * overlong encodings * \u (we use null terminated strings!) * \u0001-\u0019,\u00-\u009F. * '.' and '..' cannot be path elements. For example, the following would be invalid paths '/a/b/./c' and '/a/b/../c'. (This could result in confusion since ZooKeeper does not use relative references.) * The following characters are also not valid for use \ud800-\uf8ff, \ufff0-\u, \uXfffe-\uX (where X is 1 to e), \uf-\uf Any of these violations should result in an error, decoding should stop, and an exception thrown or error returned. Need to do path validation -- Key: ZOOKEEPER-16 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-16 Project: Zookeeper Issue Type: Bug Components: c client, java client, server Reporter: Patrick Hunt Assignee: Benjamin Reed Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1963141group_id=209147atid=1008544 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
