[jira] Commented: (ZOOKEEPER-371) to implement jdiff
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12701970#action_12701970 ] Hudson commented on ZOOKEEPER-371: -- Integrated in ZooKeeper-trunk #288 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/288/]) . jdiff documentation included in build/release to implement jdiff --- Key: ZOOKEEPER-371 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.2.0 Environment: to implement jdiff Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: zookeeper-371.patch, zookeeper-371.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12701451#action_12701451 ] Hadoop QA commented on ZOOKEEPER-371: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12406100/zookeeper-371.patch against trunk revision 766897. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 142 release audit warnings (more than the trunk's current 105 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/46/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/46/artifact/trunk/current/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/46/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/46/console This message is automatically generated. to implement jdiff --- Key: ZOOKEEPER-371 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.2.0 Environment: to implement jdiff Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: zookeeper-371.patch, zookeeper-371.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12701379#action_12701379 ] Giridharan Kesavan commented on ZOOKEEPER-371: -- I'm working on recreating this patch to exclude the jute package. -tnx to implement jdiff --- Key: ZOOKEEPER-371 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.2.0 Environment: to implement jdiff Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: zookeeper-371.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12700652#action_12700652 ] Giridharan Kesavan commented on ZOOKEEPER-371: -- -1 for the release audit is expected as the jdiff is creating files on the fly; but for the author tags I think I should talk to Nigel tnx! to implement jdiff --- Key: ZOOKEEPER-371 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.2.0 Environment: to implement jdiff Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: zookeeper-371.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12700239#action_12700239 ] Mahadev konar commented on ZOOKEEPER-371: - giri can you take a look at this? is this expected? to implement jdiff --- Key: ZOOKEEPER-371 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.2.0 Environment: to implement jdiff Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: zookeeper-371.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12699852#action_12699852 ] Mahadev konar commented on ZOOKEEPER-371: - +1 on the patch . I ll wait for hudson to run through it. to implement jdiff --- Key: ZOOKEEPER-371 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.2.0 Environment: to implement jdiff Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: zookeeper-371.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12698818#action_12698818 ] Benjamin Reed commented on ZOOKEEPER-371: - shouldn't this be generated rather than checked in? to implement jdiff --- Key: ZOOKEEPER-371 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.2.0 Environment: to implement jdiff Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: zookeeper-371.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12699034#action_12699034 ] Giridharan Kesavan commented on ZOOKEEPER-371: -- Please correct me if I'm wrong. patch contains api for 3.1.1(zookeeper_3.1.1.xml) and tha api-xml target would generate the api doc for 3.2.0(trunk version) This 3.1.1 api doc is required to compare the api changes b/w 3.1.1 and 3.2.0. Thanks, to implement jdiff --- Key: ZOOKEEPER-371 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.2.0 Environment: to implement jdiff Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: zookeeper-371.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-371) to implement jdiff
[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12699037#action_12699037 ] Mahadev konar commented on ZOOKEEPER-371: - giri, I think what ben meant was -- run jdiff on svn trunk and then run jdiff on svn trunk+patch. If their is a change then we -1 the patch. That way we do not need to check in the 3.1.1 api docs. can we do that or doing what you suggest is the right way to go? to implement jdiff --- Key: ZOOKEEPER-371 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.2.0 Environment: to implement jdiff Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: zookeeper-371.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
