[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709194#action_12709194 ] Mahadev konar commented on ZOOKEEPER-395: - yeah the patch looks good. .. Ill take a final look at it and commit it later today > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch, ZOOKEEPER-395.patch, > ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709191#action_12709191 ] Mahadev konar commented on ZOOKEEPER-395: - well, it turns out that the seg fault is a bug in c library ZOOKEEPER-402. :). > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch, ZOOKEEPER-395.patch, > ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709188#action_12709188 ] Henry Robinson commented on ZOOKEEPER-395: -- This is my to-do list (not in order of priority): 1. Finish test coverage 2. Move from shell script to pyant / nose for testing 3. Test against Python 2.6, investigate 3.0 4. Make watcher arguments optional 5. Design and implement a wrapper object 6. Add a way to get the numeric error code of the last call made (as failures are exposed as exceptions with string messages) 7. Add docstrings to the module None of these seem serious enough to block the commit, in my opinion. I think the most important one is probably to test against 2.6 and I'll do that soon. > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch, ZOOKEEPER-395.patch, > ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709166#action_12709166 ] Patrick Hunt commented on ZOOKEEPER-395: +1 -- sounds to me like this is ready to commit. are there any issues that must be addressed before commit? > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch, ZOOKEEPER-395.patch, > ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709165#action_12709165 ] Patrick Hunt commented on ZOOKEEPER-395: chmod in build.xml shouldn't be necessary - the committer will set the exec flag before committing. NOTE to comitter: be sure to set the exec flag. ;-) > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch, ZOOKEEPER-395.patch, > ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709149#action_12709149 ] Mahadev konar commented on ZOOKEEPER-395: - yes I do have the snapshot and am actually trying to see why it failed. Ill update on the jira in some time... > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch, ZOOKEEPER-395.patch, > ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709144#action_12709144 ] Henry Robinson commented on ZOOKEEPER-395: -- Still, I'd like to know why it crashed - do you still have the snapshot lying around? (and if so, is it possible to send my way for me to start a server against?) If the crash was in the C library then that's ok (from my perspective :)) as it sounds like you had changed something. If it crashed in the module that's a worry. > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch, ZOOKEEPER-395.patch, > ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[
https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709129#action_12709129
]
Mahadev konar commented on ZOOKEEPER-395:
-
yeah, I think its fine in 2.*/site-packages.
I tried running zk.py against a local zk server and this is what I got
{code}
onnecting to localhost:2181 --
Connected, handle is 0
Creating sequence node 0 0
Creating sequence node 1 0
Creating sequence node 2 0
Creating sequence node 3 0
Creating sequence node 4 0
ZNode tree --
|---/ ::
|---/zk-python :: data
|---/zk-python/sequencenode03 :: data
|---/zk-python/sequencenode04 :: data
|---/zk-python/sequencenode01 :: data
|---/zk-python/sequencenode02 :: data
|---/zk-python/sequencenode00 :: data
Segmentation fault
{code}
is zk.py working for you henry?
> Python bindings
> ---
>
> Key: ZOOKEEPER-395
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395
> Project: Zookeeper
> Issue Type: New Feature
>Affects Versions: 3.2.0
>Reporter: Henry Robinson
>Assignee: Henry Robinson
> Attachments: ZOOKEEPER-395.patch, ZOOKEEPER-395.patch,
> ZOOKEEPER-395.patch
>
>
> ZooKeeper doesn't have Python bindings. Having them would be useful, and
> would complement the extant Perl bindings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[
https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709137#action_12709137
]
Todd Lipcon commented on ZOOKEEPER-395:
---
bq. Both the server script and the test script (zkServer.sh and run_tests.sh in
zkpython/src/test) need their executable bits set which is not preserved by
this patch. Until they are chmodded, ant will not be able to run the tests
correctly.
Can you add a chmod task to the build.xml? Something like the following:
{code:xml}
{code}
and then make the test target depend on it?
> Python bindings
> ---
>
> Key: ZOOKEEPER-395
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395
> Project: Zookeeper
> Issue Type: New Feature
>Affects Versions: 3.2.0
>Reporter: Henry Robinson
>Assignee: Henry Robinson
> Attachments: ZOOKEEPER-395.patch, ZOOKEEPER-395.patch,
> ZOOKEEPER-395.patch
>
>
> ZooKeeper doesn't have Python bindings. Having them would be useful, and
> would complement the extant Perl bindings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709136#action_12709136 ] Mahadev konar commented on ZOOKEEPER-395: - hmm that was it... it wasnt a clean server ... I wonder why it just crashed... I mgiht have had a version of zk database I was doing some testing on :) ... > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch, ZOOKEEPER-395.patch, > ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709131#action_12709131 ] Henry Robinson commented on ZOOKEEPER-395: -- Yes, it works for me - looks like it's crashing for you halfway through the ZK tree, probably when it's reading the /zookeeper directory. Is this a clean server? Running against the latest module version (0.3), using python 2.3? > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch, ZOOKEEPER-395.patch, > ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709121#action_12709121 ] Henry Robinson commented on ZOOKEEPER-395: -- You're right - I think Python searches for modules by filename (certainly when I just tried renaming it, it would no longer import, although there may be more going on behind the scenes), so we would have to write import zookeeper_py which is a bit clunky to me. zookeeper.so goes in the local Python/2.5/site-packages directory on my machine which might make the differentiation clear. Even if we wrap it, it seems like we'd want *some* module to be called zookeeper eventually :) > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch, ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709117#action_12709117 ] Patrick Hunt commented on ZOOKEEPER-395: Mahadev, I believe the lib name is linked to the "import xxx" that's done in the python code. (user code currently), which is probably why Henry did it this way. However we will be putting an OO wrapper anyway, right? So perhaps renaming isn't such a big deal...? > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch, ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709106#action_12709106 ] Mahadev konar commented on ZOOKEEPER-395: - also, the library created should have a name like zookeeper_py.so ... so that users do not get confused by the name zookeeper.so. > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch, ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[
https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709105#action_12709105
]
Mahadev konar commented on ZOOKEEPER-395:
-
yes, adding the warning in README would be good. We dont have to do all the
installation in ant but just specifying what to install and what version of
python to use is good enough to have in README. Also, it will be good to have
it in the README saying whcih versions of python's we have tried running
successfully against.
Also just a minor change in README.
{code}
python setup.py build
sudo python setup.py install
from zookeeper/src/contrib/zkpython/.
{code}
should be
{code}
python src/python/setup.py build
sudo python src/python/setup.py install
from zookeeper/src/contrib/zkpython/.
{code}
> Python bindings
> ---
>
> Key: ZOOKEEPER-395
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395
> Project: Zookeeper
> Issue Type: New Feature
>Affects Versions: 3.2.0
>Reporter: Henry Robinson
>Assignee: Henry Robinson
> Attachments: ZOOKEEPER-395.patch, ZOOKEEPER-395.patch
>
>
> ZooKeeper doesn't have Python bindings. Having them would be useful, and
> would complement the extant Perl bindings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709066#action_12709066 ] Henry Robinson commented on ZOOKEEPER-395: -- Hi Mahadev, Yes, you'll need the Python development headers installed. For yum-based systems these are packaged in python-devel. These are a dependency for building the module, but not installing it. I'm not sure if adding ant rules to automatically download the package is the right thing to do, as people often like to manage those things themselves, and version matching will be complex. I should at least add a warning to the readme. I think that the module will build correctly against 2.3 (and I'll be really interested to hear about your experiences when you get Python.h installed), however it certainly won't build against anything earlier than that (as PyGIL* were introduced in 2.3 which we need to get callbacks working). I don't use many fancy features, so I hope to be safe. I've built it against 2.5.1 here, and have a 2.6 system I can try. I expect 3.0 might have changed the API though, so I doubt the module will work there. > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch, ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709061#action_12709061 ] Mahadev konar commented on ZOOKEEPER-395: - ok I figured it out, I had to install python-devel package. > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch, ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[
https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709051#action_12709051
]
Mahadev konar commented on ZOOKEEPER-395:
-
henry,
I tried installing the python module to see how it works but I am getting
this error while building
{code}
src/c/zookeeper.c:19:20: Python.h: No such file or directory
src/c/zookeeper.c:31: error: syntax error before "PyObject"
{code}
and it fails to compile with lot more errors.
This looks like some headers not availiable with my python setup. I have python
2.3 installed. Do I need to install some version greater than 2.3? or some
other python module?
> Python bindings
> ---
>
> Key: ZOOKEEPER-395
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395
> Project: Zookeeper
> Issue Type: New Feature
>Affects Versions: 3.2.0
>Reporter: Henry Robinson
>Assignee: Henry Robinson
> Attachments: ZOOKEEPER-395.patch, ZOOKEEPER-395.patch
>
>
> ZooKeeper doesn't have Python bindings. Having them would be useful, and
> would complement the extant Perl bindings.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708988#action_12708988 ] Patrick Hunt commented on ZOOKEEPER-395: shell script would probably be the simplest. I did notice: http://code.google.com/p/pyanttasks/ specifically the py-test task but that would require users to copy the ant task to their ant directory, that might be ok, pyanttasks is under apache license so it could be included in the rel, also build.xml itself could have a "test-setup" target that copies pyanttasks into ant install directory. regardless you'll need to start/stop the server in order to run the python tests. Take a look at the rest contrib for an example of what I did for that. > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch, ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708772#action_12708772 ] Mahadev konar commented on ZOOKEEPER-395: - for the tests, you could write a shell script that would run all the python unit tests and exec that script from the build.xml. would that work? also, is their any requirements for python versions? > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch, ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708634#action_12708634 ] Henry Robinson commented on ZOOKEEPER-395: -- Yes they're in hand - I didn't get much time to work on them yesterday but I've knocked a couple off today. > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708621#action_12708621 ] Mahadev konar commented on ZOOKEEPER-395: - henry, are you going to add tests to this patch? > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708335#action_12708335 ] Hadoop QA commented on ZOOKEEPER-395: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12407797/ZOOKEEPER-395.patch against trunk revision 772843. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/70/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/70/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/70/console This message is automatically generated. > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708153#action_12708153 ] Patrick Hunt commented on ZOOKEEPER-395: No worries. We appreciate you taking the time to contribute back to the community! Either way you handle 3 is fine w/me. > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708128#action_12708128 ] Henry Robinson commented on ZOOKEEPER-395: -- Thanks for the info - as you can tell I'm still getting up to speed with the Jira workflow and am still pretty clumsy with it. Thanks for your patience! 3) Will do, although I might not have the chance to do so until this evening. I was planning to write a suite of unittest-based tests as well, so I'll add those to test and figure out the build.xml incantations at the same time. > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12708124#action_12708124 ] Patrick Hunt commented on ZOOKEEPER-395: Great! A few fyis: 1) hadoopqabot only triggers on submit, so if you want to re-run the static verifications cancel and resubmit the patch after attaching the new patch file 2) if you update a patch just attach with the same name - jira will be able to track the changes that way (the latest file, if dup names, will be highlighted). don't delete the old patch (in general) 3) why not consider zk.py your smoketest/test? Move it into the test directory, we'll work out the build.xml changes necessary to build/test/package next. including adding the ability to run unit/func tests from build.xml. > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707977#action_12707977 ] Flavio Paiva Junqueira commented on ZOOKEEPER-395: -- Henry, you have to add the license header to the new files, otherwise the release audit test will fail. > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707974#action_12707974 ] Hadoop QA commented on ZOOKEEPER-395: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12407751/ZOOKEEPER-395.patch against trunk revision 772843. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 159 release audit warnings (more than the trunk's current 156 warnings). -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/67/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/67/artifact/trunk/current/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/67/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/67/console This message is automatically generated. > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-395) Python bindings
[ https://issues.apache.org/jira/browse/ZOOKEEPER-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707580#action_12707580 ] Patrick Hunt commented on ZOOKEEPER-395: Wow, this is great! Thanks Henry. I was able to successfully build and attach to a running zookeeper server (linux). I looked at doing a python binding recently but I'm afraid while I'm a decent python programmer I don't know a thing about the python/c/c++ binding. I see you used the direct layer (rather than pyrex or something), that's hard core. We'd love to include this. If you could resubmit the patch with: 1) put it into the src/contrib/zkpython directory (perl is in zkperl) 2) c++ probably in src/contrib/zkpython/src/c++ 3) python probably in src/contrib/zkpython/src/python 4) python based tests probably in src/contrib/zkpython/src/test 5) README.txt in src/contrib/zkpython > Python bindings > --- > > Key: ZOOKEEPER-395 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-395 > Project: Zookeeper > Issue Type: New Feature >Affects Versions: 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson > Attachments: ZOOKEEPER-395.patch > > > ZooKeeper doesn't have Python bindings. Having them would be useful, and > would complement the extant Perl bindings. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
