[jira] Commented: (ZOOKEEPER-447) zkServer.sh doesn't allow different config files to be specified on the command line
[ https://issues.apache.org/jira/browse/ZOOKEEPER-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739429#action_12739429 ] Hudson commented on ZOOKEEPER-447: -- Integrated in ZooKeeper-trunk #405 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/405/]) . zkServer.sh doesn't allow different config files to be specified on the command line > zkServer.sh doesn't allow different config files to be specified on the > command line > > > Key: ZOOKEEPER-447 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-447 > Project: Zookeeper > Issue Type: Improvement >Affects Versions: 3.1.1, 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson >Priority: Minor > Fix For: 3.2.1, 3.3.0 > > Attachments: ZOOKEEPER-447.patch > > > Unless I'm missing something, you can change the directory that the zoo.cfg > file is in by setting ZOOCFGDIR but not the name of the file itself. > I find it convenient myself to specify the config file on the command line, > but we should also let it be specified by environment variable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-447) zkServer.sh doesn't allow different config files to be specified on the command line
[ https://issues.apache.org/jira/browse/ZOOKEEPER-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729338#action_12729338 ] Mahadev konar commented on ZOOKEEPER-447: - this looks ready to go in since 3.2 is out. Ill wait until we decide on what we want in 3.2.1. > zkServer.sh doesn't allow different config files to be specified on the > command line > > > Key: ZOOKEEPER-447 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-447 > Project: Zookeeper > Issue Type: Improvement >Affects Versions: 3.1.1, 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson >Priority: Minor > Fix For: 3.2.1, 3.3.0 > > Attachments: ZOOKEEPER-447.patch > > > Unless I'm missing something, you can change the directory that the zoo.cfg > file is in by setting ZOOCFGDIR but not the name of the file itself. > I find it convenient myself to specify the config file on the command line, > but we should also let it be specified by environment variable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-447) zkServer.sh doesn't allow different config files to be specified on the command line
[ https://issues.apache.org/jira/browse/ZOOKEEPER-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724383#action_12724383 ] Hadoop QA commented on ZOOKEEPER-447: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12411795/ZOOKEEPER-447.patch against trunk revision 788539. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/138/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/138/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/138/console This message is automatically generated. > zkServer.sh doesn't allow different config files to be specified on the > command line > > > Key: ZOOKEEPER-447 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-447 > Project: Zookeeper > Issue Type: Improvement >Affects Versions: 3.1.1, 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson >Priority: Minor > Attachments: ZOOKEEPER-447.patch > > > Unless I'm missing something, you can change the directory that the zoo.cfg > file is in by setting ZOOCFGDIR but not the name of the file itself. > I find it convenient myself to specify the config file on the command line, > but we should also let it be specified by environment variable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-447) zkServer.sh doesn't allow different config files to be specified on the command line
[ https://issues.apache.org/jira/browse/ZOOKEEPER-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724136#action_12724136 ] Benjamin Reed commented on ZOOKEEPER-447: - +1 good idea > zkServer.sh doesn't allow different config files to be specified on the > command line > > > Key: ZOOKEEPER-447 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-447 > Project: Zookeeper > Issue Type: Improvement >Affects Versions: 3.1.1, 3.2.0 >Reporter: Henry Robinson >Assignee: Henry Robinson >Priority: Minor > Attachments: ZOOKEEPER-447.patch > > > Unless I'm missing something, you can change the directory that the zoo.cfg > file is in by setting ZOOCFGDIR but not the name of the file itself. > I find it convenient myself to specify the config file on the command line, > but we should also let it be specified by environment variable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.