[jira] Commented: (ZOOKEEPER-524) DBSizeTest is not really testing anything
[ https://issues.apache.org/jira/browse/ZOOKEEPER-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836149#action_12836149 ] Hudson commented on ZOOKEEPER-524: -- Integrated in ZooKeeper-trunk #702 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/702/]) . DBSizeTest is not really testing anything > DBSizeTest is not really testing anything > - > > Key: ZOOKEEPER-524 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-524 > Project: Zookeeper > Issue Type: Bug > Components: server, tests >Reporter: Patrick Hunt >Assignee: Benjamin Reed >Priority: Minor > Fix For: 3.3.0 > > > DBSizeTest looks like it should be testing latency, but it doesn't seem to do > it (assert is commented out). > We need to decide if this test should be fixed, or just dropped. > Also note: this test takes 40seconds on my system. Way too long. Perhaps > async create operations should be used > to populate the database. I also noticed that data size has a big impact on > overall test time (1k vs 5 bytes is something > like a 2x time diff for time to run the test). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-524) DBSizeTest is not really testing anything
[ https://issues.apache.org/jira/browse/ZOOKEEPER-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831170#action_12831170 ] Mahadev konar commented on ZOOKEEPER-524: - its a little tricky to have latency tests as a part of unit testing. I think we should remove it. ben are you going to remove the file and commit? > DBSizeTest is not really testing anything > - > > Key: ZOOKEEPER-524 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-524 > Project: Zookeeper > Issue Type: Bug > Components: server, tests >Reporter: Patrick Hunt >Assignee: Benjamin Reed >Priority: Minor > Fix For: 3.3.0 > > > DBSizeTest looks like it should be testing latency, but it doesn't seem to do > it (assert is commented out). > We need to decide if this test should be fixed, or just dropped. > Also note: this test takes 40seconds on my system. Way too long. Perhaps > async create operations should be used > to populate the database. I also noticed that data size has a big impact on > overall test time (1k vs 5 bytes is something > like a 2x time diff for time to run the test). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-524) DBSizeTest is not really testing anything
[ https://issues.apache.org/jira/browse/ZOOKEEPER-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829283#action_12829283 ] Flavio Paiva Junqueira commented on ZOOKEEPER-524: -- I must agree that the test awkward. Now, it takes 2 seconds on my laptop, so I don't understand why it takes 40 seconds on your computer, Pat. I think the idea of the test is not bad, but the implementation could be improved. For example, we could check if the latency if at most 10% higher after populating (10% is an arbitrary number, since it will be impossible to get exact values). If you guys feel strongly about removing it, I don't object and +1 it. > DBSizeTest is not really testing anything > - > > Key: ZOOKEEPER-524 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-524 > Project: Zookeeper > Issue Type: Bug > Components: server, tests >Reporter: Patrick Hunt >Assignee: Benjamin Reed >Priority: Minor > Fix For: 3.3.0 > > > DBSizeTest looks like it should be testing latency, but it doesn't seem to do > it (assert is commented out). > We need to decide if this test should be fixed, or just dropped. > Also note: this test takes 40seconds on my system. Way too long. Perhaps > async create operations should be used > to populate the database. I also noticed that data size has a big impact on > overall test time (1k vs 5 bytes is something > like a 2x time diff for time to run the test). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-524) DBSizeTest is not really testing anything
[ https://issues.apache.org/jira/browse/ZOOKEEPER-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829267#action_12829267 ] Hadoop QA commented on ZOOKEEPER-524: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org against trunk revision 903483. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no tests are needed for this patch. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/63/console This message is automatically generated. > DBSizeTest is not really testing anything > - > > Key: ZOOKEEPER-524 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-524 > Project: Zookeeper > Issue Type: Bug > Components: server, tests >Reporter: Patrick Hunt >Assignee: Benjamin Reed >Priority: Minor > Fix For: 3.3.0 > > > DBSizeTest looks like it should be testing latency, but it doesn't seem to do > it (assert is commented out). > We need to decide if this test should be fixed, or just dropped. > Also note: this test takes 40seconds on my system. Way too long. Perhaps > async create operations should be used > to populate the database. I also noticed that data size has a big impact on > overall test time (1k vs 5 bytes is something > like a 2x time diff for time to run the test). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-524) DBSizeTest is not really testing anything
[ https://issues.apache.org/jira/browse/ZOOKEEPER-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805991#action_12805991 ] Benjamin Reed commented on ZOOKEEPER-524: - is there any objection to removing the test. (especially since it isn't doing anything?) > DBSizeTest is not really testing anything > - > > Key: ZOOKEEPER-524 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-524 > Project: Zookeeper > Issue Type: Bug > Components: server, tests >Reporter: Patrick Hunt >Assignee: Benjamin Reed >Priority: Minor > Fix For: 3.3.0 > > > DBSizeTest looks like it should be testing latency, but it doesn't seem to do > it (assert is commented out). > We need to decide if this test should be fixed, or just dropped. > Also note: this test takes 40seconds on my system. Way too long. Perhaps > async create operations should be used > to populate the database. I also noticed that data size has a big impact on > overall test time (1k vs 5 bytes is something > like a 2x time diff for time to run the test). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
