[jira] Commented: (ZOOKEEPER-614) Improper synchronisation in getClientCnxnCount

2009-12-14 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790089#action_12790089
 ] 

Hudson commented on ZOOKEEPER-614:
--

Integrated in ZooKeeper-trunk #625 (See 
[http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/625/])


> Improper synchronisation in getClientCnxnCount
> --
>
> Key: ZOOKEEPER-614
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-614
> Project: Zookeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.2.1, 3.2.2
>Reporter: Henry Robinson
>Assignee: Henry Robinson
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-614.patch
>
>
> getClientCnxnCount reads from Factory.ipMap without synchronizing. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-614) Improper synchronisation in getClientCnxnCount

2009-12-11 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789545#action_12789545
 ] 

Hadoop QA commented on ZOOKEEPER-614:
-

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12427252/ZOOKEEPER-614.patch
  against trunk revision 889797.

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 3 new or modified tests.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

+1 findbugs.  The patch does not introduce any new Findbugs warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed core unit tests.

+1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/24/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/24/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/24/console

This message is automatically generated.

> Improper synchronisation in getClientCnxnCount
> --
>
> Key: ZOOKEEPER-614
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-614
> Project: Zookeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.2.1, 3.2.2
>Reporter: Henry Robinson
>Assignee: Henry Robinson
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-614.patch
>
>
> getClientCnxnCount reads from Factory.ipMap without synchronizing. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (ZOOKEEPER-614) Improper synchronisation in getClientCnxnCount

2009-12-11 Thread Mahadev konar (JIRA)

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789530#action_12789530
 ] 

Mahadev konar commented on ZOOKEEPER-614:
-

+1 the patch looks good. ill wait for hudson to run it and will commit it... 

> Improper synchronisation in getClientCnxnCount
> --
>
> Key: ZOOKEEPER-614
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-614
> Project: Zookeeper
>  Issue Type: Bug
>  Components: server
>Affects Versions: 3.2.1, 3.2.2
>Reporter: Henry Robinson
>Assignee: Henry Robinson
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-614.patch
>
>
> getClientCnxnCount reads from Factory.ipMap without synchronizing. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.