[jira] Commented: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12623634#action_12623634 ] Hudson commented on ZOOKEEPER-82: - Integrated in ZooKeeper-trunk #58 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/58/]) > Make the ZooKeeperServer more DI friendly > - > > Key: ZOOKEEPER-82 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-82-b.patch, ZOOKEEPER-82-b.patch > > > Proposed changes were discussed in [this mailing list > thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED]: > Basic goals are: > * Decouple the current configuration system from the public API. I > see stuff like ZooKeeperServer being coupled to ServerConfig a bit. > * Allow the use of setter injection in addition to constructor > injection. This is the most important thing needed to let spring more > easily configure the objects. > * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622405#action_12622405 ] Mahadev konar commented on ZOOKEEPER-82: +1 patch looks good ... we will need to update our wiki documentation to reflect the changes in this patch... > Make the ZooKeeperServer more DI friendly > - > > Key: ZOOKEEPER-82 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: ZOOKEEPER-82-b.patch, ZOOKEEPER-82-b.patch > > > Proposed changes were discussed in [this mailing list > thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED]: > Basic goals are: > * Decouple the current configuration system from the public API. I > see stuff like ZooKeeperServer being coupled to ServerConfig a bit. > * Allow the use of setter injection in addition to constructor > injection. This is the most important thing needed to let spring more > easily configure the objects. > * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622381#action_12622381 ] Patrick Hunt commented on ZOOKEEPER-82: --- I'm +1 on this patch btw, looks like a good change. > Make the ZooKeeperServer more DI friendly > - > > Key: ZOOKEEPER-82 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: ZOOKEEPER-82-b.patch, ZOOKEEPER-82-b.patch > > > Proposed changes were discussed in [this mailing list > thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED]: > Basic goals are: > * Decouple the current configuration system from the public API. I > see stuff like ZooKeeperServer being coupled to ServerConfig a bit. > * Allow the use of setter injection in addition to constructor > injection. This is the most important thing needed to let spring more > easily configure the objects. > * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617028#action_12617028 ] Hiram Chirino commented on ZOOKEEPER-82: created issue ZOOKEEPER-100 to track that Thread change idea. > Make the ZooKeeperServer more DI friendly > - > > Key: ZOOKEEPER-82 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: ZOOKEEPER-82-b.patch > > > Proposed changes were discussed in [this mailing list > thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED]: > Basic goals are: > * Decouple the current configuration system from the public API. I > see stuff like ZooKeeperServer being coupled to ServerConfig a bit. > * Allow the use of setter injection in addition to constructor > injection. This is the most important thing needed to let spring more > easily configure the objects. > * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616954#action_12616954 ] Hiram Chirino commented on ZOOKEEPER-82: Weird the patch did not change QuorumPeer at all. QuorumPeer did not currently have a main method. Seem someone else moved it to ManagedQuorumPeer. But in my next patch I'll move those java docs and update the scripts. Yes main was moved from ZooKeeperServer to new class which my patch failed to include. Sorry I'll to a attach a new patch asap. Will also add some doco for the getters/setters. BTW > Make the ZooKeeperServer more DI friendly > - > > Key: ZOOKEEPER-82 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: ZOOKEEPER-82.patch > > > Proposed changes were discussed in [this mailing list > thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED]: > Basic goals are: > * Decouple the current configuration system from the public API. I > see stuff like ZooKeeperServer being coupled to ServerConfig a bit. > * Allow the use of setter injection in addition to constructor > injection. This is the most important thing needed to let spring more > easily configure the objects. > * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616164#action_12616164 ] Patrick Hunt commented on ZOOKEEPER-82: --- select "submit patch" so that it will be more visible in jira as needing to be reviewed/voted. btw, I documented the zk "howtocontribute" process last night: http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute > Make the ZooKeeperServer more DI friendly > - > > Key: ZOOKEEPER-82 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: ZOOKEEPER-82.patch > > > Proposed changes were discussed in [this mailing list > thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED]: > Basic goals are: > * Decouple the current configuration system from the public API. I > see stuff like ZooKeeperServer being coupled to ServerConfig a bit. > * Allow the use of setter injection in addition to constructor > injection. This is the most important thing needed to let spring more > easily configure the objects. > * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616025#action_12616025 ] Hiram Chirino commented on ZOOKEEPER-82: Anybody have a chance to review the patch? > Make the ZooKeeperServer more DI friendly > - > > Key: ZOOKEEPER-82 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino >Assignee: Hiram Chirino > Attachments: ZOOKEEPER-82.patch > > > Proposed changes were discussed in [this mailing list > thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED]: > Basic goals are: > * Decouple the current configuration system from the public API. I > see stuff like ZooKeeperServer being coupled to ServerConfig a bit. > * Allow the use of setter injection in addition to constructor > injection. This is the most important thing needed to let spring more > easily configure the objects. > * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-82) Make the ZooKeeperServer more DI friendly
[ https://issues.apache.org/jira/browse/ZOOKEEPER-82?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615381#action_12615381 ] Hiram Chirino commented on ZOOKEEPER-82: While implementing this.. some smelly issues kinda poped out at me. The jmx stuff wants to be able to access the client port, to avoid tight coupling the jmx stuff to the ServerConfig stuff, I added a clientPort field to the ZKServer. Now that seems a little smelly cause I can imagine that the ZKServer could in theory one day be extended to operate on multiple ports. In QuorumPeer, the constructor used to initialize sockets and other usefull bits. To support setter based injection, I moved this initialization to the start() method, so that users can: {code} QuorumPeer qp = new QuorumPeer(); qp.setDataLogDir( dir ); // more setter injection qp.start(); {code} The big difference is that QuorumPeer used to throw an IOException if the initialization failed, now that exception occurs on qp.start() instead and it is wrapped up as a RuntimeException since it's extending the Thread.start() method which does not allow IOExceptions to be thrown. Perhaps QuorumPeer should implement Runnable instead of extending Thread so that a start() method can be defined which does have the right signature. > Make the ZooKeeperServer more DI friendly > - > > Key: ZOOKEEPER-82 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-82 > Project: Zookeeper > Issue Type: Improvement > Components: server >Reporter: Hiram Chirino > Attachments: ZOOKEEPER-82.patch > > > Proposed changes were discussed in [this mailing list > thread|http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-dev/200807.mbox/[EMAIL > PROTECTED]: > Basic goals are: > * Decouple the current configuration system from the public API. I > see stuff like ZooKeeperServer being coupled to ServerConfig a bit. > * Allow the use of setter injection in addition to constructor > injection. This is the most important thing needed to let spring more > easily configure the objects. > * Move the main() methods out of the ZooKeeperServer class. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.