[jira] Commented: (ZOOKEEPER-864) Hedwig C++ client improvements
[ https://issues.apache.org/jira/browse/ZOOKEEPER-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920160#action_12920160 ] Hudson commented on ZOOKEEPER-864: -- Integrated in ZooKeeper-trunk #964 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/964/]) ZOOKEEPER-864. Hedwig C++ client improvements > Hedwig C++ client improvements > -- > > Key: ZOOKEEPER-864 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-864 > Project: Zookeeper > Issue Type: Improvement >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 3.4.0 > > Attachments: warnings.txt, ZOOKEEPER-864.diff, ZOOKEEPER-864.diff, > ZOOKEEPER-864.diff, ZOOKEEPER-864.diff > > > I changed the socket code to use boost asio. Now the client only creates one > thread, and all operations are non-blocking. > Tests are now automated, just run "make check". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-864) Hedwig C++ client improvements
[ https://issues.apache.org/jira/browse/ZOOKEEPER-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913102#action_12913102 ] Hadoop QA commented on ZOOKEEPER-864: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12454033/ZOOKEEPER-864.diff against trunk revision 998200. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 34 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. -1 release audit. The applied patch generated 27 release audit warnings (more than the trunk's current 26 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/117/testReport/ Release audit warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/117/artifact/trunk/patchprocess/releaseAuditDiffWarnings.txt Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/117/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/117/console This message is automatically generated. > Hedwig C++ client improvements > -- > > Key: ZOOKEEPER-864 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-864 > Project: Zookeeper > Issue Type: Improvement >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 3.4.0 > > Attachments: warnings.txt, ZOOKEEPER-864.diff, ZOOKEEPER-864.diff, > ZOOKEEPER-864.diff > > > I changed the socket code to use boost asio. Now the client only creates one > thread, and all operations are non-blocking. > Tests are now automated, just run "make check". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-864) Hedwig C++ client improvements
[ https://issues.apache.org/jira/browse/ZOOKEEPER-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909002#action_12909002 ] Erwin Tam commented on ZOOKEEPER-864: - +1 Latest patch looks good to me. We can just approve it and push it in first. Thanks for the great work Ivan! > Hedwig C++ client improvements > -- > > Key: ZOOKEEPER-864 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-864 > Project: Zookeeper > Issue Type: Improvement >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 3.4.0 > > Attachments: warnings.txt, ZOOKEEPER-864.diff, ZOOKEEPER-864.diff, > ZOOKEEPER-864.diff > > > I changed the socket code to use boost asio. Now the client only creates one > thread, and all operations are non-blocking. > Tests are now automated, just run "make check". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-864) Hedwig C++ client improvements
[ https://issues.apache.org/jira/browse/ZOOKEEPER-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908666#action_12908666 ] Ivan Kelly commented on ZOOKEEPER-864: -- Yes, you are absolutely right. Unless we don't "install" protocol.h at all and try to remove it from the hedwig public headers. I remember the protocol.h stuff was causing you problems recently so this could resolve that issue too. > Hedwig C++ client improvements > -- > > Key: ZOOKEEPER-864 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-864 > Project: Zookeeper > Issue Type: Improvement >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 3.4.0 > > Attachments: warnings.txt, ZOOKEEPER-864.diff, ZOOKEEPER-864.diff, > ZOOKEEPER-864.diff > > > I changed the socket code to use boost asio. Now the client only creates one > thread, and all operations are non-blocking. > Tests are now automated, just run "make check". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-864) Hedwig C++ client improvements
[ https://issues.apache.org/jira/browse/ZOOKEEPER-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907785#action_12907785 ] Erwin Tam commented on ZOOKEEPER-864: - Ivan, the changes look good to me. One question though, do we need to include the auto-generated protocol.h header to the Makefile.am? I had to do that step manually a couple of weeks ago otherwise things didn't work when using the hedwig client libs generated. > Hedwig C++ client improvements > -- > > Key: ZOOKEEPER-864 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-864 > Project: Zookeeper > Issue Type: Improvement >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 3.4.0 > > Attachments: warnings.txt, ZOOKEEPER-864.diff, ZOOKEEPER-864.diff, > ZOOKEEPER-864.diff > > > I changed the socket code to use boost asio. Now the client only creates one > thread, and all operations are non-blocking. > Tests are now automated, just run "make check". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-864) Hedwig C++ client improvements
[ https://issues.apache.org/jira/browse/ZOOKEEPER-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906982#action_12906982 ] Michi Mutsuzaki commented on ZOOKEEPER-864: --- +1. The latest patch compiles cleanly with no warnings. Cool! I'm using gcc 3.4.6. $ /usr/bin/g++ --version g++ (GCC) 3.4.6 20060404 (Red Hat 3.4.6-9) --Michi > Hedwig C++ client improvements > -- > > Key: ZOOKEEPER-864 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-864 > Project: Zookeeper > Issue Type: Improvement >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 3.4.0 > > Attachments: warnings.txt, ZOOKEEPER-864.diff, ZOOKEEPER-864.diff, > ZOOKEEPER-864.diff > > > I changed the socket code to use boost asio. Now the client only creates one > thread, and all operations are non-blocking. > Tests are now automated, just run "make check". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-864) Hedwig C++ client improvements
[ https://issues.apache.org/jira/browse/ZOOKEEPER-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906537#action_12906537 ] Ivan Kelly commented on ZOOKEEPER-864: -- Fixed all warnings. New patch attached. > Hedwig C++ client improvements > -- > > Key: ZOOKEEPER-864 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-864 > Project: Zookeeper > Issue Type: Improvement >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 3.4.0 > > Attachments: warnings.txt, ZOOKEEPER-864.diff, ZOOKEEPER-864.diff > > > I changed the socket code to use boost asio. Now the client only creates one > thread, and all operations are non-blocking. > Tests are now automated, just run "make check". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-864) Hedwig C++ client improvements
[ https://issues.apache.org/jira/browse/ZOOKEEPER-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906471#action_12906471 ] Ivan Kelly commented on ZOOKEEPER-864: -- Ah, these are all trivial to fix. I wonder why none of the compilers I used flagged them though. What version of gcc are you using? -Ivan > Hedwig C++ client improvements > -- > > Key: ZOOKEEPER-864 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-864 > Project: Zookeeper > Issue Type: Improvement >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 3.4.0 > > Attachments: warnings.txt, ZOOKEEPER-864.diff > > > I changed the socket code to use boost asio. Now the client only creates one > thread, and all operations are non-blocking. > Tests are now automated, just run "make check". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-864) Hedwig C++ client improvements
[ https://issues.apache.org/jira/browse/ZOOKEEPER-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906231#action_12906231 ] Michi Mutsuzaki commented on ZOOKEEPER-864: --- Here are my comments: - After applying the patch, I was able to compile cpp client. - I still see some compilation warnings. I'll attach the output. Thanks! --Michi > Hedwig C++ client improvements > -- > > Key: ZOOKEEPER-864 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-864 > Project: Zookeeper > Issue Type: Improvement >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-864.diff > > > I changed the socket code to use boost asio. Now the client only creates one > thread, and all operations are non-blocking. > Tests are now automated, just run "make check". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-864) Hedwig C++ client improvements
[ https://issues.apache.org/jira/browse/ZOOKEEPER-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906102#action_12906102 ] Mahadev konar commented on ZOOKEEPER-864: - michi to answer your question, all we need is a careful review. > Hedwig C++ client improvements > -- > > Key: ZOOKEEPER-864 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-864 > Project: Zookeeper > Issue Type: Improvement >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-864.diff > > > I changed the socket code to use boost asio. Now the client only creates one > thread, and all operations are non-blocking. > Tests are now automated, just run "make check". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-864) Hedwig C++ client improvements
[ https://issues.apache.org/jira/browse/ZOOKEEPER-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906077#action_12906077 ] Michi Mutsuzaki commented on ZOOKEEPER-864: --- Thanks for the patch, Ivan! What do we need to do before we can check in this patch? --Michi > Hedwig C++ client improvements > -- > > Key: ZOOKEEPER-864 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-864 > Project: Zookeeper > Issue Type: Improvement >Reporter: Ivan Kelly >Assignee: Ivan Kelly > Fix For: 3.4.0 > > Attachments: ZOOKEEPER-864.diff > > > I changed the socket code to use boost asio. Now the client only creates one > thread, and all operations are non-blocking. > Tests are now automated, just run "make check". -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.