[jira] Commented: (ZOOKEEPER-921) zkPython incorrectly checks for existence of required ACL elements
[
https://issues.apache.org/jira/browse/ZOOKEEPER-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931830#action_12931830
]
Hadoop QA commented on ZOOKEEPER-921:
-
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12459558/ZOOKEEPER-921.patch
against trunk revision 1034003.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/27//testReport/
Findbugs warnings:
https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/27//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/27//console
This message is automatically generated.
> zkPython incorrectly checks for existence of required ACL elements
> --
>
> Key: ZOOKEEPER-921
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-921
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
>Affects Versions: 3.3.1, 3.4.0
> Environment: Mac OS X 10.6.4, included Python 2.6.1
>Reporter: Nicholas Knight
>Assignee: Nicholas Knight
> Fix For: 3.3.3, 3.4.0
>
> Attachments: zktest.py, ZOOKEEPER-921.patch
>
>
> Calling {{zookeeper.create()}} seems, under certain circumstances, to be
> corrupting a subsequent call to Python's {{logging}} module.
> Specifically, if the node does not exist (but its parent does), I end up with
> a traceback like this when I try to make the logging call:
> {noformat}
> Traceback (most recent call last):
> File "zktest.py", line 21, in
> logger.error("Boom?")
> File
> "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/logging/__init__.py",
> line 1046, in error
> if self.isEnabledFor(ERROR):
> File
> "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/logging/__init__.py",
> line 1206, in isEnabledFor
> return level >= self.getEffectiveLevel()
> File
> "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/logging/__init__.py",
> line 1194, in getEffectiveLevel
> while logger:
> TypeError: an integer is required
> {noformat}
> But if the node already exists, or the parent does not exist, I get the
> appropriate NodeExists or NoNode exceptions.
> I'll be attaching a test script that can be used to reproduce this behavior.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-921) zkPython incorrectly checks for existence of required ACL elements
[
https://issues.apache.org/jira/browse/ZOOKEEPER-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12931000#action_12931000
]
Nicholas Knight commented on ZOOKEEPER-921:
---
Sorry, been swamped. I'll have time to get a proper patch posted over the
weekend.
> zkPython incorrectly checks for existence of required ACL elements
> --
>
> Key: ZOOKEEPER-921
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-921
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
>Affects Versions: 3.3.1, 3.4.0
> Environment: Mac OS X 10.6.4, included Python 2.6.1
>Reporter: Nicholas Knight
>Assignee: Nicholas Knight
> Fix For: 3.3.3, 3.4.0
>
> Attachments: zktest.py
>
>
> Calling {{zookeeper.create()}} seems, under certain circumstances, to be
> corrupting a subsequent call to Python's {{logging}} module.
> Specifically, if the node does not exist (but its parent does), I end up with
> a traceback like this when I try to make the logging call:
> {noformat}
> Traceback (most recent call last):
> File "zktest.py", line 21, in
> logger.error("Boom?")
> File
> "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/logging/__init__.py",
> line 1046, in error
> if self.isEnabledFor(ERROR):
> File
> "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/logging/__init__.py",
> line 1206, in isEnabledFor
> return level >= self.getEffectiveLevel()
> File
> "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/logging/__init__.py",
> line 1194, in getEffectiveLevel
> while logger:
> TypeError: an integer is required
> {noformat}
> But if the node already exists, or the parent does not exist, I get the
> appropriate NodeExists or NoNode exceptions.
> I'll be attaching a test script that can be used to reproduce this behavior.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-921) zkPython incorrectly checks for existence of required ACL elements
[
https://issues.apache.org/jira/browse/ZOOKEEPER-921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930008#action_12930008
]
Henry Robinson commented on ZOOKEEPER-921:
--
Nicholas -
Good catch, thanks! Do you think you will be able to submit a patch fixing the
args checking in check_is_acl()?
Thanks,
Henry
> zkPython incorrectly checks for existence of required ACL elements
> --
>
> Key: ZOOKEEPER-921
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-921
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
>Affects Versions: 3.3.1, 3.4.0
> Environment: Mac OS X 10.6.4, included Python 2.6.1
>Reporter: Nicholas Knight
>Assignee: Nicholas Knight
> Fix For: 3.3.3, 3.4.0
>
> Attachments: zktest.py
>
>
> Calling {{zookeeper.create()}} seems, under certain circumstances, to be
> corrupting a subsequent call to Python's {{logging}} module.
> Specifically, if the node does not exist (but its parent does), I end up with
> a traceback like this when I try to make the logging call:
> {noformat}
> Traceback (most recent call last):
> File "zktest.py", line 21, in
> logger.error("Boom?")
> File
> "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/logging/__init__.py",
> line 1046, in error
> if self.isEnabledFor(ERROR):
> File
> "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/logging/__init__.py",
> line 1206, in isEnabledFor
> return level >= self.getEffectiveLevel()
> File
> "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/logging/__init__.py",
> line 1194, in getEffectiveLevel
> while logger:
> TypeError: an integer is required
> {noformat}
> But if the node already exists, or the parent does not exist, I get the
> appropriate NodeExists or NoNode exceptions.
> I'll be attaching a test script that can be used to reproduce this behavior.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
