[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-110: --- Fix Version/s: 3.0.0 > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-110.patch, ZOOKEEPER-110.patch, > ZOOKEEPER-110.patch, ZOOKEEPER-110.patch > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kornev updated ZOOKEEPER-110: Attachment: ZOOKEEPER-110.patch It turns out that the original patch used the task attribute "osfamily" that is only available since ant 1.7. This patch ensures that build.xml is compatible with pre-1.7 versions. The apache license headers are also included. Please review. Thanks! > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: ZOOKEEPER-110.patch, ZOOKEEPER-110.patch, > ZOOKEEPER-110.patch, ZOOKEEPER-110.patch > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated ZOOKEEPER-110: -- Attachment: ZOOKEEPER-110.patch Added Apache liecense header to both new files. > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: ZOOKEEPER-110.patch, ZOOKEEPER-110.patch, > ZOOKEEPER-110.patch > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated ZOOKEEPER-110: -- Attachment: ZOOKEEPER-110.patch OK, I've coded up a DOS batch file that exactly replicates the shell script using only Windows built-in commands, so this fixes the original problem I identified, removes the svnant dependency, adds no new dependencies and will work on Windows natively. Huzzah! I tested it on my OSX, Ubuntu and XP machines and they all worked. Again, the patch doesn't reflect deleting the svnant directory and contents. -jg > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: ZOOKEEPER-110.patch, ZOOKEEPER-110.patch > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated ZOOKEEPER-110: -- Attachment: (was: revthrushell.diff) > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: ZOOKEEPER-110.patch > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated ZOOKEEPER-110: -- Attachment: (was: svntask.diff) > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: ZOOKEEPER-110.patch > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated ZOOKEEPER-110: -- Attachment: ZOOKEEPER-110.patch renamed patch, deleted old version. > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: ZOOKEEPER-110.patch > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated ZOOKEEPER-110: -- Attachment: revthrushell.diff I've re-done the patch to use a shell script to obtain the revision number, ala Hadoop's approach. This works on *nix machines, maintains functionality, removes the reliance on svnant (which can be deleted from the lib directory) and introduces no new dependencies. As far as Windows machines go, the operating system's poor default scripting environment makes this rather easy task pretty difficult. However, it would be easy enough to do in MS Powershell, and I don't think it's unreasonable to expect developers' machines to have that tool installed at this point. So I could certainly write up an equivalent script in Powershell, create another exec task targeted to Windows, and we'd be back to good without introducing a cygwin dependency (just a Powershell one). One unknown: I don't know how ant would identify a Windows machine with cygwin but without Powershell. Let me know if this sounds reasonable. If so, I can explore that option. Hope this is useful. -jg > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: revthrushell.diff, svntask.diff > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-110: --- Assignee: Jakob Homan Status: Open (was: Patch Available) I'm +1 on this change, -1 on using svntask re the issues Owen mentioned. Jakob -- notice that Hadoop core does something very similar, however they use a script, could you reuse this rather than relying on a third party library? http://svn.apache.org/repos/asf/hadoop/core/trunk/build.xml http://svn.apache.org/repos/asf/hadoop/core/trunk/src/saveVersion.sh > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan >Assignee: Jakob Homan > Attachments: svntask.diff > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated ZOOKEEPER-110: -- Attachment: svntask.diff patch removes svnant and adds svntask to build script > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan > Attachments: svntask.diff > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated ZOOKEEPER-110: -- Attachment: (was: svntask.diff) > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan > Attachments: svntask.diff > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated ZOOKEEPER-110: -- Attachment: svntask.diff Patch removes svnant and adds svntask. > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan > Attachments: svntask.diff > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated ZOOKEEPER-110: -- Comment: was deleted > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan > Attachments: svntask.diff > > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-110) Build script relies on svnant, which is not compatible with subversion 1.5 working copies
[ https://issues.apache.org/jira/browse/ZOOKEEPER-110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jakob Homan updated ZOOKEEPER-110: -- Status: Patch Available (was: Open) I've modified the build.xml, replacing the previous svnant task with the same functionality using svntask (http://code.google.com/p/svntask/). Svntask is apache-licensed, however, it relies on svnkit, which has an odd dual license (http://svnkit.com/licensing.html). I'm not sure if this will create a licensing issue. Not reflected in the patch is deleting the svnant directory in src/java/lib/ and adding a new directory, src/java/lib/svntask, that includes svnkit.jar and svntask.jar, obtained from the two sites above. Hope this is useful. > Build script relies on svnant, which is not compatible with subversion 1.5 > working copies > - > > Key: ZOOKEEPER-110 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-110 > Project: Zookeeper > Issue Type: Bug > Components: build >Affects Versions: 3.0.0 > Environment: Subversion 1.5 command line, or subclipse version 1.4.x >Reporter: Jakob Homan > > The current build.xml ant script uses svnant to obtain the latest revision > number from the repo, however svnant is not compatible with subversion 1.5 > (http://subversion.tigris.org/svn_1.5_releasenotes.html), and so the build > fails with working copies checked out by this version. The build fails with > "this version of subversion is too old, please get a newer version..." This > will become more apparent as svn 1.5 trickles out; I'm using a brand new dev > environment with both subclipse 1.4 and svn 1.5 client, so I got bit rather > quickly. > Those with svn 1.5 can get the code from the trunk, but cannot do an ant > build. > svnant hasn't been updated in more than a year and appears to be dead, so it > may no longer be a viable tool for the ant build. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
