[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-136: - Resolution: Fixed Status: Resolved (was: Patch Available) +1, the patch is good. I have committed already. > sync causes hang in all followers of quorum > --- > > Key: ZOOKEEPER-136 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-136.patch > > > The attached test causes all of the followers of a quorum to hang. Leader > continues to function correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-136: Status: Patch Available (was: Open) > sync causes hang in all followers of quorum > --- > > Key: ZOOKEEPER-136 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-136.patch > > > The attached test causes all of the followers of a quorum to hang. Leader > continues to function correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-136: Attachment: ZOOKEEPER-136.patch Fixed the comments suggested by Flavio. Updated the patch to trunk. > sync causes hang in all followers of quorum > --- > > Key: ZOOKEEPER-136 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-136.patch > > > The attached test causes all of the followers of a quorum to hang. Leader > continues to function correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-136: Attachment: (was: ZOOKEEPER-136.patch) > sync causes hang in all followers of quorum > --- > > Key: ZOOKEEPER-136 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-136.patch > > > The attached test causes all of the followers of a quorum to hang. Leader > continues to function correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-136: - Status: Open (was: Patch Available) > sync causes hang in all followers of quorum > --- > > Key: ZOOKEEPER-136 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-136.patch > > > The attached test causes all of the followers of a quorum to hang. Leader > continues to function correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-136: Attachment: ZOOKEEPER-136.patch Added missing SyncTest. > sync causes hang in all followers of quorum > --- > > Key: ZOOKEEPER-136 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-136.patch > > > The attached test causes all of the followers of a quorum to hang. Leader > continues to function correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-136: Status: Patch Available (was: Open) > sync causes hang in all followers of quorum > --- > > Key: ZOOKEEPER-136 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-136.patch > > > The attached test causes all of the followers of a quorum to hang. Leader > continues to function correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-136: Attachment: (was: ZOOKEEPER-136.patch) > sync causes hang in all followers of quorum > --- > > Key: ZOOKEEPER-136 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > > The attached test causes all of the followers of a quorum to hang. Leader > continues to function correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-136: --- Status: Open (was: Patch Available) Looks like some files are missing from the patch. In particular SyncTest.java, perhaps you need to svn add (them)? > sync causes hang in all followers of quorum > --- > > Key: ZOOKEEPER-136 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-136.patch > > > The attached test causes all of the followers of a quorum to hang. Leader > continues to function correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-136: Status: Patch Available (was: Open) > sync causes hang in all followers of quorum > --- > > Key: ZOOKEEPER-136 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-136.patch > > > The attached test causes all of the followers of a quorum to hang. Leader > continues to function correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-136: Attachment: ZOOKEEPER-136.patch This patch includes the tests that Pat wrote and the fix for the problem. The fix involves three things: 1) The leader creates a FollowerSyncRequest that contains a reference to the FollowerHandler doing the sync. This allows us to get rid of the handler hashmap. 2) The pendingSyncs uses a List to track multiple syncs per change 3) CommitRequest processor was changed to take a boolean to flag whether to wait for syncs to come from the leader. > sync causes hang in all followers of quorum > --- > > Key: ZOOKEEPER-136 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > Attachments: ZOOKEEPER-136.patch > > > The attached test causes all of the followers of a quorum to hang. Leader > continues to function correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-136: Attachment: (was: testfails_ZOOKEEPER-136.patch) > sync causes hang in all followers of quorum > --- > > Key: ZOOKEEPER-136 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > > The attached test causes all of the followers of a quorum to hang. Leader > continues to function correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-136: Attachment: (was: testfails_ZOOKEEPER-136.patch) > sync causes hang in all followers of quorum > --- > > Key: ZOOKEEPER-136 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > > The attached test causes all of the followers of a quorum to hang. Leader > continues to function correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-136: Attachment: (was: log_ZOOKEEPER-136.txt) > sync causes hang in all followers of quorum > --- > > Key: ZOOKEEPER-136 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Benjamin Reed > Fix For: 3.0.0 > > > The attached test causes all of the followers of a quorum to hang. Leader > continues to function correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-136: --- Attachment: testfails_ZOOKEEPER-136.patch Ben please use this updated patch file for the basis of your fix. This patch includes everything from the last patch except: 1) patched against latest svn head 2) cleans up a number of LOG messages, in particular adds a number of DEBUG level logs that help in tracking down issues when things go wrong. > sync causes hang in all followers of quorum > --- > > Key: ZOOKEEPER-136 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.0.0 > > Attachments: log_ZOOKEEPER-136.txt, testfails_ZOOKEEPER-136.patch, > testfails_ZOOKEEPER-136.patch > > > The attached test causes all of the followers of a quorum to hang. Leader > continues to function correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-136: --- Attachment: log_ZOOKEEPER-136.txt look at time index 2008-09-05 10:53:03,911 > sync causes hang in all followers of quorum > --- > > Key: ZOOKEEPER-136 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.0.0 > > Attachments: log_ZOOKEEPER-136.txt, testfails_ZOOKEEPER-136.patch > > > The attached test causes all of the followers of a quorum to hang. Leader > continues to function correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-136) sync causes hang in all followers of quorum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-136: --- Attachment: testfails_ZOOKEEPER-136.patch The TestSync test fails on my ubuntu 1core laptop. the test basically: starts a 5 server quroum starts a client against each server (so 5 clients) each client does the following (async ops) on a node it owns: 1) create node 2) sync node 3) setdata node 4) sync node 5) delete node 6) sync node 7) wait for all results of ops 1-6 to complete each client does this 100 times in a loop then exits I am seeing that in most cases the client attached to the leader runs to completion successfully. However the clients attached to the followers stall out (eventually TIMEOUT) waiting for the 1) operation to return. > sync causes hang in all followers of quorum > --- > > Key: ZOOKEEPER-136 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-136 > Project: Zookeeper > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.0.0 > > Attachments: testfails_ZOOKEEPER-136.patch > > > The attached test causes all of the followers of a quorum to hang. Leader > continues to function correctly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
