[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-408: Resolution: Fixed Status: Resolved (was: Patch Available) I just committed this.thanks pat and flavio. > address all findbugs warnings in persistence classes > > > Key: ZOOKEEPER-408 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, > ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, > ZOOKEEPER-408.patch > > > trunk/src/java/main/org/apache/zookeeper/server/DataTree.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java > trunk/src/java/main/org/apache/zookeeper/server/DataNode.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-408: +1 please commit. > address all findbugs warnings in persistence classes > > > Key: ZOOKEEPER-408 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, > ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, > ZOOKEEPER-408.patch > > > trunk/src/java/main/org/apache/zookeeper/server/DataTree.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java > trunk/src/java/main/org/apache/zookeeper/server/DataNode.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-408: Status: Patch Available (was: Open) > address all findbugs warnings in persistence classes > > > Key: ZOOKEEPER-408 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, > ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, > ZOOKEEPER-408.patch > > > trunk/src/java/main/org/apache/zookeeper/server/DataTree.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java > trunk/src/java/main/org/apache/zookeeper/server/DataNode.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-408: Status: Open (was: Patch Available) > address all findbugs warnings in persistence classes > > > Key: ZOOKEEPER-408 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, > ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, > ZOOKEEPER-408.patch > > > trunk/src/java/main/org/apache/zookeeper/server/DataTree.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java > trunk/src/java/main/org/apache/zookeeper/server/DataNode.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-408: Attachment: ZOOKEEPER-408.patch fixed the tests (removed a line which shouldnt have been removed). > address all findbugs warnings in persistence classes > > > Key: ZOOKEEPER-408 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, > ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, > ZOOKEEPER-408.patch > > > trunk/src/java/main/org/apache/zookeeper/server/DataTree.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java > trunk/src/java/main/org/apache/zookeeper/server/DataNode.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-408: Status: Patch Available (was: Open) retyring to see if the test failure is temporary.. > address all findbugs warnings in persistence classes > > > Key: ZOOKEEPER-408 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, > ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch > > > trunk/src/java/main/org/apache/zookeeper/server/DataTree.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java > trunk/src/java/main/org/apache/zookeeper/server/DataNode.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-408: Status: Open (was: Patch Available) > address all findbugs warnings in persistence classes > > > Key: ZOOKEEPER-408 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, > ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch > > > trunk/src/java/main/org/apache/zookeeper/server/DataTree.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java > trunk/src/java/main/org/apache/zookeeper/server/DataNode.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-408: Status: Patch Available (was: Open) > address all findbugs warnings in persistence classes > > > Key: ZOOKEEPER-408 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, > ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch > > > trunk/src/java/main/org/apache/zookeeper/server/DataTree.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java > trunk/src/java/main/org/apache/zookeeper/server/DataNode.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-408: Attachment: ZOOKEEPER-408.patch missed out on a compilation problem. > address all findbugs warnings in persistence classes > > > Key: ZOOKEEPER-408 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, > ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch > > > trunk/src/java/main/org/apache/zookeeper/server/DataTree.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java > trunk/src/java/main/org/apache/zookeeper/server/DataNode.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-408: Status: Open (was: Patch Available) > address all findbugs warnings in persistence classes > > > Key: ZOOKEEPER-408 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, > ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, ZOOKEEPER-408.patch > > > trunk/src/java/main/org/apache/zookeeper/server/DataTree.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java > trunk/src/java/main/org/apache/zookeeper/server/DataNode.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-408: Attachment: ZOOKEEPER-408.patch fixed the compilation problems and some more findbugs warnnings. Now the count should be 0 for findbugs warnings. > address all findbugs warnings in persistence classes > > > Key: ZOOKEEPER-408 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, > ZOOKEEPER-408.patch, ZOOKEEPER-408.patch > > > trunk/src/java/main/org/apache/zookeeper/server/DataTree.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java > trunk/src/java/main/org/apache/zookeeper/server/DataNode.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-408: Status: Patch Available (was: Open) > address all findbugs warnings in persistence classes > > > Key: ZOOKEEPER-408 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, > ZOOKEEPER-408.patch, ZOOKEEPER-408.patch > > > trunk/src/java/main/org/apache/zookeeper/server/DataTree.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java > trunk/src/java/main/org/apache/zookeeper/server/DataNode.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-408: Status: Open (was: Patch Available) > address all findbugs warnings in persistence classes > > > Key: ZOOKEEPER-408 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, > ZOOKEEPER-408.patch > > > trunk/src/java/main/org/apache/zookeeper/server/DataTree.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java > trunk/src/java/main/org/apache/zookeeper/server/DataNode.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Reed updated ZOOKEEPER-408: Hadoop Flags: [Reviewed] +1 good job > address all findbugs warnings in persistence classes > > > Key: ZOOKEEPER-408 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, > ZOOKEEPER-408.patch > > > trunk/src/java/main/org/apache/zookeeper/server/DataTree.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java > trunk/src/java/main/org/apache/zookeeper/server/DataNode.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-408: Status: Patch Available (was: Open) > address all findbugs warnings in persistence classes > > > Key: ZOOKEEPER-408 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, > ZOOKEEPER-408.patch > > > trunk/src/java/main/org/apache/zookeeper/server/DataTree.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java > trunk/src/java/main/org/apache/zookeeper/server/DataNode.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-408: - Attachment: ZOOKEEPER-408.patch I have excluded the bug warning of AuthFastLeaderElection. In my opinion, the way it is implement is good. > address all findbugs warnings in persistence classes > > > Key: ZOOKEEPER-408 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch, > ZOOKEEPER-408.patch > > > trunk/src/java/main/org/apache/zookeeper/server/DataTree.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java > trunk/src/java/main/org/apache/zookeeper/server/DataNode.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-408: Attachment: ZOOKEEPER-408.patch this patch fixes all but one of the remaining findbugs warnings (some of them being legitimate, so had to add to finbugs exclude file). the remaning one is in AuthFastLeaderElection. Ill let flavio take a look at it before I make changes in that code.. > address all findbugs warnings in persistence classes > > > Key: ZOOKEEPER-408 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Mahadev konar > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-408.patch, ZOOKEEPER-408.patch > > > trunk/src/java/main/org/apache/zookeeper/server/DataTree.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java > trunk/src/java/main/org/apache/zookeeper/server/DataNode.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-408) address all findbugs warnings in persistence classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-408: --- Attachment: ZOOKEEPER-408.patch Addressed issues in persistence package. Still some issues in datanode/datatree, Mahadev you are more familiar with this code, can you address? Also, should we change upgrade code or just ignore it? Seems like ignore would be good as this is legacy code... thoughts? > address all findbugs warnings in persistence classes > > > Key: ZOOKEEPER-408 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-408 > Project: Zookeeper > Issue Type: Sub-task >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-408.patch > > > trunk/src/java/main/org/apache/zookeeper/server/DataTree.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java > trunk/src/java/main/org/apache/zookeeper/server/persistence/Util.java > trunk/src/java/main/org/apache/zookeeper/server/DataNode.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataNodeV1.java > trunk/src/java/main/org/apache/zookeeper/server/upgrade/DataTreeV1.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
