[jira] Updated: (ZOOKEEPER-443) trace logging in watch notification not wrapped with istraceneabled - inefficient

2009-06-15 Thread Mahadev konar (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mahadev konar updated ZOOKEEPER-443:


Resolution: Fixed
Status: Resolved  (was: Patch Available)

I just committed this. thanks pat.

> trace logging in watch notification not wrapped with istraceneabled - 
> inefficient
> -
>
> Key: ZOOKEEPER-443
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-443
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
>Priority: Critical
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-443.patch
>
>
> In org.apache.zookeeper.server.NIOServerCnxn.process(WatchedEvent) there's a 
> trace message
> that's not wrapped with isTraceEnabled, this is very inefficient and should 
> be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-443) trace logging in watch notification not wrapped with istraceneabled - inefficient

2009-06-12 Thread Benjamin Reed (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Benjamin Reed updated ZOOKEEPER-443:


Hadoop Flags: [Reviewed]

+1 agreed

> trace logging in watch notification not wrapped with istraceneabled - 
> inefficient
> -
>
> Key: ZOOKEEPER-443
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-443
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
>Priority: Critical
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-443.patch
>
>
> In org.apache.zookeeper.server.NIOServerCnxn.process(WatchedEvent) there's a 
> trace message
> that's not wrapped with isTraceEnabled, this is very inefficient and should 
> be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-443) trace logging in watch notification not wrapped with istraceneabled - inefficient

2009-06-12 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-443:
---

Assignee: Patrick Hunt
  Status: Patch Available  (was: Open)

hadoopqabot will flag this however it's just a change to logging, no tests 
necessary (already covered)

> trace logging in watch notification not wrapped with istraceneabled - 
> inefficient
> -
>
> Key: ZOOKEEPER-443
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-443
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
>Priority: Critical
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-443.patch
>
>
> In org.apache.zookeeper.server.NIOServerCnxn.process(WatchedEvent) there's a 
> trace message
> that's not wrapped with isTraceEnabled, this is very inefficient and should 
> be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (ZOOKEEPER-443) trace logging in watch notification not wrapped with istraceneabled - inefficient

2009-06-12 Thread Patrick Hunt (JIRA)

 [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Patrick Hunt updated ZOOKEEPER-443:
---

Attachment: ZOOKEEPER-443.patch

trace logging is now wrapped with isTraceEnabled. should be a noticeable 
improvement.

> trace logging in watch notification not wrapped with istraceneabled - 
> inefficient
> -
>
> Key: ZOOKEEPER-443
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-443
> Project: Zookeeper
>  Issue Type: Improvement
>  Components: server
>Reporter: Patrick Hunt
>Priority: Critical
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-443.patch
>
>
> In org.apache.zookeeper.server.NIOServerCnxn.process(WatchedEvent) there's a 
> trace message
> that's not wrapped with isTraceEnabled, this is very inefficient and should 
> be fixed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.