[jira] Updated: (ZOOKEEPER-579) zkpython needs more test coverage for ACL code paths
[ https://issues.apache.org/jira/browse/ZOOKEEPER-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-579: Attachment: (was: zookeeper-579.patch) zkpython needs more test coverage for ACL code paths Key: ZOOKEEPER-579 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-579 Project: Zookeeper Issue Type: Improvement Components: contrib-bindings Affects Versions: 3.2.1 Reporter: Henry Robinson Assignee: Henry Robinson Fix For: 3.3.0 Attachments: zookeeper-579.patch, zookeeper-579.patch zkpython's tests don't do a good enough job of exercising the ACL code paths. A few new tests that confirm that setACL and friends are working correctly are needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-579) zkpython needs more test coverage for ACL code paths
[ https://issues.apache.org/jira/browse/ZOOKEEPER-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-579: Attachment: zookeeper-579.patch i tried the patch. It works against 2.6 fine. So, I changed the README to reflect that we have just tested against 2.6 and greater (excluding 3.*). Earlier it said that it works against = 2.3. Other than that the patch looks good. I will go ahead and commit it. zkpython needs more test coverage for ACL code paths Key: ZOOKEEPER-579 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-579 Project: Zookeeper Issue Type: Improvement Components: contrib-bindings Affects Versions: 3.2.1 Reporter: Henry Robinson Assignee: Henry Robinson Fix For: 3.3.0 Attachments: zookeeper-579.patch, zookeeper-579.patch zkpython's tests don't do a good enough job of exercising the ACL code paths. A few new tests that confirm that setACL and friends are working correctly are needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-579) zkpython needs more test coverage for ACL code paths
[ https://issues.apache.org/jira/browse/ZOOKEEPER-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-579: Attachment: zookeeper-579.patch forgot to attach a new file. zkpython needs more test coverage for ACL code paths Key: ZOOKEEPER-579 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-579 Project: Zookeeper Issue Type: Improvement Components: contrib-bindings Affects Versions: 3.2.1 Reporter: Henry Robinson Assignee: Henry Robinson Fix For: 3.3.0 Attachments: zookeeper-579.patch, zookeeper-579.patch zkpython's tests don't do a good enough job of exercising the ACL code paths. A few new tests that confirm that setACL and friends are working correctly are needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-579) zkpython needs more test coverage for ACL code paths
[ https://issues.apache.org/jira/browse/ZOOKEEPER-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-579: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) I just committed this. thanks henry! zkpython needs more test coverage for ACL code paths Key: ZOOKEEPER-579 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-579 Project: Zookeeper Issue Type: Improvement Components: contrib-bindings Affects Versions: 3.2.1 Reporter: Henry Robinson Assignee: Henry Robinson Fix For: 3.3.0 Attachments: zookeeper-579.patch, zookeeper-579.patch zkpython's tests don't do a good enough job of exercising the ACL code paths. A few new tests that confirm that setACL and friends are working correctly are needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-579) zkpython needs more test coverage for ACL code paths
[ https://issues.apache.org/jira/browse/ZOOKEEPER-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-579: Fix Version/s: 3.3.0 marking it for 3.3 zkpython needs more test coverage for ACL code paths Key: ZOOKEEPER-579 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-579 Project: Zookeeper Issue Type: Improvement Components: contrib-bindings Affects Versions: 3.2.1 Reporter: Henry Robinson Assignee: Henry Robinson Fix For: 3.3.0 Attachments: zookeeper-579.patch zkpython's tests don't do a good enough job of exercising the ACL code paths. A few new tests that confirm that setACL and friends are working correctly are needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-579) zkpython needs more test coverage for ACL code paths
[ https://issues.apache.org/jira/browse/ZOOKEEPER-579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henry Robinson updated ZOOKEEPER-579: - Attachment: zookeeper-579.patch Patch adds test for aget_acl, aset_acl, set_acl and get_acl. Also adds tests in the C code for ACL objects that are roughly correctly formed, throwing InvalidACL where they are not found. This is to prevent an unpleasant bug where passing another object, say a callable, could silently succeed until a strange error condition would present. zkpython needs more test coverage for ACL code paths Key: ZOOKEEPER-579 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-579 Project: Zookeeper Issue Type: Improvement Components: contrib-bindings Affects Versions: 3.2.1 Reporter: Henry Robinson Assignee: Henry Robinson Attachments: zookeeper-579.patch zkpython's tests don't do a good enough job of exercising the ACL code paths. A few new tests that confirm that setACL and friends are working correctly are needed. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
