[Zope-Checkins] SVN: Zope/branches/gsoc-python-2.5/ The Wrapper_compare function from tp_compare to tp_richcompare.
Log message for revision 87371:
The Wrapper_compare function from tp_compare to tp_richcompare.
Also another function Wrapper_richcompare is added.
Changed:
U Zope/branches/gsoc-python-2.5/doc/CHANGES.txt
U Zope/branches/gsoc-python-2.5/lib/python/Acquisition/_Acquisition.c
-=-
Modified: Zope/branches/gsoc-python-2.5/doc/CHANGES.txt
===
--- Zope/branches/gsoc-python-2.5/doc/CHANGES.txt 2008-06-13 16:53:53 UTC
(rev 87370)
+++ Zope/branches/gsoc-python-2.5/doc/CHANGES.txt 2008-06-13 18:10:34 UTC
(rev 87371)
@@ -416,6 +416,9 @@
if( isinstance(status, types.ClassType) and issubclass(status,
Exception))
to if( isinstance(status, (type, types.ClassType)) and
issubclass(status, Exception))
for fixing the failures in the module Zope2
+
+ - The Wrapper_compare function from tp_compare to tp_richcompare.
+ Also another function Wrapper_richcompare is added.
Other Changes
Modified: Zope/branches/gsoc-python-2.5/lib/python/Acquisition/_Acquisition.c
===
--- Zope/branches/gsoc-python-2.5/lib/python/Acquisition/_Acquisition.c
2008-06-13 16:53:53 UTC (rev 87370)
+++ Zope/branches/gsoc-python-2.5/lib/python/Acquisition/_Acquisition.c
2008-06-13 18:10:34 UTC (rev 87371)
@@ -103,6 +103,32 @@
#define Build Py_BuildValue
+/* For obscure reasons, we need to use tp_richcompare instead of tp_compare.
+ * The comparisons here all most naturally compute a cmp()-like result.
+ * This little helper turns that into a bool result for rich comparisons.
+ */
+static PyObject *
+diff_to_bool(int diff, int op)
+{
+ PyObject *result;
+ int istrue;
+
+ switch (op) {
+ case Py_EQ: istrue = diff == 0; break;
+ case Py_NE: istrue = diff != 0; break;
+ case Py_LE: istrue = diff = 0; break;
+ case Py_GE: istrue = diff = 0; break;
+ case Py_LT: istrue = diff 0; break;
+ case Py_GT: istrue = diff 0; break;
+ default:
+ assert(! op unknown);
+ istrue = 0; /* To shut up compiler */
+ }
+ result = istrue ? Py_True : Py_False;
+ Py_INCREF(result);
+ return result;
+}
+
/* Declarations for objects of type Wrapper */
typedef struct {
@@ -759,6 +785,13 @@
}
static PyObject *
+Wrapper_richcompare(Wrapper *self, PyObject *w, int op)
+{
+ int diff = Wrapper_compare(self, w);
+ return diff_to_bool(diff, op);
+}
+
+static PyObject *
Wrapper_repr(Wrapper *self)
{
PyObject *r;
@@ -1241,7 +1274,7 @@
(printfunc)0,/*tp_print*/
(getattrfunc)0, /*tp_getattr*/
(setattrfunc)0, /*tp_setattr*/
- (cmpfunc)Wrapper_compare,/*tp_compare*/
+ (cmpfunc)0, /*tp_compare*/
(reprfunc)Wrapper_repr, /*tp_repr*/
Wrapper_as_number, /*tp_as_number*/
Wrapper_as_sequence,/*tp_as_sequence*/
@@ -1259,7 +1292,7 @@
Wrapper object for implicit acquisition, /* Documentation string */
/* tp_traverse */ (traverseproc)Wrapper_traverse,
/* tp_clear */ (inquiry)Wrapper_clear,
- /* tp_richcompare*/ (richcmpfunc)0,
+ /* tp_richcompare*/ (richcmpfunc)Wrapper_richcompare,
/* tp_weaklistoffset */ (long)0,
/* tp_iter */ (getiterfunc)0,
/* tp_iternext */ (iternextfunc)0,
___
Zope-Checkins maillist - Zope-Checkins@zope.org
http://mail.zope.org/mailman/listinfo/zope-checkins
[Zope-dev] buildbot failure in Zope on zope.xmlpickle
The Buildbot has detected a new failure of zope.xmlpickle on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/zope.xmlpickle/builds/95 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'zope.xmlpickle nightly' triggered this build Build Source Stamp: [branch zope.xmlpickle/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on zc.recipe.testrunner
The Buildbot has detected a new failure of zc.recipe.testrunner on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/zc.recipe.testrunner/builds/98 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'zc.recipe.testrunner nightly' triggered this build Build Source Stamp: [branch zc.recipe.testrunner/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on z3ext.formatter
The Buildbot has detected a new failure of z3ext.formatter on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/z3ext.formatter/builds/69 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'z3ext.formatter nightly' triggered this build Build Source Stamp: [branch z3ext.formatter/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on z3c.vcsync
The Buildbot has detected a new failure of z3c.vcsync on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/z3c.vcsync/builds/117 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'z3c.vcsync nightly' triggered this build Build Source Stamp: [branch z3c.vcsync/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on zope.event
The Buildbot has detected a new failure of zope.event on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/zope.event/builds/94 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'zope.event nightly' triggered this build Build Source Stamp: [branch zope.event/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on z3c.i18n
The Buildbot has detected a new failure of z3c.i18n on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/z3c.i18n/builds/96 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'z3c.i18n nightly' triggered this build Build Source Stamp: [branch z3c.i18n/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on z3c.profiler
The Buildbot has detected a new failure of z3c.profiler on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/z3c.profiler/builds/91 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'z3c.profiler nightly' triggered this build Build Source Stamp: [branch z3c.profiler/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on zope.minmax
The Buildbot has detected a new failure of zope.minmax on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/zope.minmax/builds/91 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'zope.minmax nightly' triggered this build Build Source Stamp: [branch zope.minmax/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on z3c.schema
The Buildbot has detected a new failure of z3c.schema on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/z3c.schema/builds/100 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'z3c.schema nightly' triggered this build Build Source Stamp: [branch z3c.schema/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on zope.app.preview
The Buildbot has detected a new failure of zope.app.preview on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/zope.app.preview/builds/99 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'zope.app.preview nightly' triggered this build Build Source Stamp: [branch zope.app.preview/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on zope.mimetype
The Buildbot has detected a new failure of zope.mimetype on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/zope.mimetype/builds/96 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'zope.mimetype nightly' triggered this build Build Source Stamp: [branch zope.mimetype/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on zope.i18nmessageid
The Buildbot has detected a new failure of zope.i18nmessageid on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/zope.i18nmessageid/builds/97 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'zope.i18nmessageid nightly' triggered this build Build Source Stamp: [branch zope.i18nmessageid/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on zam.skin
The Buildbot has detected a new failure of zam.skin on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/zam.skin/builds/103 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'zam.skin nightly' triggered this build Build Source Stamp: [branch zam.skin/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on zope.app.wsgi
The Buildbot has detected a new failure of zope.app.wsgi on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/zope.app.wsgi/builds/101 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'zope.app.wsgi nightly' triggered this build Build Source Stamp: [branch zope.app.wsgi/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on zope.rdb
The Buildbot has detected a new failure of zope.rdb on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/zope.rdb/builds/98 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'zope.rdb nightly' triggered this build Build Source Stamp: [branch zope.rdb/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on zc.selenium
The Buildbot has detected a new failure of zc.selenium on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/zc.selenium/builds/69 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'zc.selenium nightly' triggered this build Build Source Stamp: [branch zc.selenium/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on z3c.recipe.egg_
The Buildbot has detected a new failure of z3c.recipe.egg_ on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/z3c.recipe.egg_/builds/102 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'z3c.recipe.egg_ nightly' triggered this build Build Source Stamp: [branch z3c.recipe.egg_/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on martian
The Buildbot has detected a new failure of martian on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/martian/builds/143 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'martian nightly' triggered this build Build Source Stamp: [branch martian/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on zope.app.xmlrpcintrospection
The Buildbot has detected a new failure of zope.app.xmlrpcintrospection on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/zope.app.xmlrpcintrospection/builds/101 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'zope.app.xmlrpcintrospection nightly' triggered this build Build Source Stamp: [branch zope.app.xmlrpcintrospection/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on zc.relation
The Buildbot has detected a new failure of zc.relation on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/zc.relation/builds/102 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'zc.relation nightly' triggered this build Build Source Stamp: [branch zc.relation/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on z3c.locales
The Buildbot has detected a new failure of z3c.locales on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/z3c.locales/builds/39 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'z3c.locales nightly' triggered this build Build Source Stamp: [branch z3c.locales/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on zc.datetimewidget
The Buildbot has detected a new failure of zc.datetimewidget on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/zc.datetimewidget/builds/101 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'zc.datetimewidget nightly' triggered this build Build Source Stamp: [branch zc.datetimewidget/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on z3c.formjs
The Buildbot has detected a new failure of z3c.formjs on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/z3c.formjs/builds/102 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'z3c.formjs nightly' triggered this build Build Source Stamp: [branch z3c.formjs/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on z3c.layer
The Buildbot has detected a new failure of z3c.layer on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/z3c.layer/builds/100 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'z3c.layer nightly' triggered this build Build Source Stamp: [branch z3c.layer/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on z3c.evalexception
The Buildbot has detected a new failure of z3c.evalexception on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/z3c.evalexception/builds/97 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'z3c.evalexception nightly' triggered this build Build Source Stamp: [branch z3c.evalexception/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on zope.annotation
The Buildbot has detected a new failure of zope.annotation on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/zope.annotation/builds/99 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'zope.annotation nightly' triggered this build Build Source Stamp: [branch zope.annotation/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on zope.app.pagetemplate
The Buildbot has detected a new failure of zope.app.pagetemplate on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/zope.app.pagetemplate/builds/118 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'zope.app.pagetemplate nightly' triggered this build Build Source Stamp: [branch zope.app.pagetemplate/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on z3ext.skintool
The Buildbot has detected a new failure of z3ext.skintool on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/z3ext.skintool/builds/62 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'z3ext.skintool nightly' triggered this build Build Source Stamp: [branch z3ext.skintool/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection timed out ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on z3c.extfile
The Buildbot has detected a new failure of z3c.extfile on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/z3c.extfile/builds/103 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'z3c.extfile nightly' triggered this build Build Source Stamp: [branch z3c.extfile/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection timed out ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on zope.html
The Buildbot has detected a new failure of zope.html on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/zope.html/builds/102 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'zope.html nightly' triggered this build Build Source Stamp: [branch zope.html/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on zope.locking
The Buildbot has detected a new failure of zope.locking on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/zope.locking/builds/119 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'zope.locking nightly' triggered this build Build Source Stamp: [branch zope.locking/trunk] HEAD Blamelist: BUILD FAILED: failed svn Logs are attached. sincerely, -The Buildbot svn: Can't connect to host 'svn.zope.org': Connection refused ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Zope Tests: 5 OK
Summary of messages to the zope-tests list. Period Thu Jun 12 11:00:00 2008 UTC to Fri Jun 13 11:00:00 2008 UTC. There were 5 messages: 5 from Zope Tests. Tests passed OK --- Subject: OK : Zope-2.8 Python-2.3.6 : Linux From: Zope Tests Date: Thu Jun 12 21:01:12 EDT 2008 URL: http://mail.zope.org/pipermail/zope-tests/2008-June/009695.html Subject: OK : Zope-2.9 Python-2.4.4 : Linux From: Zope Tests Date: Thu Jun 12 21:02:42 EDT 2008 URL: http://mail.zope.org/pipermail/zope-tests/2008-June/009696.html Subject: OK : Zope-2.10 Python-2.4.4 : Linux From: Zope Tests Date: Thu Jun 12 21:04:13 EDT 2008 URL: http://mail.zope.org/pipermail/zope-tests/2008-June/009697.html Subject: OK : Zope-2.11 Python-2.4.4 : Linux From: Zope Tests Date: Thu Jun 12 21:05:43 EDT 2008 URL: http://mail.zope.org/pipermail/zope-tests/2008-June/009698.html Subject: OK : Zope-trunk Python-2.4.4 : Linux From: Zope Tests Date: Thu Jun 12 21:07:14 EDT 2008 URL: http://mail.zope.org/pipermail/zope-tests/2008-June/009699.html ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on z3c.authentication
The Buildbot has detected a new failure of z3c.authentication on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/z3c.authentication/builds/118 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'z3c.authentication nightly' triggered this build Build Source Stamp: [branch z3c.authentication/trunk] HEAD Blamelist: BUILD FAILED: failed buildout Logs are attached. sincerely, -The Buildbot Abuild/buildout.cfg Abuild/setup.py Abuild/src Abuild/src/z3c Abuild/src/z3c/authentication Abuild/src/z3c/authentication/__init__.py Abuild/src/z3c/authentication/cookie Abuild/src/z3c/authentication/cookie/testlayer.zcml Abuild/src/z3c/authentication/cookie/browser Abuild/src/z3c/authentication/cookie/browser/configure.zcml Abuild/src/z3c/authentication/cookie/browser/__init__.py Abuild/src/z3c/authentication/cookie/browser/add.pt Abuild/src/z3c/authentication/cookie/browser/browser.py Abuild/src/z3c/authentication/cookie/TODO.txt Abuild/src/z3c/authentication/cookie/plugin.py Abuild/src/z3c/authentication/cookie/configure.zcml Abuild/src/z3c/authentication/cookie/__init__.py Abuild/src/z3c/authentication/cookie/ftesting.zcml Abuild/src/z3c/authentication/cookie/tests.py Abuild/src/z3c/authentication/cookie/configurator.py Abuild/src/z3c/authentication/cookie/SETUP.cfg Abuild/src/z3c/authentication/cookie/BROWSER.txt Abuild/src/z3c/authentication/cookie/testing.py A build/src/z3c/authentication/cookie/z3c.authentication.cookie-configure.zcml Abuild/src/z3c/authentication/cookie/session.py Abuild/src/z3c/authentication/cookie/interfaces.py Abuild/src/z3c/authentication/cookie/z3c.authentication.cookie-ftesting.zcml Abuild/src/z3c/authentication/cookie/README.txt Abuild/src/z3c/authentication/simple Abuild/src/z3c/authentication/simple/group.py Abuild/src/z3c/authentication/simple/browser Abuild/src/z3c/authentication/simple/browser/add.py Abuild/src/z3c/authentication/simple/browser/group.zcml Abuild/src/z3c/authentication/simple/browser/configure.zcml Abuild/src/z3c/authentication/simple/browser/__init__.py Abuild/src/z3c/authentication/simple/browser/member.zcml Abuild/src/z3c/authentication/simple/browser/register.py Abuild/src/z3c/authentication/simple/browser/edit.py Abuild/src/z3c/authentication/simple/browser/adding.py Abuild/src/z3c/authentication/simple/browser/schemasearch.py Abuild/src/z3c/authentication/simple/TODO.txt Abuild/src/z3c/authentication/simple/principal.zcml Abuild/src/z3c/authentication/simple/configure.zcml Abuild/src/z3c/authentication/simple/vocabulary.txt Abuild/src/z3c/authentication/simple/__init__.py A build/src/z3c/authentication/simple/z3c.authentication.simple-configure.zcml Abuild/src/z3c/authentication/simple/tests.py Abuild/src/z3c/authentication/simple/member.py Abuild/src/z3c/authentication/simple/SETUP.cfg Abuild/src/z3c/authentication/simple/vocabulary.py Abuild/src/z3c/authentication/simple/group.zcml Abuild/src/z3c/authentication/simple/authentication.py Abuild/src/z3c/authentication/simple/principal.py Abuild/src/z3c/authentication/simple/event.py Abuild/src/z3c/authentication/simple/interfaces.py Abuild/src/z3c/authentication/simple/group.txt Abuild/src/z3c/authentication/simple/member.zcml Abuild/src/z3c/authentication/simple/README.txt Abuild/src/z3c/__init__.py Abuild/setup.cfg U build Checked out revision 87363. Creating directory '/home/ctheune/zope.org/slave/z3c.authentication/build/bin'. Creating directory '/home/ctheune/zope.org/slave/z3c.authentication/build/parts'. Creating directory '/home/ctheune/zope.org/slave/z3c.authentication/build/develop-eggs'. Generated script '/home/ctheune/zope.org/slave/z3c.authentication/build/bin/buildout'. Upgraded: zc.buildout version 1.0.5, setuptools version 0.6c8; restarting. Generated script '/home/ctheune/zope.org/slave/z3c.authentication/build/bin/buildout'. Develop: '/home/ctheune/zope.org/slave/z3c.authentication/build/.' Installing test. ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildbot failure in Zope on z3c.formwidget.traverser
The Buildbot has detected a new failure of z3c.formwidget.traverser on Zope. Full details are available at: http://zopebuildbot.whq.gocept.com/z3c.formwidget.traverser/builds/41 Buildbot URL: http://zopebuildbot.whq.gocept.com/ Buildslave for this Build: local Build Reason: The Nightly scheduler named 'z3c.formwidget.traverser nightly' triggered this build Build Source Stamp: [branch z3c.formwidget.traverser/trunk] HEAD Blamelist: BUILD FAILED: failed buildout Logs are attached. sincerely, -The Buildbot Abuild/bootstrap.py Abuild/buildout.cfg Abuild/setup.py Abuild/src Abuild/src/z3c Abuild/src/z3c/__init__.py Abuild/src/z3c/formwidget Abuild/src/z3c/formwidget/__init__.py Abuild/src/z3c/formwidget/traverser Abuild/src/z3c/formwidget/traverser/namespace.py Abuild/src/z3c/formwidget/traverser/configure.zcml Abuild/src/z3c/formwidget/traverser/__init__.py Abuild/src/z3c/formwidget/traverser/tests.py Abuild/src/z3c/formwidget/traverser/browser.py Abuild/src/z3c/formwidget/traverser/interfaces.py Abuild/src/z3c/formwidget/traverser/README.txt Abuild/README.txt Checked out revision 87363. Creating directory '/home/ctheune/zope.org/slave/z3c.formwidget.traverser/build/bin'. Creating directory '/home/ctheune/zope.org/slave/z3c.formwidget.traverser/build/parts'. Creating directory '/home/ctheune/zope.org/slave/z3c.formwidget.traverser/build/develop-eggs'. Generated script '/home/ctheune/zope.org/slave/z3c.formwidget.traverser/build/bin/buildout'. Upgraded: zc.buildout version 1.0.5, setuptools version 0.6c8; restarting. Generated script '/home/ctheune/zope.org/slave/z3c.formwidget.traverser/build/bin/buildout'. Develop: '/home/ctheune/zope.org/slave/z3c.formwidget.traverser/build/.' Installing test. ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] buildbot news: sending notifications and current broken builds
Christian Theune a écrit : Hi, I've watched my buildbot send out notifications for a while and pondered how to make them available to more people. I decided to send them to this list on a 'problem' level. The 'problem' level sends a message when a builder changes from a good state to a bad state but doesn't send a new message on subsequent failing builds. For me this has been reasonably quiet over the last two weeks although about 60 builders are broken. The risk of sending mail here is that a massive build failure can cause about 200 messages being send at once. If anybody knows a better approach with buildbot, please let me know, I'd be happy to implement it. A way to avoid sending 200 failure messages at once would be to put failures in a queue and send a unique mail containing all failures, when: - the last failure in the queue was more than X minutes ago or - the first failure in the queue was at least Y hours ago Christophe For everyone else: please have a look at the list of broken builds: http://zopebuildbot.whq.gocept.com/cruise If a project that you feel responsible for is broken, please check out whats wrong and maybe fix it. If the build environment isn't suitable, I'll be happy to help. This page should show a green bar! Christian ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] buildout failures
How many of these do we need? zope-dev is almost unreadable at the moment due to the number of buildout failure emails. Martin -- Author of `Professional Plone Development`, a book for developers who want to work with Plone. See http://martinaspeli.net/plone-book ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Zope2_Porting-Fixing module Acquisition
Hi,
During the porting of Zope2 to python2.5 , the failures in the module
Acquisition is regarding the C-API changes. This failures can be
removed by mapping the function Wrapper_compare to tp_richcompare
which is now mapped in to the tp_compare in the extension file
Acquisition/_Acquisition.c. Part of the new code I introduced was
copied from datetimemodule.c from Python 2.5 . Right now its not
showing any failures or errors with both python2.4 and python2.5.
The patch is
http://svn.zope.org/Zope/branches/gsoc-python-2.5/?rev=87371view=rev
Please review this patch. Is this changes and the function from
datetimemodule.c. If not is there any suggestions?
Index: lib/python/Acquisition/_Acquisition.c
===
--- lib/python/Acquisition/_Acquisition.c (revision 87254)
+++ lib/python/Acquisition/_Acquisition.c (working copy)
@@ -103,6 +103,32 @@
#define Build Py_BuildValue
+/* For obscure reasons, we need to use tp_richcompare instead of tp_compare.
+ * The comparisons here all most naturally compute a cmp()-like result.
+ * This little helper turns that into a bool result for rich comparisons.
+ */
+static PyObject *
+diff_to_bool(int diff, int op)
+{
+ PyObject *result;
+ int istrue;
+
+ switch (op) {
+ case Py_EQ: istrue = diff == 0; break;
+ case Py_NE: istrue = diff != 0; break;
+ case Py_LE: istrue = diff = 0; break;
+ case Py_GE: istrue = diff = 0; break;
+ case Py_LT: istrue = diff 0; break;
+ case Py_GT: istrue = diff 0; break;
+ default:
+ assert(! op unknown);
+ istrue = 0; /* To shut up compiler */
+ }
+ result = istrue ? Py_True : Py_False;
+ Py_INCREF(result);
+ return result;
+}
+
/* Declarations for objects of type Wrapper */
typedef struct {
@@ -759,6 +785,14 @@
}
static PyObject *
+Wrapper_richcompare(Wrapper *self, PyObject *w, int op)
+{
+ int diff = Wrapper_compare(self, w);
+ return diff_to_bool(diff, op);
+}
+
+
+static PyObject *
Wrapper_repr(Wrapper *self)
{
PyObject *r;
@@ -1241,7 +1275,7 @@
(printfunc)0,/*tp_print*/
(getattrfunc)0, /*tp_getattr*/
(setattrfunc)0, /*tp_setattr*/
- (cmpfunc)Wrapper_compare, /*tp_compare*/
+ (cmpfunc)0, /*tp_compare*/
(reprfunc)Wrapper_repr, /*tp_repr*/
Wrapper_as_number, /*tp_as_number*/
Wrapper_as_sequence, /*tp_as_sequence*/
@@ -1259,7 +1293,7 @@
Wrapper object for implicit acquisition, /* Documentation string */
/* tp_traverse */ (traverseproc)Wrapper_traverse,
/* tp_clear */ (inquiry)Wrapper_clear,
- /* tp_richcompare*/ (richcmpfunc)0,
+ /* tp_richcompare*/ (richcmpfunc)Wrapper_richcompare,
/* tp_weaklistoffset */ (long)0,
/* tp_iter */ (getiterfunc)0,
/* tp_iternext */ (iternextfunc)0,
___
Zope-Dev maillist - Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] z3c.form with Zope 2?
Hi guys, Are there any basic problems using z3c.form with Zope 2? All the tutorials and documentation I have found uses straight Zope 3. If anyone has successfully used z3c.form in a Zope 2 project I'd love to see some sample code ;-) jens ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] z3c.form with Zope 2?
Previously Jens Vagelpohl wrote: Are there any basic problems using z3c.form with Zope 2? All the tutorials and documentation I have found uses straight Zope 3. If anyone has successfully used z3c.form in a Zope 2 project I'd love to see some sample code ;-) http://svn.plone.org/svn/plone/plone.z3cform/ has Zope2 integration code for it. I don't think anything in it is plone-specific. Wichert. -- Wichert Akkerman [EMAIL PROTECTED]It is simple to make things. http://www.wiggy.net/ It is hard to make things simple. ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] new BTreeContainer implementation, please review
Hi, While fixing some bugs in zope.app.container, I've also modified the implementation of the BTreeContainer, by not inheriting from the SampleContainer, and directly accessing the btree. This had remained as a TODO in the btree.py file, so I did it, but... The result is all previous persisted BTreeContainers (such as PrincipalFolder) are broken because the btree used to be stored in self._SampleContainer__data, while the new implementation stores it in self._BTreeContainer__data. So I've added a property to offer a transparent backward compatibility: def _get__data(self): try: return self._BTreeContainer__data except: return self._SampleContainer__data def _set__data(self, value): try: self._BTreeContainer__data = value except: self._SampleContainer__data = value def _del_data(self): try: del self._BTreeContainer__data except: del self._SampleContainer__data __data = property(_get__data, _set__data, _del_data) Do you think it is safe? Is there any better solution for this? Should I rather write an evolution script? Or should I revert all this back to inheriting from SampleContainer? Christophe ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] new BTreeContainer implementation, please review
On Fri, Jun 13, 2008 at 3:40 PM, Christophe Combelles [EMAIL PROTECTED] wrote: While fixing some bugs in zope.app.container, I've also modified the implementation of the BTreeContainer, by not inheriting from the SampleContainer, and directly accessing the btree. This had remained as a TODO in the btree.py file, so I did it, but... The result is all previous persisted BTreeContainers (such as PrincipalFolder) are broken because the btree used to be stored in self._SampleContainer__data, while the new implementation stores it in self._BTreeContainer__data. So I've added a property to offer a transparent backward compatibility: [snip] Do you think it is safe? Is there any better solution for this? Should I rather write an evolution script? Or should I revert all this back to inheriting from SampleContainer? Another option would be to leave the attribute with the wrong name and just add a note that it's for backward compatible. -- Benji York Senior Software Engineer Zope Corporation ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] buildout failures
On Fri, Jun 13, 2008 at 07:44:32PM +0100, Martin Aspeli wrote: How many of these do we need? zope-dev is almost unreadable at the moment due to the number of buildout failure emails. I like buildbot emails. Well, except for the ones that complain about svn.zope.org being down. If buildbot complaints bother other people, how about creating a separate list for them? Marius Gedminas -- One could envision a different approach to persistence (hands wave and magical stardust appears overhead to percussive indian string music) where objects in the database were proxied rather than deriving from a common base class. -- Casey Duncan signature.asc Description: Digital signature ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] new BTreeContainer implementation, please review
On Fri, Jun 13, 2008 at 09:40:06PM +0200, Christophe Combelles wrote: While fixing some bugs in zope.app.container, I've also modified the implementation of the BTreeContainer, by not inheriting from the SampleContainer, and directly accessing the btree. This had remained as a TODO in the btree.py file, so I did it, but... The result is all previous persisted BTreeContainers (such as PrincipalFolder) are broken because the btree used to be stored in self._SampleContainer__data, while the new implementation stores it in self._BTreeContainer__data. So I've added a property to offer a transparent backward compatibility: def _get__data(self): try: return self._BTreeContainer__data except: Please do not use bare except clauses. Replace this with except AttributeError: return self._SampleContainer__data def _set__data(self, value): try: self._BTreeContainer__data = value except: When could this ever fail? self._SampleContainer__data = value def _del_data(self): try: del self._BTreeContainer__data except: del self._SampleContainer__data Do we need __del__ at all? __data = property(_get__data, _set__data, _del_data) Do you think it is safe? Not if you want compatibility in both directions. If you want databases created with the new zope.app.container to be readable with the old zope.app.container (consider, e.g. a developer using a sandbox and switching between bleeding-edge development and old maintenance branches), then you can't do this. Is there any better solution for this? Perhaps a __setstate__ method to rename the attribute? See the PersistentMapping class in persistent/mapping.py for an example. Should I rather write an evolution script? *loathes* Or should I revert all this back to inheriting from SampleContainer? Or you could do like Benji York suggested and always use the backwards-compatible name _SampleContainer__data. (Why oh why did SampleContainer want to use a double underscored name?) Marius Gedminas -- Of course I use Microsoft. Setting up a stable unix network is no challenge ;p signature.asc Description: Digital signature ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[Zope-dev] Re: Zope2_Porting-Fixing module Acquisition
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 ranjith kannikara wrote: During the porting of Zope2 to python2.5 , the failures in the module Acquisition is regarding the C-API changes. This failures can be removed by mapping the function Wrapper_compare to tp_richcompare which is now mapped in to the tp_compare in the extension file Acquisition/_Acquisition.c. Part of the new code I introduced was copied from datetimemodule.c from Python 2.5 . Right now its not showing any failures or errors with both python2.4 and python2.5. The patch is http://svn.zope.org/Zope/branches/gsoc-python-2.5/?rev=87371view=rev Please review this patch. Is this changes and the function from datetimemodule.c. If not is there any suggestions? The patch looks fine. Are you saying that the 'diff_to_bool' function was pulled in from another project? If so, we likely need to ensure that we get the licensing correct on it. Also, is setting 'tp_compare' to a null needed to make the tests pass? Or was that just a precaution? Thanks for moving the ball forward! Tres. - -- === Tres Seaver +1 540-429-0999 [EMAIL PROTECTED] Palladion Software Excellence by Designhttp://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFIUvNp+gerLs4ltQ4RAo5KAKDWpWsU50k5SK/8i/5P4fwprwrm+wCdGDH8 Bjl84QCrtaLNk/DK3j1u5+U= =oYoU -END PGP SIGNATURE- ___ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
[ZWeb] zope.org migration
We've completed the zope.org migration, the site is responding, mail.zope.org is up and looks to be processing mail, as well as serving the list archives and all just fine, and I can see people logging in to cvs so everything looks good. The instances running www.zope.org are more than a bit slow at the moment because they lost their object caches, so I've got a monitor running on them to put the caches in offline mode to let the instances recover a bit when they get backed up. All in all, while this took a little longer than I was anticipating, it went quite smoothly. --Dave Systems Administrator Zope Corp. 540-361-1722 [EMAIL PROTECTED] ___ Zope-web maillist - Zope-web@zope.org http://mail.zope.org/mailman/listinfo/zope-web
[Zope] not possible to download anything
Hi there, after the dislocation of the zope servers zope.org is reachable again from where I am (switzerland) however it is not possible to download anything. robert ___ Zope maillist - Zope@zope.org http://mail.zope.org/mailman/listinfo/zope ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope-dev )
Re: [Zope] not possible to download anything
On Jun 13, 2008, at 10:18 , robert rottermann wrote: Hi there, after the dislocation of the zope servers zope.org is reachable again from where I am (switzerland) however it is not possible to download anything. The Zope Corp sysadmins and Jim are aware of the problems and working on it. jens ___ Zope maillist - Zope@zope.org http://mail.zope.org/mailman/listinfo/zope ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope-dev )
