Re: [Zope-CMF] [dev] type info: content_icon vs. icon_expr property
Hi! Hanno Schlichting wrote: > yuppie wrote: >> I just noticed this checkin: http://svn.zope.org/?rev=94014&view=rev >> >> And I'm a bit confused. What's the plan? Maintaining redundant >> information? Using a different icon for the add action? Deprecating >> content_icon and migrating everything to icon_expr? > > I would be fine with deprecating content_icon and switching to icon_expr > instead of maintaining both. Sounds good to me *if* someone works on the necessary changes before the beta release. I consider the current state of your change as 'work in progress'. > The only place I know where this would be a bit difficult is in > Products.CMFCore.TypesTool.TypeInformation.getIcon which returns the > icon name and not the complete URL. AFAICS TypeInformation.getIcon is only used by DynamicType.getIcon - at least in CMF. And by default DynamicType.getIcon returns the complete URL. I think code using getIcon(relative_to_portal=1) can be changed and 'relative_to_portal' can be deprecated. So it doesn't hurt if extracting the relative URL becomes more expensive. Please note that I started using upgradeSteps for CMFDefault. .to22.upgrade_type_properties would be a good place for the migration code. And the default profiles need to be updated as well. Cheers, Yuppie ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
[Zope-CMF] CMF Tests: 6 OK
Summary of messages to the cmf-tests list. Period Wed Jan 21 12:00:00 2009 UTC to Thu Jan 22 12:00:00 2009 UTC. There were 6 messages: 6 from CMF Tests. Tests passed OK --- Subject: OK : CMF-2.1 Zope-2.10 Python-2.4.5 : Linux From: CMF Tests Date: Thu Jan 22 04:06:20 EST 2009 URL: http://mail.zope.org/pipermail/cmf-tests/2009-January/010777.html Subject: OK : CMF-2.1 Zope-2.11 Python-2.4.5 : Linux From: CMF Tests Date: Thu Jan 22 04:07:20 EST 2009 URL: http://mail.zope.org/pipermail/cmf-tests/2009-January/010778.html Subject: OK : CMF-trunk Zope-2.10 Python-2.4.5 : Linux From: CMF Tests Date: Thu Jan 22 04:08:20 EST 2009 URL: http://mail.zope.org/pipermail/cmf-tests/2009-January/010779.html Subject: OK : CMF-trunk Zope-2.11 Python-2.4.5 : Linux From: CMF Tests Date: Thu Jan 22 04:09:20 EST 2009 URL: http://mail.zope.org/pipermail/cmf-tests/2009-January/010780.html Subject: OK : CMF-trunk Zope-trunk Python-2.4.5 : Linux From: CMF Tests Date: Thu Jan 22 04:10:20 EST 2009 URL: http://mail.zope.org/pipermail/cmf-tests/2009-January/010781.html Subject: OK : CMF-trunk Zope-trunk Python-2.5.2 : Linux From: CMF Tests Date: Thu Jan 22 04:11:20 EST 2009 URL: http://mail.zope.org/pipermail/cmf-tests/2009-January/010782.html ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] [dev] type info: content_icon vs. icon_expr property
Hi. yuppie wrote: > I just noticed this checkin: http://svn.zope.org/?rev=94014&view=rev > > And I'm a bit confused. What's the plan? Maintaining redundant > information? Using a different icon for the add action? Deprecating > content_icon and migrating everything to icon_expr? I would be fine with deprecating content_icon and switching to icon_expr instead of maintaining both. The only place I know where this would be a bit difficult is in Products.CMFCore.TypesTool.TypeInformation.getIcon which returns the icon name and not the complete URL. Hanno ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
