[Zope-CMF] [dev] Topic changes: problems with revision 38002

2005-09-21 Thread yuppie 

Hi!


I see sporadic import errors caused by circular imports:

  File "Products/CMFDefault/__init__.py", line 27, in ?
import factory
  File "Products/CMFDefault/factory.py", line 25, in ?
from Portal import CMFSite
  File "Products/CMFDefault/Portal.py", line 26, in ?
from Products.CMFTopic import Topic
  File "Products/CMFTopic/__init__.py", line 25, in ?
import Topic
  File "Products/CMFTopic/Topic.py", line 22, in ?
from Products.CMFDefault.SkinnedFolder import SkinnedFolder
  File "Products/CMFDefault/__init__.py", line 27, in ?
import factory
  File "Products/CMFDefault/factory.py", line 25, in ?
from Portal import CMFSite
  File "Products/CMFDefault/Portal.py", line 26, in ?
from Products.CMFTopic import Topic
ImportError: cannot import name Topic


While not documented in CMFTopic/DEPENDENCIES.txt, 
http://svn.zope.org/CMF/trunk/?rev=38002&view=rev added a new dependency 
on CMFDefault's SkinnedFolder.


Not sure how to resolve this.


Cheers,

Yuppie

___
Zope-CMF maillist  -  Zope-CMF@lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests

Re: [Zope-CMF] [dev] Topic changes: problems with revision 38002

2005-09-22 Thread Jens Vagelpohl 


On 21 Sep 2005, at 18:10, yuppie wrote:

I see sporadic import errors caused by circular imports:




While not documented in CMFTopic/DEPENDENCIES.txt, http:// 
svn.zope.org/CMF/trunk/?rev=38002&view=rev added a new dependency  
on CMFDefault's SkinnedFolder.


Not sure how to resolve this.


Personally, I don't see a problem with that dependency itself. I  
cannot come up with any sensible use case for using CMFTopic in an  
environment where CMFDefault and SkinnedFolder are not available.


We could move the import into that setup method where the module is  
being used? Since this is in the PortalGenerator class it doesn't  
matter really.


jens

___
Zope-CMF maillist  -  Zope-CMF@lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests

Re: [Zope-CMF] [dev] Topic changes: problems with revision 38002

2005-09-22 Thread Dieter Maurer 
yuppie wrote at 2005-9-21 18:10 +0200:
> ...
>   File "Products/CMFDefault/Portal.py", line 26, in ?
> from Products.CMFTopic import Topic
>ImportError: cannot import name Topic

In a similar situation (with Archetypes) something like

   import Products.CMFTopic.Topic; Topic = Products.CMFTopic.Topic

worked around the problem.

-- 
Dieter
___
Zope-CMF maillist  -  Zope-CMF@lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests