Re: [Zope-CMF] CMF Tests: 3 OK, 1 Failed
On 2009-8-17 17:48, Alec Mitchell wrote: > Exactly. The failures are essentially cosmetic, I can fix them either > by removing the Quoted Printable configuration from MailHost or by > changing the CMF tests to expect Quoted Printable instead of Base64. > Quoted Printable is easily readable/debuggable and doesn't get > penalized by spam filters, base64 is more compact. It may make the > most sense to remove the Quoted Printable config from MailHost and > just punt this decision to some future release. I would rather see those quopri changse go in for two reasons: it makes testing emails easier us humans can read quoted printable text while base64 looks like line noice, and in my experience spamfilters tend to consider base64 encoded emails more likely to spam. Wichert. -- Wichert AkkermanIt is simple to make things. http://www.wiggy.net/ It is hard to make things simple. ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] CMF Tests: 3 OK, 1 Failed
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Aug 17, 2009, at 17:52 , Hanno Schlichting wrote: > If you get the permission to backport these changes to 2.12 (or be > bold enough to just do it, since they seem to make sense) you could > back out this one change, so the 2.12 would keep the slightly more > backwards compatible notion. Since this is just a cosmetic change and it takes 5 seconds to change the test there's no reason at all to only apply part of the changes to 2.12, provided they get applied to begin with (which I hope). Backwards-compatibility is great, but let's not overdo it. If anyone relies on those headers being specifically base64 the application is broken by design. jens -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.8 (Darwin) iEYEARECAAYFAkqJh/wACgkQRAx5nvEhZLISQwCeMXmymNDcGK60VX23RqUKABP4 fzAAnREAD45iDftlOw0FtztZ+x/bXRqY =pOCB -END PGP SIGNATURE- ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] CMF Tests: 3 OK, 1 Failed
On Mon, Aug 17, 2009 at 5:48 PM, Alec Mitchell wrote: > It may make the > most sense to remove the Quoted Printable config from MailHost and > just punt this decision to some future release. Currently your changes only apply to Zope trunk aka 2.13 which is in early development. The change looks perfectly fine to me for that release. If you get the permission to backport these changes to 2.12 (or be bold enough to just do it, since they seem to make sense) you could back out this one change, so the 2.12 would keep the slightly more backwards compatible notion. Hanno ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] CMF Tests: 3 OK, 1 Failed
On Mon, Aug 17, 2009 at 7:56 AM, Jens Vagelpohl wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > On Aug 17, 2009, at 16:45 , Tres Seaver wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >>> Subject: FAILED (failures=1) : CMF-trunk Zope-trunk Python-2.6.2 : Linux >>> From: CMF Tests >>> Date: Sun Aug 16 21:17:25 EDT 2009 >>> URL: http://mail.zope.org/pipermail/cmf-tests/2009-August/011888.html >> >> This test appears to be due to changes which Alec made in fixing the >> MailHost product on the Zope trunk. I think these doctests themselves >> are largely bogus (they are breaking on bits we don't care about), but >> maybe there is an easy fix? > > These failures have been brought up in a zope-dev thread about the MailHost > changes, they are related to a switch from base64 to quoted-printable > encoding for some headers. There has not been any final determination if > this change is OK. Alec has promised to fix the tests once this has been > decided. Exactly. The failures are essentially cosmetic, I can fix them either by removing the Quoted Printable configuration from MailHost or by changing the CMF tests to expect Quoted Printable instead of Base64. Quoted Printable is easily readable/debuggable and doesn't get penalized by spam filters, base64 is more compact. It may make the most sense to remove the Quoted Printable config from MailHost and just punt this decision to some future release. Alec ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] CMF Tests: 3 OK, 1 Failed
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Aug 17, 2009, at 16:45 , Tres Seaver wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > >> Subject: FAILED (failures=1) : CMF-trunk Zope-trunk Python-2.6.2 : >> Linux >> From: CMF Tests >> Date: Sun Aug 16 21:17:25 EDT 2009 >> URL: http://mail.zope.org/pipermail/cmf-tests/2009-August/011888.html > > This test appears to be due to changes which Alec made in fixing the > MailHost product on the Zope trunk. I think these doctests themselves > are largely bogus (they are breaking on bits we don't care about), but > maybe there is an easy fix? These failures have been brought up in a zope-dev thread about the MailHost changes, they are related to a switch from base64 to quoted- printable encoding for some headers. There has not been any final determination if this change is OK. Alec has promised to fix the tests once this has been decided. jens -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.8 (Darwin) iEYEARECAAYFAkqJb5gACgkQRAx5nvEhZLJsrgCfUcacJyJ0eLJFcpRqM1puvpq1 GHYAoInsi2odl1VtOcHSTuqsbr57I/Ff =qphC -END PGP SIGNATURE- ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests
Re: [Zope-CMF] CMF Tests: 3 OK, 1 Failed
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 CMF Tests Summarizer wrote: > Summary of messages to the cmf-tests list. > Period Sun Aug 16 12:00:00 2009 UTC to Mon Aug 17 12:00:00 2009 UTC. > There were 4 messages: 4 from CMF Tests. > > > Test failures > - > > Subject: FAILED (failures=1) : CMF-trunk Zope-trunk Python-2.6.2 : Linux > From: CMF Tests > Date: Sun Aug 16 21:17:25 EDT 2009 > URL: http://mail.zope.org/pipermail/cmf-tests/2009-August/011888.html This test appears to be due to changes which Alec made in fixing the MailHost product on the Zope trunk. I think these doctests themselves are largely bogus (they are breaking on bits we don't care about), but maybe there is an easy fix? Tres. - -- === Tres Seaver +1 540-429-0999 tsea...@palladion.com Palladion Software "Excellence by Design"http://palladion.com -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFKiW0U+gerLs4ltQ4RAtk6AKDI6mYd+M27gyISBD7NBrLZkA2KcACfblHN iE3/LP2oXYzqGQumuE+SqJA= =Srzn -END PGP SIGNATURE- ___ Zope-CMF maillist - Zope-CMF@lists.zope.org http://mail.zope.org/mailman/listinfo/zope-cmf See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests