Re: [Zope-CMF] Adapterizing CMFCore.WorkflowTool redux

2010-10-19 Thread Laurence Rowe 
On 27 September 2010 19:33, Laurence Rowe  wrote:
> On 25 September 2010 16:26, Charlie Clark
>  wrote:
>> Am 24.09.2010, 00:18 Uhr, schrieb Laurence Rowe :
>>
>>> If there are no objections I shall merge the changes back to trunk.
>>
>> +1 from me. Please update changes.txt
>>
>>  From your original post:
>>
>> * I currently adapt based on (IContentish, IWorkflowDefinition) should
>> this be made more general, i.e. (Interface, IWorkflowDefinition)? Does
>> anyone workflow anything that is not IContentish?
>>
>> Shouldn't only IWorkflowAware be adapted?
>
> I've changed it to adapt (IWorflowAware, IWorkflowDefinition) now.
> I've also made a change so that objects are possibly adapted to
> IWorkflowAware before calling notifyWorkflowCreated so this may be
> implemented as an adapter instead of a mixin.
>
>> * Is deprecating getStatusOf, setStatusOf, getHistoryOf desirable? I'm not
>> sure it would serve any particular purpose.
>>
>> Looking at the implementation the question I would ask myself is, what are
>> the alternatives? In general I'd agree with yuppie on less tool methods
>> and more adapters but not with the current spelling for multiadapters.
>
> I don't think it really serves any purpose at this time. I'll merge to
> trunk later this week assuming no objections.

Merged in 117773

Laurence
___
Zope-CMF maillist  -  Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests

[Zope-CMF] CMF Tests: 4 OK

2010-10-19 Thread CMF Tests Summarizer 
Summary of messages to the cmf-tests list.
Period Mon Oct 18 12:00:00 2010 UTC to Tue Oct 19 12:00:00 2010 UTC.
There were 4 messages: 4 from CMF Tests.


Tests passed OK
---

Subject: OK : CMF-2.1 Zope-2.10 Python-2.4.6 : Linux
From: CMF Tests
Date: Mon Oct 18 21:49:40 EDT 2010
URL: http://mail.zope.org/pipermail/cmf-tests/2010-October/013665.html

Subject: OK : CMF-2.1 Zope-2.11 Python-2.4.6 : Linux
From: CMF Tests
Date: Mon Oct 18 21:51:40 EDT 2010
URL: http://mail.zope.org/pipermail/cmf-tests/2010-October/013666.html

Subject: OK : CMF-2.2 Zope-2.12 Python-2.6.5 : Linux
From: CMF Tests
Date: Mon Oct 18 21:53:40 EDT 2010
URL: http://mail.zope.org/pipermail/cmf-tests/2010-October/013667.html

Subject: OK : CMF-trunk Zope-2.12 Python-2.6.5 : Linux
From: CMF Tests
Date: Mon Oct 18 21:55:40 EDT 2010
URL: http://mail.zope.org/pipermail/cmf-tests/2010-October/013668.html

___
Zope-CMF maillist  -  Zope-CMF@zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests