[Zope-dev] Re: ZPT: defer expression fix

2005-03-28 Thread Christian Heimes
Jens Vagelpohl wrote:
I'm assuming the unit tests still run successfully and you added unit 
tests for your changes.
All unit tests are passing with my chances. I've to write some tests 
before merging my branch. I'll write them after somebody seconds my fix.

Christian
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope )


Re: [Zope-dev] ZPT: defer expression fix

2005-03-28 Thread Jens Vagelpohl
On Mar 28, 2005, at 21:03, Christian Heimes wrote:
PageTemplates have an undocumented features called defer:. It's a kind 
of lazy initialization of variables.

I've fixed to issues in my tiran-zpt-pydefer branch (svn):
 * DeferWrappers weren't working inside a python expression because 
PythonExpr didn't know about them

 * DeferWrapper didn't cache the result of the expression like 
ordinary vars do.

I would like to merge my branch into 2.7 and 2.8 if I get an ok.
+1
I'm assuming the unit tests still run successfully and you added unit 
tests for your changes.

jens
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope )


[Zope-dev] ZPT: defer expression fix

2005-03-28 Thread Christian Heimes
PageTemplates have an undocumented features called defer:. It's a kind 
of lazy initialization of variables.

I've fixed to issues in my tiran-zpt-pydefer branch (svn):
 * DeferWrappers weren't working inside a python expression because 
PythonExpr didn't know about them

 * DeferWrapper didn't cache the result of the expression like ordinary 
vars do.

I would like to merge my branch into 2.7 and 2.8 if I get an ok.
Christian
___
Zope-Dev maillist  -  Zope-Dev@zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
**  No cross posts or HTML encoding!  **
(Related lists - 
http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope )