Re: [Zope-dev] PathIndex unindex fix
If you have write access to the Zope CVS, go ahead. Thanks, Andreas --On Donnerstag, 21. November 2002 17:35 + seb bacon [EMAIL PROTECTED] wrote: I've already fixed it; should I commit it or do you want the patches? Andreas Jung wrote: Please file a collector issue and assign it to me. -aj --On Donnerstag, 21. November 2002 13:24 + seb bacon [EMAIL PROTECTED] wrote: Anyone object to me changing PathIndex so it swallows exceptions and logs them when unindexing content? On upgrading to Zope 2.6 some if the unindex paths seem to have got hosed, and I don't want this breaking my site. ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope ) - -Andreas Jung http://www.andreas-jung.com - - EMail: andreas at andreas-jung.com - -Life is too short to (re)write parsers - - -- [] j a m k i t seb bacon T: 020 7549 0520 F: 020 7490 1152 M: 07968 301 336 W: www.jamkit.com ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope ) - -Andreas Jung http://www.andreas-jung.com - - EMail: andreas at andreas-jung.com - -Life is too short to (re)write parsers - - ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] PathIndex unindex fix
Leonardo Rochael Almeida wrote: If you are to ignore errors, please ignore specific errors that are known to happen. Please don't use a generic except. ...or re-raise only ConflictErrors. Hmmm... this issue is perhaps deeper than it first appeared. Are conflict errors swallowed by the other indexes? Should they be? I wonder if the discussion about swallowing ConflictErrors (on zodb-dev IIRC) was ever resolved? cheers, Chris ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
[Zope-dev] PathIndex unindex fix
Anyone object to me changing PathIndex so it swallows exceptions and logs them when unindexing content? On upgrading to Zope 2.6 some if the unindex paths seem to have got hosed, and I don't want this breaking my site. ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] PathIndex unindex fix
+1 from me... most other PluginIndexes already fail gracefully when something to be unindexed has disappeared. IMHO all indexes should behave that way. jens On Thursday, Nov 21, 2002, at 08:24 US/Eastern, seb bacon wrote: Anyone object to me changing PathIndex so it swallows exceptions and logs them when unindexing content? On upgrading to Zope 2.6 some if the unindex paths seem to have got hosed, and I don't want this breaking my site. ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] PathIndex unindex fix
On Thu, Nov 21, 2002 at 08:52:41AM -0500, Jens Vagelpohl wrote: | +1 from me... most other PluginIndexes already fail gracefully when | something to be unindexed has disappeared. IMHO all indexes should | behave that way. Now that you mentioned, I got an error while trying to index NZO using ZCTextIndex, so I guess it is suffering from the same issue. Anyone can confirm? []'s -- Sidnei da Silva (dreamcatcher) [EMAIL PROTECTED] X3ng Web Technology http://www.x3ng.com.br GNU/Linux user 257852 Debian GNU/Linux 3.0 (Sid) 2.4.18 ppc This file will self-destruct in five minutes. ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] PathIndex unindex fix
Please file a collector issue and assign it to me. -aj --On Donnerstag, 21. November 2002 13:24 + seb bacon [EMAIL PROTECTED] wrote: Anyone object to me changing PathIndex so it swallows exceptions and logs them when unindexing content? On upgrading to Zope 2.6 some if the unindex paths seem to have got hosed, and I don't want this breaking my site. ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope ) - -Andreas Jung http://www.andreas-jung.com - - EMail: andreas at andreas-jung.com - -Life is too short to (re)write parsers - - ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] PathIndex unindex fix
Sidnei da Silva wrote: Now that you mentioned, I got an error while trying to index NZO using ZCTextIndex, so I guess it is suffering from the same issue. Anyone can confirm? No, no, failure during _indexing_ is a good thing (tm). Failure during _unindexing_ is a bad thing (r). cheers, Chris ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] PathIndex unindex fix
On Thu, 2002-11-21 at 11:24, seb bacon wrote: Anyone object to me changing PathIndex so it swallows exceptions and logs them when unindexing content? This sounds REALLY LOUD ALARMS in my head. There is a class of errors (subclasses of ConflictError) that should never be ingored because they're automatically handled by Zope itself (in ZServer, I think). I can think of situations where a changed content causes a Conflict error, and the standard Zope retry would be enough to make the PathIndex be correctly unindexed. Actually, ZCatalogs are a conflict error magnet, I believe to ignore conflict errors is to beg for problems. If you are to ignore errors, please ignore specific errors that are known to happen. Please don't use a generic except. -- Ideas don't stay in some minds very long because they don't like solitary confinement. ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
Re: [Zope-dev] PathIndex unindex fix
I've already fixed it; should I commit it or do you want the patches? Andreas Jung wrote: Please file a collector issue and assign it to me. -aj --On Donnerstag, 21. November 2002 13:24 + seb bacon [EMAIL PROTECTED] wrote: Anyone object to me changing PathIndex so it swallows exceptions and logs them when unindexing content? On upgrading to Zope 2.6 some if the unindex paths seem to have got hosed, and I don't want this breaking my site. ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope ) - -Andreas Jung http://www.andreas-jung.com - - EMail: andreas at andreas-jung.com - -Life is too short to (re)write parsers - - -- [] j a m k i t seb bacon T: 020 7549 0520 F: 020 7490 1152 M: 07968 301 336 W: www.jamkit.com ___ Zope-Dev maillist - [EMAIL PROTECTED] http://lists.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://lists.zope.org/mailman/listinfo/zope-announce http://lists.zope.org/mailman/listinfo/zope )
